summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2022-04-09tdf#143135 Qt break recursive IM QueryCursorRectJan-Marek Glogowski
To reproduce the Impress crash, you need an IM, e.g. fcitx / ibus. This is triggered by having an active input, like double-clicking one of a presentations text fields, then leaving the window and switching back to it. This results in a stack exhaustion in a few seconds. The backtrace is basically: QWidget::setFocus QtFrame::ToTop sd::Window::GrabFocus ImplHandleExtTextInputPos QtWidget::inputMethodQuery QInputMethod::cursorRectangle QWidget::setFocus QApplication::setActiveWindow QtInstance::DoYield main I scratched my head over the longer backtrace for while, but there seems to be no good way to prevent this from LO's POV. The only alternative from the Qt VCL plugin is QtFrame::ToTop. That code is less ugly (no mutable or cached result), but QtWidget:: inputMethodQuery is earlier in the backtrace. Change-Id: Ief3a8e44bca295cc676e75050d52d70a1da98a88 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132643 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit e81385277c091dabb1f6542a94229d7dcc77289b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132612
2022-04-09tdf#147285 qt: Prefer "text/plain;charset=utf-8" over "text/plain"Michael Weghorn
If there were no data for MIME type "text/plain;charset=utf-16" in the clipboard, but "text/plain" was provided, it was previously assumed that this would be encoded in the locale's encoding, and corresponding conversion using that encoding happened to provide "text/plain;charset=utf-16" ourselves. "text/plain;charset=utf-8" data was simply ignored, but using it (if present) and preferring it over "text/plain" is more reliable (and e.g. avoids incorrect paste of Chinese characters from Firefox into Impress when using the qt5/qt6/kf5 VCL plugins on Wayland), so use it if present. Rename the "m_bConvertFromLocale" member to better fit the new meaning. (An alternative solution to adding our own handling for "text/plain;charset=utf-8" and making assumptions for the encoding of "text/plain" data would be to let Qt handle this and just call `QMimeData::text()` for the `m_bProvideUTF16FromOtherEncoding=true` case in `QtTransferable::getTransferData`. Since qtbase commit 589a01ff6b1eacf81e74a5fc4801572135214f43 ("QMimeData: Prefer UTF-8 when multiple charsets are available", contained in Qt >= 5.13), that one handles MIME type "text/plain;charset=utf-8" in addition to "text/plain".) [1] https://code.qt.io/cgit/qt/qtbase.git/commit/?id=589a01ff6b1eacf81e74a5fc4801572135214f43 Change-Id: I89f33216bf6be02a347d245b2359273af2eb530a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132631 Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> Tested-by: Jenkins (cherry picked from commit 5b3227fac58dcbd588e2389e205679cd77842bac) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132607 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-04-09tdf#145954 Qt unshare QMenubar usageJan-Marek Glogowski
The Qt code was sharing the menu bar from the top level frame, but LO expects independent menu bars per SetFrame calls. So instead of showing the new bar and then hiding the old one, this was always show and hiding the same menu bar, resulting in a hidden menu bar. As a result of unsharing, LO now must check that its menu bar pointer is still valid for usage. The QMainWindows takes ownership when a QMenuBar is assigned and destroy old ones. Change-Id: I2c6b12199a1e17a5d9f88686a4b27b1413beda47 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132581 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit 9c4ef8ce3183e27ca174475cf4a8d15cc0368f60) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132604 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-04-09tdf#144585 Qt fix Wayland LO fake popupsJan-Marek Glogowski
So Michael Weghorn was somehow reminded of an abandoned commit from me ("Qt5 rework parent handling") archived in https://gerrit.libreoffice.org/c/core/+/73463. The bug introducing the new QWidget parenting, tdf#145363, was resolved in a better way by explicitly setting parents for the modal dialogs, so LO doesn't break Qt anymore. The actual problem is, that an additional modal dialog needs to be stacked to the previous modal dialog; no "parallel" modal dialogs are allowed, which my original fix tried to enforce by reparenting. Then there is the problem with Qt::Popup's focus grabbing on show, which breaks LO's editable ComboBox. So LO's popup / FLOAT windows are mapped to Qt::ToolTip, which are automatically advertised as tooltips via accessibility. For X11 / xcb, Qt:Window with the Qt::BypassWindowManagerHint works well enough as an alternative, but WASM and Wayland don't seem to implement it correctly, so this just handles popups as Qt::ToolTip on all platforms. This reverts commit b00a68a8e19370e106cd76258a3c1825f43613ee ("tdf#145363 Qt reparent modal dialogs on show"). In addition the popup widgets are switched back to Qt::ToolTip. Change-Id: If726771b4e9cc3f639f21cf502b3ec5985873643 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132526 Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins (cherry picked from commit fbf739198aa7f02975d531521c6525073783c7f1) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132625
2022-04-09Resolves: tdf#146174 allow shortcut key event handling before menubarVincent Reher
Change-Id: Ib0dadafcc66604baf53169cb222a059ee3f97362 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132601 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-04-06Qt use platform-independent visibility functionsJan-Marek Glogowski
show() isn't just some conveniently renamed setVisible(true), but presents a window in a platform-dependant way, which - at least for WASM - means maximized and without a title bar. This is not really expected and WASM can also use multiple windows. Change-Id: I3fbaec1dfc2cd32bf3a90a94dcee01ebc88e58c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128179 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit f7346dc88200fa2160d39b4e4b4ae31fcad59a8c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132624 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-04-06tdf#147523 Qt use inner QWidget to set pointer posJan-Marek Glogowski
Regression from commit e63fe68fb1d0915b64fdf63f7fa6eed866fa3a0d ("Qt use asChild for pointer positioning"), which should just have been a cleanup for commit ca28826a087245686d7fca3ffc8ca1f03307924d ("tdf#131467 Qt set default position on first resize"). And scale the requested position by the device scale factor. Change-Id: I50b3c628d22896e987d8cc2eaf5635cb12ba3464 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132518 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins (cherry picked from commit cec215e0e3adaf26c89c4ffbaa53f87481772f0c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132388
2022-04-04lok: fix formulabar renderingSzymon Kłos
While forwardporting it was not taken into account that no pixel/logic conversion is needed. regression in: commit cf5b0d5972b02809e9b7f35780885445242b3f12 Author: Szymon Kłos <szymon.klos@collabora.com> Date: Mon Jan 17 13:11:19 2022 +0100 RTL: lok: render correctly interim windows Change-Id: Ic6716bf9335d4a9297e3e5edfeb161702b846efb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132424 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Mert Tumer <mert.tumer@collabora.com>
2022-03-30Trust the family name in the font file if necessary in AddTempDevFontHelper()Tor Lillqvist
If the passed in font name is empty, use the one that has been read from the font file. Seems like a reasonable thing to do, and I have a use for this small improvement coming. Change-Id: I3598179bf85ba3acdaca6058982ba5bf81e68288 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131300 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2022-03-30forcepoint#85 Conditional jump or move depends on uninitialised valueCaolán McNamara
==398461== by 0xCDC7960: (anonymous namespace)::CopyUntil(char16_t*&, char16_t const*&, char16_t, bool) (strhelper.cxx:88) ==398461== by 0xCDC839F: psp::WhitespaceToSpace(rtl::OUString const&, bool) (strhelper.cxx:294) ==398461== by 0xCB54980: vcl::PDFWriterImpl::setOutlineItemText(int, rtl::OUString const&) (pdfwriter_impl.cxx:9875) ==398461== by 0xCB547FF: vcl::PDFWriterImpl::createOutlineItem(int, rtl::OUString const&, int) (pdfwriter_impl.cxx:9851) ==398461== by 0xCAF39B0: vcl::PDFWriter::CreateOutlineItem(int, rtl::OUString const&, int) (pdfwriter.cxx:383) ==398461== by 0xCABD7C8: vcl::GlobalSyncData::PlayGlobalActions(vcl::PDFWriter&) (pdfextoutdevdata.cxx:250) ==398461== by 0xCAC0628: vcl::PDFExtOutDevData::PlayGlobalActions(vcl::PDFWriter&) (pdfextoutdevdata.cxx:616) ==398461== by 0x3D06EA0F: PDFExport::Export(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (pdfexport.cxx:1004) Change-Id: I6bc086997851ee06531a4a9ae263e2b26edfba84 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132035 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-03-25fix error: unused variableAndras Timar
Change-Id: I941e3abd1986bfb490acae3585e165ce42d9c71c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132119 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2022-03-25tdf#148033: Loss of precision in /MediaBox (PDFWriterImpl::emitCatalog())Lemures Lemniscati
License statement provided here: https://bugs.documentfoundation.org/show_bug.cgi?id=148033#c4 Change-Id: I93333a17d4a6a266fc25a92abf50c22cb01a2b1d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131716 (cherry picked from commit fb48a6408a515057a03c485bf00df5c34706595b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131603 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-22tdf#140222 make InterimTearableParent docking windows not dockableJim Raykowski
and only allow dockable type docking windows to be undocked/docked Change-Id: Ia1b0ccbdd911c24f83baf1c0514954e354c9070b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129650 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com> (cherry picked from commit 99ac14c8ccf89a51de1b3fb9d14789406f2dc95f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131019 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-03-22tdf#143216: pdfwriter: Don't treat semi-valid URIs as local pathsDr. David Alan Gilbert
Currently the PDF writer treats URIs that are rejected by INetURIObject, as local files, and prepends a path to them. For URIs that are valid according to the basic URI syntax, but unhandled by INetURIObject (such as http://user:password@domain) this produces a confusing result with a ./uri in the PDF. Avoid the prefixing where the URI follows the basic URI syntax, even if INetURIObject didn't like it. Change-Id: I87c599885a40fd7101c678ae79f83f594d0f23ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125202 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131259
2022-03-22pdfwriter: Add check without relativeFsysDr. David Alan Gilbert
Set relativeFsys on a per-test basis and add a test with relativeFsys off. Change-Id: I43b1d82200aca37b2cf8ac71d77a4aa61df543ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130197 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131258
2022-03-22pdfwriter: Check URIs exportedDr. David Alan Gilbert
Check the URIs that are exported. Change-Id: I2d8b00f767a61c5abdb9163701fe497bb258c790 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125203 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131257
2022-03-17jsdialog: enable dialog on demand by env varSzymon Kłos
It will be possible to enable some dialogs by environment variable: SAL_JSDIALOG_ENABLE=modules/scalc/ui/validationdialog.ui:modules/scalc/ui/validationcriteriapage.ui (you can specify multiple items with ':' separator) Change-Id: Iba1e6b7ac77716f40c9073a8064206c420f2d081 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131600 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2022-03-17jsdialog: fix toolboxes with childrenSzymon Kłos
Don't block JSON generation if toolbox has children... Fixes missing sidebar items Change-Id: I34696d780b4292881792b2190a522610a8b4b597 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131696 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2022-03-16Make LOKClipboard available to other modulesSzymon Kłos
LOKClipboard has higher level dependencies (sfx2) so it cannot be moved to the vcl where SystemClibpoard instance is created. - introduce new interface LokClipboard to differentiate from SystemClipboard so we can have vcl's and lok's implementations at the same time - publish LOKClipboard using new interface for other modules by adding component file in desktop module Thanks to that when code calls GetClipboard and we cannot get clipboard assigned to the vcl::Window* (for welded widgets) in GetSystemClipboard correct instance is returned (shared clipboard for current view) so we can access content which was copied before. Previously always a new instance was created (with empty content). test ScTiledRenderingTest::testPasteIntoWrapTextCell was broken add some content to clipboard to simulate more real case and test the content copied Change-Id: I23c0298960a710c498646493f33122b908864cba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126310 Reviewed-by: Luboš Luňák <l.lunak@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131644 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2022-03-16Avoid segv when co-editing around SvxColorTabPage.Michael Meeks
vcl::Window::ImplCallDeactivateListeners(vcl::Window*) vcl/source/window/window.cxx:3403 (discriminator 2) vcl::Window::ImplCallDeactivateListeners(vcl::Window*) vcl/source/window/window.cxx:3404 ... vcl::Window::ImplCallDeactivateListeners(vcl::Window*) vcl/source/window/window.cxx:3404 vcl::Window::ImplAsyncFocusHdl(void*) include/rtl/ref.hxx:112 ... Dialog::Execute() vcl/source/window/dialog.cxx:1056 virtual thunk to SalInstanceDialog::run() vcl/source/app/salvtables.cxx:4924 AbstractSvxNameDialog_Impl::Execute() cui/source/factory/dlgfact.cxx:222 SvxColorTabPage::ClickAddHdl_Impl(weld::Button&) include/rtl/ref.hxx:192 Change-Id: I12a78d65a8e7b8b728dde84f7c51cc19005c9aa6 Signed-off-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131352
2022-03-16lok: fix position og autofilter in RTL modeSzymon Kłos
Change-Id: I73f2b003185c326f4d66c974a2e5aaecb4e0199a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130916 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Mert Tumer <mert.tumer@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131124 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2022-03-15tdf#144862 use resolution independent positions for writer's screen-renderingCaolán McNamara
in favor of pushing it down to the text renderers and leave it to them to optimized as best they can the the rendering to make it look as well as possible. Change-Id: Ic0849c091a36e1a90453771b1c91b8ff706b679e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128418 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 4ed26badfd6fd9190cb6e54078b41eb38cb37dca)
2022-03-14jsdialog: enable Accessibility Check dialogSzymon Kłos
- fix crash due to wrong type for label - deduplicate widgets with the same id in one dialog/builder - refresh on box reordering Change-Id: I6993552342a3f139de40c3f87243bdf4e0617fc5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130797 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Henry Castro <hcastro@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131120 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2022-03-14lok: send logic autofilter positionSzymon Kłos
we need to show popup relative to the grid window Change-Id: Ib0cf66d2c0422b765a3b8035d5499b45e83f768d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130528 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Mert Tumer <mert.tumer@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131122 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2022-03-09PDF export of PDF images: don't preserve annotations in generalMiklos Vajna
Regression from 33c9bc0225a92f26770f9ef20b252af47853e7b9 (PDF export of PDF images: preserve hyperlinks, 2022-01-07), the problem was that we want to preserve hyperlinks, but annotations are added by the PDF export explicitly, so it isn't a good idea to "preserve" them as well. Fix the problem by going back to the old behavior, except when the annotation sub-type is /Link. This keeps hyperlinks working but doesn't lead to duplicated comments when re-exporting an image + adding comments explicitly. Conflicts: vcl/qa/cppunit/pdfexport/pdfexport.cxx Change-Id: I910990da59bdc1150cc346f1a5471cb6da55dd2c
2022-03-09Fix iOS compilation after recent changes to SequenceTor Lillqvist
Change-Id: I73c519174029766a3a2f61f9ad93fd63589b8184 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126957 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2022-03-09ofz#45255 handle short O_hhea tableCaolán McNamara
Change-Id: I649dfdb3eff868441125fbf62ff3c7d0d18d8d19 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131015 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-03-09ofz: Too many hatch pointsCaolán McNamara
Change-Id: I08cb9d09a9bb48ab31763f50bc2fa23cf723330f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131013 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-03-09ofz: record less than 10 bytes is invalidCaolán McNamara
Change-Id: Ie6b88efbc12b4c7fddb7459e50cba28fcbcf35fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131010 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-03-09clamp and add some logging like SvmReaderCaolán McNamara
LIBREOFFICE-OWMTGGWJ Change-Id: I8f744e1ab2684a0f0995abcc3e753a684a3b970a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130981 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-03-09clamp in StretchTextHandler like TextHandlerCaolán McNamara
Change-Id: I4e1247ef2945f46cd1e60e9e473c1a589f990bb4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130980 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-03-09tdf#136632: Use 'Save transparency' when exporting selected objects for PNGJulien Nabet
To avoid some regression, consider that transparency should be enabled by default. So only remove transparency if it's required explicitely. + change QA test since "Translucent" property isn't a bool but a sal_Int32 In officecfg/registry/schema/org/openoffice/Office/Common.xcs: <prop oor:name="Translucent" oor:type="xs:int" oor:nillable="false"> Change-Id: I9bfb6aae8e2e8a31dee82f73a9165989129f222a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131057 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131061 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-03-09ofz: detect endless loop in font processingCaolán McNamara
Change-Id: I4e6c61d8be15a560f43b5d37d646e7bad9739eb7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130778 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins
2022-03-09ofz#45165 verify table offsetsCaolán McNamara
Change-Id: I99649a03da28d3b896bed72999b50803ce0a4761 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130857 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-03-09ofz#45073 don't dereference null pointer on bogus fontCaolán McNamara
Change-Id: I28616696833b87c300d2ee7061a15921042934b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130613 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130937 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-03-09ofz: Use-of-uninitialized-valueCaolán McNamara
Change-Id: If10e8d2465ef6de62583f6547e3f68e92002f3f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130863 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-03-09ofz: check hmtx offsetCaolán McNamara
Change-Id: I650a37472c70771d40febe52efcb723195856421 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130912 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-03-09ofz: Use-of-uninitialized-valueCaolán McNamara
Change-Id: I358d826a1dafe345f610d26d0d517a7357c838d2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130853 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins
2022-03-09ofz: don't read past end of recordCaolán McNamara
Change-Id: I9fced38faf46dce9f4cc2b96e351e7ae945d0ac1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130825 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-03-09ofz: measure legal range from glyph offset, not table startCaolán McNamara
Change-Id: I04c1036e004be678b70a7df197141970aa3c8b16 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130750 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130824 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-03-09ofz: measure maximum possible contoursCaolán McNamara
Change-Id: Ie039abd835fef06514edde12b99e17360f5481a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130773 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins
2022-03-09Resolves: tdf#145580 need to use gtk_im_context_filter_keypressCaolán McNamara
for at least xim, ibus works fine. To reproduce under Fedora with gtk3 can use a keyboard layout of "US International with dead keys" with export GDK_BACKEND=x11 export GTK_IM_MODULE=xim and 'a in writer comment or calc header/footer dialog Change-Id: I49425887dccc23c4fadf2bc007b6e83fc7993f7a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130775 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-03-09lastPoint might be 0xFFFFCaolán McNamara
LIBREOFFICE-KYYAZMB9 Change-Id: Ic0d95bd39a01dc1e5e0fec83dcc2c40b3f23b747 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130461 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-03-09ofz: verify table offsetsCaolán McNamara
Change-Id: I49fa886508b3bf553d4f638bfe53c37fa3e2f338 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130682 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-03-09ofz: glyph data must be at least 10 bytes long to be usefulCaolán McNamara
Change-Id: I312c33c598013feced15c6f2dbcc66e493b703e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130686 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-03-09ofz#45081 check font lengthCaolán McNamara
Change-Id: Ib8cea70652ae90403db3546c07d24a517b1ec93e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130634 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-03-09ofz#45082 Out-of-memoryCaolán McNamara
Change-Id: I274a6beeec0013f5b974017500fe31bcecabfa86 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130636 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-03-09ofz#45073 initialize names to NULL in case of 0 glyphsCaolán McNamara
Change-Id: Ie410d2a6f3d2fcda19b1925675bd7515673b07a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130563 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-02-21Fix Bitmap::RotateSzymon Kłos
Bug introduced in: commit 74c46b12340f1afb1752f5df0bab91caca3ef63f speed up bitmap rotation it was showing some artifacts in LOK when using previews in rotation -> sin and cos values were used incorrectly Change-Id: Id85c54d0aa4488f19e7b5db2e242fdb446626699 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129528 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2022-02-21Revert "lok: copy over the alpha channel too for cairo..."Luboš Luňák
Not needed anymore (T33230) and no need to slow the function down by checking for LOK. This reverts commit a9c473c3306e28462f9a1898a94277cf0adcbe5e. Change-Id: I585ded78c8617c2560c44ec027d76b363bd26c1c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129490 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
generated by cgit (git 2.34.1) at 2025-03-12 05:39:14 +0000