summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2016-08-14loplugin:overrideparamStephan Bergmann
Change-Id: I78513a531f93f6578290107b1d71977820dac965
2016-08-14tdf#100965: Restart on initialisation-time OpenCL crashTor Lillqvist
Add a flag to the OpenCLZone indicating whether we are performing the first-start OpenCL functionality verification, so that if we run into a crash that is caught by the VCL VCLExceptionSignal_impl() handler, we terminate the process with the EXITHELPER_NORMAL_RESTART status after first having disabled OpenCL use. The wrapper process will then restart soffice.bin. This is for Windows only so far. This matches what we do if OpenGL fails early during start of LibreOffice. Change-Id: Ibb9bf3a86b7521bf16728de2a118ad4323be674b Reviewed-on: https://gerrit.libreoffice.org/28086 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2016-08-12fix windows buildNoel Grandin
after commit 500a3be0 "loplugin:countusersofdefaultparams in vcl..xmlsecurity" Change-Id: I09b07f241dc45f2d23370addfb1bc10aa2caedc4
2016-08-12loplugin:countusersofdefaultparams in vcl..xmlsecurityNoel Grandin
Change-Id: I538596a99e632178d928ff7e66ad45c71b73c6fd Reviewed-on: https://gerrit.libreoffice.org/28018 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-11Resolves: tdf#100250 scrollbar has no bgCaolán McNamara
Change-Id: I48e26b775337809759f8a76be7a9c457c94cd5c9
2016-08-11loplugin:constantparamNoel Grandin
Change-Id: Ia06b9b189033b9409d7a59a211866f66a0614886 Reviewed-on: https://gerrit.libreoffice.org/28016 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-10Intermediate iOS hackTor Lillqvist
Just to get this one file to compile. More errors come later. I just spent a short time on this while waiting for something else. Actually I have no idea what we should do on iOS nowadays. Do we want to use cairo? Do we want to use OpenGL? Would it make sense to mimic what we do on Android as much as possible? (But what do we do on Android, and is that by choice or accident?) Even if that might mean not using APIs native to iOS, but slower (not HW accelerated) FLOSS alternatives that perform the same functionality, broadly speaking? Change-Id: Id88a895b90f753417eced744141376656bcf72c3
2016-08-10Surround PaintScope code with ifdefs matching declaration in include fileTor Lillqvist
Change-Id: Iede85fc847b330b5586b95facafb690df7209d1b
2016-08-10Include <vcl/dllapi.h> for VCL_PLUGIN_PUBLICTor Lillqvist
Change-Id: I5e248ed670502a2702f08e31739a8c82c29d5302
2016-08-10gendata.hxx has movedTor Lillqvist
Change-Id: I55223078e189416c4181141a7a904e93d5c6a01e
2016-08-08gtk: a11y: quieten warningsCaolán McNamara
Change-Id: I4b4c7c22482ca0ee45a114798fcab65a9dc69789
2016-08-08Resolves: tdf#99324 let bare tabpage in dialogs get toggled auto-mnemonicsCaolán McNamara
Change-Id: Icdf2a908d131ff05a1c00b7305686edba26d4b24
2016-08-08Related: tdf#99312, add specialized interaction handlerGiuseppe Castagno
Needed to manage https certificates and authentication whenever needed. Change-Id: If20b85a9b349b203a8c46d453afa823629d114cb Reviewed-on: https://gerrit.libreoffice.org/27927 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-08-08loplugin:overrideparamStephan Bergmann
Change-Id: I34fc490407f2bdac036dced5360b438ffb1cb4e2
2016-08-08loplugin:passstuffbyrefStephan Bergmann
Change-Id: I90d280dd041051d8d8433519a7ad7fc17117fd74
2016-08-08don't try to memcpy from and to a nullptrMarkus Mohrhard
See e.g. http://crashreport.libreoffice.org/stats/crash_details/2218a489-b64c-4193-a7d4-cd01c6a607cb Change-Id: I6c123d3e9e5c6dbcb7756a686503904cbfd944a4 Reviewed-on: https://gerrit.libreoffice.org/27948 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-08-05opengl: add #version to shaders - minimum 130 which is OpenGL 3.0Tomaž Vajngerl
Change-Id: I5710ce91e804641d4c997bc3d06970a5ed0cb5b1 Reviewed-on: https://gerrit.libreoffice.org/27890 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2016-08-04Drop unneeded includeTor Lillqvist
There is no <QuickTime/QuickTime.h> in the 10.12 SDK anyway. Change-Id: I0d937d4b036d118fcb503543a516e55f859a3718
2016-08-04GSoC: notebookbar, position of popup menuSzymon Kłos
Change-Id: Ia4491a8659c8e6532681f7fca83b432e311d79d6 Reviewed-on: https://gerrit.libreoffice.org/27881 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <eszkadev@gmail.com>
2016-08-04Related: tdf#101213 speculative drop of CAIRO_OPERATOR_DIFFERENCE useCaolán McNamara
for tdf#99446 and rhbz#1283420 there is a hackaround which ended up in 5.1.5, which is not in 5.1.4, for corrupt glyphs under X. I can still reproduce the problem if I drop the CAIRO_OPERATOR_DIFFERENCE usage here with master and gtk2. This alternative hackaround to force a read of the underlying surface works just as well (help->license information is the reproducer). Change-Id: Ie3c5b07409537a1734226b4ce034620351297e25
2016-08-04like listbox put margins on both sides of an edit tooCaolán McNamara
Change-Id: I425b1005297b20ace85181edce72ab5829006a0e
2016-08-04use same scheme in Edit and ListBox for rendering text in ::DrawCaolán McNamara
Change-Id: I5b17103e838f221cf3815002979c6b8c9c443300
2016-08-04Resolves: tdf#97120 printing controls uses wrong font and font sizesCaolán McNamara
regression apparently since commit 825b3df7f1d987021ec4a08ff8e7ed78e5772c97 Date: Thu Oct 22 19:03:01 2015 +0200 tdf#94138 fix printing of edit form fields revert the GetDrawPixelFont part of that so the font is pulled from the control and not the device its printed to, this makes tdf#97120 and tdf#97120 work properly again then revert commit 6c41727484a04ab89005ffb052937dae5d7dc223 Date: Tue Dec 1 17:44:23 2015 +0100 tdf#94138 Use correct fonts for multiline edit when printing because that replicates the original GetDrawPixelFont behaviour so its not needed after the other revert. Then, to solve the original tdf#94138, in the edit StateChanged handler call ApplySettings(*this); like FixedText::StateChanged does to merge in the controlfont setting to the underlying OutputDevice of the control, which presumably is what is then retrieved from GetDrawPixelFont Change-Id: I992a0e2011ffce7748d39f7f2bc49fbf6b8eaa79
2016-08-04tdf#101008 fix XOR renderingTomaž Vajngerl
Change-Id: Ied73966633e5ffd56faccea7ec1408bd83642b58 Reviewed-on: https://gerrit.libreoffice.org/27862 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2016-08-03Reduce ENABLE_OPENGL / ENABLE_HEADLESS confusionTor Lillqvist
ENABLE_OPENGL means whether to enable the OpenGL slideshow transition code. It does not mean whether to enable use of OpenGL in general. So rename it to ENABLE_OPENGL_TRANSITIONS while at it. ENABLE_HEADLESS means whether to disable use of X11 and OpenGL on X11 (and Wayland) platforms, I think, meaning Linux and maybe Solaris and the BSDs. Maybe it should be renamed to DISABLE_X11_AND_OPENGL. Change-Id: Ibb30f51646b1bcc477fe691a3fa38c7a1e3944ae
2016-08-02gtk2: toggle menubar mnemonics on if any keyinput on it or submenusCaolán McNamara
this is closer to how I seem to see the gtk menubars work (gtk3 is native now so this doesn't affect that) Change-Id: Ie5225d2ccda698946f26408aae95d2a50cbb928b
2016-08-02Related: tdf#92516 make menu accelerators always work even if...Caolán McNamara
keyboard not used yet. The gtk2/3 menus appear to work this way. (And when not in gtk2/3 it shouldn't disable the accelerators for other platforms anyway) Change-Id: Ib7a99bd9039cd07120b3b77380f810b5b028fd57
2016-08-02Resolves: tdf#99324 let sidebar toggle auto-mnemonics on/off with altCaolán McNamara
this returns things to passing the alt to the thing with the focus and depends on ::Command handlers passing the alt-press/release back up through the Command hierarchy to get to the default top-level handler eventually Change-Id: I869120f43810adfa2fac4670c2db143b790a1f9b
2016-08-01Look also for "RDPDD Chained DD"Tor Lillqvist
Apparently in some remote desktop situations the device string uses "RDPDD" and not "RDPUDD". No idea what the semantic difference is. Change-Id: I85532b90d759d02fffb73d0f3d22166aefd4edab
2016-08-01svl: implement SfxUndoAction::GetViewShellId() interface in SfxListUndoActionMiklos Vajna
Client code in sw, sd, sc and svx is adapted, the rest is just a placeholder for now. With this, e.g. the undo item for Writer's insert comment properly tracks which window was used for the insertion. Change-Id: Idad587e6ca07ba69bf59aa7013b251af8bf95bab Reviewed-on: https://gerrit.libreoffice.org/27781 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-07-31rename ImplWindowAutoMnemonic and exposeCaolán McNamara
Change-Id: Iddb0d84b6dbfeb263a68ddc3b8b5c39bbdcf46f6
2016-07-30Fix SolarMutex not locked when using IME on dropdown list.Mark Hung
Surround ImplHandleIMEQueryCharPosition() by ImplSalYieldMutexAcquireWithWait() and ImplSalYieldMutexRelease(). Change-Id: I3843ad351f3b92801cd1e0066a3c73f2a52c44bd Reviewed-on: https://gerrit.libreoffice.org/27117 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mark Hung <marklh9@gmail.com>
2016-07-29unhook the alt handling thing from SystemWindowCaolán McNamara
so it could be used from things that aren't dialogs Change-Id: I649c5a05ad9c0634be9cef2bbe16a4643e58fc12
2016-07-29Resolves: tdf#101169 crash using column menu in baseCaolán McNamara
Change-Id: Ia4ce895d3562b29db648a7b568121a2867088493
2016-07-29only map GDK_SUPER_MASK to KEY_MOD3 and not GDK_META_MASKCaolán McNamara
on wayland I'm getting a GDK_MOD1_MASK and a GDK_META_MASK on pressing the left alt. The check for KEY_MOD2 in Window::KeyInput trips up with the extra KEY_MOD3 bit set so the auto mnemonic underlines don't appear on pressing left alt under wayland Lets map only GDK_SUPER_MASK to KEY_MOD3 Change-Id: I1e9cc9fc095f5edfa7ad7c71440232c6de1ecf04
2016-07-29this 0x4000 means KEY_MOD2Caolán McNamara
Change-Id: Id260c776241cfa5af35c51ccee7ba6942a353f8d
2016-07-29strangely misplaced modelineCaolán McNamara
Change-Id: I4c8dabbd2eeac2e3edb72a426687af8692c77497
2016-07-29comphelper,vcl: let DeInitVCL() join some AsyncEventNotifier threadsMichael Stahl
comphelper::AsyncEventNotifier is an amazing class that dispatches events in separate threads, no doubt implemented during times of exuberant optimism about the tractability of shared-state multi-threading. Unfortunately the authors forgot to think about how all those awesome threads will be joined, so if they are somehow blocked, then it may well happen that the events are dispatched when the main thread is already in DeInitVCL, and the objects required for the dispatching already smell somewhat funny. This happens quite reproducibly when changing dbaccess' ModelMethodGuard to lock the SolarMutex too, then CppunitTest_dbaccess_RowSetClones crashes in DeInitVCL() because one AsyncEventNotifier thread was blocked until then by SolarMutexGuard, and this test never Yields once its document is loaded. Try to fix this by joining the "DocumentEventNotifier" threads from DeInitVCL() itself. Since there's no rtl::WeakReference to go with rtl::Reference, refactor the AsyncEventNotifier and create a new AsyncEventNotifierAutoJoin that has to be used with std::shared_ptr and std::weak_ptr. Change-Id: I50a0749795acb04b0776e543f7125767b697ea35 Reviewed-on: https://gerrit.libreoffice.org/27581 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-07-29set antialias once when context is createdCaolán McNamara
Change-Id: Id36e716253768321e1ddfb977a22470c6b694147 Reviewed-on: https://gerrit.libreoffice.org/27510 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2016-07-28opengl: improve logging when no context is availableTomaž Vajngerl
Change-Id: Ie747db5f46b0a83bda44d211b0ac69bc19092fbc Reviewed-on: https://gerrit.libreoffice.org/27615 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2016-07-28opengl: don't initialize MSAA when we create VCL contextTomaž Vajngerl
Change-Id: Ic8060ebdabb86d8b724ee419fdfcc1f58e8a0316 Reviewed-on: https://gerrit.libreoffice.org/27614 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2016-07-28opengl: improve context creation, temp window creation on windowsTomaž Vajngerl
If anything fails at context creation then don't forget to deallocate resources. Temp window creation is written C like, as it was copy/pasted from an C example. Change-Id: Ia9d704e42206b1d4c37db2954bba4f165e3c8389 Reviewed-on: https://gerrit.libreoffice.org/27613 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2016-07-28tdf#100915 draw antialiased line just for polygon outlineTomaž Vajngerl
To get the anti-aliased polygon we draw a anti-aliased line around every trapezoid. This works fine until we draw a transparent polygon where the lines become visible because of blending. A much better and faster way is to just draw the polygon outline with anti-aliased lines. This is done with this commit. Change-Id: Ice50e5eb3343f2c5d51ade8ad0e170043541f0ff Reviewed-on: https://gerrit.libreoffice.org/27611 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2016-07-28add rtf to fftesterCaolán McNamara
Change-Id: If00b1de1e1be16214df78d15554d95847e3239e7
2016-07-28tdf#101026 Create more correct replacement control vectorArmin Le Grand
Change-Id: I909adaab3dca3c1bac4331b164343cdbc1205df2 Reviewed-on: https://gerrit.libreoffice.org/27365 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2016-07-28vcl: remove Application::InsertIdleHdl() and ImplIdleMgrMichael Stahl
This is obsolete since 5.0 introduced the new Idle scheduler. Change-Id: I8555fe35e2befb0cc2a4c39ae469a5c32a32fcb9 Reviewed-on: https://gerrit.libreoffice.org/27598 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-07-28Resolves: tdf#101132 a11y crash in hyperlinkCaolán McNamara
regression from... commit aa6c54f337a616c9ca6a39cfc8708657018d8613 Date: Mon Jan 18 09:01:15 2016 +0200 loplugin:unusedfields Change-Id: Ic2b7fe5f2d49a447a9936c4fb04bafcc7349ecf9
2016-07-28vcl: Guard against invalid statesSamuel Mehrbrodt
Got crashes here in 5.0, seem to be gone in master, but better be safe than sorry Change-Id: I434800f0e4a465233024b6a1ae1f48b010319f5c Reviewed-on: https://gerrit.libreoffice.org/27594 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-07-27cppcheck: noExplicitConstructorCaolán McNamara
Change-Id: Id0a6cd461b2ba56e3b9b944514f3b0d0eb75cc44
2016-07-27loplugin:defaultparamsTor Lillqvist
Change-Id: Ib9a838b9d840baff62f1a0453eb370b6f665326d