summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2022-05-22move fuzzer to libtiffCaolán McNamara
Change-Id: Ib2a3da65f13a239076981473410a0e3240cab670 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134744 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-22cid#1504535 Uninitialized scalar fieldCaolán McNamara
Change-Id: I8a99a5e5e4ec892c460edb4151554cd071fb54ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134719 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-22tdf#145182 related: fix SwNavigator repositioning on resizeJim Raykowski
Repositioning on resize began with commit ca8f1ff34e291b74068dace619e58c37ef169f88 which is LOK related. The fix given in this patch checks if LOK is active before executing the lines of code that cause reposition to happen when LOK is not active. Change-Id: I13e7d289dd7ef1d99966d4f5b47a961b868b1b22 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131570 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2022-05-21tiff: output libtiff error via SAL_WARN for failuresCaolán McNamara
Change-Id: Iff62f8081d5d7b1971940775bd72722f376bf3d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134716 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-21drop unused hxx filesCaolán McNamara
Change-Id: I68ea314f20b599c181f2ae9f264037918419d15c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134715 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-21ofz#47559 Integer-overflowCaolán McNamara
setLinearPosX already takes a double so use that type for nOffset, use DeviceCoordinate as the types where that is the type of the source data Change-Id: I411d5034a42648bab94d6b8789bbdd172d0cf841 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134713 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-21tiff: add some error checksCaolán McNamara
Change-Id: I55ca42f637c802bc917eeba5c08cc82074edd523 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134697 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-21tiff: use more complicated apis to need a smaller buffer during readCaolán McNamara
while the split alpha persists as a thing Change-Id: I17b37650e66ae8bd4aa42b953cd39fcfe7ac80ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134696 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-21drop old tiff filterCaolán McNamara
Change-Id: I3bfeae4751cb9173fbe2efdbda531a9a1a491c8e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134695 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-21use libtiff for tiff importCaolán McNamara
TODO: check testTdf138818 change is acceptable/meaningful Change-Id: Ia72f2e7ec49a9f8fc23b178fe61cbc3d0e1287c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134647 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-21update Skia to chrome/m103Luboš Luňák
Change-Id: I35f1ca3fc703dbf31c68f4b145344b23029a156d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134688 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-05-20build libtiffJulien Nabet
Change-Id: Id9b6e1355147c3f68b9922db14f1b4904a05c686 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134650 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-20revert some questionable changes "new loplugin:unnecessary locking"Noel Grandin
in commit f2c02331a7dc0a924bbf30cbc279e92621e89590 which, as llunak points out, are questionable Change-Id: Ifb29429631c12c4f1c0b4da044a4d599592d3642 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134660 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-20vcl: avoid EXCEPTION_INT_DIVIDE_BY_ZEROXisco Fauli
See https://crashreport.libreoffice.org/stats/signature/FormattedField::Down() or https://crashreport.libreoffice.org/stats/signature/FormattedField::Up() Change-Id: I30dfb06a1261a48a75b9d9c2380ed78121758ec2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134674 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-20work around ImplGlyphFallbackLayout() returning garbage fallbackLuboš Luňák
As the comment says, this doesn't make sense to me, and it suggests that GetGlyphFallbackFont() is broken. And in case the missing codes list was in fact modified by the call, then ignoring the font and keeping the modified list meant fallback for those glyphs wasn't provided, which was confusing checkGlyphsEqual() in SalLayoutGlyphsCache. Restoring the missing codes list will not help much will the fallback, as that'll make this loop finding the same font, but at least this stops checkGlyphsEqual() assertion failures. I cannot reproduce this locally, only on the crashtesting server, by running '--headless --convert-to pdf' with ooo#57685. Change-Id: I533c776d1e470e6d6afe39a1363f7a203f345981 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134655 Tested-by: Luboš Luňák <l.lunak@collabora.com> Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-05-20remove remnants of hack for tdf#89231Luboš Luňák
The actual part doing the substitution was removed in 47ea13ef8dc8ab9aeded6121845e3ebd1d28b292, so this doesn't really do anything. Change-Id: I47e2e67d6d62bc4279f5efea4b60451dba567ede Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134654 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Luboš Luňák <l.lunak@collabora.com> Tested-by: Jenkins
2022-05-20remove useless variableLuboš Luňák
Change-Id: Ie6e95a4d089f3adb65e4f79ae0389eecb220488a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134658 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-05-20vcl: extend test to also check the descriptionXisco Fauli
Change-Id: I53dbec86254670ca09432a316962cb9e337b286b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134661 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-05-20vcl: move bDrawn variable closer to where it is first used in DrawEPS()Chris Sherlock
Change-Id: I0c11ec2de55121cf7369672e9db1fdc6a3f63770 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134002 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-05-20new loplugin:unnecessary lockingNoel Grandin
off by default, since each warning needs careful inspection Change-Id: I805c1d1cdde531a1afdc76e87b22f879fc3c9753 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134641 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-19vcl: a11y: Add test for text alternative value of images when exporting to pdfXisco Fauli
Checking tdf#57423, I found that the support for exporting alternative test to pdf was extended to all modules ( before it was only supported in Writer ) in 2840352ba56a212d191cc16e08378c87672d7b73 < Enhance tagged PDF export for a11y >. I'm pretty surprise to see there was no existing test for tagged PDF so this one is the first. Killing two birds with one stone Change-Id: Ia4ca51438f2539bde8edc21e9c7278840e57682e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134649 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-05-19follow org.freedesktop.appearance.color-scheme settingCaolán McNamara
Change-Id: Id26d01fd19cc3ee12c0e14b785b3a5149d22baf5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134553 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-19icon-theme not dynamically changing to match desktop if set to 'auto'Caolán McNamara
Change-Id: Id5700cff1000fe4b6df6e73c1ce9ff4f206e0a96 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134612 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-19No need to cast to char hereStephan Bergmann
...when comparing some unsigned values against ordinary character literals encoding characters from the basic execution character set (which are guaranteed to have non-negative values regardless of the signed-ness of plain char, cf. C++17 [lex.charset]/3 "For each basic execution character set, the values of the members shall be non-negative") Change-Id: I2928ad81406d117e7660f2b6f122051341c3954f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134605 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-05-19merge the g_bus_get_sync callsCaolán McNamara
Change-Id: I320feb6673f18d6d8d9c5afa9ab602b9405ec581 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134604 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-19Simplify an "ImportGraphic" method by removing useless pExtHeader (WmfExternal)Julien Nabet
Change-Id: I2916610e08c3157e0438ec90592fb5b8f921cc24 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134574 Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl> Tested-by: Jenkins
2022-05-19tdf#141186 ensure child of collapsed expander is not mappedCaolán McNamara
If the expander is initially collapsed then when mapped all its children are mapped too. If they are mapped then the mnemonics of the children are taken into account on shortcuts and non-visible children in a collapsed expander can be triggered which is confusing. If the expander is expanded and collapsed the child is unmapped and the problem doesn't occur. So to avoid the problem of an initially collapsed expander, listen to the map event and if the expander is mapped but collapsed then unmap the child of the expander. Change-Id: Ib4c7a704295b338230357c4c4102a3692f8a9707 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134542 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-18OutputDevice::GetBitmap(Ex) takes logical size, not pixelMike Kaganski
Change-Id: Id882cab9bb913c33bf586d278eb94c63636403c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134554 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-05-18tdf#105972: pdf form: export date fields as date typeXisco Fauli
using AFDate_FormatEx which allows to set a custom format Change-Id: I38839965423794a0278b783c39c612c361a90eea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134543 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-05-18Remove 1 ImportGraphic methodJulien Nabet
and replace its only use in Shape::renderDiagramToGraphic (oox/source/drawingml/shape.cxx) by an existing one. It became quite useless since 2876a0f79f94cdd139cc8fa40669acde9674bf8c (2020/03/03) graphic: remove preview when importing with GraphicFilter Change-Id: Iec3b13d85297bbe7cbfefe91a2a88e33e53d506b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134503 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-05-18Fix typoAndrea Gelmini
Change-Id: I476e2eb0769a542ca17b440fa98838f39a12efcc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134467 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-05-18osl::Mutex->std::mutex in SystemDependentDataBufferNoel Grandin
Change-Id: I3fcd1671195c65d370c4d27040c698b93591678d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134528 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-18tdf#105972: pdf form: export time fields as time typeXisco Fauli
using AFTime_FormatEx which allows to set a custom format Change-Id: I2d30d9d8340782ed9ad53eb43e1f65728f926b23 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134510 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-05-18Extend loplugin:redundantcast to trivial reinterpret_cast from T to itselfStephan Bergmann
Change-Id: I7c0be7b435d6b5f97bdd40484023584146638d70 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134506 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-05-18fix CID#1504438 for ImplFontMetricDataMark Hung
Change-Id: I037ad60c4bc2189ba6e93648ba9e168c6242efe7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134500 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-18tdf#137639 qt: UTF-16-encode mime data for "text/plain;charset=utf-16"Michael Weghorn
Return a `QVariant` from a `QByteArray` containing the UTF-16-encoded characters when mime data for mime type "text/plain;charset=utf-16" is requested in `QtMimeData::retrieveData`, rather than a `QVariant` created from a a `QString`, to ensure that UTF-16 encoded data is actually used in the end. While `QString` uses UTF-16 encoding itself, `QMimeDataPrivate::retrieveTypedData` from the Qt library would convert the retrieved `QString` data to UTF-8 [1], resulting in a mismatch because UTF-8 encoded data would actually be returned when UTF-16-encoded one has been requested. This gets called as follows: 0 QtMimeData::retrieveData 1 QMimeDataPrivate::retrieveTypedData 2 QMimeData::data 3 QtMimeData::deepCopy [1] https://code.qt.io/cgit/qt/qtbase.git/tree/src/corelib/kernel/qmimedata.cpp?h=6.3.0#n212 Change-Id: I3db1476838336682584145fb43d397c8eed29ce2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134456 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-05-18ofz#46060 TimeoutCaolán McNamara
Change-Id: I157c8e12ffd33f320b1b21232afd74c83891f915 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134492 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-17Revert "tdf#122057: read tiff with deflate compression (code 32946 only)"Julien Nabet
This reverts commit f0d3727322207b3a547313e14305440ad7009079. Reason for revert: Gimp was displaying a black rectangle, thought it was ok. Then with just Firefox, I could see that it should display a design plan for a house. Change-Id: I3a87ba24e779aee74d2124bf985b66c9cd7a0bb4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134449 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-05-17tdf#122057: read tiff with deflate compression (code 32946 only)Julien Nabet
tiff format is more a multiformat container with different combination of parameters, above all compression and photometric interpretation. For this one, the only pb was deflate compression wasn't dealt with. So just use existing LO wrapper for deflate lib in package part. Remark: for the moment only decompression 32946 (legacy deflate) is managed not Adobe deflate (code 8). I expected the same behaviour but some tests with tdf#131199 showed it didn't work. Change-Id: I2c8d244fa89a2378bfe3b87d3d3262810c9952be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134485 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-05-17ofz: Avoid Integer-overflowCaolán McNamara
Change-Id: Ic61403673b09a148f69aa582b1799e01564f84e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134487 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-17tdf#105972: pdf form: export numeric and currency fields as number typeXisco Fauli
Initial support for AFNumber_Format and AFNumber_Keystroke More info in https://experienceleague.adobe.com/docs/experience-manager-learn/assets/FormsAPIReference.pdf?lang=en This patch adds support for CurrencySymbol, DecimalAccuracy and PrependCurrencySymbol for now Change-Id: I8d6ffac51d576a8c243b9c6d5be2c3517bc0125a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134471 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-05-17vcl/GetTextBreak(): don't add extra width if char width is 0.Mark Hung
Char width is 0 when multiple characters made up of one glyph. Don't insert extra space in that case. Change-Id: Ieb37aa8a4fffc534d84acf994a231e801e89f782 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134244 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2022-05-17Drop pointless and misleading copypasta commentsTor Lillqvist
Change-Id: I68701a61944c0d950468c6f069d2d2f82d5237f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134228 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2022-05-17loplugin:unnecessaryparenStephan Bergmann
Change-Id: Ic96e2ee710cb28b0475c103ab9cba5974301e164 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134407 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-05-17qt: Drop unnecessary reinterpret_castMichael Weghorn
`OString::getStr` already returns `const char *`, so there's no need to cast to that. Change-Id: Ief787f9823ffea075882658cf0adec29a8030199 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134455 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-05-17std::map -> std::unordered_map (tdf#149112)Luboš Luňák
Faster and the ordering is not needed. Change-Id: I9d9f8ef084f441d24d35dc92ecf060f576d7db2e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134414 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-05-16use FontMetric as SalLayoutGlyphsCache key rather than vcl::FontLuboš Luňák
Apparently even calling OutputDevice::GetFontMetric() rather than GetFont() makes a difference with e.g. tdf#65046-1, when only vcl::Font is used it triggers the assert in checkGlyphsEqual() because of the fonts actually being different. Change-Id: I2a2aba6bf6d4bf78b7449ccdb16be0746663ee87 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134401 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-05-16pdfwriter: validator: fix rule 6.4-3Xisco Fauli
See https://github.com/veraPDF/veraPDF-validation-profiles/wiki/PDFA-Part-1-rules#rule-64-3 Spotted while validating https://bugs.documentfoundation.org/attachment.cgi?id=179703 from tdf#148706 with verapdf <https://demo.verapdf.org/> Change-Id: Ic6cfd18b0c2e8fd252ddd470eff23941f54bb29f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134402 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-05-16Revert "use more string_view in getNameNoExtension"Stephan Bergmann
This reverts commit d4f2b8eb74f430f5fc3622d668b33df1f99a0c1d, as it causes heap-use-after-free, e.g. during CppunitTest_dbaccess_hsqldb_test, > ==24944==ERROR: AddressSanitizer: heap-use-after-free on address 0x6070001a04a8 at pc 0x0000004b6b42 bp 0x7fff0f651490 sp 0x7fff0f650c40 > READ of size 56 at 0x6070001a04a8 thread T0 > #0 0x4b6b41 in __asan_memcpy /home/tdf/lode/packages/llvm-llvmorg-12.0.1.src/compiler-rt/lib/asan/asan_interceptors_memintrinsics.cpp:22 > #1 0x7f315931e373 in rtl::addDataHelper(char16_t*, char16_t const*, unsigned long) /include/rtl/stringconcat.hxx:89:9 > #2 0x7f3159beb290 in rtl::ToStringHelper<std::basic_string_view<char16_t, std::char_traits<char16_t> > >::addData(char16_t*, std::basic_string_view<char16_t, std::char_traits<char16_t> >) /include/rtl/stringconcat.hxx:553:14 > #3 0x7f3159beb7ea in rtl::OUStringConcat<rtl::OUStringConcatMarker, std::basic_string_view<char16_t, std::char_traits<char16_t> > >::addData(char16_t*) const /include/rtl/stringconcat.hxx:252:88 > #4 0x7f3159beb59d in rtl::ToStringHelper<rtl::OUStringConcat<rtl::OUStringConcatMarker, std::basic_string_view<char16_t, std::char_traits<char16_t> > > >::addData(char16_t*, rtl::OUStringConcat<rtl::OUStringConcatMarker, std::basic_string_view<char16_t, std::char_traits<char16_t> > > const&) /include/rtl/stringconcat.hxx:271:122 > #5 0x7f315c3dc450 in rtl::OUStringConcat<rtl::OUStringConcat<rtl::OUStringConcatMarker, std::basic_string_view<char16_t, std::char_traits<char16_t> > >, char const [5]>::addData(char16_t*) const /include/rtl/stringconcat.hxx:252:119 > #6 0x7f315c3c41b2 in rtl::OUString::OUString<rtl::OUStringConcat<rtl::OUStringConcatMarker, std::basic_string_view<char16_t, std::char_traits<char16_t> > >, char const [5]>(rtl::OUStringConcat<rtl::OUStringConcat<rtl::OUStringConcatMarker, std::basic_string_view<char16_t, std::char_traits<char16_t> > >, char const [5]>&&) /include/rtl/ustring.hxx:495:34 > #7 0x7f315c3eb066 in void __gnu_cxx::new_allocator<rtl::OUString>::construct<rtl::OUString, rtl::OUStringConcat<rtl::OUStringConcat<rtl::OUStringConcatMarker, std::basic_string_view<char16_t, std::char_traits<char16_t> > >, char const [5]> >(rtl::OUString*, rtl::OUStringConcat<rtl::OUStringConcat<rtl::OUStringConcatMarker, std::basic_string_view<char16_t, std::char_traits<char16_t> > >, char const [5]>&&) /opt/rh/devtoolset-7/root/usr/lib/gcc/x86_64-redhat-linux/7/../../../../include/c++/7/ext/new_allocator.h:136:23 > #8 0x7f315c3e9e46 in void std::allocator_traits<std::allocator<rtl::OUString> >::construct<rtl::OUString, rtl::OUStringConcat<rtl::OUStringConcat<rtl::OUStringConcatMarker, std::basic_string_view<char16_t, std::char_traits<char16_t> > >, char const [5]> >(std::allocator<rtl::OUString>&, rtl::OUString*, rtl::OUStringConcat<rtl::OUStringConcat<rtl::OUStringConcatMarker, std::basic_string_view<char16_t, std::char_traits<char16_t> > >, char const [5]>&&) /opt/rh/devtoolset-7/root/usr/lib/gcc/x86_64-redhat-linux/7/../../../../include/c++/7/bits/alloc_traits.h:475:8 > #9 0x7f315c3ea266 in void std::__cxx1998::vector<rtl::OUString, std::allocator<rtl::OUString> >::_M_realloc_insert<rtl::OUStringConcat<rtl::OUStringConcat<rtl::OUStringConcatMarker, std::basic_string_view<char16_t, std::char_traits<char16_t> > >, char const [5]> >(__gnu_cxx::__normal_iterator<rtl::OUString*, std::__cxx1998::vector<rtl::OUString, std::allocator<rtl::OUString> > >, rtl::OUStringConcat<rtl::OUStringConcat<rtl::OUStringConcatMarker, std::basic_string_view<char16_t, std::char_traits<char16_t> > >, char const [5]>&&) /opt/rh/devtoolset-7/root/usr/lib/gcc/x86_64-redhat-linux/7/../../../../include/c++/7/bits/vector.tcc:415:4 > #10 0x7f315c3e9c59 in rtl::OUString& std::__cxx1998::vector<rtl::OUString, std::allocator<rtl::OUString> >::emplace_back<rtl::OUStringConcat<rtl::OUStringConcat<rtl::OUStringConcatMarker, std::basic_string_view<char16_t, std::char_traits<char16_t> > >, char const [5]> >(rtl::OUStringConcat<rtl::OUStringConcat<rtl::OUStringConcatMarker, std::basic_string_view<char16_t, std::char_traits<char16_t> > >, char const [5]>&&) /opt/rh/devtoolset-7/root/usr/lib/gcc/x86_64-redhat-linux/7/../../../../include/c++/7/bits/vector.tcc:105:4 > #11 0x7f315c3bc742 in rtl::OUString& std::__debug::vector<rtl::OUString, std::allocator<rtl::OUString> >::emplace_back<rtl::OUStringConcat<rtl::OUStringConcat<rtl::OUStringConcatMarker, std::basic_string_view<char16_t, std::char_traits<char16_t> > >, char const [5]> >(rtl::OUStringConcat<rtl::OUStringConcat<rtl::OUStringConcatMarker, std::basic_string_view<char16_t, std::char_traits<char16_t> > >, char const [5]>&&) /opt/rh/devtoolset-7/root/usr/lib/gcc/x86_64-redhat-linux/7/../../../../include/c++/7/debug/vector:489:11 > #12 0x7f315c3a7729 in ImplImageTree::getPaths(rtl::OUString const&, LanguageTag const&) /vcl/source/image/ImplImageTree.cxx:226:20 [...] (<https://ci.libreoffice.org//job/lo_ubsan/2399/>) Change-Id: I3af57646bc97c33aad4570a4d6b68dff340b4c64 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134390 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-05-16optimise common case of reading a single-pass PNGNoel Grandin
Change-Id: I5408f9d9b7c3e0d08c1bc6bafaca97f18898387f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134342 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-02-09 08:04:19 +0000