summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2017-01-06use same logic in both CreatesCaolán McNamara
Change-Id: I49dab360c5f93e40f5a6e91fbe721935d795472c
2017-01-06lsan+wmffuzzer shows a circular reference leading to a leakCaolán McNamara
graphic gets a context set on it which has a shallow copy of the graphic in it. ==37==ERROR: LeakSanitizer: detected memory leaks Indirect leak of 1024 byte(s) in 1 object(s) allocated from: #0 0x6170b0 in operator new[](unsigned long) /src/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:84 #1 0x91361b in BitmapPalette::BitmapPalette(unsigned short) /src/libreoffice/include/vcl/salbtype.hxx:467:56 #2 0x9029f0 in GIFReader::GIFReader(SvStream&) /src/libreoffice/vcl/source/filter/igif/gifread.cxx:114:7 #3 0x91648d in std::__1::__libcpp_compressed_pair_imp<std::__1::allocator<GIFReader>, GIFReader, 1u>::__libcpp_compressed_pair_imp<std::__1::allocator<GIFReader>&, SvStream&, 0ul, 0ul>(std::__1::piecewise_construct_t, std::__1::tuple<std::__1::allocator<GIFReader>&>, std::__1::tuple<SvStream&>, std::__1::__tuple_indices<0ul>, std::__1::__tuple_indices<0ul>) /usr/local/bin/../include/c++/v1/memory:2173:15 #4 0x91648d in std::__1::__compressed_pair<std::__1::allocator<GIFReader>, GIFReader>::__compressed_pair<std::__1::allocator<GIFReader>&, SvStream&>(std::__1::piecewise_construct_t, std::__1::tuple<std::__1::allocator<GIFReader>&>, std::__1::tuple<SvStream&>) /usr/local/bin/../include/c++/v1/memory:2330 #5 0x91648d in std::__1::__shared_ptr_emplace<GIFReader, std::__1::allocator<GIFReader> >::__shared_ptr_emplace<SvStream&>(std::__1::allocator<GIFReader>, SvStream&) /usr/local/bin/../include/c++/v1/memory:3827 #6 0x91648d in std::__1::shared_ptr<GIFReader> std::__1::shared_ptr<GIFReader>::make_shared<SvStream&>(SvStream&) /usr/local/bin/../include/c++/v1/memory:4443 #7 0x91284b in _ZNSt3__111make_sharedI9GIFReaderJR8SvStreamEEENS_9enable_ifIXntsr8is_arrayIT_EE5valueENS_10shared_ptrIS5_EEE4typeEDpOT0_ /usr/local/bin/../include/c++/v1/memory:4807:12 #8 0x91284b in ImportGIF(SvStream&, Graphic&) /src/libreoffice/vcl/source/filter/igif/gifread.cxx:889 #9 0x61c85c in LLVMFuzzerTestOneInput /src/libreoffice/vcl/workben/giffuzzer.cxx:18:11 #10 0x575ef58 in fuzzer::Fuzzer::ExecuteCallback(unsigned char const*, unsigned long) /src/libfuzzer/FuzzerLoop.cpp:546:13 #11 0x575fcb4 in fuzzer::Fuzzer::RunOne(unsigned char const*, unsigned long) /src/libfuzzer/FuzzerLoop.cpp:497:3 #12 0x577e43a in fuzzer::Fuzzer::RunOne(std::__1::vector<unsigned char, std::__1::allocator<unsigned char> > const&) /src/libfuzzer/FuzzerInternal.h:119:41 #13 0x575e5ad in fuzzer::Fuzzer::ShuffleAndMinimize(std::__1::vector<std::__1::vector<unsigned char, std::__1::allocator<unsigned char> >, std::__1::allocator<std::__1::vector<unsigned char, std::__1::allocator<unsigned char> > > >*) /src/libfuzzer/FuzzerLoop.cpp:476:30 #14 0x5708588 in fuzzer::FuzzerDriver(int*, char***, int (*)(unsigned char const*, unsigned long)) /src/libfuzzer/FuzzerDriver.cpp:534:6 #15 0x56fb3c8 in main /src/libfuzzer/FuzzerMain.cpp:20:10 #16 0x7fb5f13da82f in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x2082f) Change-Id: I1384f4ced094e79a27e7d15b569c88f129cd115a
2017-01-05add gif fuzzerCaolán McNamara
Change-Id: I47dc449464cc7643d05b73e9612d01e50a8d4b8e
2017-01-05Related: tdf#45820 polygon clipping during wmf load is ultra slowCaolán McNamara
For file fuzzing defer actually doing it during load and just set a clipping region, which can take a polypolygon argument, instead of setting a basic cliping rectangle + complexclip flag to specially clip certain things for normal use, continue to do the slow thing as it gives different visual output, so its either not quite the right thing, or there's bugs elsewhere that would need to be fixed to go this way the whole time Change-Id: Ieac7ab54ed7d7c1ca14afd75b25fe273fd676c5d
2017-01-05move ImageList to frameworkCaolán McNamara
this can probably be replaced by a std::*map<Image> Change-Id: Ic36c5f406f5ea51cb9ff135858e319e0877179c7
2017-01-05move CommandImageResolver out of vcl and beside its only userCaolán McNamara
Change-Id: I2bd70d87bb12d5750d8427b8a8fe786cfce8961b
2017-01-05drop unused forward declCaolán McNamara
Change-Id: Ie4a2ac8e5363539eb09bb16f13f46829c3c63785
2017-01-05drop newly unused InsertFromHorizontalBitmapCaolán McNamara
Change-Id: Ia0b0032bf261712be30ac23c8e5ce993011b2e5c
2017-01-05drop newly unused definesCaolán McNamara
Change-Id: I9ab375c851b4c0738bceec3c2cefc16df57c16ce
2017-01-05unwind radio and check img listsCaolán McNamara
Change-Id: I7ce7621254583207b913555614204a3733e74263
2017-01-05Improve last commitMaxim Monastirsky
Change-Id: I4feb71c9117e13f18e2c5215714fd0170f166b64
2017-01-05tdf#102059 NotebookBar accessible using F6 keySzymon Kłos
Change-Id: I873c49d8c0557eb3702de921fb5d2281acfed526 Reviewed-on: https://gerrit.libreoffice.org/32459 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2017-01-04tdf#104944 gtk3: Ignore mouse up event if the wrong frameMaxim Monastirsky
Change-Id: I3d0aad6d2b434866df9110d3b8493fec2d2c94fe Reviewed-on: https://gerrit.libreoffice.org/32465 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2017-01-04last bitmaps that pMaskColor arg was used on converted to true transparencyCaolán McNamara
Change-Id: I99bb32355bc53e2c870f84e60fc1e35b9dfe8270
2017-01-04convert these mono versions to pngCaolán McNamara
Change-Id: I93755ac95c170c457b32adac07557ed48ad8beee
2017-01-04drop unused SplitWindow::ImplDrawButtonRectCaolán McNamara
Change-Id: I0ccb4adfec39f8717d5921e04809af65be066d0a
2017-01-04unused bitmap resourcesCaolán McNamara
Change-Id: Ia76b548e993d13c7706ab126109086cbd0717b4c
2017-01-04follow up remove unused autohide leftoversCaolán McNamara
Change-Id: Ic7281e915075519c300a330557399111838d7d34
2017-01-04drop AutoHide codeCaolán McNamara
only used from reportdesign and that appears to be overlooked from an earlier eradication program Change-Id: I196fd7ccbc909c935daf534d55e6b39de8510f23
2017-01-04tdf#105093 sd PDF export: handle embedded videosMiklos Vajna
In practie embedded files always have a temp file URL, so from the PDF export's point of view they are still URLs, just at the end the contents of the URL is embedded to the PDF, not just the URL itself. So add a SetScreenStream() that's similar to SetScreenURL(), but it's for embedded, not linked videos. Change-Id: Ifcc60357ef0f5fed0bdec02e0c84cb16ee147781 Reviewed-on: https://gerrit.libreoffice.org/32727 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-01-04tdf#97228 Moved class ControlCacheKey in a seperate include file.Huzaifa Iftikhar
class ControlCacheKey defined in include/vcl/salnativewidgets.hxx is used only by vcl therefore it is moved to a seperate include file named ControlCacheKey.hxx which is inside vcl/inc/ControlCacheKey.hxx. This header file contains the definition of the the class ControlCacheKey. Since this class uses an object of another class named Size which is defined in gen.hxx therefore this is included in ControlCacheKey.hxx. All the files that references the class ControlCacheKey includes ControlCacheKey.hxx with the syntax: #include "ControlCacheKey.hxx" Change-Id: I7d7b3e1cf6950a953e6bbed670c1914826b2bacd Reviewed-on: https://gerrit.libreoffice.org/32422 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-01-04split SV_RESID_BITMAP_MSGBOX upCaolán McNamara
Change-Id: I4ebf48e5def5fb31aa7e34b5b6f89b220a27d1a6
2017-01-04vcl: hold VclPtrs to avoid possible lifecycle related crashers.Michael Meeks
Makes code on common EnableInput crash reporter trace safer. Change-Id: Ibcf218d0d2460383d12e19f48aaf0ab08e541532 Reviewed-on: https://gerrit.libreoffice.org/32706 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2017-01-04Related: tdf#104841 sw PDF export: handle linked videos on non-first pagesMiklos Vajna
Be explicit about the page number, this way a video on the second page doesn't end up as an annotation for the first page. (In the Impress case each slide is exported separately, so there this wasn't a problem.) Change-Id: I83ba9cb4a3b2a6734bd88a138654e391199651c6 Reviewed-on: https://gerrit.libreoffice.org/32696 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-01-03split SV_RESID_BITMAP_SCROLLBMP upCaolán McNamara
Change-Id: I303f60b3347f6e079dd951b0c2a0b727a0696eef
2017-01-03drop else branch of if (true)Caolán McNamara
Change-Id: Id11f005f32a0c66e9584c90aebb6943ed41acaf0
2017-01-03SetPin and IsPinned are in an always-false circular isolated relationshipCaolán McNamara
Change-Id: I4fb3aaa8a5e8c62091fbc542deae6af3a113a608
2017-01-03SV_HELPTEXT_ALWAYSVISIBLE is unusedCaolán McNamara
Change-Id: Ib602edbbc2d972ec77e4d9d76ac493912579554a
2017-01-03mnPinState is unusedCaolán McNamara
Change-Id: If8764b5cfda173bedfe2e911e39bf5b5e8a8573a
2017-01-03BorderWindowHitTest::Pin is never setCaolán McNamara
Change-Id: Ic50dd49b1470d4ee233e781e8c951c10c84968fd
2017-01-03no PinImgList is unusedCaolán McNamara
Change-Id: Ifc1552fe9f82cc315f8ad821120339021be68dcf
2017-01-03so maPinRect is always emptyCaolán McNamara
Change-Id: Ia2ee10ead7068d4809f5a3ba8fbf01fdf6e4a1c9
2017-01-03WB_PINABLE isn't set anywhereCaolán McNamara
Change-Id: I6acc4b9dc87dd6023b5ad7013bc27180d6e0db6c
2017-01-03Mark [Scoped]VclPtrInstance as SAL_WARN_UNUSEDStephan Bergmann
Stack-allocated instances of the non-Instance [Scoped]VclPtr variants are occasionally used merely for the side-effect of holding objects alive (like css::uno::Reference and rtl::Reference, which are also not SAL_WARN_UNUSED for that reason). Change-Id: I37ebfaf028a646cb2777c0baf0d99992057a22bd
2017-01-03avoid some numeric type conversionsJochen Nitschke
Change-Id: I89329ae1dc2c46b6412fcefd31cdb3dcd907354d Reviewed-on: https://gerrit.libreoffice.org/32658 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-01-02coverity#708661 Uninitialized scalar fieldCaolán McNamara
Change-Id: I1e87e7f6d135f9e4a0b4efbb4ce7e6e08663f675
2017-01-02fix indentCaolán McNamara
Change-Id: I39e79bc56c437323d4d860174242905ee5261cf6
2017-01-02add a jpg fuzzerCaolán McNamara
reshuffle things to share common core Change-Id: I50aa0e2ddeefaa4b2d0592b1118defd28b7347db
2017-01-02tdf#104841 sd PDF export: handle linked videosMiklos Vajna
Use the screen annotation markup for this purpose. Change-Id: I129111cbe08c19c2f3b3ae046408ff9b2a28520c Reviewed-on: https://gerrit.libreoffice.org/32654 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-01-02vcl PDF export: enable MARK() in dbglevel<2 builds as wellMiklos Vajna
Instead of mandating dbglevel=2, use the already existing environment variable to avoid additional rebuilds. Change-Id: I9ac543522e0e79dd2be74e12d0dd0551be63988f Reviewed-on: https://gerrit.libreoffice.org/32638 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-01-02The mfFontScale[n] is always 1.0Khaled Hosny
Change-Id: Ica2e67632f5bfe1f70ba7b2d7502257b47d053ce Reviewed-on: https://gerrit.libreoffice.org/32592 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2017-01-02Use FindMetricCompatibleFont() here as wellKhaled Hosny
Change-Id: I4b4c360a58f5e0176688294dc3d18aacfd000277 Reviewed-on: https://gerrit.libreoffice.org/32581 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2017-01-01return earlier, no logic change intendedCaolán McNamara
Change-Id: Icd75c46eb57c059fb60fd9701e6bb1fb651d8f3f
2017-01-01so noone cares about the return of [Read|Write]ImpGraphicCaolán McNamara
Change-Id: I2e251ff71b1f20e43c797c3fc901f3a70dce7c6c
2017-01-01noone cares about the return from WriteGraphic eitherCaolán McNamara
Change-Id: Ia91a8b4ae7768bd1623b8e2b545fcc9beff1fbc7
2017-01-01noone cares about the return from ReadGraphicCaolán McNamara
Change-Id: Ifd86dee6f2657155faaa31a229feb16178d89f34
2017-01-01return earlier, no logic change intendedCaolán McNamara
Change-Id: I39679d1c24ffa6f11c067a8fc3957c6a870f7403
2016-12-31coverity#1398232 Uninitialized scalar fieldCaolán McNamara
Change-Id: Ia5e9ebecc032e59bf98d32b0de0f11617da8b2ba
2016-12-31unused maMapUnitRes memberCaolán McNamara
since commit 7abd369964a0c7f9f80cdbc9e47c7dc120fe8257 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Thu Nov 3 14:00:28 2016 +0200 loplugin:unusedmethods Change-Id: Ie1f840c3ec9a2d5888f95cf05e531a8a9464bf2e Reviewed-on: https://gerrit.libreoffice.org/30524 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Change-Id: I4cb8167698d460df6a56c5b3b7d01841e3f1a69a
2016-12-31coverity#1398233 Uninitialized scalar fieldCaolán McNamara
Change-Id: I79661c54dc5ffe3c690ec544fbb5de0fb8a87302
generated by cgit (git 2.34.1) at 2025-01-07 22:51:04 +0000