summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2021-09-20tdf#124176 - Use pragma once instead of include guardsChris Sherlock
This patch is created in preparation of a patch I have queued to test and move PhysicalFontFace to vcl::font namespace. Change-Id: I805a8bd1fa881fc4bc6d2f26f1051b9247587701 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122226 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-09-20clean up ambiguous confusing rectangle APIs like IsInside()Luboš Luňák
Reading 'rectA.IsInside( rectB )' kind of suggests that the code checks whether 'rectA is inside rectB', but it's actually the other way around. Rename IsInside() -> Contains(), IsOver() -> Overlaps(), which should make it clear which way the logic goes. Change-Id: I9347450fe7dc34c96df6d636a4e3e660de1801ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122271 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Luboš Luňák <l.lunak@collabora.com> Tested-by: Jenkins
2021-09-20Add sal/config.h in preparation for patchChris Sherlock
The convention is that we need to add sal/config.h to the start of files. I have a patch queued to be able to create a FontMetric from a PhysicalFontFace. Submitting this patch so I can hopefully one day land this patch. Change-Id: I5817acd6e194da576f2c8a13539d38954a4f4e15 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122172 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-09-20vcl: unneeded functions in PhysicalFontFaceChris Sherlock
Nothing uses PhysicalFontFace::SetBitmapSize(), so remove it. This in turn meant that the class doesn't ever use CompareWithSize() directly, as this calls on CompareIgnoreSize() when no width or height is set I have removed CompareWithSize(). Change-Id: I1012ffd3bc0f39f917a8b725f9985844967533dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121931 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-09-19cid#1492159 Uninitialized scalar fieldCaolán McNamara
since... commit c2e6a068c112f4c5866b6371d02362bd71f903a3 Date: Wed Sep 8 12:07:48 2021 +1000 vcl: create FontMetric from PhysicalFontFace where previously we had... FontMetric aFontMetric; ... aFontMetric.SetFamilyName( rData.GetFamilyName() ); ... return aFontMetric; so the FontMetric default ctor was called which initialized all FontMetric's members, but afterwards with... return FontMetric(rData); the new FontMetric ctor taking a const PhysicalFontFace& arg left all the non-inherited members of FontMetric uninitialized Change-Id: I91ee08ed1d63d15eccec44c87841884b2992eacb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122317 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-19ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: I8de015f7c748de338f989a383838ce3921d176a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122315 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-19vcl: test PhysicalFontFamily and move to vcl::font namespaceChris Sherlock
- Adds a series of unit tests for PhysicalFontFamily - Moves PhysicalFontFamily into vcl::font - Move PhysicalFontFamily.hxx into vcl/inc/font This is part of a series of patches where I also move font files into the relevant font directories, and into the vcl::font namespace. Change-Id: I9e8d7ceb5ec3494bf3ab6560645e52e88223ee69 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121903 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-09-18ofz: reduce size of hwp inputCaolán McNamara
fuzzer seems to hover right at the edge of an intermittent timeout Change-Id: I478c0f355ceb4d05c60834db3f2dc14a72696794 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122303 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-18vcl: add sal/config.h in preparation for patchChris Sherlock
The convention is that we need to add sal/config.h to the start of files. I have a patch queued to test PhysicalFontFamily and move it to vcl::font. Submitting patch to update the modelines in the files that I will change in that patch. Change-Id: I92275250bc5e12f7e6f7c0d4b6405d6a6e8de033 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122179 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-09-18vcl: create FontMetric from PhysicalFontFaceChris Sherlock
A FontMetric can be created from a PhysicalFontFace, so setup a constructor that takes a PhysicalFontFace object to instantiate the FontMetric. The OutputDevice functions GetDevFont() and GetDevFontCount() don't necessarily make much sense, so have changed GetDevFont() to GetFontMetricFromCollection() and GetDevFontCount() to GetFontFaceCollectionCount(). Change-Id: I1577679b949a49a7cf1248838786d0f5e84a5245 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121796 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-09-18vcl: rename ImplDeviceFontList to PhysicalFontFaceCollection and testChris Sherlock
- renamed ImplDeviceFontList to PhysicalFontFaceCollection and moved to own header file - wrote unit test for PhysicalFontFaceCollection Note that this is part of a series of patches where I also move font files into the relevant font directories, and into the vcl::font namespace. Change-Id: I43669137bcd9a9b2a9417b2369a5cb1b93b93733 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121663 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2021-09-18vcl: add sal/config.h in preparation for patchChris Sherlock
The convention is that we need to add sal/config.h to the start of files. <chris_wot> mikekaganski do you want me to add sal/config.h to cxx files <chris_wot> as well as headers? <mikekaganski> chris_wot: rather ask sberg :) <@sberg> chris_wot, always, always as first include, by convention <chris_wot> thanks, I'll make sure I do this on any files I touch - if that's OK I have a patch queued to rename ImplDeviceFontList to PhysicalFontFaceCollection, which I am adding a test to. Submitting this patch so I can hopefully one day land this patch. Change-Id: I9d74f850745760774a9f8050023f584cf52dc070 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122167 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-09-18tdf#124176 - Use pragma once instead of include guardsChris Sherlock
I have a patch queued to rename ImplDeviceFontList to PhysicalFontFaceCollection, which I am adding a test to. Submitting patch to update the include guards to pragma once Change-Id: I091817905599089edec1138eeee06ba3dacd6964 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122225 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-09-17gtk4: fill context menusCaolán McNamara
Change-Id: Ie59f569f8917dee730e79a3bea6c3e6161ae9fea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122241 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-17vcl: update vim modelines in preparation for new changeChris Sherlock
I have a patch queued to rename ImplDeviceFontList to PhysicalFontFaceCollection, which I am adding a test to. Submitting patch to update the modelines in the files that I will change in that patch. Change-Id: I3b0b022cbfa7b05dbfbb5c2d03f6d68128c0598f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122232 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-09-17gtk4: guard vcl calls from gtkCaolán McNamara
Change-Id: Iff35ff96c5df987258979b388485af4f3d1f039e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122240 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-17Fix gtk4 build ('--enable-werror')Michael Weghorn
Fixes [CXX] vcl/unx/gtk4/transferableprovider.cxx In file included from vcl/unx/gtk4/salnativewidgets-gtk.cxx:10: vcl/unx/gtk4/../gtk3/salnativewidgets-gtk.cxx:364:19: error: ‘gTreeViewWidget’ defined but not used [-Werror=unused-variable] 364 | static GtkWidget* gTreeViewWidget; | ^~~~~~~~~~~~~~~ vcl/unx/gtk4/../gtk3/salnativewidgets-gtk.cxx:363:19: error: ‘gListBox’ defined but not used [-Werror=unused-variable] 363 | static GtkWidget* gListBox; | ^~~~~~~~ vcl/unx/gtk4/../gtk3/salnativewidgets-gtk.cxx:362:19: error: ‘gComboBox’ defined but not used [-Werror=unused-variable] 362 | static GtkWidget* gComboBox; | ^~~~~~~~~ vcl/unx/gtk4/../gtk3/salnativewidgets-gtk.cxx:355:19: error: ‘gSpinBox’ defined but not used [-Werror=unused-variable] 355 | static GtkWidget* gSpinBox; | ^~~~~~~~ cc1plus: all warnings being treated as errors make[1]: *** [solenv/gbuild/LinkTarget.mk:307: workdir/CxxObject/vcl/unx/gtk4/salnativewidgets-gtk.o] Error 1 make[1]: *** Waiting for unfinished jobs.... In file included from vcl/unx/gtk4/notifyinglayout.hxx:13, from vcl/unx/gtk4/gtkinst.cxx:14: vcl/unx/gtk4/../gtk3/gtkinst.cxx:4385:11: error: ‘static void {anonymous}::GtkInstanceWidget::LinkStubasync_drag_cancel(void*, void*)’ defined but not used [-Werror=unused-function] 4385 | IMPL_LINK(GtkInstanceWidget, async_drag_cancel, void*, arg, void) | ^~~~~~~~~~~~~~~~~ include/tools/link.hxx:45:13: note: in definition of macro ‘IMPL_LINK’ 45 | RetType Class::LinkStub##Member(void * instance, ArgType data) { \ | ^~~~~ cc1plus: all warnings being treated as errors make[1]: *** [solenv/gbuild/LinkTarget.mk:304: workdir/CxxObject/vcl/unx/gtk4/gtkinst.o] Error 1 make: *** [Makefile:288: build] Error 2 Change-Id: Id570c22aa66bf134fdc4dda31a0cf1f867f3653d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122235 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2021-09-17gtk4: get menus attached to menubuttons after load time workingCaolán McNamara
run update_action_group_from_popover_model on the newly attached menu Change-Id: If871dea4833c60efc5853de19031fc6e45544170 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122198 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Jenkins
2021-09-17gtk4: listen to "toggled" so callbacks see get_menu_item_active of trueCaolán McNamara
Change-Id: I130ebbb6dad9c0f69667a1c95e97583183656710 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122211 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-17Drop conditional WM_GETOBJECT define from vcl/win/window/salframe.cxxMichael Weghorn
WM_GETOBJECT is already defined in WinUser.h. Change-Id: I7594560698dd2a17412f5075f8b689decbd4ca49 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122202 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2021-09-17avoid more window invalidation in LOK modeLuboš Luňák
This is an extension of 9b73d3e8926d5f9b10464d19b539eef3eb088f50. If we're not painting to windows in LOK mode, then it's a waste of CPU time to calculate invalidations for them when it'll be thrown away anyway. Change-Id: I20b1064cb9e41fd6d88b8dc2ee4edb80ae0e9104 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122194 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-09-16gtk4: use gtk_menu_button_set_child when available to fill in iconCaolán McNamara
Change-Id: I3da421969cf1775cbf0072bf94891d883a96b70e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122193 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-16gtk4: 4.6.0 will have gtk_menu_button_set_childCaolán McNamara
which will solve the problem of setting icons and keeping the drop down for GtkMenuButtons used in toolbars Change-Id: I9e0632c8756e7085868541d11709aa598f738bf0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122192 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-16gtk4: set always-show-arrow on GtkMenuToolButton replacementsCaolán McNamara
Change-Id: I4c1be40e40d2f1e2bcbf26cffda7a6dd52e4f731 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122191 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-16gtk4: adjust to GtkMenuButton changes in 4.6 onwardsCaolán McNamara
Change-Id: I892aae979f8fb9b5a7c13a790905d7e7e3f2c087 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122190 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-16find_menu_button only needed for gtk3Caolán McNamara
Change-Id: I3eeb7dea4ff36b8c969aec210161c1729ab9b372 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122189 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-16gtk4: set can-shrink to False for GtkPictureCaolán McNamara
for the icon in GtkMenuButton in the calc, insert, header and footer in gtk 4.6 where the MenuButton begins to support a child widget again but the icon while now shown in squished Change-Id: Ibc274d88b1185eee0ee61973b40b5cde2d08f554 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122187 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-16gtk4: set newly available always-show-arrow propertyCaolán McNamara
since 4.4 Change-Id: I6d7d0077617077606a7ef48f22183fcd3ca69c88 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122181 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-15add some logging for intermittent windows jenkins crashNoel Grandin
Change-Id: I8ad589dd8d0a64f75179d3330c80c9c43a21ff32 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122155 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-15loplugin:finalclassesNoel Grandin
Change-Id: I88831f290e1923db6fb5a733746bfa3bc7fbc7e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122148 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-15gtk4: remove text-button css property on setting a child image widgetCaolán McNamara
I suspect this happens automatically > 4.2.1 Change-Id: I1b752ee5cec00005fe0f552548f38eab40249087 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122144 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-15No need to check for x = 0 in atan2 hereMike Kaganski
The guarantee is that either x or y argument is non-0. It was this way ever since "initial import" commit 8ab086b6cc054501bfbf7ef6fa509c393691e860. Change-Id: I2f5ccbbc9a4f00aafef151ef3dd008eddeef0e78 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122114 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-09-15Resolves: tdf#143487 don't draw a border at all for DrawFrameStyle::NONECaolán McNamara
Change-Id: I7794376c9475a32276d23135365c99a3f6fb7d84 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122142 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-15default Aliasing of secondary mpAlphaVDev to the same as its ownerCaolán McNamara
when its created, as noted in... commit e1a5bcb20e15400320f926165b6d798fa36c564e Author: Caolán McNamara <caolanm@redhat.com> Date: Tue Sep 14 20:30:58 2021 +0100 tdf#143831 fix black background appearing on spellchecking wavy lines ... OutputDevice::SetAntialiasing only mirrors its arg to the secondary mpAlphaVDev if it exists, and it doesn't exist until the size is set so move that call down a bit (this is probably another preexisting bug maybe worth following up on to set that when mpAlphaVDev is created) Change-Id: I8ef27aae4dcabe529327224bfc6cd7b4bb2a5af5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122141 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-15loplugin:unusedfieldsNoel Grandin
m_pSoftMaskStream is dead since commit 581e7d7057afa87036d84e42c0e0a8a7368e20c7 Author: Joseph Powers <jpowers27@cox.net> Date: Thu Sep 1 20:51:15 2011 -0700 unusedcode.easy: PDFWriter cleanup Change-Id: If397981fb09a7b74ba2294513c13186cc51ad5fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122139 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-15gtk4: allow combobox text width to shrink smaller than natural requestCaolán McNamara
Change-Id: I9648097ca9f77494ec4ddb2662dbc0372b998cd4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122140 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-15loplugin:constvarsNoel Grandin
Change-Id: I9b35d6333afa6b305bf73fc55a7e60c8365674e9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122134 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-15ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: I5ae6f55789eebdc688ead4524a7af7a7739314bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122110 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-15Related: tdf#143831 the svp aliased case ends up overly washed outCaolán McNamara
as seen under gtk3 Change-Id: I0bcea49f8c24e9f773b357483cea78e58bb07e15 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122099 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-15Related: tdf#143831 add guards to ImplDrawWaveLineBezierCaolán McNamara
seeing as the mpAlphaVDev ImplDrawWaveLineBezier sub call is not protected otherwise now that it can be called from the outer case Change-Id: I66f0fea134aa177bd7493720670c4724311752a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122098 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-15tdf#143831 fix black background appearing on spellchecking wavy linesCaolán McNamara
SetBackground() doesn't fill the outputdevice automatically, Erase() has to be called to do that. Then the way the horrible transparency split 24bit rgb + 8bit alpha thing works is that the same thing has to be drawn into the 24bit surface and the 8bit surface with black used as the line/fill color in the 8bit surface. OutputDevice::SetAntialiasing only mirrors its arg to the secondary mpAlphaVDev if it exists, and it doesn't exist until the size is set so move that call down a bit (this is probably another preexisting bug maybe worth following up on to set that when mpAlphaVDev is created) Change-Id: I39f71def6b51d78746b41ed2e30a36dc150370bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122097 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-15Use <comphelper/servicehelper.hxx> implementing XUnoTunnel part 4Mike Kaganski
- Change implementations of getSomething to use getSomethingImpl Or where that's impossible, use getSomething_cast to unify this and reduce number of places where we reinterpret_cast. All static methods getting tunnel ids were renamed to getUnoTunnelId, to comply with the convention used in <comphelper/servicehelper.hxx>. TODO (in separate commits): - Revise uses of getSomething to use getFromUnoTunnel Change-Id: Ifde9e214b52e5df678de71fcc32d2199c82e85cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122100 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-09-15Use <comphelper/servicehelper.hxx> implementing XUnoTunnel part 3 [API CHANGE]Mike Kaganski
- Replace all uses of OImplementationId in core with UnoIdInit - Deprecate OImplementationId in <cppuhelper/typeprovider.hxx> OImplementationId uses broken double checked locking; additionally, it uses it at the first call to getImplementationId, not when the object is constructed. This implementation can't be changed, cince it's part of published API; it can't rely on C++11, which would be required for use of thread-safe statics and move the initialization to ctor. The class has obsolete _bUseEthernetAddress member, that is unused and ignored since 4e9fa7e339a1cd6cb2fec643715991bcf5057cec. No need to implement it when replacing its uses to UnoIdInit. The deprecation is the API CHANGE. No published API is introduced to replace it; 3rd-party code should seek alternative solutions, or just keep using the deprecated functionality. TODO (in separate commits): - Change implementations of getSomething to use getSomethingImpl - Revise uses of getSomething to use getFromUnoTunnel Change-Id: I8b6e684e5389bc0d5bb3b7f21f72a4c8f684107d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122077 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-09-15Use <comphelper/servicehelper.hxx> implementing XUnoTunnel part 1Mike Kaganski
The header got some changes: 1. Move UnoTunnelIdInit and isUnoTunnelId into 'comphelper' namespace 2. Rename UnoTunnelIdInit to UnoIdInit, as a precondition to replace of uses of OImplementationId with it, including in XTypeProvider 3. Introduce convenience functions 'getSomething_cast' to cast between sal_Int64 and object pointers uniformly. 4. Rename getUnoTunnelImplementation to getFromUnoTunnel, both to make it a bit shorter, and to reflect its function better. Templatize it to take also css::uno::Any for convenience. 5. Introduce getSomethingImpl, inspired by sw::UnoTunnelImpl; allow it handle cases both with and without fallback to parent. 6. Adjust UNO3_GETIMPLEMENTATION_* macros TODO (in separate commits): - Drop sw::UnoTunnelImpl and sw::UnoTunnelGetImplementation - Replace all uses of OImplementationId in core with UnoIdInit - Deprecate OImplementationId in <cppuhelper/typeprovider.hxx> - Change implementations of getSomething to use getSomethingImpl - Revise uses of getSomething to use getFromUnoTunnel Change-Id: If4a3cb024130f1f552f988f0479589da1cd066e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122022 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-09-14ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: Ib3afba47155bc70f579284244514d745f1075f7a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122080 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-13tdf#142415 mouse events not propogated to table control event handlersCaolán McNamara
handle this with explicit callbacks from the cell widget for those events Change-Id: Ie605ca4286afc0fbd321f339fb7963771a303df5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122050 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-13loplugin:cow_wrapperNoel Grandin
check the classes that use o3tl::cow_wrapper so that they don't unnecessarity trigger copies Change-Id: I545e627598217f3e61ba2c384adb8d4f8b404829 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122030 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-13loplugin:methodcyclesNoel Grandin
Change-Id: Ia14e47b811ca56d8d4517f262e008985d6aebe35 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122020 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-12ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: Id142604aca139f0e0a249ba32b6462a2b8db72d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121963 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-11ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: Idf446aaa9b29f61168e29f76382f6258d1b78276 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121936 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-02-04 00:51:10 +0000