summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2018-10-03loplugin:unusedmethodsNoel Grandin
Change-Id: I9e583df920657ab401162db79decb192c4f69f90 Reviewed-on: https://gerrit.libreoffice.org/61283 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-03We need to include <o3tl/make_unique.hxx> hereTor Lillqvist
Change-Id: I9670407cd9e848d208f844f6d0879a5a19b86f4c
2018-10-03when gtk3 >= 3.22.0 set natural size propagateCaolán McNamara
so 1-10 in format numbering etc isn't slightly clipped with a scrollbar on top of it Change-Id: I55909993d4b4c846ca0aeff2f2cd458dfa59d860 Reviewed-on: https://gerrit.libreoffice.org/61262 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-03weld SwSvxNumBulletTabDialogCaolán McNamara
Change-Id: I8ea74dc15bba04c0615e61c069407160a7b95c4c Reviewed-on: https://gerrit.libreoffice.org/61242 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-02tdf#120234 ignore all proxy windowsJan-Marek Glogowski
I thought just border windows can act as proxies, but this bug proves me wrong; also floating windows set mpClientWindow and may have an additional nested proxy border window. Interestingly proxies can have multiple children, which I tested with a temporary assertion I added!? So just ignore all proxy windows until we find a real one, And drop the assertion as it doesn't make sense any more. I'm just wondering why I always read Child instead of Client... Change-Id: I83a1a5743b434399aae361cb14058993ba60c83c Reviewed-on: https://gerrit.libreoffice.org/61196 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-10-02We shouldn't call DrawTextLayout() without a context on iOSTor Lillqvist
Change-Id: I3e72909ca1aa9f97721d982f16624f496152ae2d
2018-10-02LibreOfficeKit wants the tile pixmap bytes to be in BGRA order in memoryTor Lillqvist
To get that with CoreGraphics on iOS we need to use also kCGImageByteOrder32Little in the CGBitmapContextCreate() call, otherwise the bytes will be in ARGB order in memory. (Not touching the macOS code here.) Change-Id: I3c2dd94feb1c6bf46c5b335f5901b29e5fe1e7fb
2018-10-02weld SvxNumOptionsTabPageCaolán McNamara
Change-Id: Ie2ae18b1722e91996887162b4a8ff02d2d812341 Reviewed-on: https://gerrit.libreoffice.org/61228 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-02filename may be nullCaolán McNamara
Change-Id: I373886d3613607b8ee8e96d8c0314865f3991a92 Reviewed-on: https://gerrit.libreoffice.org/61241 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-02Implement filter for Qt5AccessibleWidget::relationsSamuel Mehrbrodt
Change-Id: I1859d612e13b2f0d837aa65012552c441346cb1a Reviewed-on: https://gerrit.libreoffice.org/61236 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-10-02Implement Qt5AccessibleWidget::relationsSamuel Mehrbrodt
without considering 'match' parameter for now Change-Id: I03ec7017fdaae8c8e20f19e6c827aafb093e8a53 Reviewed-on: https://gerrit.libreoffice.org/61231 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-10-02printdialog: Use labelling a11y relation instead of static roleSamuel Thibault
The field names are arguably rather labels for the static-role widgets providing the status. Change-Id: Ic3407adf84d7399696e51de712635a986fa0c190 Reviewed-on: https://gerrit.libreoffice.org/60142 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-10-02Qt5AccessibleWidget: Implement keyBindingsForActionSamuel Mehrbrodt
Change-Id: I53d6d36374fc35eb8370ad6d83723aafb01fb8b4 Reviewed-on: https://gerrit.libreoffice.org/61199 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-10-02Qt5AccessibleWidget: Implement QAccessibleActionInterfaceSamuel Mehrbrodt
shows available action and allows to execute them Change-Id: I944e4eccaac7c458af77b471c1d6e10650b1e798 Reviewed-on: https://gerrit.libreoffice.org/61183 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-10-02Unify sal plugin loadersJan-Marek Glogowski
Change-Id: Ic099761eaff80349e985ccf62e3f4aa6b2e98022 Reviewed-on: https://gerrit.libreoffice.org/61103 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-10-02Implement MacOSX VCL backend as pluginJan-Marek Glogowski
Change-Id: Ie90af62eff146064c3b066a8f7ca1c3a69f44c39 Reviewed-on: https://gerrit.libreoffice.org/61102 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-10-02Implement Windows VCL backend as pluginJan-Marek Glogowski
Change-Id: If9c7c67f48311ac68ecc9f8e3a07f9bb7c73d962 Reviewed-on: https://gerrit.libreoffice.org/61101 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-10-02make all notebooks scrollable and enable_popupCaolán McNamara
Change-Id: I16a6d556ca4c6b3f876dc0c8380d01fe3022209e Reviewed-on: https://gerrit.libreoffice.org/61195 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-02weld SvxLineTabDialogCaolán McNamara
Change-Id: Icb13a6eb2e8c6f6dbd3cf477051bc0bd682e2e7a Reviewed-on: https://gerrit.libreoffice.org/61193 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-02tdf#115262 sc: fix cumulative placement error of imagesMiklos Vajna
Commit 708d1c5ab242b545ced598879233fc662d7e6cc0 (sc lok: emit RowColumnHeader info in twips, 2015-11-02) improved precision of the twip -> pixel conversion ratio, but ignored the detail that limited precision used to silence cumulative errors that appear with larger precision. The original use-case was better precision of row/column headers for the LOK API, so keep that as-is, but go back to the original behavior on the desktop. Change-Id: Ide169ab1745a9a9299caf3334559884ff7223cbe Reviewed-on: https://gerrit.libreoffice.org/61219 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-01Qt5 pass LO clang compiler pluginsJan-Marek Glogowski
loplugin:simplifydynamiccast Change-Id: I437b4a249243c6c9be6b6776295e0657474b8ab6 Reviewed-on: https://gerrit.libreoffice.org/61171 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-10-01weld SvxLineTabPageCaolán McNamara
Change-Id: I91d7ec8a51ce935db40c57feeeed7b160cf4dad8 Reviewed-on: https://gerrit.libreoffice.org/61172 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-01pass menuitem ident around directly, instead of deriving from itemidCaolán McNamara
sidestepping the while duplicate itemids in separate submenus problem Change-Id: Icb57ac805f3c8c4fc3a68341e318375c6492cbb1 Reviewed-on: https://gerrit.libreoffice.org/61189 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-01Qt5AccessibleWidget: Implement childAtSamuel Mehrbrodt
Change-Id: I8703b33cf5d9f4ea119daf94392d67c9375cbb01 Reviewed-on: https://gerrit.libreoffice.org/61178 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-10-01Change all font-based tests to depend on ooo_fontsJan-Marek Glogowski
Instead of depending on individual font packages. Most didn't depend on fonts at all. Change-Id: I190295bbecb1b44aa34aaf0874afadd35b5daeb4 Reviewed-on: https://gerrit.libreoffice.org/61159 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-10-01qt5 a11y: Use UNO Api instead of vcl::Window methodsSamuel Mehrbrodt
This gets us into the document itself, not only the widgets. Change-Id: Id0cf1294817309c889729d01242cae69d2391130 Reviewed-on: https://gerrit.libreoffice.org/61094 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-09-30weld SvxLineEndDefTabPageCaolán McNamara
Change-Id: I3e947511bbffae4cd48388b17a8fb9a13d453bab Reviewed-on: https://gerrit.libreoffice.org/61139 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-30add GetFileImageId and check if there is no parentCaolán McNamara
Change-Id: I80fdcb800642dbb850072a259d0f742e8c6cbb20 Reviewed-on: https://gerrit.libreoffice.org/61071 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-30weld SwTestAccountSettingsDialogCaolán McNamara
Change-Id: Idead8d63dc472403e15eb9adf3cb82467e4d6721 Reviewed-on: https://gerrit.libreoffice.org/61106 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-29band-aid: deprecated-declarations related to gtkJulien Nabet
Don't hesitate to revert this one but only if there's a patch to fix it. Change-Id: Ib15352e1a94d0542120f6710acfe19887494ed51 Reviewed-on: https://gerrit.libreoffice.org/61142 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-09-29tdf#120169 handle [combo|list]box can-focus speciallyCaolán McNamara
Change-Id: I93fec026079ac37993e48fac48d937a0a20e5b0f Reviewed-on: https://gerrit.libreoffice.org/61081 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-29Handle initial TabControl and border windowJan-Marek Glogowski
ImplGetSubChildWindow has special code to handle a TabControl and its pages. If the function finds a TabControl as a child it'll return its window and then recurse into the current page. This currently breaks in the case where the initial parent is a TabControl. where the function will walk all of the tab pages. The function also ignores border windows, but not if the initial parent is a border window. This patch correctly handles both cases and as a bonus drops all the special page handling during child iteration. Change-Id: Ie8699dae8d08628b66b33e0704237b9e219874bc Reviewed-on: https://gerrit.libreoffice.org/61037 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-09-28listen to [leave|enter]-notify-event at event widget levelCaolán McNamara
rather than toplevel. This avoid the problem under wayland where with an initially maximized calc clicking in it will select all cells from 0,0 to the clicked cell until the mouse is released Change-Id: I138fe587c9cb7cfff0293847c00730593e3244e1 Reviewed-on: https://gerrit.libreoffice.org/61087 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-28fix oss-fuzz buildCaolán McNamara
Change-Id: Id8b33ac7b3988a8fef7bff3b03cfe9c1c167adc3 Reviewed-on: https://gerrit.libreoffice.org/61090 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-28weld SvxNumberFormatTabPageCaolán McNamara
Change-Id: Ia6e6497d5c9b6c47e34e5cb5b3913d25e73c3a69 Reviewed-on: https://gerrit.libreoffice.org/60944 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-28gla11y: check element visibilityJan-Marek Glogowski
Add warnings for different visibility settings in the "label-for" and "labelled-by" elements. Sine LO doesn't support multiple annotations per accessibility element, we have to switch them manually, if we change the visibility of one element of a pair. Change-Id: I9b3d941248b804b8435591536277677e99b77340 Reviewed-on: https://gerrit.libreoffice.org/61050 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-09-28Qt5AccessibleWidget: Add state mappingSamuel Mehrbrodt
Change-Id: I6c846fcb56ecfc24d966dfd01b97c47460fdf16b Reviewed-on: https://gerrit.libreoffice.org/61068 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-09-28Qt5AccessibleWidget: Implement foreground and background colorSamuel Mehrbrodt
Change-Id: Ice848f429ce8b9d4395e3cf1c23c22aa806fb5f9 Reviewed-on: https://gerrit.libreoffice.org/61043 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-09-28Move TabPage lookup into extra functionJan-Marek Glogowski
This way it's easier to read the follow up patch. Change-Id: I42e8f78b69b4ed2cb28bf0f36496eb751e8cb433 Reviewed-on: https://gerrit.libreoffice.org/61036 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-09-28Constify vcl::Window child lookupJan-Marek Glogowski
Also removes the function comments before the implementations, as these are just the same as already in the header. Change-Id: I11425dc4aa372423fcf469ab1374159ce8b180e2 Reviewed-on: https://gerrit.libreoffice.org/61035 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-09-28loplugin:unusedfieldsNoel Grandin
Change-Id: I355fad84ed8765e8eb3fadb7c239b3b902ec1747 Reviewed-on: https://gerrit.libreoffice.org/61059 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-28Guard against invalid statesSamuel Mehrbrodt
Happened while trying the qt5 a11y stuff that mpWindowImpl was invalid. Change-Id: Ibe238bdcce6410689b1e65f7f45f7b9deea06de7 Reviewed-on: https://gerrit.libreoffice.org/61032 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-09-28Implement Qt5AccessibleWidget::isValidSamuel Mehrbrodt
Change-Id: Ie2ef115bc655d0f64e8b269e73d3343176f115e3 Reviewed-on: https://gerrit.libreoffice.org/61042 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-09-27Do build cppunit for iOS, tooTor Lillqvist
I am writing a separate unit test app that will include selected existing unit tests that make sense and are important to run on iOS. Change-Id: I4722f1ed872ba21e181eeba5ed3b58e82d8fed72 Reviewed-on: https://gerrit.libreoffice.org/61049 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2018-09-27printdialog: fix some accessibility warningsSamuel Thibault
Change-Id: Icf508473d194bc8c6f01e551b6659a625b8ee229 Reviewed-on: https://gerrit.libreoffice.org/60141 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-09-27qt5: Add basic a11y supportSamuel Mehrbrodt
Widget tree is displayed and basic role mapping is available. Still needs quite some work (positions, actions, texts, etc.) Change-Id: I9d26a762f1d9684f33bbb80a384cf2a0b8a905c0 Reviewed-on: https://gerrit.libreoffice.org/60853 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-09-27Fix typosAndrea Gelmini
Change-Id: Icfe120db02a70d43e4120d1f4cbb2704640d3990 Reviewed-on: https://gerrit.libreoffice.org/59470 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-09-27loplugin:methodcycles more graph theory for the winNoel Grandin
implemeent a reduction approach, which is good at finding virtual methods that only themselves or their virtual partners. The accessibility GetVisArea stuff is dead since commit 891e41fac81fbd8d5cdb277b26639abfd25a7143 Date: Wed Apr 4 11:23:22 2018 +0200 dead code in AccessibleTextHelper_Impl::UpdateVisibleChildren Change-Id: I78d9d8bca585ecec8394f2c3fe2baa93db0e58f5 Reviewed-on: https://gerrit.libreoffice.org/60912 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-27dispose custom widget a11y on teardownCaolán McNamara
Change-Id: Iea80ffff0b36e093e4b8e513e924a21da67cb2ce Reviewed-on: https://gerrit.libreoffice.org/61009 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-26uitest: checking whether we have focus needs to be recursiveMarkus Mohrhard
Change-Id: Id18a56cdf5b23433178882a953fd85954c0ccc1c Reviewed-on: https://gerrit.libreoffice.org/61008 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Jenkins
generated by cgit (git 2.34.1) at 2025-01-25 09:26:49 +0000