summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2021-06-16Add MapMode cppunit test to vcl.panoskorovesis
The test creates multiple MapModes (relative and non-relative) with custom and default attributes, which then checks. Change-Id: Iaed461ece9cc044b5b271456a6bac10b1533062a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117232 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-06-16Add MoveClipRegion cppunit test to vclpanoskorovesis
The test creates two MoveClipRegions and checks their attributes. mtfxmldump.cxx was modified to support MoveClipRegion case. Change-Id: Ibfabf9d4048cf94e43c259e411a6c59b73baff34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117153 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-06-15gtk4: use GtkPicture for view, user interfaceCaolán McNamara
Change-Id: I6677233dc0594d6b2e9ea4b8f901550dbff46361 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117261 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-15gtk4: support moving children in and out of GtkGridCaolán McNamara
Change-Id: Ia90b9586ff39f0a668da4e0f9beef7ed26626ebf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117260 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-15gtk4: double-encode ampersand if use-underline is usedCaolán McNamara
as seen in calc paste special dialog see https://gitlab.gnome.org/GNOME/gtk/-/issues/4041 Change-Id: I5425d1f5b5474fc6cda949e8fcb76b734ab893e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117259 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-15gtk4: don't convert generated button image-childCaolán McNamara
its already convert, so don't double convert to remove e.g. already converted icon-size in calc paste special Change-Id: Id87ca7a6dfecdca102e1a12a37eed90b0e40e48c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117250 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-15gtk4: further disambiguation of Image/PictureCaolán McNamara
examples of GtkPicture wanted: a) math, format, spacing b) all, help, about examples of GtkImage wanted: a) writer, format, columns, next/prev b) writer, insert, hyperlink c) calc, paste special Change-Id: I53ad0a40f30a4963a8490c4e76fa50c463de0903 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117249 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-15gtk4: convert all the larger old icon sizes to GTK_ICON_SIZE_LARGECaolán McNamara
Change-Id: I88921495e60f47b54e4d473315ee953872e61891 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117248 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-15gtk4: support image at top in button with vert orientation of child boxCaolán McNamara
Change-Id: I87b7c2752120d272eb176307465d658f4a980170 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117244 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-15gtk4: leave Help button unchanged if its in a GtkMessageDialogCaolán McNamara
as opposed to a help button which will be relocated to the titlebar Change-Id: I2053ad05025cce9e0a894b555160b56eb5bc2f6b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117239 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-15gtk4: support moving between containersCaolán McNamara
just GtkBoxes for now Change-Id: I2247661649c67944290451de98e80db7faf41648 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117238 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-15gtk4: add more working dialogsCaolán McNamara
Change-Id: I0a31192fcfc175e0db509e8061e7980127cb50ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117202 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-15gtk4: add more working dialogsCaolán McNamara
Change-Id: Id17952c6915b2c15b7b443c5d4bd5fb6ac55c150 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117200 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-15gtk4: add more working dialogsCaolán McNamara
Change-Id: Ife00799a8eab3d73a635ed6c2bd31cfb6e5d2d91 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117196 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-15gtk4: add more working dialogsCaolán McNamara
Change-Id: I5950424b16a4aabd8a4e15b912bb5b3b178c4052 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117183 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-15vcl: outdevmap.hxx -> rendercontext/ImplMapRes.hxxChris Sherlock
Change-Id: I96e191999e43e1a4203d548eeacd386ed883cd8b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115368 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-06-15Revert "tdf#142832: a blind fix - calculate rectangle size properly"Mike Kaganski
This reverts commit 57d122258437c0a14b303a8d961aa5e8f6f67f57. Reason for revert: As mentioned in https://docs.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-getwindowrect, > In conformance with conventions for the RECT structure, the bottom- > right coordinates of the returned rectangle are exclusive. In other > words, the pixel at (right, bottom) lies immediately outside the > rectangle. So it was incorrect change. Change-Id: I2b29871a5d9b944ce2f9119edb2e87c53d9ae298 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117212 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-06-14tdf#142832: a blind fix - calculate rectangle size properlyMike Kaganski
The size was calculated wrong - it needed a "+1". But a rectangle constructor taking L, T, R, and B is actually simpler. Change-Id: I4152f9b43f0ae8f1829038645fcf83bae156c618 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117129 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-06-14gtk4: create separators on menu import by appending a new sectionCaolán McNamara
where we have established that we always have a section in a menu to close when opening a new one Change-Id: I8af90dd89281dd0f10bcec5665d96412108cb5d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117179 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-14gtk4: supporting hiding menu items by moving actions out of actiongroupCaolán McNamara
and using hidden-when of action-missing and keep the hidden items in a different actiongroup Change-Id: Idaa4f1762c4df2700827fd45527027cc48415548 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117178 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-14gtk4: add hidden-when of action-missing to menu itemsCaolán McNamara
Change-Id: I054f3573c8a251c605ab1f3a426f6a905a908851 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117177 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-14gtk4: connect to underlying ToggleButton "toggle" of MenuButtonCaolán McNamara
e.g. writer, tools, autotext, autotext menubutton Change-Id: Ie29078eee4daff032421f8838ed2215101eb21e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117171 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-14gtk4: reenable a cluster of working dialogsCaolán McNamara
Change-Id: I11c86ab60354259c8dc98c974d313efe8f8d5acc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117170 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-14stack-use-after-scopeStephan Bergmann
(Graphic::GetGfxLink returns a temporary GfxLink object---whose lifetime thus ends at the end of the full expression---and GfxLink::getDataContainer returns a reference into that temporary object---which thus became dangling at the end of the full expression.) Change-Id: I1b84088a74c8c9efb5502f3b3917252858c01557 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117159 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-06-14tdf#142393 crash on filter by color dropdownlist (gen)Noel Grandin
the frame/window can become disposed during the early stages of this method Change-Id: I974cbeefa75a3b5274e397a6da70db8b7cf73528 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117157 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-14Add ClipRegion cppunit test to vclpanoskorovesis
The test creates multiple ClipRegions with different shapes and tests their attributes. Makefile was edited to support basegfx::B2DPolyPolygon Change-Id: Iabdf744e1749627b2bc4cbc0c8e933b38552e785 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116959 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-06-14pragma once - BackendCapabilitiesTomaž Vajngerl
Change-Id: Id37ea7e70a81afbe2c4f3590569af863e0f7824f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117103 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-06-14gtk4: reenable pdf export dialog and pagesCaolán McNamara
Change-Id: Ie9c1846343bf74b25e33f79f31b9eee8631fab9e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117101 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-14gtk4: reenable some more working dialogsCaolán McNamara
Change-Id: I857d96cfdf17accdcfd973ea04c51a34a3b68863 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117099 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-12Fix typosAndrea Gelmini
Change-Id: Ibd4f8ac232eddad2b8a6c970999f0adf61a07acf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117077 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Jenkins
2021-06-11when converting WMF to WMF, simply do a direct copyLuboš Luňák
Actually, if we have the graphics data, just copy the graphics data, that'll keep both the EMF+ and non-EMF+ content. Change-Id: Ia14df0ba2a94d4310ee745b49de1d2190e425f05 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117063 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-06-11drop EMF+ also when converting WMF, not just EMFLuboš Luňák
A WMF may have EMF with EMF+ actions embedded. When we read that, we drop drawing non-EMF+ actions if we use EMF+. But EMF+ actions are stored as MetaCommentAction in the metafile, and WMF writer (unlike EMF) writer simply ignores comments. So when writing WMF, make sure to read non-EMF actions so that something is written. This is an extension of 295626a0bd39540544b774094a63df23e5376839. Change-Id: I37355f694fe656b661abe54274ea203934e68151 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117062 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-06-11gtk4: starting point for welded menusCaolán McNamara
submenus will need a rethink I guess Change-Id: I6d2a645267146c537fe7ba62d8be2501855e7f62 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117067 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-11gtk4: build deeper levels of GMenuModelCaolán McNamara
Change-Id: Ia2cbe4fdc583d272152b4eaa9da9f9d2ff4af550 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117066 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-11MetaAction::Clone() -> constLuboš Luňák
Change-Id: Ie5785127a1fb202b146710dfedf3838d2a607670 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117035 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-06-11gtk4: support separators via manipulating menu sectionsCaolán McNamara
Change-Id: Iaade04dd5a4fa89ef74a22a19ebe5e37655fc61a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117058 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-11qt5/kf5: Fix crash on exitMichael Weghorn
This extends the solution from commit fa8db25af6218262b3dab2e93b76464975889ceb Date: Thu Jun 3 20:47:10 2021 +0100 gtk4 crash on exit to cover the qt5/kf5 cases as well, after seeing equivalent crashes with kf5 VCL plugin (e.g. when starting Writer and no profile exists) after commit 556243467a0ac3f647de75bf3fb6c9f3b72466a4 Date: Wed Jun 2 13:06:54 2021 +0200 fix shutdown leak in CppunitTest_sw_filters_test Change-Id: I4ef25bac0891c059588dbc8e6abe50db14230dea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117042 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2021-06-11Simplify Sequences initializations (vcl)Julien Nabet
Change-Id: Id93bde17dbc4c71ad93bc094b94408fc9e39ec98 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117055 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-06-11gtk4: process sections and submenus of toplevel menumodelCaolán McNamara
and place initial contents into a section by default Change-Id: I1e7bb20bf5efb481e4f7ed0f38c8b46c06f7a7d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117050 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-11ofz#35150 crash in Bitmap::Crop from wmf loadCaolán McNamara
which is a problem since... commit 33d2cf7008de79106b5da4bba0241aa14d81d88f Date: Sat Jun 5 19:30:46 2021 +0200 WMF Change the sign of read fields in BITBLT and DIB records Change-Id: Iea1261a52866d691435f0612f672636009c00355 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117039 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-11ofz#35149 crash in vcl::bitmap::CreateFromData from wmf loadCaolán McNamara
which has started since... commit 01ded1e6d362dbcd7148334c6965d6ad00981d4a Date: Tue Jun 8 23:07:28 2021 +0200 WMF tdf#55058 tdf#142722 Add implementation of BitBlt and StretchBlt Change-Id: I5bbde55dbd9e239c05544ac4a21e2758770245d2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117038 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-11CppunitTest_vcl_svm_test: add missing basegfx linkMiklos Vajna
Missing probably because https://gerrit.libreoffice.org/c/core/+/116967/1 was merged before its https://gerrit.libreoffice.org/c/core/+/116959/4 parent. Change-Id: I0c6304c98f27e1f24ee615e4580c8ad7458bf79b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117027 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-06-11Add IntersectClipRegion cppunit tests to vclpanoskorovesis
Two tests where added, IntersectRectClipRegion and IntersectRegionClipRegion, along with their .svm files. The tests create mutliple IntersectClipRegions and test their attributes. Change-Id: I33b7b13b4f3eef1de07cc063ef22fea034d65cfc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116967 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-06-10-Werror,-Wunused-but-set-variable (Clang 13 trunk)Stephan Bergmann
...ever since the code's introduction in adf0066a17538a394550237a54f6fc0027f6ed29 "#i91478# aqua implementation (continued)" Change-Id: I2dd7bbaba9e8068929f4792b7f953cbf01e03a7d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116989 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-06-10loplugin:unnecessaryreturn RoadmapWizardNoel Grandin
Change-Id: I269fd92a6076fe9ebe18646e537e7031aec47fef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116976 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-10loplugin:unnecessaryreturn SvImpLBox::SetMostRightNoel Grandin
Change-Id: Id556d8c86c1229a51bd600da433d564979c1cd40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116975 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-10loplugin:unnecessaryreturn SalX11Display::DispatchNoel Grandin
Change-Id: I270f6538d921ad2116cc29ada3e4543027531764 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116974 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-10loplugin:unnecessaryreturn SalFrame::SetPluginParentNoel Grandin
Change-Id: If927a834f5b5d722fc36cce40e161597af6234ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116972 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-10tdf#142629: vcl_filters_test: Add unittestXisco Fauli
Change-Id: Id0397bc8e16eb22853ce3388f8ef3cc8f8558692 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116961 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-06-10avoid possible repeated cairo surface creationLuboš Luňák
Doing the frame size adjustments only after the if condition meant that in headless mode the surface could be destroyed and created again for the same size. Also AcquireGraphics() passed different frame size to SetGraphics() than SetPosSize(). Change-Id: I9d6884a3917dfbd7b2cfe4fcd4e350c8bc9f4305 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116272 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>