summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2019-03-04simplify UNO getTypes methodsNoel Grandin
Change-Id: Ia8b07edec54527fb4904536fabb03a18e8452550 Reviewed-on: https://gerrit.libreoffice.org/68659 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-04Revert "new loplugin typedefparam"Noel Grandin
This reverts commit 9865440d217d975206a3f91612f0666312bc8fd8. This is not ready to land yet, seems like the latest update of the logic reveals a bunch more places I need to fix before it can land.
2019-03-04new loplugin typedefparamNoel Grandin
verify that parameters use the exact same typedef-names (if any) in definition and declaration Change-Id: I55d2817f599b0253904dce2d35a1a93967e15a77 Reviewed-on: https://gerrit.libreoffice.org/68439 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-03HELPDELAY_SHORT is unused - get rid of related defines, tooMike Kaganski
It is unused since commit bd45c56a07e77662570f9dd5dc1710f8f9ca0e3b. Change-Id: I3d70b0cc112a6f4a8f57a65831cb0a46ac36514a Reviewed-on: https://gerrit.libreoffice.org/68641 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-03-02ofz#13431 fix buildCaolán McNamara
Change-Id: I29c271188dc96205e335dbf8d7b11a3711e6e634
2019-03-01weld SwInsertDBColAutoPilotCaolán McNamara
Change-Id: I5e46a88de2ff11ecd38667338b84babee24a2a11 Reviewed-on: https://gerrit.libreoffice.org/68591 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-01Some more WIN32 -> _WIN32Stephan Bergmann
...at least some of which have presumably been missing from ce43d0ae9279edbf1ad108fe0d8325327a038d49 "use consistent #define checks for the Windows platform" by accident (and some just clean up comments) Change-Id: I5532685c7df96ae3c8a25b73d8064d7433964a9b Reviewed-on: https://gerrit.libreoffice.org/68580 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2019-03-01ignore disposed toplevelsCaolán McNamara
Change-Id: Ib5a9bad2537d43f7b6588dbdb958e4cdd34f7023 Reviewed-on: https://gerrit.libreoffice.org/68384 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-01ofz#13431 fix buildCaolán McNamara
Change-Id: I55085ede7161c06c85ab14d553f27ac505cbbbc2
2019-02-28tdf#122537: Use "best speed" instead of default compression level on iOSTor Lillqvist
Speed is more important than size in the use case where this showed up in a profile of the iOS app (inserting an image). This change causes zlib's deflate_fast() being used instead of its deflate_slow(). For a specific image I tested with the former takes 1.5 s, the latter 3.4 s. This is just one aspect of the slowness of image insertio. The resizing operations mentioned in the bug report is not yet investigated. Change-Id: Icf023522b965cb0265000c821a478610d098cd0a Reviewed-on: https://gerrit.libreoffice.org/68434 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/68488 Tested-by: Jenkins
2019-02-27weld UpdateDialogCaolán McNamara
Change-Id: Ieca75774925a8766162481713f6e8a6ba0e9feb0 Reviewed-on: https://gerrit.libreoffice.org/68396 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-27weld LicenseDialogImplCaolán McNamara
Change-Id: I4b2dbd2446779e7179d2b79bf81cc2ff879377bf Reviewed-on: https://gerrit.libreoffice.org/68389 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-27tdf#122689 qt5: Consider external clipboard updatesMichael Weghorn
Previously, once 'm_aContents' had been assigned in 'VclQt5Clipboard::setContents()', its value (or the one set in a subsequent call to the same method) was always returned in 'VclQt5Clipboard::getContents()', thus ignoring all system clipboard updates done by any other third-party applications, preventing copy-paste from other applications. In order to take external clipboard updates into account, add a slot for the 'QClipboard::changed' signal and drop the current own clipboard content if the clipboard has been updated by another application. In order to detect whether the clipboard update was made by this 'VclQt5Clipboard' itself or elsewhere, a custom MIME type "application/x-libreoffice-clipboard-uuid" is added, whose value is set to the clipboard's (randomly generated) UUID. If the entry is present and has the correct value, the clipboard content was added by this clipboard and can be kept. Otherwise, clear 'm_aContents', so that it's newly assigned in 'VclQt5Clipboard::getContents()', taking into account the external clipboard update. [Side note: Testing showed that, on Wayland, more 'QClipboard::changed' events were emitted without the clipboard content actually having changed (e.g. when switching focus between windows), which is why an approach of simply setting a flag and checking for that one is not enough, like "wrapping" the 'QClipboard::setMimeData()' call in 'VclQt5Clipboard::setContents()' as follows m_bIsFillingClipboard = true; clipboard->setMimeData(pMimeData.release(), m_aClipboardMode); m_bIsFillingClipboard = false; and then evaluating the 'm_bIsfillingClipboard' flag in 'VclQt5Clipboard::handleClipboardChange' instead of using the UUID-based approach. These additional 'QClipboard::changed' events did not show up the same way while testing on X11.] Change-Id: Ib3a6a4f9b7f5ca3573666fb9c072ae97cf2e0049 Reviewed-on: https://gerrit.libreoffice.org/68214 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-02-27KDE5: set correct parent menu in functionAleksei Nikiforov
Set correct parent menu in function Qt5Menu::InsertMenuItem instead of just returning it and setting it later if needed. Change-Id: Id866987e91ec1d57c720735da6afc44109aa901a Reviewed-on: https://gerrit.libreoffice.org/68437 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-02-27tdf#121970 KDE5: Regenerate menu when it's set as submenuAleksei Nikiforov
Also add item bits change notification function for SalMenu to properly convert regenerated menu items to check or radiocheck items. Change-Id: I61f16a771b484644bbefd9afaf2776232d38a2f9 Reviewed-on: https://gerrit.libreoffice.org/68438 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-02-27tdf#104235: Qt5Frame: Set default iconMichael Weghorn
Set a default icon in Qt5Frame constructor, similar to how it's done for the gtk and gtk3 VCL plugins in 'GtkSalFrame::InitCommon'. Change-Id: I4e4e62ffa0eca6499f4752ff467d004cae68788f Reviewed-on: https://gerrit.libreoffice.org/68450 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-02-27ofz#13431 fix buildCaolán McNamara
since commit c600817e8349db7957f517365f65f25e4e042439 Date: Mon Feb 25 15:34:13 2019 +0200 Make SdAbstractDialogFactory::Create() do its job also on non-DESKTOP Change-Id: I95ff8ed3dc81ec542ac76d5f5bbd7582391c84a5
2019-02-27Resolves: tdf#123711 measure scrollbar for optimal widthCaolán McNamara
Change-Id: I30225124e44e8a6290270ecba5024f36508817d3 Reviewed-on: https://gerrit.libreoffice.org/68428 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-27convert more Start timer methods from sal_uLong->sal_uInt64Noel Grandin
Change-Id: I1ed43bab00a5bc456032410ccf32b3fd64cc970c Reviewed-on: https://gerrit.libreoffice.org/68419 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-27make cursor images part of the themeNoel Grandin
This first step only affects GTK3, later we will extend the support to other platforms. Note that these images are derived from the OSX PNG files, not the header-file encoded data we currently use for gtk/gtk3. Also rename the files to more useful names. Change-Id: Ia13a3f2ac35b06672aff724f4cf5bdcd823f6342 Reviewed-on: https://gerrit.libreoffice.org/67528 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-27tdf#123406 KDE5: Use delayed frame destructionAleksei Nikiforov
Destroy Qt5Frame after all events are received. Update Qt5Object to use delayed destruction too. Change-Id: I07c7251e097ad56f3616f325fdc394d00fec4f4f Reviewed-on: https://gerrit.libreoffice.org/68316 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-02-27tdf#119720 KDE5: Don't show hidden windows on modality changeAleksei Nikiforov
This change fixes clipping and drawing issues for document recovery window and other modal windows. Change-Id: I005254d4cd2598f4f2d02ba7e7bbf7388affe36c Reviewed-on: https://gerrit.libreoffice.org/68307 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-02-26parentclass set_size_request is sufficientCaolán McNamara
Change-Id: I872fdb2d6d4c6279b6d4dc8f38e1153fcd919f22 Reviewed-on: https://gerrit.libreoffice.org/68395 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-26loplugin:indentation (clang-cl)Stephan Bergmann
Change-Id: I94689e4eed290b4505d2caba2d9802ef7fb6cffd Reviewed-on: https://gerrit.libreoffice.org/68378 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-02-26tdf#120824 KDE5: fix visible/enabled state for menuAleksei Nikiforov
Change-Id: I003703f0bc2e1697124e068a68bfb2e24c33cd1a Reviewed-on: https://gerrit.libreoffice.org/68351 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-02-26fix android build (2)Noel Grandin
after commit 589ce33041df5ca1c3f6d914d5d33d0fffb69f8f Date: Mon Feb 25 14:38:21 2019 +0200 sal_uIntPtr->sal_uInt64 in SalTimer::Start Change-Id: I0fe5d972d2acf90a98f6e0203c51e509a60920c1
2019-02-26fix android buildNoel Grandin
after commit 589ce33041df5ca1c3f6d914d5d33d0fffb69f8f Date: Mon Feb 25 14:38:21 2019 +0200 sal_uIntPtr->sal_uInt64 in SalTimer::Start Change-Id: I0091ac4750dfb2ca8a3f4b5a544f7ec4f0ee0957
2019-02-26fix windows buildNoel Grandin
after commit b792e4ee22d7b625a214f6eceb1c223f35b9a606 sal_uLong->sal_uInt32 in drawEPS Change-Id: Ic35c165cd9dd756e229c33f643355150d6249688
2019-02-26sal_uIntPtr->sal_uInt32 inSalClipRegion::BeginSetClipRegionNoel Grandin
sal_uInt32 seems reasonable given that this is the number of rectanges in an image. And then convert all of the other BeginSetClipRegion methods to use sal_uInt32 too. Change-Id: I85a712ec823662ac30f3859051e2b974fb99775e Reviewed-on: https://gerrit.libreoffice.org/68343 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-26sal_uIntPtr->sal_uInt64 in SalTimer::StartNoel Grandin
because the call site specifies millis in a sal_uInt64 variable Change-Id: I5cf42407b9e7f3cdef976d8f442609723fd67af9 Reviewed-on: https://gerrit.libreoffice.org/68342 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-26sal_uLong->sal_uInt32 in drawEPSNoel Grandin
Change-Id: I58beedfee1a55df971e778ba2aa3b6989ba53663 Reviewed-on: https://gerrit.libreoffice.org/68341 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-26sal_uIntPtr->unsigned in X11SalBitmapNoel Grandin
Change-Id: I4ed777711c1302b3aaa73474b6182214c61b09f2 Reviewed-on: https://gerrit.libreoffice.org/68340 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-25We don't want any MODELESSDIALOG dialogs in the iOS app, they don't workTor Lillqvist
(And probably the same holds for Android, too.) This change makes at least the Format>Character... and Format>Paragraph... dialogs in the iOS app show up. For some reason they are claimed to be modeless, and that meant that the mechanism for dialog display in the iOS app did not work. The exact mecahnism is unclear to me, but the alleged modelessness was the root cause. Change-Id: I237a5e16ec34221912a2fb062068101562ba7dbb
2019-02-22tdf#122256 KDE5: Make menubar work for windows with parentsAleksei Nikiforov
Change-Id: I325faec8594e1c5b8b2c34a135f1604244e4826c Reviewed-on: https://gerrit.libreoffice.org/68140 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-02-22Removed duplicated includesAndrea Gelmini
Change-Id: I12ebc2dcbd836154c75ad910ec746ae371c865ee Reviewed-on: https://gerrit.libreoffice.org/68188 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-02-22loplugin:unusedfields in vclNoel Grandin
maStatusText in HelpTextWindow is dead since commit bd3ea40ed49074c4fa4439de7b5dea4fc3161880 Date: Fri Jan 21 14:48:58 2011 +0200 Remove ShowHelpStatusText and HideHelpStatusText and associated cruft Change-Id: I7a74e2a1b909a479f9338bd4da5fad06ccc25283 Reviewed-on: https://gerrit.libreoffice.org/68153 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-21wrong "to-page" reported in split notebooksCaolán McNamara
and when switching decks we need that notification to occur too Change-Id: Ica3c83ad34e072faf044c6d4667f34756688de09 Reviewed-on: https://gerrit.libreoffice.org/68171 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-21menu of currency combobox in format-cells is too narrowCaolán McNamara
we want the combobox to be narrower than it wants to be. To make that happen we have only the option of shrinking the cell renderer of the combobox area. And that is also used by the menu. Setting a small value of e.g. 1 works to let the combobox not request more width than that, and the combobox will correctly render within the wider size it actually gets. But then the menu is a min width menu, which is undesirable, we want the menu to be as wide as it can be. So calculate what part of the combobox belongs to the cell area and set the widest cell area we can within the overall combobox width, resulting in the widest menu we can get. Change-Id: Ie3e9960a320a70471ac21d2a88f32632cafa951f Reviewed-on: https://gerrit.libreoffice.org/68167 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-21weld RecoveryDialogCaolán McNamara
Change-Id: Iaa755aca2468a23465a3ab8d8115ee19e3b05f6d Reviewed-on: https://gerrit.libreoffice.org/68155 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-21weld HangulHanjaConversionDialogCaolán McNamara
Change-Id: Ia41f1a03581a0a48d59706ac5b3c569fc39c7f4d Reviewed-on: https://gerrit.libreoffice.org/68099 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-21recovery dialogs legitimately don't have parentsCaolán McNamara
Change-Id: I853a4471723c39bbdb8cf71409f518640b54cb83 Reviewed-on: https://gerrit.libreoffice.org/68110 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-21loplugin:indentation (macOS)Stephan Bergmann
* Some .m/.mm files that still contained tabs instead of spaces have been cleaned up with Emacs' untabify (and apple_remote/source/HIDRemoteControlDevice.m needed further manual adaptions): apple_remote/source/GlobalKeyboardDevice.m apple_remote/source/HIDRemoteControlDevice.m apple_remote/source/KeyspanFrontRowControl.m apple_remote/source/RemoteControl.m vcl/osx/a11yrolehelper.mm * Some of the changes predate 0626e66d761de18f62e4d00d427903032da9d517 "Avoid loplugin:indentation after preproc conditional inclusion lines" and would likely have no longer been flagged since. Change-Id: Ibf5faffa743c7f79b36109d9879eb79d63c8c40f Reviewed-on: https://gerrit.libreoffice.org/68090 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-02-20weld SaveProgressDialogCaolán McNamara
Change-Id: Iad1786962dedb6cae0cf8720022498bfd793feb1 Reviewed-on: https://gerrit.libreoffice.org/68105 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-20get better optimal size for a radiobutton with an image in itCaolán McNamara
(not an image used as the indicator, which is already covered, but if an image follows the indicator Change-Id: I9e3f9c466d997f91f54912660f8c54eea6deb721 Reviewed-on: https://gerrit.libreoffice.org/68097 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-20kde5 fpicker: Reuse 'initialize()' from base classMichael Weghorn
Take over missing case from 'KDE5FilePicker::initialize' to 'Qt5FilePicker::initialize' and make 'Qt5FilePicker::addCustomControl' virtual, so that the subclass's implementation is called in the 'initialize()' method (in particular to avoid adding another autoextension checkbox). Drop the 'KDE5FilePicker::initialize' so that the base class implementation is used, which now does the same thing. Add 'override' keyword in KDE5Filepicker.hxx. Change-Id: Id151a4d4862af4275f6c21c6537a79c52e3ed513 Reviewed-on: https://gerrit.libreoffice.org/68059 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2019-02-20Make 'setDefaultName()' work again for kde5 fpickerMichael Weghorn
Add an option to Qt5FilePicker constructor to say whether the QFileDialog should be a native one or not, since 'QFileDialog::selectFile' does not preselect the correct name in the native dialog any more if the 'QFileDialog::DontUseNativeDialog' option has ever been set, i.e. QFileDialog fileDialog; fileDialog.setOption(QFileDialog::DontUseNativeDialog); fileDialog.setOption(QFileDialog::DontUseNativeDialog, false); fileDialog.selectFile("test.txt"); will not properly set the name in the native file dialog, which broke 'setDefaultName' for the KDE5FilePicker. This makes it work again, even though I think that the underlying issue is a Qt bug (s. https://bugreports.qt.io/browse/QTBUG-73682 ). Change-Id: I99a1e7c97d594925d600fa8eaf3303f9013551c2 Reviewed-on: https://gerrit.libreoffice.org/68058 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2019-02-20KDE5FilePicker: Reuse custom controls from parent classMichael Weghorn
Use the custom controls widgets from the parent class Qt5FileWidget and drop the own class members that were used for this. Also call the base class's implementations for the methods that interact with the custom controls. Since the native Plasma/kde5 file picker handles automatic file extensions by itself while the non-native qt5 one does not, the methods in KDE5FilePicker only forward those method calls that are not related to the corresponding control ('CHECKBOX_AUTOEXTENSION'). Change-Id: Ia2de3211ffba7814683914a5e629208b19b2ed82 Reviewed-on: https://gerrit.libreoffice.org/68057 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2019-02-20Qt5FilePicker::addCustomControl: Add missing from kde5Michael Weghorn
Take over functionality from 'KDE5FilePicker::addCustomControl' that has not been implemented in qt5 one yet. Change-Id: I9690e163b3b739bfec6813d9a4e1e0170b730187 Reviewed-on: https://gerrit.libreoffice.org/68056 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2019-02-20kde5 fpicker: Reuse parent class member to store custom widgetsMichael Weghorn
Directly access member 'm_pExtraControls' from parent class Qt5FilePicker for managing custom widgets, rather than maintaining an own one. This is meant as an intermediate step, further refactoring will follow. Change-Id: I0568d3db68dc24042e198d36f4b5e49608f93a0e Reviewed-on: https://gerrit.libreoffice.org/68055 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2019-02-20kde5 fpicker: Reuse existing handle{G,S}etListValueMichael Weghorn
Turn existing functions in Qt5FilePicker into protected static class methods and reuse them in KDE5FilePicker. The qt5 implementation covers everything that kde5 had, and a little more (e.g. covers case 'ControlActions::DELETE_ITEM' in 'handleSetListValue' as well). Change-Id: I9673b20e3313c0628a76f0d94e018327f4af8523 Reviewed-on: https://gerrit.libreoffice.org/68054 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
generated by cgit (git 2.34.1) at 2025-02-04 03:04:40 +0000