summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2017-01-18change DrawControlText to return new rect rather than change old oneCaolán McNamara
Change-Id: Id5c80ff263e429d4239a844db216e87a656edb2e
2017-01-18Ref...DeviceTextLayout::GetTextArray is only called by Ref...DeviceTextLayoutCaolán McNamara
so set it as private to de-confuse this a little Change-Id: Idde7f78a767227cc2d52e417b6c39d12e1339745
2017-01-18fix up stubCaolán McNamara
Change-Id: I17cb60fa1dd55667a15a7dbc50532993c3145244
2017-01-18tdf#102139 : avoid switching to the empty tab after exiting the OLE ObjectSzymon Kłos
Change-Id: I67c395106d2a24c679cddaddd9aba138388463a5 Reviewed-on: https://gerrit.libreoffice.org/33237 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <eszkadev@gmail.com>
2017-01-18don't need so many bracketsCaolán McNamara
Change-Id: I6488bf57af2e7ae9aadd340dc0ef2467f0ea5111
2017-01-18ofz: reduce scope, check stream, validate nActionsCaolán McNamara
Change-Id: Ie420ad40b0d852708828620cd26c2f746398f5a8
2017-01-18TODO: fix reindentation below if you can accept being blamed by the SCMCaolán McNamara
Change-Id: I853c2a12c7f49b9562d348409726c10d977a6619
2017-01-18bodge the ms_MY currency for fuzzing stubCaolán McNamara
Change-Id: I6f2c6c1873a771188d4d2e06b8fb4a6376cf2cc4
2017-01-18pdf export: make FontIdentifier comparison strict weak ordering.Mark Hung
VS Runtime Library debug assertion failed "Expression: invalid operator<" when exporting attachment of tdf#98879 to pdf. The document uses both vertical and vertical fonts. Change-Id: I4a2c519c539c28515cac876298be820cad8b9014 Reviewed-on: https://gerrit.libreoffice.org/33082 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-17GTK3 getTransferDataFlavorsAsVector: Filter out non-MIME-typesStephan Bergmann
...that would cause needless (though caught, so not causing real harm) exceptions downstream, as in > #0 0x00007ffff6a2d4dd in __cxxabiv1::__cxa_throw(void*, std::type_info*, void (*)(void*)) (obj=0x7c60480, tinfo=0x7ffff7b0c940 <typeinfo for com::sun::star::lang::IllegalArgumentException>, dest=0x7fff81733b80 <com::sun::star::lang::IllegalArgumentException::~IllegalArgumentException()>) at ../../../../libstdc++-v3/libsupc++/eh_throw.cc:63 > #1 0x00007fff817318c5 in CMimeContentType::acceptSym(rtl::OUString const&) (this=0x7fff4617b608, pSymTlb="/") at dtrans/source/cnttype/mcnttype.cxx:113 > #2 0x00007fff817317de in CMimeContentType::type() (this=0x7fff4617b608) at dtrans/source/cnttype/mcnttype.cxx:148 > #3 0x00007fff81730bf6 in CMimeContentType::init(rtl::OUString const&) (this=0x7fff4617b608, aCntType="INTEGER") at dtrans/source/cnttype/mcnttype.cxx:95 > #4 0x00007fff81730a5d in CMimeContentType::CMimeContentType(rtl::OUString const&) (this=0x7fff4617b608, aCntType="INTEGER") at dtrans/source/cnttype/mcnttype.cxx:35 > #5 0x00007fff8172daee in CMimeContentTypeFactory::createMimeContentType(rtl::OUString const&) (this=0x7fff46165e48, aContentType="INTEGER") at dtrans/source/cnttype/mcnttfactory.cxx:50 > #6 0x00007fff8172dbe3 in non-virtual thunk to CMimeContentTypeFactory::createMimeContentType(rtl::OUString const&) () at instdir/program/../program/libmcnttype.so > #7 0x00007fffeecc97e1 in TransferableDataHelper::FillDataFlavorExVector(com::sun::star::uno::Sequence<com::sun::star::datatransfer::DataFlavor> const&, std::__debug::vector<DataFlavorEx, std::allocator<DataFlavorEx> >&) (rDataFlavorSeq=uno::Sequence of length 23 = {...}, rDataFlavorExVector=std::__debug::vector of length 1, capacity 1 = {...}) at svtools/source/misc/transfer.cxx:1221 > #8 0x00007fffeecc894e in TransferableDataHelper::InitFormats() (this=0x7fffffffa698) at svtools/source/misc/transfer.cxx:1308 > #9 0x00007fffeecc8722 in TransferableDataHelper::TransferableDataHelper(com::sun::star::uno::Reference<com::sun::star::datatransfer::XTransferable> const&) (this=0x7fffffffa698, rxTransferable=uno::Reference to (GtkClipboardTransferable *) 0x7fff46181718) at svtools/source/misc/transfer.cxx:1128 > #10 0x00007fffeecd00bd in TransferableDataHelper::CreateFromSystemClipboard(vcl::Window*) (pWindow=0x1675000) at svtools/source/misc/transfer.cxx:2118 > #11 0x00007fff9f267777 in SwBaseShell::StateClpbrd(SfxItemSet&) (this=0x37df2d0, rSet=SfxItemSet of pool 0x23bed90 with parent 0x0 and Which ranges: [(5311, 5312), (5712, 5712)] = {...}) at sw/source/uibase/shells/basesh.cxx:462 > #12 0x00007fff9f2673c8 in SfxStubSwBaseShellStateClpbrd(SfxShell*, SfxItemSet&) (pShell=0x37df2d0, rSet=SfxItemSet of pool 0x23bed90 with parent 0x0 and Which ranges: [(5311, 5312), (5712, 5712)] = {...}) at workdir/SdiTarget/sw/sdi/swslots.hxx:2104 > #13 0x00007ffff1b9c632 in SfxShell::CallState(void (*)(SfxShell*, SfxItemSet&), SfxItemSet&) (this=0x37df2d0, pFunc=0x7fff9f2673a0 <SfxStubSwBaseShellStateClpbrd(SfxShell*, SfxItemSet&)>, rSet=SfxItemSet of pool 0x23bed90 with parent 0x0 and Which ranges: [(5311, 5312), (5712, 5712)] = {...}) at include/sfx2/shell.hxx:216 > #14 0x00007ffff1bb41c8 in SfxDispatcher::FillState_(SfxSlotServer const&, SfxItemSet&, SfxSlot const*) (this=0x257eea0, rSvr=..., rState=SfxItemSet of pool 0x23bed90 with parent 0x0 and Which ranges: [(5311, 5312), (5712, 5712)] = {...}, pRealSlot=0x7fff9ffad240 <aSwBaseShellSlots_Impl>) at sfx2/source/control/dispatch.cxx:1894 > #15 0x00007ffff1b91d58 in SfxBindings::Update_Impl(SfxStateCache*) (this=0x257ee30, pCache=0x37e0570) at sfx2/source/control/bindings.cxx:327 > #16 0x00007ffff1b9421c in SfxBindings::NextJob_Impl(Timer*) (this=0x257ee30, pTimer=0x1a1e398) at sfx2/source/control/bindings.cxx:1498 > #17 0x00007ffff1b983ed in SfxBindings::NextJob(Timer*) (this=0x257ee30, pTimer=0x1a1e398) at sfx2/source/control/bindings.cxx:1441 > #18 0x00007ffff1b90478 in SfxBindings::LinkStubNextJob(void*, Timer*) (instance=0x257ee30, data=0x1a1e398) at sfx2/source/control/bindings.cxx:1439 > #19 0x00007fffec93f228 in Link<Timer*, void>::Call(Timer*) const (this=0x1a1e3b8, data=0x1a1e398) at include/tools/link.hxx:84 > #20 0x00007fffec93f007 in Timer::Invoke() (this=0x1a1e398) at vcl/source/app/timer.cxx:88 ... Change-Id: I5bac21f400cea04957554483aab2d44cca5b4bfc
2017-01-17I very much doubt we need this single special LinuxPPC ifdefCaolán McNamara
Change-Id: I1661981fabcefde9ef7819fa554a31c68972e619
2017-01-17add en_MY stubCaolán McNamara
Change-Id: Idef19273a6c45719e8771147c0788228e366d771
2017-01-17replace #ifdef SOLARIS with #ifdef __sunMichael Stahl
Check for a macro that is defined by the compiler, we don't really need one defined by the build system. Change-Id: Iccb8e3198396881395c97a6b81690ebe64b7e9d2
2017-01-17KDE4 Qt always processes all pending eventsJan-Marek Glogowski
Change-Id: I6a6e37c36a64640b641b116867da5c63c9d36bca
2017-01-17Change Idle to be a Timer subclassJan-Marek Glogowski
Drops a lot of duplicated code, as Idle is just a convenience class for instant, mostly low priority timers. Change-Id: I847592e92e86d15ab1cab168bf0e667322e48048
2017-01-17Refactor Scheduler to add Task classJan-Marek Glogowski
Moves all the "task-specific" stuff into a Task class and just keeps the "real" static Scheduler functions in the original Scheduler class. Change-Id: I9eb02d46e2bcf1abb06af5bab1fa0ee734d1984c
2017-01-17Convert bTimer => bIdleJan-Marek Glogowski
All other places already refer to being Idle, so change the Scheduler::ProcessTaskScheduling argument to bIdle and adapt all other scheduler-related functions. Change-Id: If5a605abbc3e620092127b65ada29f11215a0343
2017-01-17Always schedule with the same timeJan-Marek Glogowski
No need to always update the time - scheduling should be fast! Change-Id: Ic4c01f5a5759ef4970f1385aab6ef93cd67f33b6
2017-01-17tdf#97087 GDB pretty print the Scheduler task listJan-Marek Glogowski
In addition to the GDB pretty printer, this annotates a lot more Timers and Idles. Change-Id: I5b93fab02161b23bb753e65ef92643a04fb0789c
2017-01-17use rtl::Reference in DropTargetNoel Grandin
instead of storing both a raw pointer and a uno::Reference Change-Id: Ia03e68ce7c0bec4b6e43e9ab32d8a918ea467f5b
2017-01-17Typo: charakter->characterJulien Nabet
Change-Id: Ie925c3f15fc00cbc16f1b73d5e61be4d6fe9b8ec Reviewed-on: https://gerrit.libreoffice.org/33191 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-01-16vcl: Edit::ImplGetCharPos() no calling iterateCodePoints on empty stringMichael Stahl
(regression from 018beb38848fbd93889f29969f7ca5c68d0ac546) Change-Id: I4783d3de09eddbd00f5f91574fae1afde38f2bc6
2017-01-16tdf#102139 : prevent the notebookbar from switching to empty tabSzymon Kłos
Change-Id: I0b463fef98d7597c9b7f22ee84701519a0f2b575 Reviewed-on: https://gerrit.libreoffice.org/33100 Reviewed-by: Szymon Kłos <eszkadev@gmail.com> Tested-by: Szymon Kłos <eszkadev@gmail.com>
2017-01-16tdf#105017 Crash when click a "New Theme..." in Gallery on detached SideBarNoel Grandin
caused by VclPtr fixes which meant instead of the dialog staying in an always-zero ref-count state, it went up to a ref-count of 1, then down to zero, which triggered a delete before the dialog had finished displaying. And revert my fix in commit 0c1cd678f71e519f5a4e623d93442e046485005a which just worked around the underlying problem Change-Id: Icb35535dd06a2d1db1016d00d106760847d87430
2017-01-16drop old unused vcl/qa/complex testsCaolán McNamara
Change-Id: I3570b465d406921cbbb225825f9ba410161c9635
2017-01-15-Werror,-Wunused-private-fieldStephan Bergmann
Change-Id: Ice443900fe8066e3f9edaf789b81f6f941414b0a
2017-01-15tdf#105015: Don’t ignore all printer fontsKhaled Hosny
For whatever reason we query printer output device for fonts and for whatever reason GDI will only report fonts from the printer which often in formats we want to ignore. This results in aborting the application when we reject all fonts on the printer! Just special case printer output devices and hope for the best. I think this commit is partially blamed as it is evidenced now that there was a good reason to only abort for window output devices, but I’m leaving this as it is for now: commit ea7102c93c33884a68d4dba0de7d52f8ed4f4579 Author: Chris Sherlock <chris.sherlock79@gmail.com> Date: Tue Mar 25 21:54:20 2014 +1100 fdo#74702 OutputDevice::ImplInitFontList() fails if no fonts on device It makes no sense that ImplInitFontList() only fails for Window instances. I have carefully checked all the functions that use this function, and there are no good cases when no fonts won't cause problems. In fact, we have a number of functions that specifically rely on the fact that ImplInitFontList will populate OutputDevice::mpFontCollection with at least one font. Therefore, I'm making this abort if it can't populate the collection, regardless of whether it is a Window, Printer or VirtualDevice. I have also refactored GetDefaultDevice - I now check the default pOutDev parameter to see if it is NULL (the default), in which case it is referring to the default window, so I call on Application::GetDefaultDevice() instead of going straight to the pimpl data structure used by the Application class. Reviewed-on: https://gerrit.libreoffice.org/33014 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 88d6675a40034fa786efd75cf14175f3c0c83e2e) Change-Id: I3f34ba0cea9f88966ace3a5ef7fac868972ea5ac Reviewed-on: https://gerrit.libreoffice.org/33087 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2017-01-14vcl: Fix string comparison for reading text attributesTakeshi Abe
The original code seems to do the opposite. Change-Id: Ib112bcd14338cef84c562e4a670bcb1fcc06583e Reviewed-on: https://gerrit.libreoffice.org/33080 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-01-14vcl: add SVM metafile reading and writing test and extend xml dumpTomaž Vajngerl
Change-Id: I88ffb795a9c33ea62d05d599757a287335c7d680 Reviewed-on: https://gerrit.libreoffice.org/32914 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-01-14u*,v*: load BitmapEx resources instead of Image onesCaolán McNamara
Change-Id: If279c55a0055e51e04b31e0db745779c3a44bcd6
2017-01-14move Image(Bitmap, MaskBitmap) code to last user of itCaolán McNamara
the last use looks rather dubious to me, I wonder if anything can really end up here Change-Id: I13314610405463122891b3ed0f311da65fd1d542
2017-01-14coverity#735343 Unchecked return valueCaolán McNamara
Change-Id: I18c605511094ad48557a24a89a391d8361a001a7
2017-01-13vcl: Fix memory leaksTakeshi Abe
Change-Id: Id2e1b945d17abeffd35828ffde6eba821de0cefe Reviewed-on: https://gerrit.libreoffice.org/33047 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-01-13tdf# 105017 Crash when click a "New Theme..." in Gallery on detached SideBarNoel Grandin
Change-Id: I6a3c44a0a08cf036776976d40c985889698c08ac Reviewed-on: https://gerrit.libreoffice.org/33041 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-13use the same number in alloc and memsetCaolán McNamara
Change-Id: Ie532985e655d1dd383a1781422213cee0787bfae
2017-01-13ofz: ensure all not explicitly set indexes are zeroCaolán McNamara
Change-Id: Idbe6ceeb61d3dfe26f281349181e7a60f7e59000
2017-01-13make this a tiny bit less unreadableCaolán McNamara
Change-Id: Ib8205e76f6d1d59ef06eba6e3365c0b4cad0ecaf
2017-01-13fix android buildNoel Grandin
Change-Id: I55ff31b40366398b6159ee7a99c75e393a05b36a
2017-01-13new loplugin: useuniqueptr: vclNoel Grandin
Change-Id: Idcbc8655108ff57c06c33bbcabd652387bf3c4ec Reviewed-on: https://gerrit.libreoffice.org/32948 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-12Drop unused struct membersKhaled Hosny
Change-Id: I37aea9a2a40ab0e9642709de3b9e935bee9a6a53 Reviewed-on: https://gerrit.libreoffice.org/32986 Reviewed-by: Khaled Hosny <khaledhosny@eglug.org> Tested-by: Khaled Hosny <khaledhosny@eglug.org>
2017-01-12Resolves: tdf#104897 sort windows buttons into yes, no, cancelCaolán McNamara
and kde, for gnome/macosx use no, cancel, yes Change-Id: I4aff39938c1c9f81b47934d8f1d9400c106781ad
2017-01-12don't check every possible kde variant, startswith kde is good enoughCaolán McNamara
Change-Id: I7fb9d22af32ad5bab2deedfc993e1ffaebd57111
2017-01-12update symbols names to match current realityCaolán McNamara
Change-Id: Iba6dbec0ec1061e8953eed06a14632305bdb3e44
2017-01-12add ppm/pbm fuzzerCaolán McNamara
Change-Id: I6f403570abcf50be4cf11f20ea52bb2a07367b2a
2017-01-12add met fuzzerCaolán McNamara
Change-Id: I061739db5e7913ef13d3b862b5dee9152734d473
2017-01-12add dxf fuzzerCaolán McNamara
Change-Id: Ibf3d42ef0e0b0698309e567a92d0c5c45cc2ef94
2017-01-12make the include of OpenGLHelper.hxx not global hereDouglas Mencken
surround it like in pieces of code which actually uses it Change-Id: Iac993553455248a2d2f999f857b781dbdb37acf5 Reviewed-on: https://gerrit.libreoffice.org/32852 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2017-01-11don't position cursor inside a utf-16 sequenceCaolán McNamara
seen examining rhbz#1409011 insert three 0x2F940 in insert special character click on end and press backspace and text was mangled clise inside the 3 glyph sequence and press delete/backspace and more mangling Change-Id: I5898e9272e7a90e8b9dabb0be65f493df7dcbaf9
2017-01-11Some loplugin:conststringvar/stringconstant improvements: vclStephan Bergmann
Change-Id: I999549a840864060be4e80fe973ebb530202b807
2017-01-11Resolves: rhbz#1408500 gtk3 toolbar borders too distinct vs native gtk3 onesCaolán McNamara
Change-Id: I7ce284d3e6f999e2ac08326dc40b060bf70d7d4b