summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2015-09-07prevent crash with non-vcl OpenGL contextsMarkus Mohrhard
Change-Id: Ia829b0f723c8ded1237e52d48f034da3c1ac249e
2015-09-07clang-analyzer-deadcode.DeadStoresStephan Bergmann
...ever since its inception with 485d404dc2d12f86acd9c69f19e9075bd375e861 "vcl118: #i115788# fix file specs vs. URI" Change-Id: I990c3610b29b060b516a21ec6cba615fa101ccb5
2015-09-07clang-analyzer-deadcode.DeadStoresStephan Bergmann
...needlessly added with 6d96720fd51ca4710c9ffef3db68ac13678f5bed "#98991# fix CJKV vertical glyph rotation, avoid obsolete FT helper functions" Change-Id: Ic0311ca8ae2b4c7d33c42f7fecaae4c95c24500a
2015-09-07clang-analyzer-deadcode.DeadStoresStephan Bergmann
...ever since its inception with a949f50ce969b1f8d018d2913c0d86cfcec4e72a "implemented GetGlyphOutline()" Change-Id: I4591ac5c3d42053b3caa9d68bb12ad02dc319b66
2015-09-07clang-analyzer-deadcode.DeadStoresStephan Bergmann
...ever since its inception with 2d1f08d63942666c0094904f50ba8c512ab69b9d "CWS-TOOLING: integrate CWS otf01" Change-Id: I92ec60f5704e632126f3ba98140c520ae5c9e784
2015-09-07clang-analyzer-deadcode.DeadStoresStephan Bergmann
...ever since its inception with 5624be5a3520a16d57724064e16df3722d728010 "CWS-TOOLING: integrate CWS graphite01" Change-Id: Ib530362efe1b52f43a2a25e531cce9326001044d
2015-09-07clang-analyzer-deadcode.DeadStoresStephan Bergmann
...ever since its inception with d9bf8cb9c3f087115f72ba371e1291fd0eba3818 "add serverside font feature" Change-Id: I430b457dbf278be3299883ba0fac09a6b68c5d67
2015-09-07tdf#93884 windows opengl: make space around cached glyphs depend on font sizeMiklos Vajna
Cached glyphs used to have a 2px border in all font sizes, that's too small for larger fonts. Make the border size depend on the font size for larger fonts to make sure that the rendered glyphs are indeed independent. The introduced GLYPH_SPACE_RATIO = 8 constant is the smallest value where I don't see overflows anymore for large fonts. With this, not even the bugdoc renders correctly when presenting, but also the text is OK when the font size is set to the max allowed by the UI (96pt). Change-Id: I52aa5c4444583fc0467291463697a63f2b8fc86c
2015-09-06Related: tdf#84277 Hide separator only between two windowsMaxim Monastirsky
Change-Id: I3176933d20dce9f595fd6a9c0ee434a3709fa560
2015-09-04Minor refactoring and cleanup of Scheduler and Timer.Ashod Nakashian
Members are now const-correct. Replaced compile-time constants with enum. Refactored common functions from Timer to Scheduler. Disabled timer-precision unittests as they misfire often. These changes are non-functional. Change-Id: I6bb3d9fc402cadd556d9063ed9a4888f114c73d7 Reviewed-on: https://gerrit.libreoffice.org/17977 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-09-04Reduce nVal scopeStephan Bergmann
Change-Id: Id5756033ccfbe392ae8264afbd3e2e0afd487f6b
2015-09-04Uniformly use if --- else if brachnes hereStephan Bergmann
Change-Id: I80d9d0d4c4d56aa8d52dc2e108a9b24025fb0f76
2015-09-04clang-tidy clang-analyzer-deadcode.DeadStoresStephan Bergmann
Change-Id: I1588f55b4be2d32dcafae27ac45eb5def1407fa6
2015-09-04clang-tidy clang-analyzer-deadcode.DeadStoresStephan Bergmann
These modifications are redundant since they got moved around with a16eaec9364d0c880858108e764c510aba8c7ed6 "INTEGRATION: CWS sj22: #i122882# graphic with negative size is no longer disapearing." Change-Id: Iba58054b5638c1d78b369ca4041d0d273c5a2954
2015-09-04missing part of natural sort commitCaolán McNamara
Change-Id: I8cf86d69cfed220c940a5a3d499790d82b7ba319
2015-09-04tdf#92505 vcl: fix substituting missing glyphsMiklos Vajna
Commit a6b00d16eb27a5e7e31c721671001a909ecef960 (Related bnc#822625: Cache FontEntry with the original FontSelectPattern.) and the follow-up 16a62079018aea0e72636bdb00576487b4e830b9 (Oops, this reference can't be const., 2014-05-28) changed the font cache key, so that it's directly what was the argument to ImplFontCache::GetFontEntry(), which leads to missing glyphs in the bugdoc, e.g. the 4 check mark characters are rendered as a check mark only in the DejaVu Sans case on my machine, the other 3 cases result in placeholders. Fix the problem by changing back the key to aFontSelData, which is possibly modified in ImplFontCache::GetFontEntry() before used as a key. Change-Id: I80eb4ba0f986a10100b6ae421d1346f235ce83b7
2015-09-04Avoid a SAL_INFO about OpenGL when not using OpenGLTor Lillqvist
Change-Id: Ia066c240776cecc855b59ab0ccc84e7fdcbf4b79
2015-09-04fix slider drawing, change to always draw the whole widgetTomaž Vajngerl
Change-Id: Ifca2f72962b808a355bd7dcc20babaeb61272bf8
2015-09-04vcl: replace boost::ptr_deque with std::deque<std::unique_ptr>Caolán McNamara
Change-Id: Id53ee54dda5454669affd5ca5324a2d7c5387063
2015-09-04Related: tdf#92982 vcl rendercontext: optimize non-buffered paint of CursorMiklos Vajna
Change-Id: Ic8065d4f656d42f1e2e7d8b4c602010fa0ae2d34
2015-09-04convert Link<> to typedNoel Grandin
Change-Id: I2136c3db2742afcb4722f69297276bea1e0119f4 Reviewed-on: https://gerrit.libreoffice.org/18306 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-04remove unused Link<> fieldsNoel Grandin
Change-Id: I81401ae6d1b1e95375bf4a5792b3b83189be5683 Reviewed-on: https://gerrit.libreoffice.org/18304 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-03tdf#93892: Un-share maUserBuffer when the BitmapWriteAccess is requested.Jan Holesovsky
Otherwise Bad Things Happen, and we may accidentally overwrite random other / shared data. Change-Id: I463354a6e910a2cb43faa229708fe5c14c79535a
2015-09-03Fix mis-mergeStephan Bergmann
...where fb6f2e1109abdd09e80dbcd6660a9530fc06ff0f "Resolves: #i121407# Gallery reorganizations..." first cherry-picked the younger 8012fae6cedcf325130d70adf0a486e8918f452f before f7d373d18f965b36f310d44044bdba6476f6eb03 "Added ColorDepth change test with assertion to the Bitmap::Scale method" then cherry-picked the older 4be8cc079667cca2cae91dba9e46c16ccff1537f, leading to the two checks at the top of Bitmap::Scale to not return early as intended. Thanks to clang-tidy clang-analyzer-deadcode.DeadStores for flagging this. Change-Id: Id89cc517a9f7efdff040c70f3b0e640d969cf24d
2015-09-03clang-tidy clang-analyzer-deadcode.DeadStoresStephan Bergmann
...given that setting bCalcPortion to false is always followed by a break out of the while loop ever since the code's inception in 8ab086b6cc054501bfbf7ef6fa509c393691e860 "initial import," bCalcPortion is apparently always true when read Change-Id: I83ba29a78512360500a0c9c8c1baf1ccbad87951
2015-09-03clang-tidy clang-analyzer-deadcode.DeadStoresStephan Bergmann
...of computing nDraw, since 04c037d8a8f1ca954181d75ab3a7cc648a5d1d63 "refactor ScrollBar to use RenderContext" replaced call to ImplDraw(nDraw,this) with call to Invalidate() Change-Id: Ifb9a2494715363c35c19574e85852b488667f97e
2015-09-03clang-tidy clang-analyzer-deadcode.DeadStoresStephan Bergmann
...the two consecutive writes to nX had been like that ever since the code block's inception in 4716735ba7d0ad133ff018481f94d6b4f201bbd9 "#103362# improve positioning and resizing of system windows," so assume the first one is indeed unnecessary. Change-Id: I52a9a8a15fa38a0d14f9e521e15b7f71013f46c0
2015-09-03clang-tidy clang-analyzer-deadcode.DeadStoresStephan Bergmann
...at least since the commented-out code using it got removed with 99f58dc2a6d9d2976948b2fe01b1ed1ae63d685e "vcl: remove dead code and useless task comments from winproc.cxx" Change-Id: Idddd3af6d667370cb937aa065382c1913ab8e911
2015-09-03tdf#93870 - GL accel. via VCL canvas for presentations when GL enabled.Michael Meeks
Change-Id: Ia31a88cb3d9e6baa987b22f77f407a3f592031f1 Reviewed-on: https://gerrit.libreoffice.org/18285 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2015-09-03Restored missing includes from source files.Ashod Nakashian
These source files relied on pch to include these missing headers (at least on Windows). Also included the script used to find the missing includes. The script is self-contained and includes unittests. It detects superfluous includes and required includes (which was used to restore the includes in this patch). Change-Id: I7ee09e5c712f42d5f6c3524898bc62dda78f5cc0 Reviewed-on: https://gerrit.libreoffice.org/18208 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-03remove KDE3 support, --enable-kde and --enable-kdeabMichael Stahl
With the new RHEL6-era baseline TDF can finally ship KDE4 support. Change-Id: I227278b576a3ed2f2aaa751d41b469ca92dc78b3 Reviewed-on: https://gerrit.libreoffice.org/18267 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-03convert Link<> to typedNoel Grandin
Change-Id: I8bea5ac685b0076649412bd95501461242797d77 Reviewed-on: https://gerrit.libreoffice.org/18266 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-03convert Link<> to typedNoel Grandin
Change-Id: Ic0482dc5ed26eb2fc6ccde73022eff8b4786de83 Reviewed-on: https://gerrit.libreoffice.org/18258 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-03opengl: let OutputDevice do the bezier subdivisionTomaž Vajngerl
Change-Id: I0620cd29695d792320c6e3209dff84822485d883
2015-09-02Resolve merge failure: an OutputDevice parameter not WorkWindow.Michael Meeks
Change-Id: I366fcab22550f5d386af7ed3be0ad25456317b7d
2015-09-02Add another vcldemo OpenGL test to try to catch another Windows nasty.Michael Meeks
Change-Id: I43e48617617e89f5aa089ef1487215c5b81c50bc
2015-09-02tdf#93867 - clear current GL context before thread switch.Michael Meeks
Fixes regression from otherwise a nice cleanup in: d20092259c7ea63885a539f911788715f8147ee9 Also get polarity of debug logging only with a context right. Change-Id: Id322471f01e5656e758aefc57b0d4d5ad073ec54
2015-09-02Don't call GL debugging methods if there is no context.Michael Meeks
Change-Id: Ie6b824953b8ad19fd1b6a146cb6bf52bbb152ef7 Reviewed-on: https://gerrit.libreoffice.org/18276 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2015-09-02Add SAL_DISABLE_GL_WATCHDOG env. var for obvious reasons.Michael Meeks
Change-Id: Iec7cb6504a389972d8187954d5ed7aff94f2e01c
2015-09-02tdf#93859 opengl - don't cache radiobuttons, refactor code dupl.Tomaž Vajngerl
Radio buttons and check boxes can't be cached with current framework as they have an additional rendering state provided in additional data. Refactor code to control which controls can be cached in one place only. Change-Id: I095a01cbf5dde013247d70ada89020f64c8c6510
2015-09-02tdf#93857 opengl: adapt UniscribeLayout's DrawCachedGlyphs() to FillDXArray()Miklos Vajna
The problem was UniscribeLayout::DrawCachedGlyphs() counted the total advance value unconditionally from mpGlyphAdvances, while UniscribeLayout::FillDXArray() (which provides advance values to e.g. Writer) only used mpGlyphAdvances in case of NULL mpJustifications. Fix this by first checking mpJustifications in UniscribeLayout::DrawCachedGlyphs(), too. With this, e.g. typing "x" in Writer 10 times will not result in a "misplaced" cursor caret. Change-Id: I16c7a258ff77b25c5121b9b974e72ad6efe5e9fc
2015-09-02vcl: rename DESKTOP_KDE to DESKTOP_KDE3Michael Stahl
Change-Id: Ie9d4d339f0fe3248a7fd7f790adcb89e660d34ec
2015-09-02ditch gnome-vfs2 supportCaolán McNamara
Change-Id: I882c04fd3a255f55511b1884157de26e7574e6db Reviewed-on: https://gerrit.libreoffice.org/18262 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-02tdf#93850 - Defer watchdog during shader compiles.Michael Meeks
Shader compilation can take a while the first time; best not to disable GL at that point. Have more of a hair trigger at other times. Also explicitly exit if we appear to have hung in std::abort handling. Change-Id: I45f0873672f950fb3baba0ca859d854a0bb25064
2015-09-02tdf#93839 - Encourage vdevs to pick up new GL Contexts for Linux.Michael Meeks
Change-Id: I1c40df21a1b1b6d0637f399cf29ca4f49a81d183
2015-09-02windows opengl: Avoid an unnecessary wglMakeCurrent() call.Jan Holesovsky
Change-Id: I1c1287a29067c053565c49c0ce96918a2d27d87f
2015-09-02SetXXX(bool) with a default value of false are just wrongNoel Grandin
Change-Id: I4888d0474199bb10ca81d1ad03118a150f574671 Reviewed-on: https://gerrit.libreoffice.org/18235 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-01More useful param typeStephan Bergmann
...for arg that ultimately ends up as const GLVoid *pixels arg to glTexImage2D Change-Id: I69ba2f1dd397fa103f3f59638bec727add3caed7
2015-09-01More vcl unit test headers for good measure.Michael Meeks
Change-Id: I55df85df2d01c322e5725fb2844333f967ef48e2
2015-09-01vcl: evidently that test needs glew headers nowMichael Stahl
Change-Id: I6c9742c8be222a33feea9f6291b29dde73869a93