summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2017-03-14tdf#106059 PDF export: include content of PDF images as an embedded fileMiklos Vajna
Initial step to have vector output for PDF images in the PDF export result. Change-Id: I3d08403d3c83e11c63af69312f9af7474dcd2ead Reviewed-on: https://gerrit.libreoffice.org/34366 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 5fd4c95affbad94f5630425e35bced434d18e3d8)
2017-03-14vcl pdf import: use pdfium instead of draw_pdf_importMiklos Vajna
Replace creating a full Draw component with direct pdfium library calls. This also means that the result is now a bitmap, not a metafile for now. Also decouple HAVE_FEATURE_PDFIMPORT and HAVE_FEATURE_PDFIUM, the first is the "import PDF into Draw" feature, the second is the "insert PDF as image" feature. Reviewed-on: https://gerrit.libreoffice.org/34217 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 6657d52417295265367cf3ffe5832b60e3c38011) Conflicts: config_host/config_features.h.in vcl/Library_vcl.mk vcl/source/gdi/impgraph.cxx Change-Id: I72c25642ec84cc831df362e02b1520c6e6d9adcf
2017-03-14vcl: move out ImportPDF() from the global namespaceMiklos Vajna
It's a public symbol and can live in the vcl namespace just fine. Change-Id: I677f22e79f8ddc0c0756cc9bfeb498249354c516 (cherry picked from commit 0939e079abe3cea70c951fbe1859c39e11cfca29)
2017-03-14tdf#105093 sd PDF export: handle embedded videosMiklos Vajna
In practie embedded files always have a temp file URL, so from the PDF export's point of view they are still URLs, just at the end the contents of the URL is embedded to the PDF, not just the URL itself. So add a SetScreenStream() that's similar to SetScreenURL(), but it's for embedded, not linked videos. Change-Id: Ifcc60357ef0f5fed0bdec02e0c84cb16ee147781 Reviewed-on: https://gerrit.libreoffice.org/32727 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 4ad249af88d15f2c8a09f0721a59d82718fcc201)
2017-03-14Related: tdf#104841 sw PDF export: handle linked videos on non-first pagesMiklos Vajna
Be explicit about the page number, this way a video on the second page doesn't end up as an annotation for the first page. (In the Impress case each slide is exported separately, so there this wasn't a problem.) Change-Id: I83ba9cb4a3b2a6734bd88a138654e391199651c6 Reviewed-on: https://gerrit.libreoffice.org/32696 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 0e71075bb7379af318482bb3abbb630c58db9ec9)
2017-03-14tdf#104841 sd PDF export: handle linked videosMiklos Vajna
Use the screen annotation markup for this purpose. Change-Id: I129111cbe08c19c2f3b3ae046408ff9b2a28520c Reviewed-on: https://gerrit.libreoffice.org/32654 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 9d6a749bc664f1876c938afb9eba4adc9f6ee09a)
2017-03-14vcl PDF export: enable MARK() in dbglevel<2 builds as wellMiklos Vajna
Instead of mandating dbglevel=2, use the already existing environment variable to avoid additional rebuilds. Change-Id: I9ac543522e0e79dd2be74e12d0dd0551be63988f Reviewed-on: https://gerrit.libreoffice.org/32638 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 49968942a62f6feb6db4dcf385ddee925a57b497)
2017-03-10CIA: unnecessary dllCaolán McNamara
Reviewed-on: https://gerrit.libreoffice.org/34972 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 587cf92e5cff091f863227fffa347df875fb86f7) Change-Id: Icbc3eaff000d90885cf85d8195868e1248493896 Reviewed-on: https://gerrit.libreoffice.org/34974 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit ef58999df39ed665e34a87574b370a338c1ef9a4)
2017-03-10Revert my fix for tdf#71409, to hopefully fix tdf#104381.Kohei Yoshida
This reverts commit 87e040fd0f04307534920d0765af6d5878794a98. This reverts commit a0ef7474521413c8967559a635e6fdc0d88f1df6. Conflicts: vcl/unx/gtk/a11y/atkutil.cxx Change-Id: Ib3a799e27b2495ebd1e7723f1cb5babf0dfbc702 Reviewed-on: https://gerrit.libreoffice.org/34730 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> (cherry picked from commit 10077a06d8f6d08f276f99024528ee31a57390a9) Reviewed-on: https://gerrit.libreoffice.org/34732 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit 6f36ee01ab3d7934880bfd8b5d337288dcbf62c7)
2017-03-10tdf#103831, tdf#100986: Force using GDI when neededKhaled Hosny
Our DirectWrite renderer is incomplete and can’t handle rotated text or text with horizontal scaling, so route these two through GDI for now. Reviewed-on: https://gerrit.libreoffice.org/34848 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org> (cherry picked from commit a51b7a1c3a7e7cf7b0c733e1dec40288278c1884) Change-Id: I87b85796a29e3acce782e01b4c629fec6f1a9e25 Reviewed-on: https://gerrit.libreoffice.org/34862 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit 4375eefb644d03ab4bafbc091436166a8494dc91)
2017-03-06ofz: Z_NEED_DICT is unsupportedCaolán McNamara
Change-Id: Ib0945d5a4606915aff9ee3019203caaf2a3cc7c5 (cherry picked from commit aacaacc16938b030a1341d8dbaf56c6a2efeb1dc) Reviewed-on: https://gerrit.libreoffice.org/34743 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit 6f3cc872c58d8b34ca9f0a06f2d65b3b6cc1c7ee)
2017-03-06Tolerate mouse move generation on disposed windows.Michael Meeks
http://crashreport.libreoffice.org/stats/crash_details/524d28fb-4fd2-4d11-83b1-1360b5ab5068 Change-Id: I19a13f751b5cf000c9938ff991d7d44bba0a4de7 Reviewed-on: https://gerrit.libreoffice.org/34756 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit a9be0b6a4e39240871a9b35ae9afd04f242a3ea4) Reviewed-on: https://gerrit.libreoffice.org/34757 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit e2eb25a52d86eec868ace658dd3a27eaf536b311)
2017-03-01tdf#104482 Force updating progress bar on safeJan-Marek Glogowski
I don't know why the progress bar on load is handled differently then on safe. As a workaround, this converts all Flush() calls to Update() calls, but we should update the UI on safe correctly. Change-Id: I97d6fc5797d08e9556f7fa7f9f8110aef30b3772 (cherry picked from commit 0b08eacd79a2133a07410dfb99bcc04bb9dd2199) Reviewed-on: https://gerrit.libreoffice.org/34551 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit b192cf7791aa7a218b0657715f4c4ad2adf5bb4d)
2017-02-24Revert "tdf#95761 All Hotkeys with CTRL+ALT+ not worked"Andras Timar
This reverts commit 5deedec2ab708b841d0d696c8039c7fbcd4e62a7. It is a bad idea to use Ctrl+Alt accelerator keys. It fixes tdf#97908. (cherry picked from commit df00c67da8e8701179dbe66efa00e4a795d51700)
2017-02-24tdf#104509: Fix GetGlyphBoundRect on MacKhaled Hosny
The rectangle top and bottom were mixed up! I tried to fix this in 8cef9b4dbafdebc0566d6d7f715f27f978ddfe5b, but it was not the right fix. Change-Id: Ia033ff2823bfd641e830d748d413d7791bfee5b8 Reviewed-on: https://gerrit.libreoffice.org/34557 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org> (cherry picked from commit 04d086531ff4a3ab24b704489270c7c23792bd20) Reviewed-on: https://gerrit.libreoffice.org/34559 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 659a38ba7678c7a62ba0872f390c59329daadb90)
2017-02-24Don’t return false for blank glyphsKhaled Hosny
CTFontCreatePathForGlyph() will return NULL for blank glyphs causing CoreTextStyle::GetGlyphOutline() to return false which propagated as error all the way to OutputDevice::GetTextOutlines() causing it to needlessly enter into fallback code. Other implementations just return true and an empty polygon here. Change-Id: Ib20ebff00f7cb3aae22f1c6b4c3a0e9d7a429987 Reviewed-on: https://gerrit.libreoffice.org/31902 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org> (cherry picked from commit 04a77bfa9c5a3da6d99ee6ad8d4802638b7d76fa) Reviewed-on: https://gerrit.libreoffice.org/34558 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 0a0b98ae530c7f27c2f790a889f3edbfc98858bd)
2017-02-24Fix visible space on Mac with the new layout engineKhaled Hosny
This is not an issue on master since the alternative Mac code path is gone, but we need to skip it in 5.3 when the old layout engine is not used as well. Change-Id: Ib0c8fcf072229c59e15877815c9d88aed94672f0 Reviewed-on: https://gerrit.libreoffice.org/34433 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 4f8edca85216b46b266fc5dba3103da57e5975be)
2017-02-20tdf#105256 gtk findfocus return only if focusedJustin Luth
A patch related to tdf#96685 (commit 598e6a024163f1510d076000788b7745625f5ed5) caused the initial regression that Japanese-mozc would freeze(tdf#100903). That patch only modified what happened when the text was marked as focused. However, the regression fix for Japanese bug 100903 (commit 1c81af2c1814e8bd12701f85e09cebf5fe206647) was not placed inside of the "if focused" code, and so it applies to more situations than were broken by the first regression, thus causing new bug 105256. So, applying fix 100903 ONLY when focused solves both problems. Change-Id: I1d8381f2d8cf793d481287ae975ce8a485b6c573 Reviewed-on: https://gerrit.libreoffice.org/34453 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp> (cherry picked from commit 1c3a784d38fc5986c78bab8d283c4661347baf43) Reviewed-on: https://gerrit.libreoffice.org/34486 Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit c6a48e66deef01aa82409aec0ab3c2a9201d467b)
2017-02-18loplugin:vclwidgets check for assigning from VclPt<T> to T*Noel Grandin
Inspired by a recent bug report where we were assigning the result of VclPtr<T>::Create to a raw pointer. As a consequence, we also need to change various methods that were returning newly created Window subclasses via raw pointer, to instead return those via VclPtr Change-Id: I8118e0195a5b2b4780e646cfb0e151692e54ae2b Reviewed-on: https://gerrit.libreoffice.org/31318 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit e6ffb539ee232ea0c679928ff456c1cf97429f63)
2017-02-17lok: refill font list if emptyHenry Castro
After preinit stage the font list is empty when creating documents. Reviewed-on: https://gerrit.libreoffice.org/32108 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com> Conflicts: sd/source/ui/docshell/docshel4.cxx svtools/source/control/ctrltool.cxx Change-Id: Ia6938d521626f4b4022f0f993e77c017e4932415 Reviewed-on: https://gerrit.libreoffice.org/32796 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com> (cherry picked from commit 0ad4b2570f06aa014f8446757931afa1f2305458)
2017-02-17Fix -Werror,-Wunused-private-field in the DISABLE_EXPORT caseTor Lillqvist
Change-Id: I237a691ac6b7b3edcc7b2fbdfc36ed72ae46fe0c (cherry picked from commit df1de153d4a9e103dbf4580f91b3b15a77c44c1a)
2017-02-17Fix my windows build.Kohei Yoshida
Change-Id: I0cd6213f58e8b2d3d5950dfbb12e524de2950265 (cherry picked from commit 7637a20a622d6799ba867bd0122841a393178545)
2017-02-16Resolves: ofz#576 unexpected exception with invalid fractionCaolán McNamara
(cherry picked from commit cff6cdb2ee37e836b9bab39500d24fcedc360121) Change-Id: I1d653775e88e9fa2ba7b62fce39d52fc21ffe363 Reviewed-on: https://gerrit.libreoffice.org/34069 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-02-15Simple work-around for unpleasant framework shutdown to avoid crash.Michael Meeks
http://crashreport.libreoffice.org/stats/crash_details/2de31c06-da20-4280-916a-e282a337b16b Change-Id: I0b599de9b36f62d65988c1ab698f1559134fbf7c Reviewed-on: https://gerrit.libreoffice.org/34294 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit 2c60e02bbfde8655828a5b019642f5e85f975e61) Reviewed-on: https://gerrit.libreoffice.org/34297 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-02-13Resolves: tdf#101972 skip invalidating labels on alt if autoaccel is disabledCaolán McNamara
so no Invalidate will be called if auto accelerators are not enabled so there should be no blinking under windows Change-Id: Iccc5dad7af41f39ac02d3be93e935f2d926a82a6 (cherry picked from commit f67dc04cfdd9e63a45ec6c8bc00829bce8f17d4b) Reviewed-on: https://gerrit.libreoffice.org/34076 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-02-09tdf#105286 use alternative font when glyph is not vertical.Mark Hung
In vertical layout, a vertical font is selected. For windows, that means prepending a '@' to the font name. Switch back to the one without '@' in order to display characters that needs to be rotated 90 degrees in vertical layout correctly. cherry-picked from aa9251103a131880afa621501936603d8c75af9d. Change-Id: I4e0361929f898eddc671b739b36a12dd26d68018 Reviewed-on: https://gerrit.libreoffice.org/33064 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org> Reviewed-on: https://gerrit.libreoffice.org/34093
2017-02-09ofz#574 sanitize png palette indexesCaolán McNamara
clarify we're not setting a pal index in the mask no logic changed intended, SetPixelIndex expands to this, just want to clarify that this is an alpha value, not an index into a palette (cherry picked from commit e5b23d924d60e7a0fb67c44c6dad3f4cb3bd5ddc) Change-Id: I006ffdf5c8c751e7e07b133716022e2a9b154478 e9bb188b116adf3eab4e2bb1d6da8badbaead88b Reviewed-on: https://gerrit.libreoffice.org/34035 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-02-02fix crash with gtk3, opengl and presentation consoleCaolán McNamara
PresenterSlideShowView::PaintInnerWindow has a mbIsForcedPaintPending flag which is used to throw away the console canvas, but for other backends the paint occurs at a much different time after a clear has a chance to get triggered, while for gtk3 it happens as its being setup. hack around this presenter console weirdness by skipping the initial paint for this salsysobj case Change-Id: If1b23600ef07241e52d92bd5eb38b9e90d9ed192 (cherry picked from commit 0861cb6d72f0d718928a1998c8a0e2c690e8b09f) Reviewed-on: https://gerrit.libreoffice.org/33804 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-02-01tdf#105461 PDF export: handle text fill colorMiklos Vajna
Text portion level background in Writer text was working already, as Writer paints its background explicitly, and then uses no text fill color in the metafile (that is turned into a PDF later). However, text fill color is used for Writer shape text and also in Impress. The rectangle is not just the text itself, but also the ascent / descent region, this matches the desktop rendering result. (cherry picked from commit ee32c7d8083ae1449d6b379034be92995c142da9) Change-Id: I644007ade43a8b9e663890643b826ae12c427ea5 Reviewed-on: https://gerrit.libreoffice.org/33794 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-02-01gtk3 hidpi xor hack needs to use unscaled extentsCaolán McNamara
so that e.g. the xor cursor in csv dialog can be seen when moving the mouse across the ruler Change-Id: Ia2f367d5f610d486a8e10b6bc278cbc8029cf2a1 (cherry picked from commit 00c4679641bc2b84c6496258c0c5bd84df75ae42) Reviewed-on: https://gerrit.libreoffice.org/33791 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-02-01Related: tdf#105514 recursive fallback GetOpenGLContextCaolán McNamara
Change-Id: Icb8f3751806ef9c1c7c92cd8b7cc7c28595eca22 Reviewed-on: https://gerrit.libreoffice.org/33580 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 9a61fdbf0b64dac30a2fe098388cd20471cca7bb) Reviewed-on: https://gerrit.libreoffice.org/33747 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-02-01ofz#502 negative indexCaolán McNamara
Change-Id: I2eb3da9d378cd8fdace5ccd644f501f5119f6698 Reviewed-on: https://gerrit.libreoffice.org/33740 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-02-01Resolves: rhbz#1417480 stray bare XWarpPointer call in gtk3 codeCaolán McNamara
which blows up under wayland naturally can get here from tools->options->mouse positioning->"dialog center" table->insert table Change-Id: Id81b06a63cc3a2a1073d236e2f36dc65e533e598 (cherry picked from commit b4b989b59cc5841fdf4635b19b975cae3a88430f) Reviewed-on: https://gerrit.libreoffice.org/33690 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-01-26only alloc pDXAry if we are going to use itCaolán McNamara
Change-Id: I4fa075124ad55d3a06e1f3d21845f73778c841b6 Reviewed-on: https://gerrit.libreoffice.org/33588 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-01-26ofz#424 vcl: reset nLen tooMichael Stahl
Change-Id: I8794bfebaf729345bfd1aa44dcd66099db7ca1cd Reviewed-on: https://gerrit.libreoffice.org/33583 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-26Resolves: tdf#94457 our EmfPlusSetPageTransform is malformedCaolán McNamara
we write a single short, resulting in a record of 0x000C in length MS-EMFPLUS spec has EmfPlusSetPageTransform as 0x0010 in length because we're not writing the 4 byte PageScale value. the previous pageunit unit we are writing is of value 1, which is UnitTypeDisplay, the same spec says... "The unit of measure for page space coordinates, from the UnitType enumeration. This value SHOULD NOT be UnitTypeDisplay or UnitTypeWorld" and footnotes that with... "Windows never writes those values to the PageUnit field, but they are accepted with undefined results." Change-Id: Ic8b5ec463b59aab28ae9897947dfcdbd35b22048 Reviewed-on: https://gerrit.libreoffice.org/33559 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-01-26Resolves: tdf#104598 make bright theme shadow the same as it always wasCaolán McNamara
The shadow color was originally set via StyleSettings::Set3DColors taking the background color as the input, and doing DecreaseLuminance(64) on it to make the shadow color So, continue to follow that mode if the "dark shadow" is darker than the foreground, and IncreaseLuminance the equal amount the other direction for dark themes. This way under a dark theme the problem of impossible to see rulers of tdf#90214 is still fixed, while the bright theme colors are the same as they always were, which avoid the wearing-on-the-nerves "regression" problem. Change-Id: I33133ff180ecadce3a14ee45bd33db73c56c0225 (cherry picked from commit 19663d39f400dac3682228f3f0146807bbbebe74) Reviewed-on: https://gerrit.libreoffice.org/33523 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-01-26fix guardCaolán McNamara
Change-Id: If7787ca67f3c0d45ac0425a12719e92e0040bcc3 Reviewed-on: https://gerrit.libreoffice.org/33518 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-01-25ofz#463 unable to mmapCaolán McNamara
Reviewed-on: https://gerrit.libreoffice.org/33519 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit f6c465bc8e7583a8321f5c881cb008b980e0e3fa) Change-Id: I509faeda019f42bbe7cdc5fc249f2ea2076bb702 Reviewed-on: https://gerrit.libreoffice.org/33521 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2017-01-25ofz#439 protect against 0 len textCaolán McNamara
Change-Id: Ib67284636235b0d43df626a4aeed67f2bc64b491 Reviewed-on: https://gerrit.libreoffice.org/33375 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-01-24Resolves: ofz#424 guard against broken dxary lengthCaolán McNamara
Change-Id: Ia2569e963edd75cd6c27399d33e73bafe8b3f073 Reviewed-on: https://gerrit.libreoffice.org/33320 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-01-22Resolves: tdf#105416 blank windows under HiDPI RTLCaolán McNamara
Change-Id: I819f06babd448c37ce2d58297562b640aba1c8c6 (cherry picked from commit 4e9cfc178c47893229f8030bfe73e2b7c5de92c3) Reviewed-on: https://gerrit.libreoffice.org/33302 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2017-01-19Resolves: tdf#98593 buttons in writer show different text at different zoomsCaolán McNamara
The DrawControlText always renders with a reference device positions but we pass in a rectangle which is derived a different way. So, add a GetControlTextRect which operates on the same reference device as DrawControlText so the rectangles match The rectangle is mapped from pixels to logic and back from logic to pixel, so add an argument to store the logic size from GetControlTextRect and re-use it without conversion on the cases where we pass back the original rectangle zooming in/out on the button in writer is now stable wrt text shown at all zoom levels Change-Id: Ic581eca67d0ff265e2753ab8b6c40e8fca7e6ae4 Reviewed-on: https://gerrit.libreoffice.org/33277 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit db9ef688edd86b31606e0dd6df6a77732faca49b) change DrawControlText to return new rect rather than change old one Change-Id: Id5c80ff263e429d4239a844db216e87a656edb2e (cherry picked from commit bc6479e92b56df742dd7339d337ffc78d2f9e4a1) Ref...DeviceTextLayout::GetTextArray is only called by Ref...DeviceTextLayout so set it as private to de-confuse this a little Change-Id: Idde7f78a767227cc2d52e417b6c39d12e1339745 (cherry picked from commit 3d002fdb8738d9bbc9b04c0270510e349bd58149) Reviewed-on: https://gerrit.libreoffice.org/33281 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-01-18ofz#419 same problem as wmf and emfCaolán McNamara
this is the *third* effective copy of this, see the other two uses of LF_FACESIZE in wmf parsing Change-Id: I475b18314784ad072fe58730c361fc5ca6e65819 Reviewed-on: https://gerrit.libreoffice.org/33256 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-01-18ofz: reduce scope, check stream, validate nActionsCaolán McNamara
(cherry picked from commit bd78b28a1233e26c023a52df6b119d60a61d53ad) Change-Id: Ie420ad40b0d852708828620cd26c2f746398f5a8 Reviewed-on: https://gerrit.libreoffice.org/33259 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-01-17ofz#411: XPMReader::ImplGetColKey short readCaolán McNamara
Change-Id: I2e47ef6478b8349a562b294d0fbdad65c2a3b543 Reviewed-on: https://gerrit.libreoffice.org/33217 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-01-17tdf#105017 Crash when click a "New Theme..." in Gallery on detached SideBarNoel Grandin
caused by VclPtr fixes which meant instead of the dialog staying in an always-zero ref-count state, it went up to a ref-count of 1, then down to zero, which triggered a delete before the dialog had finished displaying. And revert my fix in commit 0c1cd678f71e519f5a4e623d93442e046485005a which just worked around the underlying problem Change-Id: Icb35535dd06a2d1db1016d00d106760847d87430 (cherry picked from commit cd9d8315141c3070f43e145ed4ee390e837eb73f) Reviewed-on: https://gerrit.libreoffice.org/33209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-14vcl: Fix string comparison for reading text attributesTakeshi Abe
The original code seems to do the opposite. Change-Id: Ib112bcd14338cef84c562e4a670bcb1fcc06583e Reviewed-on: https://gerrit.libreoffice.org/33080 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 99eed82939999d9a9689788a4134dd05d5c20c5a) Reviewed-on: https://gerrit.libreoffice.org/33081
2017-01-14tdf#105017 Crash when click a "New Theme..." in Gallery on detached SideBarNoel Grandin
Change-Id: I6a3c44a0a08cf036776976d40c985889698c08ac Reviewed-on: https://gerrit.libreoffice.org/33041 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit a076a062ceb02bd34a460819db61dcbfbca5c8d7) Reviewed-on: https://gerrit.libreoffice.org/33056 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-13ofz: ensure all not explicitly set indexes are zeroCaolán McNamara
Change-Id: Idbe6ceeb61d3dfe26f281349181e7a60f7e59000 (cherry picked from commit 14d9b3519adac8543b52ddb84e49eecbdd1d9eb2) Reviewed-on: https://gerrit.libreoffice.org/33035 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
generated by cgit (git 2.34.1) at 2025-03-13 06:14:05 +0000