summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2018-03-17Typos concerning hierarchyJulien Nabet
Change-Id: Ied3c6d1513f2181a5f7da2904a0df2f806146cec Reviewed-on: https://gerrit.libreoffice.org/51465 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-03-17uitest logger: call correct function for key loggingSaurav Chirania
isMod2() and isMod3() functions have been used in place to isMod1() to generate correct key logs. Change-Id: Idcb83ad8bf00d31cac08cb7ff17ecca635b44967 Reviewed-on: https://gerrit.libreoffice.org/51367 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-16rhbz#1392145 ensure titlebar close button matches 'outside' directionCaolán McNamara
Change-Id: I20e925c58adb56acd4d1a63720d330c8b6613441 Reviewed-on: https://gerrit.libreoffice.org/51433 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-16use digit width instead of char widthCaolán McNamara
its the same across backends Change-Id: I37c83cbf1139babcd014c7cfdee06a13bea845c7 Reviewed-on: https://gerrit.libreoffice.org/51423 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-16move cairo extract bitmap code from canvas to vclNoel Grandin
part of making GetMask/GetAlpha an internal detail of vcl Change-Id: I45c2e9fdae08d7f444a64e8e04a6f65bb525cbd1 Reviewed-on: https://gerrit.libreoffice.org/51417 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-16move some mask code from SvxMSDffManager::ImportGraphic inside BitmapExNoel Grandin
part of moving GetMask/GetAlpha touching code inside vcl Change-Id: I46e908ed6216dd521143ca94d2dcbd7e95d8b9ce Reviewed-on: https://gerrit.libreoffice.org/51408 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-16weld SvxObjectTitleDescDialogCaolán McNamara
Change-Id: Id08c201ee4377fe84618906725e7699d29dc1160 Reviewed-on: https://gerrit.libreoffice.org/51395 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-16Simplify codeStephan Bergmann
...avoiding loplugin:salunicodeliteral and loplugin:stringconstant Change-Id: I560682ac87b24f47fc16a6ef17232c7fbc8c9099
2018-03-16don't bother dithering for 256bit displaysNoel Grandin
which surely are a minority by now Also drop the GetColorCount() method on OutputDevice and clean up the remaining call sites to use GetBitCount() Change-Id: I4e2c6f2523796f7df7f54eb005f1539e34d9ea40 Reviewed-on: https://gerrit.libreoffice.org/51389 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-16move framework/toolkit use of BitmapEx::GetMask inside vclNoel Grandin
Change-Id: I2a942377d6e9b8b09673e5ad2804e0e7fb2bb943 Reviewed-on: https://gerrit.libreoffice.org/51387 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-16remove constructor with UniqueID from GraphicObjectTomaž Vajngerl
Change-Id: I03924c993a95adaf6e19589779546fce2b38c745 Reviewed-on: https://gerrit.libreoffice.org/51333 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-16Remove XGraphic creation with Grap.Obj. URL in GraphicProviderTomaž Vajngerl
Change-Id: Ie51be332df88791cb13c3835582acc0a4e7250f9 Reviewed-on: https://gerrit.libreoffice.org/51332 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-16tdf#116213 OS X and OpenGL bitmap scaline sizes are not 32-bit alignedChris Sherlock
Change-Id: I92b43ae2f034bf63cc3f212ec8728c5c6b5e8934 Reviewed-on: https://gerrit.libreoffice.org/51222 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-03-16Fix typosAndrea Gelmini
Change-Id: If70b03cad4c46010a59cf3bee139e801230fa3aa Reviewed-on: https://gerrit.libreoffice.org/51385 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-03-16lokdialog: Invalidate upon window size changePranav Kant
This problem can be seen with some of the dialogs like chart dialogs where not all of the area which should be invalidated is invalidated. The reason being that their container gets resized but not lok-invalidated. Change-Id: I12eb68e8644ca67b2666badb7b772b92a145c624 Reviewed-on: https://gerrit.libreoffice.org/51264 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2018-03-16XGraphicObject: remove construct. with uniqueIDTomaž Vajngerl
Also make getUniqueID return empty string. Change-Id: I200a1facf088a205302991e5c26fe93adec55a87 Reviewed-on: https://gerrit.libreoffice.org/51330 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-16more robust method to load a Graphic from URL, +clean upTomaž Vajngerl
Change-Id: Ib7fb107a56a3cc9fffb6cfaa9bbc2117434902df Reviewed-on: https://gerrit.libreoffice.org/51329 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-15weld sort dialogCaolán McNamara
rework huge language listbox into a combobox see https://gitlab.gnome.org/GNOME/gtk/issues/94 and the lack of typeahead/search for lists Change-Id: I4a3af695d86bbcb92e5cdd500c4acb7cfaf37f41 Reviewed-on: https://gerrit.libreoffice.org/51340 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-15move swffilter use of BitmapEx::GetAlpha inside vclNoel Grandin
Change-Id: I22f489a26b8566ddc00c0c77f95127adb8eb2489 Reviewed-on: https://gerrit.libreoffice.org/51324 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-15move Bitmap::ScopedWriteAccess inside vclNoel Grandin
would have liked to make the AcquireWriteAccess methods DLLPRIVATE, but they are needed by the workbench and testing code Change-Id: I22497788eb68dfb84b7e542e5ef53322892a5274 Reviewed-on: https://gerrit.libreoffice.org/51310 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-15move emf code to vclNoel Grandin
part of making ScopedWriteAccess an internal detail of vcl Change-Id: If66de7c248d442a860508bbddf68e390983da240 Reviewed-on: https://gerrit.libreoffice.org/51309 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-03-15move some GDI import code from svx to vclNoel Grandin
part of making ScopedWriteAccess an internal detail of vcl Change-Id: I916f2ca05c9d7c17b62c91e113df6d8454bb4351 Reviewed-on: https://gerrit.libreoffice.org/51283 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-15change recursive ImageURL prop. search to use XGraphicTomaž Vajngerl
In two cases we need to traverse and gather all ImageURL properties and get the URL string and store the graphic content to a storage (like we do in xmloff filter). ImageURL property can now only store external URL and Graphic stores the embedded XGraphic, so this was changed to look into Graphic property first and then ImageURL. We also don't gather URL sting anymore so they need to be loaded to XGraphic when gathering them. Change-Id: I5f3f4be2b403b9589d72b8733df0c97109f2b65d Reviewed-on: https://gerrit.libreoffice.org/51308 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-14Fix typoAndrea Gelmini
Change-Id: I3cdc41b937e6c974ab6f953b7a9a834328905b17 Reviewed-on: https://gerrit.libreoffice.org/51238 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-03-14loplugin:unusedmethodsNoel Grandin
Change-Id: I7c780be3e2740fd9b03c39ebe16935d61caf4f7e Reviewed-on: https://gerrit.libreoffice.org/51257 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-14tdf#115297: 1bit images displaying fixed (again)Vasily Melenchuk
Previous fix 25cd843664919974f0d21ca7a0b02cc43e9eeabb like any other before it have some regressions, so reverted. The root of most problems: fix for tdf#104141 d148340babf6c973f7d463909d7a51e16c953248, where mask drawing was implemented in bitmap drawing code. So instead of guessing for type of bitmap, mask is drawn with DrawBitmapEx resolving all known problems (tdf#114726, tdf#115297, tdf#113918 and tdf#104141). Change-Id: Ie00f7552d667e237b3c0f9505ee09cb51e85c43c Reviewed-on: https://gerrit.libreoffice.org/50828 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-14prefix is unused when all implementations have constructorsStephan Bergmann
Change-Id: I5d2efaa16932c0014cfb7491136b5d37f3e6dded Reviewed-on: https://gerrit.libreoffice.org/51160 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-03-14tdf#115565 Change tab key behavior to navigate out of gotopage controlJim Raykowski
...in Writer Sidebar Navigator deck helper toolbox Change-Id: Ieeabcb30f421aa0ce2a5f841e45fff5f57358215 Reviewed-on: https://gerrit.libreoffice.org/50295 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-03-13tdf#116344: Don’t Kashida justify Syriac textKhaled Hosny
I’ve always suspected this check in VCL is wrong since Writer calculates Kashida positions for Arabic only. If we *really* want to Kashida justify Syriac, then Writer has to be first taught how to calculate Kashida positions for it. Change-Id: I20c03a3a54bce14c9bebb55426bd22537fe50d6a Reviewed-on: https://gerrit.libreoffice.org/51223 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2018-03-13vcl: race in OSX SalYieldMutex::doReleaseMichael Stahl
m_nCount must be accessed with m_aMutex locked. Change-Id: I7e05cac2b549b975804d6061721c1da4d0b9f64e Reviewed-on: https://gerrit.libreoffice.org/50236 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-03-13ofz#6888/forcepoint#27 adjust consistency checkCaolán McNamara
Change-Id: I0d1f04170bcbc08fe30236e2444761d9d71fb1fb Reviewed-on: https://gerrit.libreoffice.org/51221 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-13make transformBitmap code from canvas to vclNoel Grandin
part of making ScopedWriteAccess an internal detail of vcl Change-Id: Ida03bc73fe746cde97f6fcb5cde2f066b63d92e9 Reviewed-on: https://gerrit.libreoffice.org/51216 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-13Use a Unicode ellipsis character when a menu item ends with three dotsTor Lillqvist
Change-Id: I5ee724ef4b24f880e8bbc3ce0147331818b4f479 Reviewed-on: https://gerrit.libreoffice.org/51193 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2018-03-13lokdialog: Tunnel the spell-checking context menu with recommendations.Jan Holesovsky
Change-Id: I1a7952e88a3f89346c97d2516628b4a7a0423de6 Reviewed-on: https://gerrit.libreoffice.org/51062 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk> Reviewed-on: https://gerrit.libreoffice.org/51166 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-03-13related: tdf#116264 give windows message dialogs less border widthCaolán McNamara
Change-Id: Ieced9b02515ffc7479bfc66ca501e20962d5572e Reviewed-on: https://gerrit.libreoffice.org/51172 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-13lokdialog: For floating menus, ignore the screen size in the LOK case.Jan Holesovsky
Change-Id: I85f6fcbc865eba7aac48a4c2e7d8c4bb82311581 Reviewed-on: https://gerrit.libreoffice.org/51063 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk> Reviewed-on: https://gerrit.libreoffice.org/51165 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-03-13vcl: prefix BitmapEx member variables with an 'm'Chris Sherlock
Change-Id: I39c52cd670e6148fca1f65c35a5ff411bfda7137 Reviewed-on: https://gerrit.libreoffice.org/51143 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-13vcl: rename BitmapFilter::filter() to execute(), rename existing classesChris Sherlock
Change-Id: I0c7b840de6bb4c7570bd6a55ccf3b427f98cc524 Reviewed-on: https://gerrit.libreoffice.org/51142 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-12tdf#116322: Don’t hard-code RTL character rangesKhaled Hosny
Calc’s ScOutputData::LayoutStrings() has an optimization that skips edit engine for what it seems to consider simple enough text (single script, no bidi controls, etc) and it ends up calling this code in OutputDevice that hard-codes RTL character ranges and skips bidi algorithm if none is found. Since the list of RTL characters is not fixed and new version of Unicode can added new RTL characters, help the next boor soul that will spend another day debugging this in the future by removing the hard-coded RTL ranges and instead check for some known LTR ranges. Change-Id: I6eb8fd3d1342a5539d607bf54e9c2de31f5a32b4 Reviewed-on: https://gerrit.libreoffice.org/51118 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2018-03-12forcepoint #27 check region bands loaded from stream for consistencyCaolán McNamara
Change-Id: I92376b5fb4208c78fa25a94d4dd394256793161c Reviewed-on: https://gerrit.libreoffice.org/51144 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-12forcepoint #25 ensure null terminationCaolán McNamara
Change-Id: I37f4787fb5772e959c45280d9650adcc15591033 Reviewed-on: https://gerrit.libreoffice.org/51128 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-12tdf#115649: ensure we own SolarMutex in the callbackMike Kaganski
The crash is caused by releasing SolarMutex we don't own; the release happens in Application::Reschedule() inside SalPrintAbortProc. The crashing callstack: ucrtbase.dll!abort() mergedlo.dll!comphelper::GenericSolarMutex::doRelease(bool bUnlockAll) Line 72 mergedlo.dll!SalYieldMutex::doRelease(bool bUnlockAll) Line 177 [Inline Frame] mergedlo.dll!SolarMutexReleaser::{ctor}() Line 1473 mergedlo.dll!WinSalInstance::DoYield(bool bWait, bool bHandleAllCurrentEvents) Line 550 mergedlo.dll!ImplYield(bool i_bWait, bool i_bAllEvents) Line 469 mergedlo.dll!SalPrintAbortProc(HDC__ * hPrnDC, int __formal) Line 1308 gdi32full.dll!vSAPCallback() gdi32full.dll!ExtEscapeImpl() gdi32.dll!ExtEscape() [Frames may be missing, no binary loaded for KMUU727V.DLL] KMUU727V.DLL!0000000011d0dc21() Change-Id: I955eab7894186900d0d99e28f62d87cc645e4a5a Reviewed-on: https://gerrit.libreoffice.org/51052 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-03-12loplugin:redundantfcastStephan Bergmann
Change-Id: I6d93a634d2cde982c764233dc28a9c5270593cc1
2018-03-12loplugin:redundantfcastStephan Bergmann
Change-Id: I71d2321b47ff40576072898680897832a7b3b77e
2018-03-11weld color pickerCaolán McNamara
Change-Id: I487b9a0cc13b2b60a0f1e28667773b5d3b5c66cc Reviewed-on: https://gerrit.libreoffice.org/51001 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-11Move (and rename) graphic stuff from svtools to vclTomaž Vajngerl
This is preparing to change how GraphicManager works where it won't base itself around GraphicObject anymore but Graphic. No functional or cosmetic change was made to the classes, only changes that were needed because of the move and rename. The only thing that wasn't moved is the GraphicRenderer as it is not needed in vcl for now (but makes sense to move it in the future to keep graphic stuff together). grfmgr was renamed to GraphicObject as the GraphicManager will be changed a lot and most likely moved out, so the name grfmgr won't make any sense anymore. All the UNO implementations were renamed with a prefix Uno and used the same name as the class name. This is made to be more specific which are the Uno objects (for example graphic.cxx contained the implementation of XGraphic, which is similar to graph.cxx contains Graphic). Change-Id: I54a2fa6c7e997469aaa7770db05244adb9f64137 Reviewed-on: https://gerrit.libreoffice.org/51068 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-10margin change should trigger relayoutCaolán McNamara
Change-Id: Idfcca3c6c37244ff073b9fc2fdc40955c39d01d1 Reviewed-on: https://gerrit.libreoffice.org/51012 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-10move canvas helper code into vclNoel Grandin
part of making BitmapWriteAccess an internal feature of vcl Change-Id: Iee94f47e120d82a23e57342952d04e9b2792cd1a Reviewed-on: https://gerrit.libreoffice.org/50999 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-09Make VCL_DLLPUBLIC virtual functions non-inlineStephan Bergmann
at least Linux-rpm_deb-x86@71-TDF tinderbox was having a hiccup: > /tinderbox/buildslave/build/workdir/CxxObject/sd/source/ui/func/fuinsert.o: In function `weld::DialogController::run()': > /tinderbox/buildslave/source/libo-master/include/vcl/weld.hxx:551: undefined reference to `weld::MessageDialogController::getDialog()' Change-Id: Ib05808a7a283b5aad7329a82c0de3125db4f8506 Reviewed-on: https://gerrit.libreoffice.org/51018 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-03-09loplugin:nullptr (clang-cl)Stephan Bergmann
Change-Id: I239a6024131a0e659d1723085af3cb7fb64b17cc Reviewed-on: https://gerrit.libreoffice.org/51013 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
generated by cgit (git 2.34.1) at 2024-12-29 17:23:50 +0000