summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2021-05-06loplugin:unusedmethodsNoel Grandin
plugin code needed some updating because it was interacting badly with PCH code in pluginhandler::ignoreLocation Change-Id: I228f94a4e285747bd1d5b8536010f8617118cafa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115212 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-06ofz#33899 basprov also now neededCaolán McNamara
since... commit a52590d76b89dc75be2aa87f4287624c89f1e82f Date: Fri Apr 30 22:01:24 2021 +0900 update native-code.py with services for vba scripts in Calc Change-Id: I56d071786b85491a833d75a573b95c166e57b24c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115214 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-06add get_clipboard to widgetCaolán McNamara
Change-Id: I9a623e558bc18286af773e0aa3120185a30baa52 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115172 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-06cid#1482086 silence bogus Double freeCaolán McNamara
Change-Id: I54bd03f6a46f894b729d3977057f0729640db49a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115175 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-06cid#1401334 silence Uncaught exceptionCaolán McNamara
Change-Id: I7d0d9324afdfd5e06e2def62919dbefb78abdb3a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115173 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-06make it possible to write canvas unittestsLuboš Luňák
One of the problems is that canvas apparently works only with windows, but tests obviously need an offscreen surface. This patch moves Window::GetCanvas() to OutputDevice, and makes vclcanvas capable of working with OutputDevice classes that are not windows. Other canvas implementations still don't work, but presumably at least cairocanvas could be fixed too. This commit adds a "simple" test that just draws a line and tries to verify it's been drawn properly. Adding another test should be a matter of basing it on this existing one, and then copy&pasting the complicated UNO way of drawing using canvas from somewhere, such as canvas/workben/canvasdemo.cxx. Change-Id: I42db12b09433763cd31c3dd497c10157424b8598 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115117 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-05-06tdf#141424 Include the margin sizes while calculating width of window.Gülşah Köse
Follow up development f61fcf6fe6b9f54dd57ca5d868b1b0436e9cec61 First one fixed only horizontal panes. Apply the same fix to vertical panes (eg: sidebar->gallery) Change-Id: I7e5e1bb7bf559741dd265a8bbc6f845a2f31efde Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115151 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2021-05-05add io libraries to fuzzer-commonCaolán McNamara
since... commit a52590d76b89dc75be2aa87f4287624c89f1e82f Date: Fri Apr 30 22:01:24 2021 +0900 update native-code.py with services for vba scripts in Calc Change-Id: I38c5e25cfdd24b0e9f2046795c5b2572c1eb880a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115155 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-05convert sal_uLong and tools::Long in vcl/settingsNoel Grandin
Change-Id: I69711b791884218f4a14c85fe69072b9ea06dc79 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115109 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-05WASM: add Emscripten demo applicationJan-Marek Glogowski
Change-Id: I31297142761255b1f357fc9677a644b7a93c921a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111128 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2021-05-05loplugin:constmethodNoel Grandin
Change-Id: I7913fd8144d521b8293ac43036d0fad82e457cd1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115145 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-05tdf#141424 Include the margin sizes while calculating width of window.Gülşah Köse
Change-Id: I0863dc62f1ade6cc07835e83eb242f3d5a9906bd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115068 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2021-05-05vcl: adjust cairo text renderer for vertical writingMark Hung
, remove extra matrix translation and use the positions from Harfbuzz more directly. Change-Id: I2eb337b7f3bd70f4726f56d85a38f4a1f0931155 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115018 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Mark Hung <marklh9@gmail.com>
2021-05-05vcl: adjust LayoutText() for vertical writing.Mark Hung
Revert 58af692e2814 "tdf#111967 translate offsets so it is relative to vorigin", which use hb_font_add_glyph_origin_for_direction to change the origin for vertical writing. This caused major problem in Y-axis. For X-axis, align the baseline of the vertical run to the center of the rotated horizontal run, by adding "(ascender + descener) / 2. Besides the alignment mentioned above, underlying text rendering code should be able to render properly based on the positions that Harfbuzz API creates. Change-Id: Ic1ef1f734686d0e61c4b2a6bf7feb7c870bba84f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115014 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2021-05-05factor in treeview borders for get_height_rowsCaolán McNamara
as seen in tdf#142049 for format chart type where the scrollbar appears in gen when that's something it tries to avoid Change-Id: I494114078603797b0450363816823e5898a3ef01 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115141 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-05factor in borders regardless of WB_BORDERCaolán McNamara
Change-Id: If6321b3c903212b6b1b68c028a2c5aa4f9a59a3a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115140 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-05the border size SvTreeListBox uses is not StyleSettings::GetBorderSizeCaolán McNamara
so use the actual border sizes in use Change-Id: If6d1032936565c199332522a31a1bc984f126547 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115139 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-05vcl pdfium render: handle widget annotations for form fieldsMiklos Vajna
Note that we render the bitmaps without FPDF_ANNOT, so comments are not rendered into the bitmaps, rather we create them on top of the bitmaps in Draw, explicitly. FPDF_FFLDraw() draws content which is already an annotation, but not yet interactive content; so this just fixes "missing text", as far as the user is concerned. Verified that e.g. vcl/qa/cppunit/data/PangramAcrobatAnnotations.pdf indeed still doesn't render comments into bitmaps after this. Change-Id: I2b74d585729305cc1d3a9fefa258d4d76d1bd038 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115122 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-05-05sal_uLong->Color in BitmapDuoToneFilterNoel Grandin
Change-Id: I3f57d9b21d439fa8449579d9cdaac9377ac80934 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115110 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-05sal_uLong->sal_Int32 in BitmapNoel Grandin
Change-Id: I267fbdb8946d307440cb675f6ff985bf58db5e4c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115108 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-04restore focus to the GtkEntry of GtkComboBoxText on menu popdownCaolán McNamara
the font size/name dropdowns in the document toolbar should continue to restore focus to the document directly while typical ones should vcl-alike select the GtkEntry contents Change-Id: Ic6c6cd48362dac6e4476c42a4070a83cd50faa2b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115104 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-04sal_uLong->sal_Int64 in BitmapNoel Grandin
Change-Id: Ia9796cca66f405c38545a5ba3aab7c76a465a0d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115106 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-04Related: tdf#141857 send style-updated after app settings are updatedCaolán McNamara
so the libreoffice settings are updated before the widget updates, otherwise the app settings are the old settings when the widget updates Change-Id: Id32dd55a1e5102cc707d6ee74eddfae2247e105a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115070 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-04sal_uLong->sal_Int32 in PointerStateNoel Grandin
Change-Id: I5b3ea673d1b89d6584ad4e4cc5ada927791eeb29 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115048 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-04loplugin:redundantstaticStephan Bergmann
Change-Id: I933a51e9107d8f7dff5eeb03f9aba14dff534574 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115046 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-05-04loplugin:finalprotectedStephan Bergmann
Change-Id: I57e70a5a6432f721952d412e14270ae22b4d7a4c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115045 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-05-03loplugin:stringadd improvement for appending numbersNoel Grandin
I was wrong, the Concat framework already optimised appending numbers by stack-allocating small buffers, so include them in the plugin Change-Id: I922edbdde273c89abfe21d51c5d25dc01c97db25 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115037 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-03vcl: remove MetricVectorChris Sherlock
Change-Id: Ib700887ca79f423c65dfb75eea36bbfd808fa172 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114976 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-05-03loplugin:unnecessaryparen small improvementNoel Grandin
when calling a function, and passing only one arg, but the function has defaulted args, we were ignoring this case. Change-Id: I86517f18e30531127664088ddc09ef96dbd8bdf5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115033 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-03sal_uLong->sal_uInt32 in SvTreeListNoel Grandin
Change-Id: I0f543c6b2ce246cf603a3ccebfa6b815e7c2545c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115007 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-03sal_uLong->sal_Int32 in IMapCircleObjectNoel Grandin
Change-Id: I47f4901d38cfb14011a0b7db4cc38203e3e14e30 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115009 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-03tdf#76258 Filter by colorsSamuel Mehrbrodt
UI/Logic implementation Change-Id: If7b48219caa466d8a3341bdc4e104d696e8988c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114385 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2021-05-03sal_uLong->sal_Int32 in ButtonNoel Grandin
Change-Id: Ib2a9f8eecbeee4de1ac8f0fc1a5bfa93f6746d48 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115008 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-02sal_uLong->sal_Int32 in TextHintNoel Grandin
Change-Id: If8125e1343b74c2216fb8e9f9e1e16669062de14 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115004 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-02throw() -> noexcept, part 2/3: Automatic loplugin:noexcept rewriteStephan Bergmann
Change-Id: I076f16d0536b534abf0ced4d76051eadb4c0e033 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114949 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-05-02GraphicAttributes: put const. and op. '=' into the header fileTomaž Vajngerl
Change-Id: I1bc38f89457c3593673b445e7571a4fd82d5960b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114982 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-05-02tdf#79049 speed up OOXML workbook load (4)Noel Grandin
Optimise LocaleDataWrapper for reads by initialising the data we in the constructor, so we don't need any kind of locking Reduces load time from 34s to 28s. Change-Id: I4bd3bddb30b70ba015fe5b1372534f9507762b74 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114960 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-01Related: cid#1478001 CreateVirtualDevice never passed a null pGraphics argCaolán McNamara
Change-Id: I0701b15a28ab3583586c0c8018c511e100b41a93 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114948 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-01cid#1478001 Dereference before null checkCaolán McNamara
Change-Id: I86fe97280c62bf871b23ea2e9274439bab7af929 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114947 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-30don't grab focus if we already have focusCaolán McNamara
for cases like the combobox of tdf#138281 so we don't end up selecting the content if we already had focus Change-Id: I2294b2d17d56e5282d7d84859eb9002ebb3b9ada Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114938 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-30simplify WallpaperNoel Grandin
All of it's member fields are already COW types, so it doesn't need the complication Change-Id: I44e402e8e80fe96462fc4e1aa06b9ec6815e3cd0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114933 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-30vcl: iOS/macOS - move graphic render func. into AquaGraphicsBackendTomaž Vajngerl
This change moves graphic rendering function under AquaSalGraphics into a new AquaGraphicsBackend, which inherits from SalGraphicsImpl. This is part of the refactoring to make it mandatory that a SalGraphics always has a SalGraphicsImpl associated, which will make it possible to simplify the SalGraphics interface and enable the posibility to implement alernative graphic backends (Skia). Common variables and attributes are moved to AquaSharedAttributes and are shared between SalGraphics and SalGraphicsImpl. Change-Id: Ie48da87002ec8e4011ba92fdc9170f3a86761517 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114701 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-04-30loplugin:stringadd (clang-cl)Stephan Bergmann
Change-Id: I132643eb73129e1319af36b7c8aac36a516714b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114896 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-04-29tdf#141963 put focus in vcl parent during Function key processingCaolán McNamara
Change-Id: Ib63567c9ce208cb7dd522a1bce9d99fa44a72554 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114883 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-29loplugin:stringadd simplify some *StringBuffer operationsNoel Grandin
pulled from a larger patch which I created with a more permissive variant of this plugin Change-Id: I7abf1f3f09e84703b6e0e52fe9587dff691b2187 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114875 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-29vcl: print dialog: remove broken codeXisco Fauli
This was introduced in 149807eb6100090e178505ba4a264bb38eba1e0c < Resolves tdf#127782 - Print dialog height > trying to fix the problem of the window size not being remembered after reopening the dialog, however, the problem is still reproducible in master with GEN, thus, remove this code Change-Id: I65f327fa692cd3e2b5597d04e9e15abc952fe6d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114874 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-04-29do not apply line dashing in drawinglayer (tdf#136957)Luboš Luňák
basegfx::utils::applyLineDashing() is not as good as the actual VCL backend dashing, and there are some rounding errors because of all the canvas transformation matrices or whatever, which leads to the drawing problem. So use LineInfo to carry the dashing information. As a part of this change, also make LineInfo use doubles instead of ints. The use of transformation matrices means that the values may be fractional and less than one. Change-Id: Ia5ac7d266cab344b7137052c81fbd96c1ce28003 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114710 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-04-29allow push/pop multiple levels of freeze/thawCaolán McNamara
so can freely protect a block with freeze/thaw regardless of current freeze/thaw state Change-Id: I1bd60bfc02fe784e36ae371a737f4fdfb15a0888 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114615 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-29remove support for BITMASK in vcl backendsNoel Grandin
Rather use a proper alpha channel if we need transparency. This is another small step towards merged alpha in our vcl layer. I suspect the intent in a lot of this code was to save memory. Which have been a thing way back then, but these days our backends mostly end up doing a copy-and-convert to a real alpha channel anyway, so the existing code is actually now a pessimisation. Change-Id: I4a2bcbb2f76b841f05bc00580f364492829c69de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114808 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-28Skia understands that linewidth == 0 means hairlineLuboš Luňák
Change-Id: Ic5aea464d6414fc2218179143d16121ef293bdfe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114816 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
generated by cgit (git 2.34.1) at 2025-02-08 03:52:56 +0000