summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2018-03-05Make LibreOffice buildable on Haiku.Kacper Kasper
* Obviously VCL wiring is missing, but most components do build. Change-Id: Ie853ada1423a8f4c2b647be59cd47a7730c42978 Reviewed-on: https://gerrit.libreoffice.org/50293 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-03-05vcl, make ios/dummies compilejan Iversen
Point .... were not defined Change-Id: I725b3058d44d527ca2d3201060e4f467fd69c78d
2018-03-05vcl: move vcl/source/gdi/bitmap.cxx to vcl/source/bitmap/bitmap.cxxChris Sherlock
Change-Id: Ib74ac5016b6f99adef41b6ee562701b5158cffd3 Reviewed-on: https://gerrit.libreoffice.org/50532 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-05weld InputDialogCaolán McNamara
Change-Id: I821dcea904cad7cc6f9394bccf6560624d23729b Reviewed-on: https://gerrit.libreoffice.org/50756 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-03weld license dialogCaolán McNamara
Change-Id: Icfd921923cf6396db4cc5ecabd7b65d0b4c9aef7 Reviewed-on: https://gerrit.libreoffice.org/50648 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-02weld convert text-to-table/table-to-text dialogCaolán McNamara
Change-Id: I81137c0fe0b0e243ebc5b836ac09448d746b2214 Reviewed-on: https://gerrit.libreoffice.org/50644 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-02forcepoint #16: fix heap-use-after-freeMiklos Vajna
PDFDocument::Tokenize() in the aKeyword == "obj" case allocates a PDFObjectElement, stores it as an owning pointer inside rElements, and also stores two non-owning references to it in m_aOffsetObjects and m_aIDObjects. So make sure those 2 other containers are also cleared then elements go away. LO_TRACE="valgrind" bin/run pdfverify <sample> doesn't report errors anymore after the fix. Change-Id: Ie103de3e24a1080257a79e53b994e8536a9597bc Reviewed-on: https://gerrit.libreoffice.org/50627 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-02weld split cells dialogCaolán McNamara
Change-Id: I726c6d84807ab3efba509058eed554fe4c0ffced Reviewed-on: https://gerrit.libreoffice.org/50636 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-02forcepoint #14 check to see if we incremented at allCaolán McNamara
Change-Id: Ia4670adbddcc8501cf522be296b3061a3529f880 Reviewed-on: https://gerrit.libreoffice.org/50605 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-02delete colordata.hxxNoel Grandin
move what we still need into color.hxx Change-Id: Ied7e31eb16468aa334c666b1499a6262f16a6350 Reviewed-on: https://gerrit.libreoffice.org/50561 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-02drop old tools/gen methods in vclNoel Grandin
Change-Id: I863ce5ae46ae90f06780261fa17b087a7153c807 Reviewed-on: https://gerrit.libreoffice.org/50445 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-01hook up extended tips to find them in our helpCaolán McNamara
Change-Id: I1360403b3b21eec3fd37bb5ba74e0fab1945af94 Reviewed-on: https://gerrit.libreoffice.org/50590 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-01debuging versions crash a lotCaolán McNamara
regression from... commit c3074cb5784329eaf558c2f58d96a64085b42d48 Date: Sun Jan 7 00:39:33 2018 +1100 vcl: remove dead code Change-Id: I1a81ae3fe8063377deaf41a9159d763ca9b4f9c4
2018-03-01tdf#115353 Status bar: no cache in settextTamas Bunth
Change-Id: I6c1312bbba553be738e23cee0c76d589c809dff8 Reviewed-on: https://gerrit.libreoffice.org/50584 Reviewed-by: Tamás Bunth <btomi96@gmail.com> Tested-by: Tamás Bunth <btomi96@gmail.com>
2018-03-01tdf#60533 invoke ubidi_setPara with correct paraLevel parameter.Mark Hung
Replace UBIDI_DEFAULT_LTR and UBIDI_DEFAULT_RTL with 0 and 1 respectively. According to the ICU document for ubidi_setPara, paraLevel specifies the default level for the text, and the function shall determine the level from the text when UBIDI_DEFAULT_LTR or UBIDI_DEFAULT_RTL is used as paraLevel. However we already know that the paragraph is right-to-left when SalLayoutFlags::BiDiRtl is set. Besides, having default writing direction deteremined based on text cause a problem when the text contains only latin or weak directionality characters like brackets in a right-to-left paragraph. Change-Id: I4d627d2c2112ab1bba67408433f2e09f87b1ea46 Reviewed-on: https://gerrit.libreoffice.org/50493 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-03-01tdf#116001 Incorrect Colors in Chart Wall AreaNoel Grandin
regression from commit b10c7022f1be6e4825269bd5872575b5b53744ef "use RawBitmap in BPixelRasterToBitmapEx" we need to implement alpha support in vcl::bitmap::CreateFromData Change-Id: I68bebbe1dd15e3bb04de312309c1631d6bb7fe2d Reviewed-on: https://gerrit.libreoffice.org/50556 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-01weld ScStringInputDlg to native dialogCaolán McNamara
ScStringInputDlg and SwStringInputDlg do the same thing, but one uses the old name as the label and leaves the new name blank in the entry. The other puts the old name into the entry and autoselects it and uses a normal label. Both are used from the rename button of the shared autoformat dialog. Change-Id: I2ebf09a79f92c3f9020304e23e8907b67c06cd35 Reviewed-on: https://gerrit.libreoffice.org/50525 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-01vcl: remove dead codeChris Sherlock
I have converted the debug code that causes a force redraw/widget_queue_draw/dumpframes to be activated when using the environment variable VCL_GTK3_PAINTDEBUG=1 Change-Id: Ia2d41dbd42b5b45f97b195efa15c91674f5956bf Reviewed-on: https://gerrit.libreoffice.org/47493 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-03-01give ok, cancel, help buttons those namesCaolán McNamara
So they can be used to sort the buttons into native ordering (eventually). Give them the gtk response ids, so they can be used by native gtk3 dialog loading (eventually) Change-Id: Ide49649b8ea6a2e0c003d23c3a88f0cb06822b05 Reviewed-on: https://gerrit.libreoffice.org/50535 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-01loplugin:redundantfcastNoel Grandin
Change-Id: Ia696f0eda9f87cb449c149b0650a2cb7ca9cafb1
2018-02-28tdf#115297: alternative fix for displaying 1bit imagesVasily Melenchuk
Previous fixes for 1bit monochrome / paletted images produced some regressions, so here is attempt to fix problem at the root. Partially reverted 66dbd4da3afcadb1393daf9be9cecff71b86509a and fixed in a different way without tdf#115297, tdf#114726 and related. Change-Id: I6849ed5ac41770ba905c930065c80e58509dba2e Reviewed-on: https://gerrit.libreoffice.org/50454 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-02-28lok: update main threadHenry Castro
In the pre-initialization phase of the tiled rendering case the SvpSalInstance is created in a different process and when a new process is created (fork), the main thread identifier does not match so it is required to update it. Change-Id: I189e53f0b46c60f34a8016222079c9b1e2b3fef8 Reviewed-on: https://gerrit.libreoffice.org/50477 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
2018-02-28use ok, cancel under kde vs cancel, ok under gnomeCaolán McNamara
for the native welded dialogs Change-Id: I34663616826c1eb084262ea1c830f8580785d50c Reviewed-on: https://gerrit.libreoffice.org/50458 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-28vcl: test greyscale bitmap conversion functionsChris Sherlock
Change-Id: I9a71bcbc0bac0bdd4a401b129a7abd55eb43c910 Reviewed-on: https://gerrit.libreoffice.org/50399 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-02-28iOS, removed read to pipesjan Iversen
needed to run iOS Change-Id: I1176ce24023cde21846c71ffadb1bf01cb2c8399
2018-02-28Let Application::Abort always dump core in debug buildsStephan Bergmann
Change-Id: I788601193f77641d613005a93e73cf184cb0daf0 Reviewed-on: https://gerrit.libreoffice.org/50436 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-02-28convert COL_ constants to be of type ColorNoel Grandin
Change-Id: I0e25c8950ac26b851ff42f71e1471fcbe4770d48 Reviewed-on: https://gerrit.libreoffice.org/50373 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-27cast MessBox into exileCaolán McNamara
Change-Id: I2fccc06b2228c1e7fd791d049d951d3a09f0f814 Reviewed-on: https://gerrit.libreoffice.org/50432 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-27vcl: improve ErrCode std::ostream pretty-printerMiklos Vajna
Let's say you specify a non-existing export filter during conversion. Old output: Error: Please verify input parameters... (SfxBaseModel::impl_store <file:///test.html> failed: 0x81a(Error Area:Io Class:Parameter Code:2074)) New output: Error: Please verify input parameters... (SfxBaseModel::impl_store <file:///test.html> failed: 0x81a(Error Area:Io Class:Parameter Code:26)) The later (at least) allows going to include/vcl/errcode.hxx, searching for Io.*Parameter.*26, and leads to ERRCODE_IO_INVALIDPARAMETER. Change-Id: Iecfcfa4e805147131fde73cc0b89fa38f6ea61d4 Reviewed-on: https://gerrit.libreoffice.org/50421 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-02-27lok: mouse pointer events on document windows onlyPranav Kant
Change-Id: Ie21db52b2dd0d4f55289896caba5174380316e65
2018-02-27lok sc: Post mouse events to main threadPranav Kant
Change-Id: I1311938d7c01d0e3bfd239743e6cb2148da56cdf Reviewed-on: https://gerrit.libreoffice.org/50253 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2018-02-27replace Color(COL_*) with COL_*Noel Grandin
using git grep -lwP "Color\s*\(\s*(COL_\w+)\s*\)" | xargs perl -pi -e "s/Color\s*\(\s*(COL_\w+)\s*\)//g" and then some manual fixup where the resulting expression no longer compiled Change-Id: I0e268d78611c3be40bba9f60ecfdc087a36c0df4 Reviewed-on: https://gerrit.libreoffice.org/50372 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-27convert various MessBox to weld::MessageDialogCaolán McNamara
Change-Id: I4d2d0393c753114aeb9bb7e646dfdc810f6caa38 Reviewed-on: https://gerrit.libreoffice.org/50398 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-27convert remaining WarningBox to weld::MessageDialogCaolán McNamara
Change-Id: I7e3c156a6ad47ac232636ae274280c1cb7556d4a
2018-02-27vcl: test BitmapPalette greysChris Sherlock
Change-Id: Ief511d75e5a9b1e9230036c453edcb8b0a039221 Reviewed-on: https://gerrit.libreoffice.org/50328 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-02-26split out GetStandardWarningBoxImageCaolán McNamara
Change-Id: I2c8315c7223adac2d7e0e2aa403db0f865bdc48e Reviewed-on: https://gerrit.libreoffice.org/50377 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-26convert corner case warningboxes with checkboxesCaolán McNamara
Change-Id: Ic8b58b792236a733b6687148eac5c06bbf734acf Reviewed-on: https://gerrit.libreoffice.org/50325 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-26vcl: Bitmap::MakeMono() -> Bitmap::MakeMonochrome()Chris Sherlock
Change-Id: I6b5259d56e8fe5855f8a1125bb87a3dea8e5f425 Reviewed-on: https://gerrit.libreoffice.org/50301 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-26vcl, solve iOS compile failure.jan Iversen
"voided" new formal parameter Change-Id: I7d8849765eb6a2642f48159bae34c3b8bec3a8cd
2018-02-26convert remaining ErrorBox to weld::MessageDialogCaolán McNamara
and convert remaining QueryBox to weld::MessageDialog Change-Id: Ifb4c316dee8eabf57c4940c44e29c65a2781aa6c
2018-02-26use less RGB_COLORDATANoel Grandin
part of removing ColorData Change-Id: If31b5b88545529863377e9a178f45f4516bf6cbb Reviewed-on: https://gerrit.libreoffice.org/50345 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-26vcl: fix hangs in SvpSalInstanceMichael Stahl
Since commit cb8bfa9a32799bcde4e960fa56e388d5f7b2a928 the main thread will read from the timer pipe until it is empty. But evidently this introduces the problem that the poll() in another thread will not return, as the file descriptor will no longer be readable; see https://paste.debian.net/1011306/ for a reproducer of that rather under-documented poll behaviour. So other threads can get stuck forever in poll, and then the main thread can block in poll too with no other thread to wake it up. This is the problem that plagues UITest_writerperfect_epubexport. The timer pipe is difficult to fix, since the main thread can block on either the poll or the subsequent AcquireYieldMutex(). So replace the timer pipe with a condition etc. that is mostly copied from the OSX AquaSalInstance/SalYieldMutex implementation. The main thread now does something different than the other threads, and blocks on a condition_variable with a timeout, while other threads still block on acquiring the mutex. Non-main threads can poke the main thread to do a DoYield() on their behalf, and then get the result back with a blocking read from a pipe, all while holding the YieldMutex. This requires some fudging of the YieldMutex so that the main thread can borrow the ownership temporarily. Unfortunately SvpSalInstance, in addition to being directly instantiable for --headless, has a whole bunch of subclasses: * HeadlessSalInstance * AndroidSalInstance * IosSalInstance * GtkInstance (in the gtk3 case) * KDE5SalInstance Of these GtkInstance overrides everything related to the DoYield/SalYieldMutex implementation, but the others will be affected by the change. This commit will probably break IOS due to me not understanding the point of the undocumented random #ifdef IOS in svpinst.cxx. Change-Id: I1bbb143952dda89579e97ac32cd147e5b987573c Reviewed-on: https://gerrit.libreoffice.org/50237 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-02-26sc lok: Make the Validation "Invalid value." message box working.Jan Holesovsky
Change-Id: Ic0131fa6fc397ae440efed834266b8396aa9e619 Reviewed-on: https://gerrit.libreoffice.org/50160 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-02-26loplugin:oncevar extend to tools/gen.hxx typesNoel Grandin
Change-Id: I5c75875da44334569c02e2ff039b33c38397a0a2 Reviewed-on: https://gerrit.libreoffice.org/50283 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-26ColorData->Color in variousNoel Grandin
Change-Id: I22018b6a535224316d93bfd621771248b873a218 Reviewed-on: https://gerrit.libreoffice.org/50167 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-26vcl: consolidate ColorOf() and GrayOf() functionsChris Sherlock
Change-Id: Ic80dda409ceaff89be5f249cf906abbb40679f3c Reviewed-on: https://gerrit.libreoffice.org/50272 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-26vcl: remove init and destroy functions from Bitmap{Info|Read}AccessChris Sherlock
Nothing else ever calls them except the constructor and destructors of the BitmapInfoAccess class itself - thus there is no real need for them to exist. Change-Id: Ib9a78dc5ed67b11c837f2c347ad74d0164e91770 Reviewed-on: https://gerrit.libreoffice.org/50324 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-26bool cast operator for Graphic objectTomaž Vajngerl
Change-Id: Iec236538271b33eb9e6dcfd98903657c1198476e Reviewed-on: https://gerrit.libreoffice.org/50332 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2018-02-25vcl: test Bitmap::MakeMonoChris Sherlock
Change-Id: I0387981296313eba4e0fb796750c0a5de8e3b7a2 Reviewed-on: https://gerrit.libreoffice.org/50306 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-02-25vcl: add BitmapColor testsChris Sherlock
Change-Id: Ic7f781f7f174d40b81ba85e8386acec325fefc4e Reviewed-on: https://gerrit.libreoffice.org/50271 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
generated by cgit (git 2.34.1) at 2025-02-06 02:26:13 +0000