summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2019-09-24copy to clipboard without intermediate vcl::WindowCaolán McNamara
Change-Id: I36d26e583e08ef66564e232b54fa00a468a280c6 Reviewed-on: https://gerrit.libreoffice.org/79453 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-24Use lazy-loading stock Image to simplify framework image lists.Michael Meeks
Project stock names through XGraphic via origin URL. (cherry picked from commit 77b88eebaadebb626108172e4f2de36c60960051) Change-Id: Ib445694f7c142a163ef7e7bc0beea39b88b99e14 Reviewed-on: https://gerrit.libreoffice.org/79420 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-09-24support O(U)String::number() for fast string concatenationLuboš Luňák
When I did the fast string concatenation, I didn't add any support for number(), which simply returned a O(U)String, and so it did the extra allocation/deallocation, although that could be avoided. In order to support this, number() now returns a special temporary return type, similarly to O(U)StringConcat, which allows delaying the concatenation the same way. Also similarly, the change of the return type in some cases requires explicit cast to the actual string type. Usage of OString::getStr() is so extensive in the codebase that I actually added it to the helper class, after that it's only relatively few cases. Change-Id: Iba6e158010e1e458089698c426803052b6f46031 Reviewed-on: https://gerrit.libreoffice.org/78873 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-09-24gtk3: Depend on the window stylecontextCorentin Noël
Make all GtkStyleContext children of the one from the current toplevel and ensures that the scale factor is the same as the parent. Also make sure to load images using the right scaling factor. Change-Id: I491d79941690fc69171e9aac950493dcca7c78f2 Reviewed-on: https://gerrit.libreoffice.org/79311 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-23loplugin:fragiledestructor (macOS)Stephan Bergmann
Change-Id: I85542ed9e631ad8589d3bc3469d171ab1d5cb4f9 Reviewed-on: https://gerrit.libreoffice.org/79396 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-09-23tdf#39593 use getUnoTunnelImplementationArkadiy Illarionov
Change-Id: I78eb67913a568c610e38e5002f914773c4906dfd Reviewed-on: https://gerrit.libreoffice.org/79350 Tested-by: Jenkins Reviewed-by: Arkadiy Illarionov <qarkai@gmail.com>
2019-09-23loplugin:fragiledestructor (macOS)Stephan Bergmann
Change-Id: I8ac1f67999ccbb6c411359ac6fd4c473dc339d44 Reviewed-on: https://gerrit.libreoffice.org/79398 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-09-23do not require $(SRCDIR) in every gb_Library_set_precompiled_headerLuboš Luňák
Change-Id: I7b3a22584bb2e4d501f509ffcd80929feed23a4c Reviewed-on: https://gerrit.libreoffice.org/79360 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-09-22tdf#127325: Revert "Use HarfBuzz to get glyph bounding rectangle"Khaled Hosny
This reverts commit 502d73cda8fa1f482634bb6435fd1440757fdad9. Change-Id: Ib1a318e6d9a722f9ca056ba1df3a6f2ab19855e5 Reviewed-on: https://gerrit.libreoffice.org/79323 Tested-by: Jenkins Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2019-09-21wizdlg only needed in vcl nowCaolán McNamara
Change-Id: I87d14fff339d18088795a876e2bf6c818b1674e3 Reviewed-on: https://gerrit.libreoffice.org/78973 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-20Replace remaining occurrences of LIBO_HEADLESS with HAVE_FEATURE_UIAndras Timar
Change-Id: Ie2b04ee443dece851d3d96afbc932aa64369c75c Reviewed-on: https://gerrit.libreoffice.org/79084 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-09-20make WizardShell use RoadmapWizardMachineCaolán McNamara
Change-Id: Id7e1e163f17cd4866c37bbd6cad73b8c721f4dae Reviewed-on: https://gerrit.libreoffice.org/78969 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-20expand to fill VclBinCaolán McNamara
Change-Id: If40894e9b92f21150936bbd8a9e25982d3a908cb Reviewed-on: https://gerrit.libreoffice.org/79305 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-20get the toplevel GtkWindow widgetCaolán McNamara
Change-Id: Ibcc20027062568b239d893bcf51887749abe4646 Reviewed-on: https://gerrit.libreoffice.org/79304 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-20ensure embedded widget is realizedCaolán McNamara
Change-Id: Id43ca34d31d8e45482786a0739d981d7c85de686 Reviewed-on: https://gerrit.libreoffice.org/79303 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-20weld OfaTreeOptionsDialogCaolán McNamara
including ability to host a vcl::Window based XWindow hierarchy inside a native widget, e.g. the dictionary extensions have option pages Change-Id: I17d933bac12679e10164214a9045b677291a6557 Reviewed-on: https://gerrit.libreoffice.org/79070 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-20weld Application Colors pageCaolán McNamara
Change-Id: Ib074afdb9cf57decb435bb6ec3867af5989019ef Reviewed-on: https://gerrit.libreoffice.org/79225 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-20Blacklist include for IWYUKelemen Gábor
After commit a3b03ba1316b1ec0a9b0a3b45b96dc0a49aa9f1f Change-Id: I76f24a1617e9d359fd40ef4af17982c484bb3808 Reviewed-on: https://gerrit.libreoffice.org/79042 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-09-20Resolves: tdf#127645 ignore floating windows like we do tooltipsCaolán McNamara
Change-Id: I727e10a1e884841554437e376bde2ff483d278a4 Reviewed-on: https://gerrit.libreoffice.org/79282 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-20Resolves: tdf#127646 remove undispatched events in dtorCaolán McNamara
Change-Id: I8d18b0b667a905131fd0edee1f73ebab144e6307 Reviewed-on: https://gerrit.libreoffice.org/79244 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-19mpWindow might be a GtkEventBox instead of a GtkWindowCaolán McNamara
Change-Id: I6f547d6d21a60661c78bc919536dc4cf319089e5 Reviewed-on: https://gerrit.libreoffice.org/79120 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-19when mpWindow is an eventbox we want the toplevel it is inCaolán McNamara
usually it is already a toplevel, so this only arises in the unusual WB_SYSTEMCHILDWINDOW case Change-Id: Ie0c7ffad87c75fb4e1443b9ab22e1f226782ac3a Reviewed-on: https://gerrit.libreoffice.org/79117 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-19improve and enable loplugin:fragiledestructorNoel Grandin
Where the problem was benign and the class was not extended, I marked the class as final. Where the problem was benign and the class was extended, I marked the relevant callee methods as final. Other cases were excluded in the plugin. Change-Id: Idb762fb2206af4e8b534aa35ff77f8368c7909bc Reviewed-on: https://gerrit.libreoffice.org/79089 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-18remove unused crc functionality from ZCodecNoel Grandin
Change-Id: I3e57e815b538ad5749b4bab3d4ef8e295cbe116b Reviewed-on: https://gerrit.libreoffice.org/79098 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-18not actually using the ZCodec CRC hereNoel Grandin
so don't bother to compute it Change-Id: I62f3b4dda2ac12e2a7bff9fdf0f40b3074e33382 Reviewed-on: https://gerrit.libreoffice.org/79097 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-18fix column sensitivity mapCaolán McNamara
Change-Id: I14a972bef0caf8a9eef12078aadbad4f2f363a64 Reviewed-on: https://gerrit.libreoffice.org/79086 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-18-Werror=volatile in OpenGLZoneStephan Bergmann
Recent GCC 10 trunk in C++20 mode reports issues like > vcl/inc/opengl/zone.hxx:37:21: error: ‘++’ expression of ‘volatile’-qualified type is deprecated [-Werror=volatile] > 37 | OpenGLZone() { gnEnterCount++; } > | ^~~~~~~~~~~~ so look for a type that is more appropriate here (see the comment added to vcl/inc/opengl/zone.hxx for details). (Though calls like OpenGLZone::isInZone(), comparing gnEnterCount and gnLeaveCount, in OpenGLWatchdogThread::execute are still not done atomically, of course.) Change-Id: Ie5563addc65f629336f89cbccb73f7b9ac5e9870 Reviewed-on: https://gerrit.libreoffice.org/79072 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-09-17Consolidate places that manipulate OpenGLZone::gnEnter/LeaveCount directlyStephan Bergmann
(keeping the inline'd-ness of what the OpenGLZone ctor/dtor do, in case that might actually be relevant for performance) Change-Id: I411b83d1b99ed46b35857c7cca10f95dbc1c8e27 Reviewed-on: https://gerrit.libreoffice.org/79062 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-09-17No need for explicit OpenGLZone::enter/leave calls from vcldemoStephan Bergmann
(though I have no idea how to actually test the affected code) Change-Id: Ib74d966d021e337bfab94c223812cb51c02c705f Reviewed-on: https://gerrit.libreoffice.org/79059 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-09-17move GetStandardText to stdtext.hxxCaolán McNamara
Change-Id: Iaf9b5107cf88390f62d5ca94bf985c77bcb8b7ad Reviewed-on: https://gerrit.libreoffice.org/79048 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-17avoid some copyingNoel Grandin
Change-Id: I2e8da57f0fe048c3cf7288bf688f9411e62a1ffc Reviewed-on: https://gerrit.libreoffice.org/79035 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-17Better fixStephan Bergmann
...for 32efe70bbfc6c64df7cf73b6a6c0976ae1e038c8 "Fix linux x86 build" Change-Id: Ic935300777fc43dfb315e1117ca7f96916cc43c6 Reviewed-on: https://gerrit.libreoffice.org/79050 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-09-16Fix linux x86 buildThorsten Behrens
Change-Id: I308752f8e4fd6ac58a417a41545e70171d5370a3 Reviewed-on: https://gerrit.libreoffice.org/79019 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-09-16missing includeStephan Bergmann
(Windows --disable-pch missed declaration of HasAtHook again after 55402d82c5a81322ff7bca3c277a8813bd967a09 "tdf#42949 Fix IWYU warnings in vcl/source/[o-w]*/" had reverted be394e1cec8eefd21f5963857b90c2268b511fc5 "missing include") Change-Id: I4f8ba1721d68852b2921daef1a3b538154be190a Reviewed-on: https://gerrit.libreoffice.org/78995 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-09-16move WriteGradient and ReadGradient to the TypeSerializer classTomaž Vajngerl
Change-Id: I40f72470c2a5a4a9ffff45ccc3295e7a8f1f3584 Reviewed-on: https://gerrit.libreoffice.org/78876 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-09-16vcl: update the svm test for gradient with additional exampleTomaž Vajngerl
Change-Id: If4202cb7b13bc1af81303cc682af5f30d414c5b5 Reviewed-on: https://gerrit.libreoffice.org/78875 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-09-16tdf#74702: remove GetOutDevType() from SmTmpDeviceChris Sherlock
Adds in logic to OutputDevice that takes a font color and the font's background color - if the font and background is dark then return the stock white color, if the font and background are bright, then return the stock black color, otherwise just return the font color. Also added a unit test to ensure that SmTmpDevice restores font and test color correctly. Change-Id: Id805682778d82826c644e7a27017c8d30b1ff5eb Reviewed-on: https://gerrit.libreoffice.org/75524 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2019-09-16drop VclComboBoxText in favor of GtkComboBoxTextCaolán McNamara
Change-Id: I772b0e9daeee69bf981ab68332d9be2ca0c2e02a Reviewed-on: https://gerrit.libreoffice.org/78967 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-16tdf#42949 Fix IWYU warnings in vcl/unx/generic/*Gabor Kelemen
Also recheck vcl/inc/unx/* Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I6e91c51892063b0ae6fe571753c4924f2481f3c2 Reviewed-on: https://gerrit.libreoffice.org/78618 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-09-16vcl:pdf : simplify PDF/A code generationArnaud Versini
Change-Id: I2c5116891d28d37e23048a027124b803af8e25e4 Reviewed-on: https://gerrit.libreoffice.org/78867 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-09-15add WinBits and InitFlag to RoadmapWizard ctorCaolán McNamara
so wizard modality and resizability flags in .ui can be honoured by VclBuilder Change-Id: I5dd40796349862261d0b67cf14bfb6a62d8c19ab Reviewed-on: https://gerrit.libreoffice.org/78948 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-15ditch wizarddialog.ui nowCaolán McNamara
Change-Id: I4c0b169849ccd255766bbadf4b1eac900a0b192f Reviewed-on: https://gerrit.libreoffice.org/78940 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-15unused OWizardPage ctorCaolán McNamara
Change-Id: I80089f9a01023380b067983ac30364a75a488485 Reviewed-on: https://gerrit.libreoffice.org/78938 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-15split RoadmapWizard into its own headerCaolán McNamara
Change-Id: Ic0b790a6535f09782a9cb0fa1add480cbbe8c503 Reviewed-on: https://gerrit.libreoffice.org/78922 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-15merge RoadmapWizard and OWizardMachineCaolán McNamara
Change-Id: Ib8c68cb5e96f8bfa9b2398946b87f3b451b3a37e Reviewed-on: https://gerrit.libreoffice.org/78912 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-15base new page id off current last page idCaolán McNamara
So when appending a page, not originally in the .ui, we use an id of +1 of the final id, rather than an id equal to the number of pages. That way we don't end up with duplicate ids if there was a page removed before appending another one Change-Id: I150f479112198bc26fc2dc143fa4622f5e0de713 Reviewed-on: https://gerrit.libreoffice.org/78911 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-14assert for missing model in GtkTreeViewCaolán McNamara
Change-Id: I48550a06d73c974d6637026abc90e1e4d74c4257 Reviewed-on: https://gerrit.libreoffice.org/78861 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-14rework IM underline impl wrt mix of UTF-8/16/32 unitsCaolán McNamara
e.g. ctrl+shift+e type boy then space twice in writer. The UTF-32 units are 0x65 0x1f466 0x1f3fb. The underline should encompass the whole range, prior to this the trailing Emoji Modifier Fitzpatrick was separated from the boy base emoji by an incomplete underline Change-Id: I2e846e8eeedf96f341ed7f50d504883768e9eff0 Reviewed-on: https://gerrit.libreoffice.org/78878 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-14inherit from one classCaolán McNamara
Change-Id: Ia3cb14429a42e445c14cecc20728d59d985f4b5d Reviewed-on: https://gerrit.libreoffice.org/78837 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-12vcl: document what LO_COLLECT_UIINFO does and how to use itMiklos Vajna
See <https://wiki.documentfoundation.org/Development/UITests> for more info. Change-Id: I17f647a5c67aa6aef3bf7ac4743fdc778f8a59d3 Reviewed-on: https://gerrit.libreoffice.org/78836 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
generated by cgit (git 2.34.1) at 2025-01-10 15:02:39 +0000