summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2014-03-26First batch of adding SAL_OVERRRIDE to overriding function declarationsStephan Bergmann
...mostly done with a rewriting Clang plugin, with just some manual tweaking necessary to fix poor macro usage. Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-26fdo#74702 Move device specific bitmap drawing to its own functionChris Sherlock
Device specific drawing has been moved to its own function. VirtualDevice and Window draw in the same way, so can be shared in OutputDevice, however Printer has its only specific ways of drawing so it needs its own method. Change-Id: I051fee029a1ec022a131bb12588189178c4109b2 Reviewed-on: https://gerrit.libreoffice.org/8724 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2014-03-26Split TYPEINFO into plain and TYPEINFO_OVERRIDEStephan Bergmann
...where the latter contains SAL_OVERRIDE annotations Change-Id: Id64794b388d83dfe7026440e8b20a5b5efd412d1
2014-03-26Return two accidentally removed member functionsTor Lillqvist
Change-Id: Ideef97c6ddcde9a3c324084a53792c965c7b6707
2014-03-26Seems we don't need any basebmp stuff in AquaSalGraphics on iOSTor Lillqvist
No repeatable visible differences in TiledLibreOffice for my test docs. Probably we should unify the iOS vcl code even harder with the OS X code, get rid of the last remains of the pre-tiled-rendering basebmp bitmap-based stuff. Change-Id: I2484585d3d0ef5ce758d0a654717d23464464c1a
2014-03-26Sprinkle some SAL_OVERRIDEsTor Lillqvist
Add SAL_OVERRIDE markup to SalInstance and its derived classes for Unix. In the process, found one pointlessly virtual function (not overridden in any derived class). Change-Id: I49e021e77d53b658e664178372b333a13ffdc9aa
2014-03-26Bin DestroyVirtualDevice(): Just use delete directly at call sitesTor Lillqvist
Change-Id: I47c67d3d89ab22b07b3ec6fe7ea6e035d21e85b6
2014-03-25Remove now unused tools/debug.hxx profiling functionalityStephan Bergmann
Change-Id: I13adca8c2f929c8a9226b26ef57b26363dfdf0b3
2014-03-25osl_setDetailedDebugMessageFunc is effectively doing nothingStephan Bergmann
...since the osl/diagnose.h macros got rebased onto sal/log.hxx, so remove the corresponding tools/debug.h functionality. Change-Id: Ife4b5b1a2608230d0dbfc3fa8852243c89ed292f
2014-03-25DBG_OUT_WARNING is unusedStephan Bergmann
...and thus DgbData::nWarningOut is unused, too. Change-Id: I388d2be7dafbfdc173a731dc7daf1c8b5efcd61d
2014-03-25Fix to commit 03568b2e2405fc44435b95720f3680ab1daea836Chris Sherlock
During a rebase I accidentally removed the VirtualDevice::EnableRTL(). Also taking the opportunity to make the function virtual in window.hxx. Change-Id: Ic239d8dc131dfcc6b049c30d2fad4d2d12059059 Reviewed-on: https://gerrit.libreoffice.org/8745 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-03-25fdo#74702 DrawTransformedBitmapEx simplifiedChris Sherlock
Removed bPrinter check from DrawTransformedBitmapEx, also removes meOutDevType. Change-Id: I5fd09efc4f3467702ab9671dc45da1a9c0e3f927 Reviewed-on: https://gerrit.libreoffice.org/8723 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2014-03-25fdo#74702 Move GetBitCount() and GetAlphaBitCount into correct classesChris Sherlock
GetBitCount() works differently for VirtualDevices. GetAlphaBitCount() is really only used by VirtualDevice, so moved functionality from OutputDevice to VirtualDevice. Change-Id: Ic00e32f1fa385542bcce8c9475f0ea5eb9a077f9 Reviewed-on: https://gerrit.libreoffice.org/8722 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2014-03-25fdo#74702 Moved EnableRTL() logic to specific classes where appropriateChris Sherlock
OutputDevice::EnableRTL() is a bit of a mess. It uses a runtime variable to see if it is using a VirtualDevice, and it uses a dynamic_cast to see if the object is a Window or a Control! I have made it virtual and moved the knowledge of class specific functionality from OutputDevice to VirtualDevice, Window and Control as needed. OutputDevice::EnableRTL() functionality is then called. Also: small formatting change to outdev.hxx, also included a note that WindowImpl is a pimpl in window.hxx. Change-Id: I44b66601c4457fb2e0bbc1014fb7acf8f6942f80 Reviewed-on: https://gerrit.libreoffice.org/8721 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2014-03-25prevent KDE/Qt from interfering with the session managerLuboš Luňák
I occassionally get lockups in IceProcessMessages() called from QtCore, I'm actually not exactly sure why, as theoretically two connections from one app shouldn't be a problem, but since LO does its own session handling, there's no need to the KDE/Qt code to be involved, so prevent it from connecting to the session manager altogether. Change-Id: Iebe20d4cb5403e5fea8bd5d8c1f69b62d1c2907b
2014-03-25remove commented codeThomas Arnhold
commented out since it came in with 835219840d42cfb891614db2ed7bf0386293468a
2014-03-25Remove commented-out debug codeStephan Bergmann
Change-Id: I1442d57eb2f80d98370549659eece5a2cd7db3c5
2014-03-24fix Mac buildStephan Bergmann
Change-Id: Ifde3ac63353b04827303c32f7832fcb828b7149d
2014-03-2464-bit OS X build fixTor Lillqvist
Change-Id: Icf344f3ad4d508bb47500db3bc5cfb5ee642acfa
2014-03-24GetPaintArea() was operating directly on the region, no need to return it.Jan Holesovsky
Rename it accordingly, so that it is more obvious. Change-Id: Ifb313f1e60b50761247a65b7ce2c6b38773c1304
2014-03-24fdo#76179: deleting mpDefaultWin causes a DBG_TESTSOLARMUTEXStephan Bergmann
...so deinit support for that only afterwards Change-Id: I89b8014bd26aecd9da67eaddc4a8facc620bf16e
2014-03-24Revert "Resolves: #i124375# force soft-hyphen visibility for CoreText..."Caolán McNamara
prefer 4dba6f5837539746293ef6808ea39a764ab7654d "fdo#67370: Hyphens are not visible in tagged PDF" This reverts commit 8214c1d6156c90cbf259b15cf1c8e15ea1c70daf.
2014-03-24Make sure to include Foundation.h to get NSStringTor Lillqvist
Change-Id: I063c7abcbce003a8bbfd8aa8d57416a6aad84760
2014-03-24Fix a few problems in the iOS vcl codeTor Lillqvist
We don't need the headless SvpSalBitmap code after all on iOS, so bypass all of svpbmp.cxx for iOS. I accidentally had left duplicates for some AquaSalGraphics methods in headless/svpgdi.cxx in addition to the ones in quartz/salgdicommon.cxx. This is obviously bogus, the linker just picks the ones that come first in the archive. (Remember the ugly "#define SvpSalGraphics AquaSalGraphics" trick, so for instance SvpSalGraphics::setClipRegion actuall is AquaSalGraphics::setClipRegion.) It's the Quartz ones we want, as since the switch to tiled rendering the iOS vcl code is supposed to work much more like the OS X one. (There is still some significant refactoring to do there. Possibly no "headless" code needs to be used at all for iOS.) A couple of functions moved from salgdiutils.cxx (which isn't compiled for iOS) to salgdicommon.cxx. The SetState() function now gets used also on iOS, and to properly undo its CG context stacking I pop it in SetVirDevGraphics() when the virtual device is being destroyed. This fixed the rendering of some simple shapes that use overlapping and transparency, but not that of the "monster" SmartArts. Change-Id: I2bfaa4129e3641dbdd1dd240c1d07f9bdcfea1b8
2014-03-24Resolves: #i124375# force soft-hyphen visibility for CoreText...Herbert Dürr
to meet Writer+EEng expectations (cherry picked from commit c7243848547b19a3b237f18629b809d93ee821c4) Conflicts: vcl/aqua/source/gdi/ctlayout.cxx Change-Id: If580bcb517695ae1c94657ac9348ad36eda37e9d
2014-03-24callcatcher: update unused codeCaolán McNamara
Change-Id: I48990c044e4583e835f3e995527ba423e8c459fb
2014-03-24fdo#74702 ImplDrawBitmap functionality moved to protected functionChris Sherlock
OutputDevice::ImplDrawBitmap() has functionality that cannot be used by printers. I have moved that into a protected function, ScaleBitmap() Change-Id: Ia1297e259283b8b2f4cf069e3a64a574592a1846 Reviewed-on: https://gerrit.libreoffice.org/8720 Tested-by: Norbert Thiebaud <nthiebaud@gmail.com> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-03-24fdo#74702 GetPaintArea protected function introducedChris Sherlock
GetPaintArea has been introduced for Window - we intersect with the available paintable boundary to get the actual paintable area needed. For OutputDevice, GetPaintArea just returns the same area. Change-Id: If38b09eb54d516d189cedf8bba15b184e6b6f7d5 Reviewed-on: https://gerrit.libreoffice.org/8727 Tested-by: Norbert Thiebaud <nthiebaud@gmail.com> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-03-24Decrease indentation by returning early.Jan Holesovsky
Change-Id: I9ab5b4dbd28c720c9d7cdd8a1642462643abe94c
2014-03-23No need for these (void)sKhaled Hosny
Change-Id: I946009c4ffacf51c7f144acf85060ccd4a31620a
2014-03-22cppcheck: fix reassigned varsJulien Nabet
Change-Id: I9038045b5756ca956febe5d2ab7b05d15c4a7bca
2014-03-22coverity#705969 Dereference before null checkCaolán McNamara
Change-Id: Icb19931bb529e6c2b98621a603cdb86011d68a9e
2014-03-22fix higher debug level buildsCaolán McNamara
Change-Id: Ie8225ad476c43cbff2ee8fb0f3178b3cc4662ac9
2014-03-22WaE: unused variable 'aSrcOutRect'Tor Lillqvist
Change-Id: Ic64d9e3be43b3ad1751070242fc3ad9f7b35a92a
2014-03-22cppcheck: fix Possible inefficient checkingJulien Nabet
Change-Id: I71449d40875970aa49320ae86a3104d132f5d5e9
2014-03-22casting to void to silence a WaE lead to windows complaining.Norbert Thiebaud
Change-Id: I203b52d0a80dd3c04b75aab7e8a683b609e3efba
2014-03-22WaE unused parameterNorbert Thiebaud
Change-Id: I1390e327d8085badcfc3067763576fc6a0f3887c
2014-03-22fdo#74702 DrawOutDev() and CopyArea() functions now noops in PrinterChris Sherlock
DrawOutDev() and CopyArea() functions now assert when called from a Printer instance. This has allowed the removal of meOutDevType, which I hope to eventually completely eradicate from LO. I've also included DrawOutDev(...) which holds a parameter with a reference to a Printer object. This shouldn't be possible, so it asserts. Change-Id: Iabee853ca7c8bfc99349da086d1944ee13210a2e Reviewed-on: https://gerrit.libreoffice.org/8592 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-03-22fdo#74702 Moved CopyArea() Window specific functionChris Sherlock
There is Window specific code in OutputDevice::CopyArea(...). I have moved this to a protected function CopyAreaFinal(...). Conflicts: include/vcl/print.hxx vcl/source/gdi/outdev2.cxx Change-Id: I9098ec960527a2aca6154ac6e791b947a8e4f78e Reviewed-on: https://gerrit.libreoffice.org/8605 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-03-22fdo#74702 Move BitmapEx drawing code to seperate functionsChris Sherlock
New virtual functions DrawTransformBitmapExDirect() and TransformReduceBitmapExTargetRange(). Printers cannot do either of these things so I make it a noop in the Printer class, Window and VirtualDevice will continue to work as intended. I have documented these functions in OutputDevice. Also made some small formatting changes to print.hxx to align tabs. Change-Id: Idd31d230f95d3b5ea360c72dc8191d47bfd8402b Reviewed-on: https://gerrit.libreoffice.org/8588 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-03-21Resolves: fdo#76457 image buttons too narrowCaolán McNamara
but we liked the size of the symbol buttons regression since 1f6e88276006bea5d597ee6ca6fdf3af4dbf5ffd Really the PushButton::CalcMinimumSize and PushButton::ImplDrawPushButton are the better place to handle this, but its such a train-wreck Change-Id: Ib7ba00c6a9c2698ff4e4f264c4242bf48a686da8
2014-03-21fdo#74702 ImplPrintMask() implemented in PrinterChris Sherlock
Printer should implement ImplPrintMask(), as a protected function. If OutputDevice calls it, then do nothing. Also removed commented out code. Change-Id: If3e7d3b2057f0c89f48f81a4a7a7b2360c0a3439 Reviewed-on: https://gerrit.libreoffice.org/8593 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-03-21fdo#74702 Moved ImplReleaseGraphics into correct classesChris Sherlock
Made OutputDevice::ImplReleaseGraphics a pure virtual function, then implemented function in Printer, Window and VirtualDevice. The reason was that OutputDevice was checking to see if it was a Printer, Window or VirtualDevice that was calling on it in an if statement, very uncool :-) Now I let the classes themselves do the work. There is some common functionality, which is to release the fonts. I have put this into a protected OutputDevice function, ImplReleaseFonts. Change-Id: Id41db2119d4022ea2fc7855158ca9f610af3c85c Reviewed-on: https://gerrit.libreoffice.org/8548 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-03-21Revert "fdo#74064 The filename gets properly highlighted in the Save As dialog."Kohei Yoshida
This reverts commit 55eb86699d7d4b2151530e9a0b3ca2e99033595b, which caused a regression fdo#76466.
2014-03-21Fold psprint_config into vclKhaled Hosny
The files are only used by the psprint stuff in vcl, so move them closer to it. We should kill all of this anyway, but that is for another day. Change-Id: Ie3b893c92d556333c9d8b041859d5e97604ace10 Reviewed-on: https://gerrit.libreoffice.org/8694 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-03-21Related: fdo#74468 drop hard-coded 'sec' and use FUNIT_SECONDSCaolán McNamara
Change-Id: I11e2aa39d77c01446387b13ba4bc9f40b61a958a
2014-03-21coverity#1000766 Dereference before null checkCaolán McNamara
Change-Id: I539cb91511fe95d004044a98736b4a6b99f24a5b
2014-03-21coverity#705966 Dereference before null checkCaolán McNamara
Change-Id: I74507ce67f928bdeb626d4070dbd2a45cc126521
2014-03-21coverity#736078 Missing break in switchCaolán McNamara
Change-Id: I9b47828d3aea4d84788958f56056c1b62a806b36
2014-03-21coverity#708662 Uninitialized pointer fieldCaolán McNamara
Change-Id: Icfa4ee2a525016775b5917143b5c4333212db362
generated by cgit (git 2.34.1) at 2024-12-27 00:37:27 +0000