summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2020-03-05vcl: move read and write to/from GfxLink to TypeSerializerTomaž Vajngerl
Change-Id: Ie99d00ea54296f5f3a909ade7115d9a9251f688e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89983 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-03-05vcl: put first and last native type into GfxLinkType enumTomaž Vajngerl
Until now we had define GFX_LINK_FIRST_NATIVE_ID and define GFX_LINK_LAST_NATIVE_ID which pointed to the first and last type n the GfxLinkType which represented the native type. A more elegant way to solve this is to assign an alias to the first and last value. So now we have "NativeFirst" and "NativeLast" defined in the GfxLinkType enum instead. Change-Id: I5613a1b544fc7ae4f8b884df94c6fa4e2fb322d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89982 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-03-05Add a separate log tag for the UI builderTor Lillqvist
Change-Id: I54d0233574fa84f1fe988a88f6220985e9149b83 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90004 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-03-04Fix typoAndrea Gelmini
Change-Id: I48d8000abc0cd835781dffe6b2b6621639a5435f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89900 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2020-03-04scroll to the row when putting the cursor in itCaolán McNamara
Change-Id: If1edbf1d0f94176a12a9359c17179301304f2c56 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89988 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-04add iter_previous_siblingCaolán McNamara
Change-Id: Ic9ff26361cc9fed32760260e085660f05e13f4d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89987 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-04Fix typoAndrea Gelmini
Change-Id: I90b8ec6b62ae421822acdec0d99b0ff768b01e09 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89990 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-03-04We have had C++11 for some time nowTor Lillqvist
Change-Id: I3946aba66a49518fb6c3fe6e1767babecddc956b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89962 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-03-04leave focus where it came from for GtkMenuToolButtonsCaolán McNamara
Change-Id: I111aac99120ae2d3284f5c41a52cde718079a383 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89976 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-04graphic: remove preview when importing with GraphicFilterTomaž Vajngerl
The property "PreviewSizeHint" and the enum value ForPreview in GraphicFilterImportFlags doesn't seem to be used from outside, so let's remove it as it simplifies the PNG and JPEG import filters. It is generally more recommended to load the bitmap file fully and only then resize it to a smaller (preview) size. Change-Id: I97f333686c25f7a7a4bdf6c6f0885154b515fd3d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89932 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-03-04graphic: remove "AllowPartialStreamRead" from graphic importTomaž Vajngerl
Only have an impact on PNG anyway, and it's not really clear in what way. I don't really find any references where this is set. Change-Id: I49519f2116bb0d90648910acddd6176261398c6c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89931 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-03-04graphic: remove CreateNativeLink property for graphic importTomaž Vajngerl
Doesn't seem to be used and we always want to creat a native link anyway. Change-Id: I2e50093491b771bb251816525cf492cf030bc496 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89930 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-03-04tdf#131076 allow 'return' in GtkComboBox to activate default widgetCaolán McNamara
typically ok and accept the dialog. alt+down is documented as the default menu-activate key binding, space will also work to popup the menu from a combobox. Change-Id: I7bec880670cc006b288996d6f59a88fe9a9fb8cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89950 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-04vcl: rename GetContext to GetReaderContext in GraphicTomaž Vajngerl
GetContext is a very generic method name, so rename it to a more specific GetReaderContext name. It is easier to find references. Change-Id: Ieb05ac63080598357107dc3e485b481910cd79cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89929 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-03-04allow control over treeview scroll positionCaolán McNamara
Change-Id: Ifa29416c4a716b3759f279ae4f0ce9179325f7a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89927 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-04tdf#130150 Improve clipping in PDF exportArmin.Le.Grand (CIB)
For more info and discusson please have a look at the task. It reverts the change from tdf#99680 which did a wrong paradigm change in how clip in Region(s) is defined and tries to fix the underlying error in a more correct way. This includes problems noted in tdf#44388 and tdf#113449. This is a decent improvement, but - due to dealing with numerical problems - not yet the whole healing. Still thinking about how to solve this for good. Adapted PdfExportTest::testTdf99680() and PdfExportTest::testTdf99680_2() as needed, empty clip regions are allowed again. Added comments, too. Had to change solvePolygonOperationAnd to work on ranges if both inputs *are* ranges. The AND-case is then completely solvable. Also increased geometry for transformations of clip geometries - may help later. Change-Id: I2370447597faa6efb81d58ee31c63654e304262e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89874 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-03-03Bin duplicationTor Lillqvist
Change-Id: I26dda20f0a1e51cc4ea820f9814a978e23ba9b96 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89892 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-03-03fix ODRNoel Grandin
Orientation here clashes with Orientation in include/vcl/prntypes.hxx Change-Id: Ib68dec61990aebad6154eb2f5e00eb8680ebe196 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89888 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-03Qt5 just ignore invalid font attributesJan-Marek Glogowski
This ignores the *_DONTKNOW and _FORCE_EQUAL_SIZE values, except for the stretch, where we map DONTKNOW to QFont::AnyStretch. Change-Id: Ifdf55e798566681852ad4b585f4aeb0ebfbd1cf9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89884 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-03-03tdf#101181 Implement glow effect on shapesTamas Bunth
Glow effect is a color-blurred outline outside of the shape. In ooxml document it is specified with the <a:glow> element. The commit contains the following: - Add support for importing and exporting <a:glow> from ooxml documents. - Assign new properties to XShape which stores glow-related attributes. - A new 2D primitive is introduced in module 'drawinglayer' which is responsible for representing the glow primitive which is to be rendered. + A glow primitive is a clone of the original shape which has been scaled up slightly and a new color has been assigned to it. The radius of the glow effect and the color is defined in the <a:glow> element being imported. - A blur algorithm is introduced in module 'vcl', which is called during rendering the primitive. + The blur algorithm works on a bitmap. + Since the algorithm is CPU-intensive, the result is cached in the processor and it is recalculated only if needed. - Add support for importing and exporting glow effect to ODF format. For that, new attributes of element <style:graphic-properties> has been added: + loext:glow, which can have the values "visible" or "hidden" + loext:glow-radius: which holds the radius of the glow effect in cm. + loext:glow-color: holds the color of the glow effect - Tests have been added to assert properties after pptx import and export. Change-Id: I836aeb5e0f24e2c8d5725834c8c0f98083bc82e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89125 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2020-03-03deem placeholders entries currently expanding as logically still placeholdersCaolán McNamara
Change-Id: I87ebc1d7e095f465c76fcd9b76c01749fe6b57df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89871 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-03add a collapsing row hookCaolán McNamara
Change-Id: I83d690715a9e427d23b3f2316fd114c037487d54 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89841 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-03Revert "Make Chart Creation Wizard async"Stephan Bergmann
This reverts commit ed86b6250cd00ed6b7bdb81307bc66adba129cae. Reason for revert: Most Jenkins builds for that change were aborted after timing out, and many other Gerrit Jenkins and tinderbox builds now time out, too. It very much smells like that commit was the culprit. Change-Id: I5473c58957f92d63113e32f862ad9c114f9c844c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89803 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-03-02ofz#20976 build-failureCaolán McNamara
Change-Id: I6fc81e6ef13f77dea410f95e159a932089603aeb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89801 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-02Revert "ofz#20976 build-failure"Caolán McNamara
This reverts commit 5b22433d79823372744038c5ae28094bc938fb48. Reason for revert: <INSERT REASONING HERE> Change-Id: I4a104ca86dadbcc7f797df41326d48a53ca1c990 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89800 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-02ofz#20976 build-failureCaolán McNamara
Change-Id: I31434d2b979aff20a53b164ffbb3d19247cd1ce3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89826 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-02Qt5 unify font attribute conversionsJan-Marek Glogowski
Adds conversion functions for VCLs FontWeight, FontWidth and FontItalic to Qt5FontFace and remove the partial "switch" tables from KF5SalFrame. And correctly handle the FontWidth in Qt5Font as the stretch value, so the default font in qt5 gets the correct stretch and doesn't look bold. Change-Id: I698986416dff13e6dfaf9dfa7f95851b89e9137d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89813 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-03-02Qt5 some refactoring for HiDPI mergeJan-Marek Glogowski
This is a preparatory patch for merging the initial fix for tdf#127687, the Qt5 HiDPI scaling support, and generally to make the style handling code a little bit more readable. It includes: * Moving all lcl_ Qt5Graphics_Controls functions into the class as private functions without lcl_ prefix. * Add three additional helpers - pixelMetric, sizeFromContents and subControlRect - to cut down boilerplate QApplication::style()-> prefixes for the style calls everywhere. * Drop the superfluous Qt5Frame::TriggerPaintEvent functions. * Drop the single, broken maGeometry.nTopDecoration filling. * Split some very long lines of nested call code by using some intermediate variables. * Move a Qt5Data include from hxx into cpp Change-Id: Iae1bfafd14c4163447f3d55e2307f0f617e68a0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89751 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-03-02tdf#131031 Gtk3 presume the resize did happenJan-Marek Glogowski
Regression from commit b26ca5b13733b46c2df0787502f885e15b390956 ("tdf#130841 resize to client size after SetPosSize"). It just happens for me on gtk3, not gen and not win. But since gtk3 also sets the nX and nY value SetPosSize eventually before the fact, do the same for the nWidth and nHeight. Change-Id: I2898c403b73de790f3f988b8b8ec2067f4b0b43f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89760 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-03-02Make Chart Creation Wizard asyncSzymon Kłos
* FuInsertChart as a memeber in ScTabViewShell stores instance is needed to react on the dialog's result * CreationWizardUnoDlg converted to XAsynchronousExecutableDialog added dialog close handler which notifies listeners In the Online dialog become dead after closing, additional PostUserEvent was needed to kill the dialog after real close (without it user needed to select any cell to close dialog) * Reuse in Writer Change-Id: I9fe123d5c189d568f0edb4d36173a224a820a8a3 Reviewed-on: https://gerrit.libreoffice.org/79654 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/79571 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-03-02gtk3 a11y: fix get_text(1,-1)Samuel Thibault
Even when the end offset is -1, we have to return the text starting a the given starting position, up to the end, but not necessarily from the beginning. Change-Id: I6a79092c683c273eaedb8661545df71b742110ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89486 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-03-01nDepth is only written to, not readCaolán McNamara
Change-Id: Idf6f038e535f48558b04f3aea63c01c9e164ee8c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89779 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-29tdf#130768 add a pre-scale version for cairoArmin Le Grand
As explained in the task, suopport (2) by adding a cached pre-scaled cairo_surface_t buffer that works similar to a mip-map and thus uses as maximum a fa tor 0f 1.25 for speeding up painting of smaller versions of huge bitmaps Change-Id: I4fcc221a0fbb5a243fe93813f3fe1f3cdb4e0566 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89718 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2020-02-29tdf#130515 Time field in Base form will not display correct formatNoel Grandin
regression from commit 65b7b6322b662785bf032e66c76abc36c9a2bb0e Date: Wed Feb 8 10:40:28 2017 +0200 loplugin:unusedenumconstants read-only constants in vcl Change-Id: Icf2e385763c8ece34521895331d148a5baacf2d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89706 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-28weld calc navigatorCaolán McNamara
note: non-standard dnd via parent so the treeview triggers the dnd but doesn't itself strictly speaking drive the dnd, see copying a range from the navigator where the calc main edit window shows the outline where the copy of the range from the calc main window will go Change-Id: Ideecbe779e3d9bb5b392357a93ec25f625180ba8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89597 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-28tdf#130071 tdf#127815 qt5: Use ExtTextInput only for multi-char key eventsMichael Weghorn
Only call the SalEvent::ExtTextInput callback for key input events if their text is longer than one character, in which case treating them as SalEvent::KeyInput would produce incorrect results, given that only the first character is set as the SalKeyEvent's mnCharCode below (s.a. tdf#124118). S.a. commit 61c8324394c690ced18ce692ab6d29c8031ad1a8 ("#88063# fixed event handling for redflag", 2001-06-12) which made events with text longer than 1 unicode char to be handled by SalEvent::ExtTextInput for the gen VCL plugin even if not in preedit mode. Process other key events by calling SalEvent::KeyInput callback, which e.g. makes shortcuts involving non-Latin characters (tdf#130071) and auto-insertion of non-breaking spaces when typing French text (tdf#127815) work. The gtk3 and gen VCL plugins also use the length of the text as one criterion to make a disctinction of whether to call SalEvent::ExtTextInput or SalEvent::KeyInput, s. GtkSalFrame::IMHandler::signalIMCommit and X11SalFrame::HandleKeyEvent. Those also take into account whether in preedit mode, but for the qt5 case, input method events when using e.g. ibus are handled in Qt5Widget::inputMethodEvent and the Qt5Widget::handleKeyEvent code path is not used anyway. Change-Id: I2f8925ea26a4fb5419226265c579242889e2a506 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89663 Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2020-02-28use COL_AUTO to let set_font_color reset to automatic text colorCaolán McNamara
Change-Id: I5761081fde66da3dc8071709e53b2014f10b5916 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89651 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-28Close dialog on EndDialog to avoid respawning dead windowsSzymon Kłos
Change-Id: I69cd45871868390dc45265c9754791e711079a0b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89623 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-02-27tdf#130679 Draw: Convert to polygon doesn't workNoel Grandin
regression from commit 1cd32bcf1b92bd53320717626601135623dadd55 Date: Mon Dec 10 11:28:59 2018 +0200 loplugin:useuniqueptr in vcl Change-Id: I7753f54822d0249d1fcda97581051d023969fc2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89636 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-27loplugin:unusedfieldsNoel Grandin
Change-Id: I0d3941ed2a6f0caadbe080ac8a6273c5ec21462c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89616 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-27Fix compilation on Windows with --disable-skiaKelemen Gábor
Trying to compile with option --disable-skia failed with: error C2027: use of undefined type 'SkiaControlsCache' Change-Id: I44b40cf7c2a8f356f8a49312a413c924c141c7df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89458 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-02-27loplugin:singlevalfieldsNoel Grandin
Change-Id: I3aa19805fab937cd9516ce8127753a0f599c73c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89611 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-26lru_scale_cache - cache the same bitmap at multiple scales.Michael Meeks
Helps accelerate different views at different scales, as well as document / image thumbnailing on save, as well as stray views that can get rendered behind the scenes at odd scales on mobile. Each scale + bitmap combination is another key in the LRU table. Change-Id: Id82ce2e4180608082c9ca16fad35bba9e8c2e81a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89497 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89503 Tested-by: Jenkins
2020-02-26WIN prevent deadlock in SetForegroundWindowJan-Marek Glogowski
As mentioned in various blogs, like Raymon Chens "The old new thing", 2008-08-01, "I warned you: The dangers of attaching input queues", using AttachThreadInput to steal the input from an other thread, so SetForegroundWindow becomes more reliable, can deadlock in that call in win32u.dll!NtUserCallHwndLock. Stackoverflow also has a multitude of suggestions and links in "Win32 SetForegroundWindow unreliable", to circumvent Windows focus-stealing prevention mechanisms. A customer is experiencing these hangs reliably and often when opening LO windows via Java UNO, because the Window and the UNO thread are different and trigger this code path. Removing the calls to AttachThreadInput fixes the problem for them. This has started lately and nobody really knows why. I also know other customers with a similar Java UNO setup, which don't experience them. For better foreground handling, the calling app eventually should either use AllowSetForegroundWindow or CoAllowSetForegroundWindow (for COM servers), to give up the foreground / input handling. So this just drops the AttachThreadInput calls. Change-Id: I8de0a17aaaa44c24b1ee728b2ef6ec3aea951c54 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89527 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-02-26tdf#130845 sidebar widget visible when sidebar collapsedCaolán McNamara
default to "false" and track the parent widget clipping/visibility instead of "true" which makes it unconditionally visible Change-Id: I1f8cec2b07ac20c33ff09cc278424d7e20199946 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89552 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-26get the real last row, not the last toplevel rowCaolán McNamara
Change-Id: I7de72c383f11187ec706cd6971ff0431d04db72f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89539 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-26only call enter/leave page when not changing programaticallyCaolán McNamara
which is how the vcl version traditionally works, this results in the "General" tab in the basic dialog editor 'sticking' as the the default page Change-Id: I2bc88093df48724c32c99add5234968fa672e4a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89463 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-26leave "skipped" events available to gtk parent handlerCaolán McNamara
Change-Id: I6cf4b8b308ec41a46aeb6b48554d87a2fa316d85 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89475 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-26Resolves tdf#130500 - Sukapura icon themeHeiko Tietze
Added to core and made default on macOS Change-Id: I1c1e8caab514198717cf6cd7e8c00a1c1d5c15da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89183 Tested-by: Jenkins Tested-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id> Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-02-26loplugin:nullptr (clang-cl)Stephan Bergmann
Change-Id: I0d40f6ee515430f2d32fb7d3bcc193273d36c016 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89469 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>