summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2015-06-01fix build breakEike Rathke
6feb828757477669325ebd8bc4491b7e4d1283dc used SalLayoutFlags enum value that aren't introduced yet on this branch. Change-Id: I64b30ad36a6812a3c2992d9185e816c1eba4642d
2015-05-27Resolves: tdf#89231 if no font has 0x202F fallback to a normal spaceCaolán McNamara
Change-Id: I2325c0b09ccf66ee15597251ad027b295de5502f (cherry picked from commit f76ecc3e9ce51b35fc18db55b808270079a3652b) Reviewed-on: https://gerrit.libreoffice.org/15912 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-05-26add missing includesDavid Tardon
Change-Id: I2b091eb8c407f032f15674338c917bbe7e06d15b (cherry picked from commit 75155bcf07d296352162d0b963493b4ba0238cca)
2015-05-26Resolves: tdf#90155 don't hide+show window before initial show completesCaolán McNamara
(cherry picked from commit c4bae028efbd32c8938c3a6051d58c1f202d5b8a) Change-Id: I16f6fb4ef025f2e464ca581fc348e8dd18981285 Reviewed-on: https://gerrit.libreoffice.org/15910 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-05-20tdf#90604: vcl: reduce MapMode precision further to 32 bits...Michael Stahl
tdf#91195: vcl: reduce MapMode Fraction precision to avoid... ... overlow in ImplMapLogicToPixel. 50 bits is still too much, 44 appears to work for exporting PNG. DocumentToGraphicRenderer::renderToGraphic() converts a double to Fraction which is the source of the excess precision. (cherry picked from commit c8dad7ebb7c1738ae1348f92d67124c165d83f00) ... which mysteriously causes the Export PNG to produce a non-blank image again. The cause is probably that DocumentToGraphicRenderer::renderToGraphic() records a VCL MetaFile, and the ReadFraction/WriteFraction do only 32 bits, while the Fraction interface promises to handle "long". (regression from 2ce0aededea43231d91a0955fc0676120dcc4f13) (cherry picked from commit 21be3257d9d10f0f65c2ae49d7ef3beb81018bfc) vcl: fix the MapMode ctor too to limit precision to 32 bits (cherry picked from commit 0a9b99787c65e49f08b27566d277eab8306cca54) Change-Id: Ic4289a3157ea802c17f0bc24db94ea45eabd9728 Reviewed-on: https://gerrit.libreoffice.org/15800 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-04-29tdf#71034: [OS X] Ugly (too heavy) fake boldKhaled Hosny
Instead of using a hardcoded stroking value, adopt the formula used by AOO which seems to give better results. Change-Id: I87d55e1fadccf4521c26cd60458d968fcd8a2386 Reviewed-on: https://gerrit.libreoffice.org/15563 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2015-04-27-Werror,-Wformat-securityStephan Bergmann
Change-Id: I62ff8a172a9c4f361ef5fcb6d60bd9fd2e959c2d (cherry picked from commit b8cf9b3359195f4f9f7e92f5db224a91cf994306)
2015-04-25Resolves: tdf#73211 gtk checkboxes need erase afer togglingCaolán McNamara
because an unchecked checkbox can have a smaller paint area than a checked checkbox. This has always bugged me (cherry picked from commit d194074aa34e3724dd9b93fbc81bf2ba793cd37a) Conflicts: vcl/unx/gtk3/gdi/gtk3salnativewidgets-gtk.cxx Change-Id: Iac0f075089611b47c381863a9655445d732bfddc Reviewed-on: https://gerrit.libreoffice.org/15508 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2015-04-20tdf#71278 Fix cursor hiding in presentation modeMatthew Francis
The original commit was based on a misunderstanding. In fact, the call to GetSalData()->getCursor() at the end of AquaSalFrame::getCurrentCursor() already handles POINTER_NULL correctly, or at least in the same way as on other platforms. The cursor in presentation mode disappears after 10 seconds - if this is to be changed, it should be changed for all platforms. (cherry picked from commit 58a3a99efec9d4bcb4ab61c41bf2feb707c8e1ef and commit b144821188aac238a38d647dff489fc53d9bf3f6) Change-Id: I6d468caa597afa39d17317a60b3dffc190165ac4 Reviewed-on: https://gerrit.libreoffice.org/15395 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-04-17tdf#86793: vcl: speed up OutputDevice::GetEllipsisString()Michael Stahl
The ridiculous algrorithm used for TEXT_DRAW_CENTERELLIPSIS will go faster if we cut out most of the text at the beginning instead of one at a time. (regression from 912ecaf565e68d2ca3fb9584712313e712749f75) (cherry picked from commit c6ec3e4cee8c7c22380780f2661ac23946cdb050) Change-Id: I9310dda1847222215bafe372e3efef9d365e1ad9 Reviewed-on: https://gerrit.libreoffice.org/15355 Tested-by: Miklos Vajna <vmiklos@collabora.co.uk> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-04-16tdf#84294: vcl: fix PDF export of transparent Writer frames in LO 4.3Michael Stahl
The transparent frame background is painted opaque because OutputDevice::DrawTransparent() records a MetaTransparentAction instead of returning early. Note that master and 4.4 use drawinglayer to paint backgrounds so the problem is only visible in 4.3. (regression from 36b59f2efc2bfb2c9256c39eb5687808deb) Change-Id: Ide7a076b72123097a9fe099b96d36cda7f7bb082 (cherry picked from commit 581314958f0ddd6c3a0536ce2d7e7e6f0c53a8ec) Reviewed-on: https://gerrit.libreoffice.org/15342 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2015-04-13Resolves: tdf#90384 queue_resize needs to Invalidate the optimal cache sizeCaolán McNamara
but the PanelLayout didn't (cherry picked from commit b39a6449d5debc7cdf55c3f967b441f3de4d50f3) Conflicts: svx/source/sidebar/PanelLayout.cxx vcl/source/window/dockwin.cxx vcl/source/window/syswin.cxx Change-Id: I38a8975f1488fa2a2ffe91b66745e1a1c6c48a28 Reviewed-on: https://gerrit.libreoffice.org/15215 Tested-by: David Tardon <dtardon@redhat.com> Reviewed-by: David Tardon <dtardon@redhat.com>
2015-04-08Resolves: fdo#84795 Menus don't disappear with right mouse clickCaolán McNamara
re-do this so right-clicking when a menu is open closes that menu but doesn't cause another popup menu or otherwise pass that click through to the app Revert "fdo#84795 Menu, DropDown-List don't disappear with right mouse click" This reverts commit fa022a9c4fe74f3f67fb3c35ef49022842d7499b. because if a right-click context menu is active and we click outside it in order to remove it then that click goes to whatever is underneath the mouse which is undesirable the list dropdown part of this looks good, its the general menus that are the problem Conflicts: vcl/source/window/winproc.cxx (cherry picked from commit 473eae3a7d43ca13ef14eca844b991ffd143e3a0) Conflicts: vcl/source/window/winproc.cxx Change-Id: Ib96e52f22cdeefd59dbf4333f555d9f52b3385e2 Resolves: fdo#84795 Menus don't disappear with right mouse click Change-Id: I95ae2e2d564ec1c45de6df5158e4dec1d93053cb (cherry picked from commit 4f9e20c46b616c7c51bae74bfefd5247f922b2a6) why would we ever want FLOATWIN_POPUPMODE_PATHMOUSECANCELCLICK if we're from the menubar we never set it, but if we are a submenu from a menu in the menubar we set it. with it set, and on right click, the right click is passed through to what ever is underneath the pointer I don't see why we want to do that, especially the inconsistency from e.g. the File menu, vs the "File->New" menu Change-Id: I548f5c95e2511b5e921e8b74600f65eecdd8f498 (cherry picked from commit a8f9dd59de4e655bc77fa0546b81440aee46b837) remove the gap now to pretend it was never there Change-Id: I234defd865e6bf5d9d9eccc85cde7e69c0549c3f (cherry picked from commit a62d7f3b08b413d17e650279110ab8a48c419b18) Reviewed-on: https://gerrit.libreoffice.org/15092 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2015-04-08Resolves: tdf#86399 don't clobber cluster start caret posCaolán McNamara
with other cluster element bounds (cherry picked from commit b1030f75d3e47719ca63ec518f1da75196bead1a) Conflicts: vcl/source/gdi/sallayout.cxx Change-Id: I2cc976eb6a0ef42a2678be80637c7220e2247921 Reviewed-on: https://gerrit.libreoffice.org/15119 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2015-04-03tdf#81813: Typing to select value in dropdown resets after space characterJulien Nabet
Change-Id: I6972cdad9708a46bb8338590312196e55c4f8778 Reviewed-on: https://gerrit.libreoffice.org/15024 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 44c87a5dc921ea6dd28fdc016c61aa62cfd4f4d6) Reviewed-on: https://gerrit.libreoffice.org/15098
2015-04-02fix hang with ooo71962-1.odtCaolán McNamara
script run ends after chunk we are rendering (cherry picked from commit 00bf3a4259c1f960eff05b17649cc734c275950f) Change-Id: Idbfe11c385db72a80d3d204f8638d67395580d1b Reviewed-on: https://gerrit.libreoffice.org/15115 Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com> Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2015-03-26tdf#67990: Management of case in comboboxJulien Nabet
I noticed these 2 points: 1) Combobox were used with autocomplete with default (false) value for matchCase => so initialize autocomplete with true value for matchCase 2) FindMatchingEntry uses bLazy as !matchCase but when bLazy = false, no autocomplete can work since you must type the whole word so just use "entryCombo" startsWith "typed string" instead of "entryCombo" == "typed string" (thank you Lionel for this tip: http://nabble.documentfoundation.org/Finding-the-right-location-for-tdf-67990-Base-module-td4143324.html) Change-Id: Ib1063002c3284122fd5279f27c1ccbc177bbac7c Reviewed-on: https://gerrit.libreoffice.org/14885 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 76f33f10309b0ee384a75a7a854858b068d60495) Reviewed-on: https://gerrit.libreoffice.org/15021
2015-03-19vcl/text: fix duplicate text in fontwork tdf#81876Pierre-Eric Pelloux-Prayer
Regression introduced by commit 2ba05b4800d6cc322276a6911792363f8eb32051 because space character will take the error code path. The error propagates up to GetTextOutlines which then uses the fallback method. In this case, we now reset any work done before, to avoid having duplicate outlines. Change-Id: Ie15524ac462d4b4bb3c482e49c4fe96a2f2d2c71 Reviewed-on: https://gerrit.libreoffice.org/14850 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 162f11cdb94b415ff9d58674e94fb01a745a69eb) Reviewed-on: https://gerrit.libreoffice.org/14899 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2015-03-18fdo#52540, fdo#88051: fix Graphite layoutLászló Németh
The previous fixes were incomplete solutions (see the new test cases of the bug reports). Change-Id: I928f09d94edf68d268de9046c16582e6f016d561 Reviewed-on: https://gerrit.libreoffice.org/14880 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-03-09Resolves: fdo#86493 Fix crash while scaling large bitmaps.Ashod Nakashian
Fast bitmap scaling overflowed the LUT used by the nearest-neighbor algorithm. When a bitmap has 46k pixel on a side and is enlarged, the scaling code overflows the 32-bit long, resulting in negative indexes, which then segfaults. This isn't as rare as it sounds. At least in web-view in writer the border/shadow bitmap is as long as the document (which is an issue in its own right,) which can overflow for large documents during scaling and segfault. Reviewed-on: https://gerrit.libreoffice.org/14597 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit c91bfb9ac7d110c5dca0ea34ec0e1668a985b34c) Change-Id: I1ccf73d02469f6601a9a7e67b30524cb497cf6bc Reviewed-on: https://gerrit.libreoffice.org/14809 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-03-09tdf#84102: Expose XAccessibleExtendedAttributes through ATKJacobo Aragunde Pérez
Those attributes contain a lot of interesting properties, among them the heading level which fixes this bug. Change-Id: I634ef404123cb1b2831563b9b186db4b7e9e7d8b (cherry picked from commit 1e6515e64cb4a40071e09d5df000a94f96311ea1) Reviewed-on: https://gerrit.libreoffice.org/14807 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-03-05tdf#89482 - return size of system virtual device resource at construction.Michael Meeks
Reviewed-on: https://gerrit.libreoffice.org/14678 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com> Conflicts: vcl/inc/win/salinst.h Change-Id: I832a5626b52935180f24857e56297840667eec2a Reviewed-on: https://gerrit.libreoffice.org/14679 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-03-02in BITFIELDS mode (3) there are *3* pal entries not 12Caolán McNamara
There are 12 *bytes*, which presumably is the thinko there. But this nPalCount gets multiplied by 4 to convert it to bytes later. This is the source of the bad mask values found after "Use the cairo-compatible basebmp surface for headless" etc. Arbitrary values ended up being read as mask values. Change-Id: If5d93f74b1c58d3ecdb5186f93cb0215a556586a (cherry picked from commit 5e5b90c12862b522a4553337fbf6309bb8278b8c) Reviewed-on: https://gerrit.libreoffice.org/14659 Tested-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-02-27tdf#89666: vcl: speed up HbLayoutEngine line layout for large paragraphsMichael Stahl
When formatting a 180k char Writer paragraph, most of the time is spent in vcl::ScriptRun::next(), which is called twice per line from SwTxtGuess::Guess(), once via GetTxtBreak() and once via GetTxtSize(). In the second call, from GetTxtSize(), the end position of the line is known, and passed to vcl, and iterating beyond that position seems pointless. This reduces vcl::ScriptRun::next() from 24 to 11 billion callgrind cycles when built with GCC 4.9.2 -m32 -Os. Change-Id: Ia23fcccaf5ef9c9ecdcb54bfc8f0f8a043c8711e (cherry picked from commit 7fde44c85620f8079bc4863fe3f7ea1f69a0f88c) Reviewed-on: https://gerrit.libreoffice.org/14646 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-02-17Resolves: tdf#86159 floating windows have complicated bordersCaolán McNamara
take the border window dimensions into account on the layout size, but not the layout position (cherry picked from commit d1f38b47c29ef5e2db2cabeb657668637d97e13d) Conflicts: include/vcl/syswin.hxx Change-Id: I9deb722933e325c92e93ae917fa8e34eaccfca2d Reviewed-on: https://gerrit.libreoffice.org/14480 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-02-12Resolves: tdf#87663 update checker tries to add icon to toc preview toolbarCaolán McNamara
i.e. CRASH when attempting to add ToC to document if the updatechecker fires while this dialog is activating/active because the preview has hidden menubars which have no associated window Change-Id: I45a254dba647910d7743f6d8173c2547dd82c791 (cherry picked from commit c6b40488c07149a2fcc8023dce4e9efb9e2fdf89) Reviewed-on: https://gerrit.libreoffice.org/14445 Reviewed-by: Eike Rathke <erack@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-02-12Resolves: tdf#89252 Fix bold, regular font spacing bug for Graphite fontsMartin Hosken
Change-Id: I31a09fa753ed15e302e5407ce8a0c46f3b13e099 Reviewed-on: https://gerrit.libreoffice.org/14380 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 0ed14401925d16932ed98bc418d395adac047b39) Reviewed-on: https://gerrit.libreoffice.org/14440
2015-02-09tdf#88836: UI: in-form navigation bar icons goneZolnai Tamás
Regression from: 6419c745e5e9802da264250d5e131fb9a3b6e4de Revert it and use IsEmpty() instead of operator!(). (cherry picked from commit 905d4db48a0b98f540c8abc3e12fb80be4826029) Conflicts: vcl/source/gdi/impgraph.cxx Change-Id: Icc4f5dbba848a1d4ef807e598f0aa3b940459c82 Reviewed-on: https://gerrit.libreoffice.org/14357 Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2015-02-06Resolves tdf#89129: crash when defining a specific relationshipJulien Nabet
Returns early if comparison matches so you can reduce iterator scope and avoid last test for logging. Cherry-picked from 30f6ec7cfdf63cea265148bbe3a07d8df34e96d5 /usr/include/c++/4.9/debug/safe_iterator.h:168:error: attempt to copy- construct an iterator from a singular iterator. Objects involved in the operation: iterator "this" @ 0x0x7fffffff3a30 { type = N11__gnu_debug14_Safe_iteratorIN9__gnu_cxx17__normal_iteratorIPPvNSt9__cxx19986vectorIS3_SaIS3_EEEEENSt7__debug6vectorIS3_S7_EEEE (mutable iterator); state = past-the-end; references sequence with type `NSt7__debug6vectorIPvSaIS1_EEE' @ 0x0x7fffffff4088 } iterator "other" @ 0x0x7fffffff3a90 { type = N11__gnu_debug14_Safe_iteratorIN9__gnu_cxx17__normal_iteratorIPPvNSt9__cxx19986vectorIS3_SaIS3_EEEEENSt7__debug6vectorIS3_S7_EEEE (mutable iterator); state = singular; references sequence with type `NSt7__debug6vectorIPvSaIS1_EEE' @ 0x0x7fffffff4088 } 4 0x00002aaab193d6e9 in boost::void_ptr_iterator<__gnu_debug::_Safe_iterator<__gnu_cxx::__normal_iterator<void**, std::__cxx1998::vector<void*, std::allocator<void*> > >, std::__debug::vector<void*, std::allocator<void*> > >, ImplBtnDlgItem>::base (this=0x7fffffff3a90) at /home/julien/compile-libreoffice/libreoffice/workdir/UnpackedTarball/boost/boost/ptr_container/detail/void_ptr_iterator.hpp:121 5 0x00002aaab193d269 in boost::operator==<__gnu_debug::_Safe_iterator<__gnu_cxx::__normal_iterator<void**, std::__cxx1998::vector<void*, std::allocator<void*> > >, std::__debug::vector<void*, std::allocator<void*> > >, ImplBtnDlgItem, __gnu_debug::_Safe_iterator<__gnu_cxx::__normal_iterator<void**, std::__cxx1998::vector<void*, std::allocator<void*> > >, std::__debug::vector<void*, std::allocator<void*> > >, ImplBtnDlgItem> (l=..., r=...) at /home/julien/compile-libreoffice/libreoffice/workdir/UnpackedTarball/boost/boost/ptr_container/detail/void_ptr_iterator.hpp:179 6 0x00002aaab193c2ca in ButtonDialog::RemoveButton (this=0x7fffffff3d90, nId=1) at /home/julien/compile-libreoffice/libreoffice/vcl/source/window/btndlg.cxx:340 7 0x00002aaad8ed109b in dbaui::ORelationTableView::lookForUiActivities (this=0x317ef30) at /home/julien/compile-libreoffice/libreoffice/dbaccess/source/ui/relationdesign/RelationTableView.cxx:342 Change-Id: Ied45c222c94d2a362075a3b1550b6092aad77c62 Reviewed-on: https://gerrit.libreoffice.org/14325 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu> Reviewed-on: https://gerrit.libreoffice.org/14348
2015-02-03tdf#88051 fix Graphite layout at Linux Libertine G ligature followed by tabLászló Németh
Change-Id: Iecedb87f6329c1cddcaa4cd939b349924e58d256 Reviewed-on: https://gerrit.libreoffice.org/14200 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-02-03Resolves: fdo#87639 Image-filter Smooth crashesCaolán McNamara
regression from commit 10e77ab3ff6f4314137acd6e2702a6e5c1ce1fae Author: Thorsten Behrens <thb@documentfoundation.org> Date: Sun Nov 2 22:37:32 2014 +0100 coverity#1242508: swapped arguments rename the variables to indicate which are source and which are dest indexes and that the aNewBitmap argument is always, and assert that it must be, of equivalent rotated source to the Bitmap which has ImplConvolutionPass called on it. Change-Id: If9715b9f29655da66c6981c0f7cab3d89c528ed7 (cherry picked from commit 4b9ecfd4f45501e4696f966c714fc2bcc43ce38b) Reviewed-on: https://gerrit.libreoffice.org/14115 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-30rhbz#1177022: vcl: fix PDF embedding of Type 1 fontsMichael Stahl
Problem is that for the "CM Typewriter" font the Width for "space" (32) is exported as 0 instead of 525, which is the correct value in the AFM. The reason is that PDFWriterImpl::emitEmbeddedFont() has various arrays to map from font code points to Unicode code points, and there are duplicate mappings, so the 160->32 mapping overrides 32->32. The PrintFontManager::PrintFont::readAfmMetrics() actually creates a Unicode to font code mapping (which may legitimately be n:1) that is then inverted; add an additional hack to store a set of "preferred" Unicodes so that PDFWriterImpl can pick the right Unicode. Presumably the code that is stored explicitly via "C" or "CH" in the AFM should take priority over more generic mappings. (cherry picked from commit 5183910a90e97cafc3cfaaad40acdaec0b792f6d) Conflicts: vcl/inc/cairotextrender.hxx vcl/inc/textrender.hxx vcl/inc/unx/salgdi.h vcl/source/gdi/pdfwriter_impl.cxx Change-Id: Id4205a1cd45ba6a0a5facee1e39f70c3535e7dd4 Reviewed-on: https://gerrit.libreoffice.org/14205 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-28when drawing a transformed bitmap in opengl backend, scale it betterLuboš Luňák
The plain scaling is rather rough, and in fact drawing a scaled bitmap the normal way gives much better results (because OutputDevice pre-scales the bitmap before it's drawn). This one may be a bit slow perhaps, but hopefully nobody there's no code that'd extensively use bitmap drawing with custom transformations (wishful thinking). Change-Id: I83e05307adfaeac0ed0757f1a0b2603f64caf8f8 Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2015-01-28make it possible to easily have variants of glsl programsLuboš Luňák
Now it's possible to add a preamble to the compiled program, so there can be just one program with #ifdef's inside and the small variants can be selected using #define in the preamble instead of having several almost identical programs. Change-Id: I6c5112313b91b6269ebdecdfc896e0f96209ea2b Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2015-01-28prefer ptr_container to manual memory managementMarkus Mohrhard
Signed-off-by: Michael Meeks <michael.meeks@collabora.com> Conflicts: vcl/source/opengl/OpenGLContext.cxx Change-Id: I11326c2873aad5116fd70bfa31eb94e93fef3f40
2015-01-28some debug code for finding leaked OpenGLContextsMarkus Mohrhard
Change-Id: I10e8c344ae6aa2e0a4ef562154f57e2070c70e2f Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2015-01-28Apply GLSL patch for areaScaleFragmentShaderChris Sherlock
Thanks to Lubos Lunak Change-Id: I9bb72e1a5b11102963481dac7c11ab4a9fe90b0b Signed-off-by: Chris Sherlock <chris.sherlock79@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/14095 Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2015-01-28there's no bigger or smaller halfLuboš Luňák
Change-Id: Ida0e92abd806d017d17365fa2ac53b4f7cb2ebad Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2015-01-28draw polypolygon outline properly (if wanted)Luboš Luňák
Again, polygons can apparently have curved edges. Change-Id: I6519da7bb7f0dde7f1550fe6b03c09be127f77d6 Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2015-01-27don't strip font names of apparent script suffixes anymoreCaolán McNamara
e.g. "CM Roman CE" should be left alone. bump font cache id to invalidate old cached lists I think this practice stems from Window 3.1/Word 95 where the encoding was included in the font name http://www.webcenter.ru/~kazarn/eng/fonts_ttf.htm#charsettbl Microsoft Office still generates RTF files with weird-ass Win 3.1 style fontnames but any actual existing fonts that happen to have names that fall into that pattern should be left alone now. Change-Id: Ibb704048d63b33ce510d6b1076700c6e94a0af2a (cherry picked from commit 15e1c881684c0127c0ca989924bbf2508b4fd780) Reviewed-on: https://gerrit.libreoffice.org/14210 Tested-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-01-27Resolves: rhbz#1177022 no width set on space glyph with CM Typewriter fontsCaolán McNamara
Change-Id: I0dfb044b8a339fa6c473e42f31fc28c200cd03ea (cherry picked from commit 37dc4bdbf25847c95f1668553dbae3e2dc885816) Reviewed-on: https://gerrit.libreoffice.org/14204 Tested-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-01-27font cache gets broken on adding an embedded fontCaolán McNamara
Change-Id: I665cde5d4c89443238efb283c86277dedf621197 (cherry picked from commit 20142afafc809890d5e8dcfd4103c46319a488df) Reviewed-on: https://gerrit.libreoffice.org/14045 Tested-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-01-27Resolves: tdf#88819 printing with ps hangsCaolán McNamara
regression from commit bbf3aa7f92c194c9cc4546c95706e6b28e0c070c Author: Caolán McNamara <caolanm@redhat.com> Date: Fri Nov 14 11:06:44 2014 +0000 coverity#705989 silence Insecure temporary file and coverity#705983 Insecure temporary file Change-Id: If580196322e68098adc38a9fdb775827843a9c30 Reviewed-on: https://gerrit.libreoffice.org/14202 Tested-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-01-23calling alloca() requires #include <sal/alloca.h>Michael Stahl
Change-Id: I59e5ede0c0cfb10f4196d79ae762132ae4ecb9bb (cherry picked from commit 91567c26f436ccce0fb60ad6a9671f046a4a68e7) Reviewed-on: https://gerrit.libreoffice.org/14125 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-21do not draw with SALCOLOR_NONELuboš Luňák
Change-Id: I882a42f58ac298d333985068b2fe6ef9ac198c8b Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2015-01-20accidentally ran make with VALGRIND set and walked away...Caolán McNamara
and found this bug triggered by CppunitTest_filter_eps_test when I got back Change-Id: I20943e5bd0fbf8aed923699dd5f1e88fada43e81 (cherry picked from commit 6cf58a33676cebc9f2c1d26163793ba7dce46262) Reviewed-on: https://gerrit.libreoffice.org/14044 Tested-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-01-20Fix Windows build (typo: VENT_COMMAND instead of EVENT_COMMAND)László Németh
Change-Id: I31ba4b911dfc0acbcc4dece80bb5ed8bedb4cd54 Reviewed-on: https://gerrit.libreoffice.org/14048 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-19Resolves: fdo#32664 pass keyboard media keys through to the OSCaolán McNamara
if we didn't make use of them. (cherry picked from commit 508c020cf5f7999f0c23d972133f9b6bf85de245) Conflicts: sw/source/uibase/docvw/edtwin.cxx vcl/osx/salinst.cxx vcl/win/source/window/salframe.cxx Change-Id: Iee1c2fef5966a614b068c832bf8c6b51973b4c8a Reviewed-on: https://gerrit.libreoffice.org/13993 Reviewed-by: Eike Rathke <erack@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-19Resolves: fdo#88417 Dropdown for ruler settings should show radio buttonsCaolán McNamara
This reverts commit 9995222d1141b326197a387cc7897b3971ce9e9a and additionally converts the ruler settings to radio buttons and not checkboxes Conflicts: vcl/source/control/tabctrl.cxx Change-Id: Ie0eac5f07729447942065b7f415398165fbf067c (cherry picked from commit 251737f0dd186b0f169f5ba237e1e8c28a320e00) Reviewed-on: https://gerrit.libreoffice.org/14017 Tested-by: David Tardon <dtardon@redhat.com> Reviewed-by: David Tardon <dtardon@redhat.com>
2015-01-19vcl: fix glsl int casts of floats.Michael Meeks
Change-Id: Ifa22e2914a1e34f6e2fd635973eca4101914bb88 Signed-off-by: Jan Holesovsky <kendy@collabora.com>