summaryrefslogtreecommitdiff
path: root/winaccessibility/source/UAccCOM/MAccessible.cxx
AgeCommit message (Collapse)Author
2017-10-27loplugin:includeform: winaccessibility (Windows)Stephan Bergmann
Change-Id: I8b83e650202c2b169803c22a7f94223a180dd48a
2017-10-05Rename and move SAL_U/W to o3tl::toU/WMike Kaganski
Previosly (since commit 9ac98e6e3488e434bf4864ecfb13a121784f640b) it was expected to gradually remove SAL_U/W usage in Windows code by replacing with reinterpret_cast or changing to some bettertypes. But as it's useful to make use of fact that LibreOffice and Windows use compatible representation of strings, this commit puts these functions to a better-suited o3tl, and recommends that the functions be consistently used throughout Windows-specific code to reflect the compatibility and keep the casts safe. Change-Id: I2f7c65606d0e2d0c01a00f08812bb4ab7659c5f6 Reviewed-on: https://gerrit.libreoffice.org/43150 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-10-03Replace more reinterpret_cast with SAL_W/SAL_UMike Kaganski
Change-Id: Ia632e4083222ad9e7f17c2ad0d0825f189c700cc Reviewed-on: https://gerrit.libreoffice.org/43071 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-08-31loplugin:constparams: winaccessibility (clang-cl)Stephan Bergmann
Change-Id: Ic668c1ee6c2dac70642480bc584f962921b428b2
2017-08-17remove UL/L suffixes from integer constants on the RHS of expressionsNoel Grandin
Change-Id: I899a8126c9d971601fea6c77eca165718aea0ac5 Reviewed-on: https://gerrit.libreoffice.org/41237 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-11convert std::map::insert to std::map::emplaceNoel Grandin
which is considerably less verbose Change-Id: Ifa373e8eb09e39bd6c8d3578641610a6055a187b Reviewed-on: https://gerrit.libreoffice.org/40978 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-17loplugin:unnecessaryparen: winaccessibility (clang-cl)Stephan Bergmann
Change-Id: I9d83d16adbccd1dc29ea23dfa012a349c74150a3
2017-05-11Clean up uses of SAL_U/SAL_W: winaccessibilityStephan Bergmann
Change-Id: I8f2abf0d338d01453f273b279e34c882de461b00
2017-04-04Finally switch MSVC to sal_Unicode = char16_t, tooStephan Bergmann
There is lots of (Windows-only) code that relied on sal_Unicode being the same as wchar_t, and the best change may be different in each case (and doing the changes may be somewhat error prone). So for now add SAL_U/SAL_W scaffolding functions to sal/types.h, remove their uses one by one again, and finally drop those functions again. Change-Id: I2cc791bd941d089901abb5f6fc2f05fbc49e65ea Reviewed-on: https://gerrit.libreoffice.org/36077 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-04-03use actual UNO enums in vcl..xmlsecurityNoel Grandin
Change-Id: Id862544f27ebcbe8363f93dc83192d0f0cddb5cc Reviewed-on: https://gerrit.libreoffice.org/36041 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-25Fix typosAndrea Gelmini
Change-Id: I80b6d080aa31ff8b9d043b983993f4d26d8dc87c Reviewed-on: https://gerrit.libreoffice.org/35662 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-02-12Typo: (De)SelectMutipleChidren->(De)SelectMultipleChidrenJulien Nabet
Change-Id: Ia3a998e3629c5e002379e6a85b015b6546c59fb8 Reviewed-on: https://gerrit.libreoffice.org/34156 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-01-11loplugin:externvar (clang-cl)Stephan Bergmann
Change-Id: I0f967f75dc41b3dc65790cf97bdac992033d1c92
2017-01-06loplugin:salboolStephan Bergmann
Change-Id: I7dfd48a04e2dff1391d10acb75180711b403af9b
2016-10-15clang-cl loplugin: winaccessibilityStephan Bergmann
Change-Id: I40f8a6fef9d66b28a1d72551a6873b041b38b09d Reviewed-on: https://gerrit.libreoffice.org/29840 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-14Fix GetMnemonicCharStephan Bergmann
For one, had a (false) occurrence of loplugin:bodynotinblock. For another, would have erroneously reported 'A' instead of 'B' for "~~A~B". Change-Id: I6b2e09ad0d0e132896a9f2802bf4355a25f2d296 Reviewed-on: https://gerrit.libreoffice.org/29808 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-10cppcheck: variableScopeJochen Nitschke
Change-Id: I6c8b7aaedf7fcde5165d3a65af54aa0bcafc0b82 Reviewed-on: https://gerrit.libreoffice.org/29624 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-08-25-Werror,-Wnonportable-include-path (clang-cl)Stephan Bergmann
Change-Id: Ia468adf0bea2f7fca9b370ef0ff8b05e34b3ac19
2016-05-25SAL_FALLTRHOUGH in Windows-only codeStephan Bergmann
Change-Id: If35da46c209746a86687e1c3f60f72f2f08aa681
2016-05-25Harmless missing breakStephan Bergmann
Change-Id: I0e0abfea2f38fdc25077a8c5a9a7d2438cde2362
2016-05-16Fix typosAndrea Gelmini
Change-Id: If7262e114b5b4cd40e9c0a8929940199ea747595 Reviewed-on: https://gerrit.libreoffice.org/25025 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-03-04Silence -Werror,-Wnon-virtual-dtor in generated UAccCOM.h (clang-cl)Stephan Bergmann
Change-Id: I9466931485ed5421be589def16185d5c036bdcb8
2016-02-09Remove excess newlinesChris Sherlock
A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-26-Werror,-Wsign-compare (clang-cl)Stephan Bergmann
Change-Id: I7a3f17e84bbf44a472838ab20b4490f1ef3654d6
2015-11-28Remove unused dataStephan Bergmann
Change-Id: Ica186e36851ebcf0f902e7a2b731b6157e8a50d5
2015-11-28-Werror,-WreorderStephan Bergmann
Change-Id: I86eb0de03c07d527cfd852f41e1969febf8276a6
2015-11-24com::sun::star->css in winaccessibility/Noel Grandin
Change-Id: I644364fc6d8fc334044a3e53fcde24a6ef86c021 Reviewed-on: https://gerrit.libreoffice.org/20142 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-04-01Replace remaining getCppuType et al with cppu::UnoTypeStephan Bergmann
Change-Id: I718cbc10c992b0515d3c4e2a62e38a6331a288d0
2014-05-27Remove unnecessary semicolonsPeter Senna Tschudin
A simplified version of the semantic match that finds this problem is follows: (http://coccinelle.lip6.fr/) // <smpl> @r1@ statement S; position p,p1; @@ S@p1;@p @script:python r2@ p << r1.p; p1 << r1.p1; @@ if p[0].line != p1[0].line_end: cocci.include_match(False) @@ position r1.p; @@ -;@p // </smpl> Change-Id: Ib9708d37fbb4c6060f88d5dae3814a2d37b2091e Reviewed-on: https://gerrit.libreoffice.org/9493 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-05-23Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part20Julien Nabet
Change-Id: If87cdfb2c605254f6d69baa4ca5aec09091caa68
2014-05-22cppcheck: Variable 'dChildIndex,...' is assigned a value that is never usedThomas Arnhold
Change-Id: Ifa4ea7faa4bcf6580f10c8ece15a01d72f2903f3
2014-02-04fdo#39944: Add DOCUMENT_* accessibility UNO rolesJacobo Aragunde Pérez
Added a set of UNO accessibility roles for specific kinds of documents: * DOCUMENT_PRESENTATION for Impress * DOCUMENT_SPREADSHEET for Calc * DOCUMENT_TEXT for Writer The other applications still use the existing DOCUMENT role. These roles translates directly to ATK but in the other toolkits we keep using the same association that DOCUMENT role had. Change-Id: Ibac47527e5effdecb28d2314cde8558cf4fb010a Reviewed-on: https://gerrit.libreoffice.org/7847 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2014-01-31Remove UNOIDL "array" and "union" vaporware remnantsStephan Bergmann
...and deprecate what cannot be removed for compatibility. Change-Id: I1ea335af775b867b468b8285113631167729a92a
2014-01-27Typo decendant => descendant in winaccessibility/MAccessibleJulien Nabet
Change-Id: I2e49ab149b2bbdad623f8694221b6169cdfd2d9a
2014-01-27fdo#73464 - guard against NULL / unset m_xAccessible.Michael Meeks
Change-Id: I3351acf18d334447336ee98761190fdff32d5b85
2014-01-27Resolves: #i124095# Multiple IAccessible and IAccessible2...Steve Yin
interface methods do not check for NULL pointer access, nor do they trap exceptions Fixed by Michael Curran (cherry picked from commit 113171f2a5d726af6c5266e98e8e790ac6729d2d) Conflicts: winaccessibility/source/UAccCOM/MAccessible.cxx Change-Id: I28d4b885a6c2db487c2754c2ca11290b3844570b
2014-01-06Initialize m_containedObjectsSteve Yin
(cherry picked from commit 795b3bb9e59c9bf049d27538c860cd66633dddcf) Change-Id: I45e495ad8b3513613102b7ce7777803303980fbe
2013-12-12winaccessibility: remove some noise from not-implemented methodsMichael Stahl
Change-Id: I8046ae37cba87f0e5df550de831229345df1c6f8
2013-12-12winaccessibility: GetChildInterface may return 0Michael Stahl
Change-Id: I950072d22cd315d1898b76a2c345121d31d432c4
2013-12-12winaccessibility: fix locking in UAccCOMMichael Stahl
The COM components will (usually? always?) be called on the main thread via COM, and may also be called on any thread from the UNO event listeners. Both ways may access the global AccWinObjectManager. So the easiest way to lock all that without introducing new deadlocks seems to be to just use the SolarMutex. The fact that the main thread is in a COM STA is rather irrelevant here since we don't currently do the required manual marshalling of the COM pointers so they can be accessed from UNO event listeners running in threads other than the main thread anyway. To get that to build: - use prewin.h and postwin.h around ATL headers - link UAccCOM against vcl - define both UNICODE and _UNICODE to not break on mis-matching TCHAR nonsense Change-Id: I1ccdf7a4a5c2b5f0b9c29ef39d126c4b8a16898a
2013-12-12winaccessibility: remove CheckEnableAccessible.h and assorted noiseMichael Stahl
Change-Id: I45e1d72b1abf64a965397c50ac3b95b5bbee3206
2013-12-12winaccessibility: InlineIsEqualGUID is defined by guiddef.hMichael Stahl
Change-Id: Ia469076ec6f815133e77a14940e8afa05e177231
2013-12-12winaccessibility: use SAL_N_ELEMENTSMichael Stahl
Change-Id: I479117e0794375f1ec0c96b78db22b3569b456ec
2013-12-12winaccessibility: clean up the AGGMAP in CMAccessibleMichael Stahl
Replace it with a map for the new direct C++ instantiation and move this implementation detail to the cxx file. Change-Id: Ia961da03f8eb899481cf02f430c921aa8abd7c5c
2013-12-02winaccessibility: fix my stupid mistake in createAggInstanceMichael Stahl
Change-Id: I7701021befcf1dbad85557c2095fe4bf0b4e0ff1
2013-11-28winaccessibility: remove obsolete act.hxxMichael Stahl
... obsoleted by 732ec36edfd09d2091d70c4d71b5f182fe279c45 Change-Id: I7f7a9becac2430a7ed4d096be741b610462a8a00
2013-11-25winaccessibility: replace CoCreateInstance with direct instantiationMichael Stahl
This is an alternative (to 732ec36edfd09d2091d70c4d71b5f182fe279c45) solution to the "CoCreateInstance does not work" problem: replace all CoCreateInstance calls with equivalent calls to create the components directly. Since the only reason why this COM stuff needs to be registered at all is that AccObject uses CoCreateInstance() to create its COM objects, another possible solution appears to be to simply link the libraries and instantiate the COM objects directly, without COM. The only difference appears to be that CoCreateInstance would automatically add proxy objects in case the COM objects reside in a single-threaded appartment; not sure if that is relevant here. Change-Id: I8ffb8af501f6084f3145fa4d4f53366a070e1691 Reviewed-on: https://gerrit.libreoffice.org/6792 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2013-11-24winaccessibility: make XAccessibleAction member ReferenceMichael Stahl
Maybe it would be kept alive by AccObject::m_AccActionRef but why not play it safe. Change-Id: I03c2be04e97dcde8a177ef8dfd0d75595ab13a53
2013-11-24winaccessibility: CMAccessible needs only one XAccessibleContextMichael Stahl
Merge aliases pRContextInterface (unused) and pRContext; this is exacerbated by countless local variables pRContext that shadow the member... Change-Id: I6bc71911fb41a2ce2590d614020ecea36d6ab4f8
2013-11-24winaccessibility: CMAccessible needs only one member for XAccessibleMichael Stahl
Merge aliases pUNOInterface and pRef; also pAchorUNOInterface is never used. Change-Id: I1b3841a9aca9d2438b25c66c7f67d09ce13b41f9
generated by cgit (git 2.34.1) at 2024-08-07 21:26:45 +0000