summaryrefslogtreecommitdiff
path: root/winaccessibility/source/UAccCOM
AgeCommit message (Collapse)Author
2018-11-01clang-tidy: (WIP) bugprone-too-small-loop-variable findingsTamás Zolnai
Change-Id: Iaa255b39928ac45dec1ed37e368c149d6027f561 Reviewed-on: https://gerrit.libreoffice.org/62701 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-10-24remove more rtl::OUString and OString prefixesNoel Grandin
which seem to have snuck back in since the great rounds of removals. Change-Id: I85f7f5f4801c0b48dae8b50f51f83595b286d6a1 Reviewed-on: https://gerrit.libreoffice.org/62229 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-20dubious SysAllocString checkCaolán McNamara
Change-Id: I1aece8321b12351b5e8a2d5c33e513531cbc95a1 Reviewed-on: https://gerrit.libreoffice.org/62007 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-20tdf#120703 (PVS)Mike Kaganski
V745 A 'wchar_t *' type string is incorrectly converted to 'BSTR' type string. Consider using 'SysAllocString' function. V560 A part of conditional expression is always false: !ppdispParent. V595 The 'm_pIParent' pointer was utilized before it was verified against nullptr. Check lines: 673, 675. V745 A 'wchar_t *' type string is incorrectly converted to 'BSTR' type string. Consider using 'SysAllocString' function. V530 The return value of function 'SysAllocString' is required to be utilized. V1032 The pointer '& pChildXAcc' is cast to a more strictly aligned pointer type. V512 A call of the 'GetUNOInterface' function will lead to overflow of the buffer '& pChildXAcc'. V547 Expression 'pSeq' is always true. V547 Expression 'pChild' is always true. V512 A call of the 'GetUNOInterface' function will lead to overflow of the buffer '& pTempUNO'. V1032 The pointer '& pTempUNO' is cast to a more strictly aligned pointer type. V716 Suspicious type conversion in return statement: returned HRESULT, but function actually returns BOOL. Change-Id: I2185992dad0127144416783e25476d05c0365b74 Reviewed-on: https://gerrit.libreoffice.org/62075 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-20pvs-studio: 'memcpy' function will lead to underflow of the bufferCaolán McNamara
Change-Id: I285d5ddcc8906d1e38c6b58c625dc7c894ad433a Reviewed-on: https://gerrit.libreoffice.org/62064 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-20alloc should have been freeCaolán McNamara
Change-Id: I325a815ff17446bc389f889a028f5e2ced57d7e7 Reviewed-on: https://gerrit.libreoffice.org/62008 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-02Move GetkeyBindingStrByXkeyBinding to comphelperSamuel Mehrbrodt
So that it is available to other a11y implementations as well Change-Id: Ib82c4861cf9e0e90c64703b13c46548a080ffd10 Reviewed-on: https://gerrit.libreoffice.org/61198 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-10-02Remove unused getOLECHARFromKeyCodeSamuel Mehrbrodt
Change-Id: Idacfeff59f8578c5be72cb1de25447d6e147c975 Reviewed-on: https://gerrit.libreoffice.org/61197 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-09-24loplugin:external (clang-cl)Stephan Bergmann
Including: * expanding STDAPI to its definition (as per <https://msdn.microsoft.com/library/ms686631(vs.85).aspx> "STDAPI"), to add __declspec(dllexport) into its middle, in extensions/source/activex/so_activex.cxx; as discussed in the comments at <https://gerrit.libreoffice.org/#/c/60691/> "Get rid of Windows .def files in setup_native, use __declspec(dllexport)", having a function both listed in a .def file EXPORTS and marking it dllexport is OK, and the latter helps the heuristics of loplugin:external; however, the relevant functions in extensions/source/activex/so_activex.cxx probably don't even need to be exported in the first place? * follow-up loplugin:salcall in sal/osl/w32/file-impl.hxx Change-Id: Ida6e17eba19cfa3d7e5c72dda57409005c0a0191 Reviewed-on: https://gerrit.libreoffice.org/60938 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-17loplugin:simplifyconstruct (clang-cl)Stephan Bergmann
Change-Id: I7cae6b3f31b10efc72884bce4bda7bf6b380cbc2 Reviewed-on: https://gerrit.libreoffice.org/60597 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-03-13winaccessibility: GraphicURL is not set anymoreTomaž Vajngerl
Change-Id: I87dd8abcf52dac0c92936fe71b905ed6dd1beefd Reviewed-on: https://gerrit.libreoffice.org/51108 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-01-23More loplugin:cstylecast on WindowsStephan Bergmann
Automatic rewrite (of loplugin:cstylecast and loplugin:unnecessaryparen) after cab0427cadddb3aaf1349c66f2fa13a4234ba4b2 "Enable loplugin:cstylecast for some more cases" and a409d32e7f6fc09e041079d6dbc3c927497adfed "More loplugin:cstylecast" Change-Id: Ib3355159dd08333e1b7a8d091caf2069cdcc7862 Reviewed-on: https://gerrit.libreoffice.org/48317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-17Fix typosAndrea Gelmini
Change-Id: I5fff9ccb1bc74b85ee378439ffa2272583ffcb0f Reviewed-on: https://gerrit.libreoffice.org/48024 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-11-29loplugin:unnecessaryparen (clang-cl)Stephan Bergmann
Change-Id: I3a2b7ed3fdef3b77c0a052b10f88918aa616779e Reviewed-on: https://gerrit.libreoffice.org/45469 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-10-27loplugin:includeform: winaccessibility (Windows)Stephan Bergmann
Change-Id: I8b83e650202c2b169803c22a7f94223a180dd48a
2017-10-05Rename and move SAL_U/W to o3tl::toU/WMike Kaganski
Previosly (since commit 9ac98e6e3488e434bf4864ecfb13a121784f640b) it was expected to gradually remove SAL_U/W usage in Windows code by replacing with reinterpret_cast or changing to some bettertypes. But as it's useful to make use of fact that LibreOffice and Windows use compatible representation of strings, this commit puts these functions to a better-suited o3tl, and recommends that the functions be consistently used throughout Windows-specific code to reflect the compatibility and keep the casts safe. Change-Id: I2f7c65606d0e2d0c01a00f08812bb4ab7659c5f6 Reviewed-on: https://gerrit.libreoffice.org/43150 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-10-03Replace more reinterpret_cast with SAL_W/SAL_UMike Kaganski
Change-Id: Ia632e4083222ad9e7f17c2ad0d0825f189c700cc Reviewed-on: https://gerrit.libreoffice.org/43071 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-09-30Use SAL_W/SAL_U instead of reinterpret_cast btwn wchar_t* and sal_Unicode*Mike Kaganski
This is type-safe, and allows to catch cases where a source type is changed for some reason, but reinterpret_cast masks that Change-Id: Ib64b6fa2e22d94a6bba890f0ccc3e20325c6f0a1 Reviewed-on: https://gerrit.libreoffice.org/42961 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-09-18Use even more WIN32_LEAN_AND_MEANMike Kaganski
Change-Id: I538fe5b41156366e0e87b3a93e58a3947afd18f5 Reviewed-on: https://gerrit.libreoffice.org/42398 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-08-31loplugin:constparams: winaccessibility (clang-cl)Stephan Bergmann
Change-Id: Ic668c1ee6c2dac70642480bc584f962921b428b2
2017-08-17remove UL/L suffixes from integer constants on the RHS of expressionsNoel Grandin
Change-Id: I899a8126c9d971601fea6c77eca165718aea0ac5 Reviewed-on: https://gerrit.libreoffice.org/41237 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-11convert std::map::insert to std::map::emplaceNoel Grandin
which is considerably less verbose Change-Id: Ifa373e8eb09e39bd6c8d3578641610a6055a187b Reviewed-on: https://gerrit.libreoffice.org/40978 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-17loplugin:unnecessaryparen: winaccessibility (clang-cl)Stephan Bergmann
Change-Id: I9d83d16adbccd1dc29ea23dfa012a349c74150a3
2017-07-11simplify calls OUString::copy in foo.copy(x, foo.getLength() - x)Noel Grandin
Change-Id: I20318c77dcc3bc2a64336541ef5a3f412bfd9483 Reviewed-on: https://gerrit.libreoffice.org/39803 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-03loplugin:oncevar (clang-cl): winaccessibilityStephan Bergmann
Change-Id: I26dca32ba03c7fe163886ebcd4a6a8bc4871b065
2017-05-11Clean up uses of SAL_U/SAL_W: winaccessibilityStephan Bergmann
Change-Id: I8f2abf0d338d01453f273b279e34c882de461b00
2017-04-06Use OUString function variants that take a (narrow) string literalStephan Bergmann
...instead of going via an OUString temporary created from a char16_t string literal Change-Id: I9bdc1fe5e92988fbe227534a183c0c5a86ebc2a1
2017-04-04Finally switch MSVC to sal_Unicode = char16_t, tooStephan Bergmann
There is lots of (Windows-only) code that relied on sal_Unicode being the same as wchar_t, and the best change may be different in each case (and doing the changes may be somewhat error prone). So for now add SAL_U/SAL_W scaffolding functions to sal/types.h, remove their uses one by one again, and finally drop those functions again. Change-Id: I2cc791bd941d089901abb5f6fc2f05fbc49e65ea Reviewed-on: https://gerrit.libreoffice.org/36077 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-04-04loplugin:redundantcast (clang-cl)Stephan Bergmann
Change-Id: Ie096d75c1bc774e77c589845f61276d1478234ef Reviewed-on: https://gerrit.libreoffice.org/36065 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-04-04loplugin:redundantinline (clang-cl)Stephan Bergmann
Change-Id: I03a19b599005f6ef25040889a1e1802445ebf430 Reviewed-on: https://gerrit.libreoffice.org/36063 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-04-03use actual UNO enums in vcl..xmlsecurityNoel Grandin
Change-Id: Id862544f27ebcbe8363f93dc83192d0f0cddb5cc Reviewed-on: https://gerrit.libreoffice.org/36041 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-25Fix typosAndrea Gelmini
Change-Id: I80b6d080aa31ff8b9d043b983993f4d26d8dc87c Reviewed-on: https://gerrit.libreoffice.org/35662 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-15loplugin:unncessaryoverride (clang-cl)Stephan Bergmann
Change-Id: Id2b5cd255188e32216d1dd79f3dc5c4f08eb9373
2017-03-06drop various _MSC_VER < 1900 conditionalsCaolán McNamara
Change-Id: I68d93b260db1f542bb3b44858b61b2d30ae93530 Reviewed-on: https://gerrit.libreoffice.org/34856 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-02-12Typo: (De)SelectMutipleChidren->(De)SelectMultipleChidrenJulien Nabet
Change-Id: Ia3a998e3629c5e002379e6a85b015b6546c59fb8 Reviewed-on: https://gerrit.libreoffice.org/34156 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-01-11loplugin:externvar (clang-cl)Stephan Bergmann
Change-Id: I0f967f75dc41b3dc65790cf97bdac992033d1c92
2017-01-06loplugin:salboolStephan Bergmann
Change-Id: I7dfd48a04e2dff1391d10acb75180711b403af9b
2016-10-15clang-cl loplugin: winaccessibilityStephan Bergmann
Change-Id: I40f8a6fef9d66b28a1d72551a6873b041b38b09d Reviewed-on: https://gerrit.libreoffice.org/29840 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-14Fix GetMnemonicCharStephan Bergmann
For one, had a (false) occurrence of loplugin:bodynotinblock. For another, would have erroneously reported 'A' instead of 'B' for "~~A~B". Change-Id: I6b2e09ad0d0e132896a9f2802bf4355a25f2d296 Reviewed-on: https://gerrit.libreoffice.org/29808 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-11cppcheck: uninitMemberVarJochen Nitschke
Change-Id: I4ff6d15941bf561ed67d84e4bda532131c8c7a43 Reviewed-on: https://gerrit.libreoffice.org/29622 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-10cppcheck: variableScopeJochen Nitschke
Change-Id: I6c8b7aaedf7fcde5165d3a65af54aa0bcafc0b82 Reviewed-on: https://gerrit.libreoffice.org/29624 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-02cppcheck invalidPrintfArgTypeJochen Nitschke
signedness and long vs int corrections Change-Id: I67c6b9e05b16f5d8d4693879f1656db50dc7ec48 Reviewed-on: https://gerrit.libreoffice.org/29355 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-08-25-Werror,-Wnonportable-include-path (clang-cl)Stephan Bergmann
Change-Id: Ia468adf0bea2f7fca9b370ef0ff8b05e34b3ac19
2016-05-25SAL_FALLTRHOUGH in Windows-only codeStephan Bergmann
Change-Id: If35da46c209746a86687e1c3f60f72f2f08aa681
2016-05-25Harmless missing breakStephan Bergmann
Change-Id: I0e0abfea2f38fdc25077a8c5a9a7d2438cde2362
2016-05-24remove unused struct memberJochen Nitschke
TYPE_BSTR_MAP.type was never used, this makes struct obsolete. replace magic numbers with constants Change-Id: Ifbe236c102f78cc570401254dda2fba9bb2c2a95 Reviewed-on: https://gerrit.libreoffice.org/25228 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-05-16Fix typosAndrea Gelmini
Change-Id: If7262e114b5b4cd40e9c0a8929940199ea747595 Reviewed-on: https://gerrit.libreoffice.org/25025 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-05-04Fix Windows-only code, part 5Stephan Bergmann
Change-Id: I1e51996d1035624b373dc5d27a7528f8351e0934
2016-05-04Fix Windows-only code, part 4Stephan Bergmann
Change-Id: Idf3f8c24a61973068f5354873d25dc2317fbb732
2016-03-04-Werror,-WshadowStephan Bergmann
Looks odd that this isGet block is a perfect copy of what is already done before this else-if block, but I have no insight at all into that code, so just leave it at that. Change-Id: Ieefd6618cb6b0dc49bc4d2c4733b02be2a8e3f7e
generated by cgit (git 2.34.1) at 2025-02-11 02:20:39 +0000