Age | Commit message (Collapse) | Author |
|
The web wizard runs some XSLT over the exported file. It registers
a handler that is called when the output stream is closed, and this
Process.streamClosedHandler() calls terminate(), which causes the
deadlock, because it wants to join() the extra XSLT thread but the
handler is actually called from the XSLT thread itself.
Fix that by moving the terminate() to another function that runs in the
main thread.
It does not deadlock on Unixes because osl_joinWithThread() actually
detects an attempt to join the calling thread and returns early.
Change-Id: Ia176562fa28b97c7e8956c1e8975c9aa6ee23236
|
|
Change-Id: I9888f8ab7bccdd2902d619487279999f2ff9ab13
|
|
Change-Id: I3afde8e7f8b0b88e8f1a5d1ad71429c2aa7d7a94
|
|
The hard-coded "/" separator causes getFileURLFromSystemPath to fail,
and it's not obvious why the URL is being converted to a system path
in the first place.
Change-Id: I06ebe6d92954c4f3c884ae6f0b327ea8a36c10a4
|
|
Change-Id: I5187364d420ab78c36a91632efab9c32951d867a
|
|
Change-Id: I52cbaad71560d73f5e24f3de3cd62b00d678dd6c
Reviewed-on: https://gerrit.libreoffice.org/17187
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
Fixes
Traceback (most recent call last):
File "/home/laci/m/bibisect/lo-linux-dbgutil-daily/opt/program/wizards/web/WWD_Events.py", line 249, in addDocument
oLoadDocs = self.LoadDocs(self.xMSF, self.xUnoDialog, files, self)
TypeError: __init__() missing 1 required positional argument: 'parent_'
and:
Traceback (most recent call last):
File "/home/julien/compile-libreoffice/libreoffice/instdir/program/wizards/web/WWD_Events.py", line 252, in addDocument
oLoadDocs.loadDocuments()
File "/home/julien/compile-libreoffice/libreoffice/instdir/program/wizards/web/WWD_Events.py", line 934, in loadDocuments
doc.cp_URL = FileAccess.connectURLs(files[0], self.files[i])
NameError: global name 'files' is not defined
Change-Id: I737117a6981e541f12453bb9d9b2680f5fb79142
Reviewed-on: https://gerrit.libreoffice.org/16756
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I020c7ce4d9aa93cb0292378a410cdb9f7788e920
Signed-off-by: Michael Stahl <mstahl@redhat.com>
|
|
Change-Id: I564b4df26c45c035f455ecf6db573b25c5eb4699
|
|
Change-Id: I98b4dfb0f72f315065693335e2f882bb2eed3afe
Reviewed-on: https://gerrit.libreoffice.org/16713
Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
|
|
Change-Id: I9dcc0ce882dfd533d98a4f71625bb85e44084283
|
|
Change-Id: I80995af6459af9f647e66d1c85da2eedad2647b9
Reviewed-on: https://gerrit.libreoffice.org/16523
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: Ifd126a535f18db79a18aaec61b76cdf26ab33dff
Reviewed-on: https://gerrit.libreoffice.org/16522
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I60ed5eb658d50cbc7dc572facb5463b7527b4d9b
Reviewed-on: https://gerrit.libreoffice.org/16408
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
|
|
this is the canonical order, and it makes the code easier to read
Change-Id: I272e7f1e140296e582702b6dbf77a03eefb65470
Reviewed-on: https://gerrit.libreoffice.org/16242
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: David Ostrovsky <david@ostrovsky.org>
|
|
Change-Id: I0e74d800593245fa00013035c9498b77988b072b
|
|
Change-Id: Ifaa52b49b717d893846fc1e7ae4ac50735f824ac
Reviewed-on: https://gerrit.libreoffice.org/16260
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
|
|
Change-Id: I21c352a63d668c174eef212dbfbe6346c678ce4d
|
|
Make the order be 'public static' or 'private static'
Just makes the code nicer to read.
Change-Id: I182424bda45a2d68642e5d04c6091d268ace1fe2
Reviewed-on: https://gerrit.libreoffice.org/16202
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
the file name widget is empty when it shouldn't be.
the other wizards get this right
Change-Id: Icdb629e676a73fcf8d8be4352818abbef455bbaf
|
|
Change-Id: If1cdc67535b11d9309503b14ffad2aa3718661c6
|
|
Change-Id: I22a5b9fa29d465a21e682279e6e88d37bd8adf93
|
|
Change-Id: Ifa031a872bd618c41b0fbb2e0fd5a17e0f7b0a53
|
|
...to match what is recorded in the .component files
Change-Id: Ie548cd37872d3b8540222201afaac73040e65c8f
|
|
Change-Id: I1579c4a79f8806d4580b282737e829462361af98
|
|
Change-Id: I5e938a0b53ea7a1b020bc73634bff70913f3ebc3
|
|
found with
$ git grep -lP 'return\s*\(\s*\w+\s*\)\s*;'
Change-Id: Ic51606877a9edcadeb647c5bf17bc928b69ab60e
|
|
Change-Id: I61d6a92e5301e07c9180d94dafec23ef1a06e0ef
|
|
Change-Id: I5b8958561375690dcf81b9fc1bb8e7b4904e0cb0
|
|
Change-Id: I2bdde7524a97039c94a8da5ac5d2eba38c91d71a
|
|
Change-Id: Ie5d18aa59885172bd701ddcfb0e62f5ad3816de9
|
|
Change-Id: Ia3195a21ad46b4c9830ee6293135dfe5945986a2
Reviewed-on: https://gerrit.libreoffice.org/13985
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
and remove the need to worry about keeping indexes correct
Change-Id: I9a5fc00f7e28f305279b41099274c96daebebb95
|
|
Change-Id: If6a69eb384b7b7e6c71e96f126a27bcd45709ad4
|
|
Change-Id: I5258b47cba25451b36645e9de3a6a43e3ea3af4c
|
|
found by looking for unused parameters (in Eclipse)
Change-Id: I03cf9bc8312e59747b2d0ac153ee2fc8d76be893
|
|
found by PMD
Change-Id: Id852cfec984a181b91aca1c00a41e342b720a4bf
|
|
found by UCDetector
Change-Id: I6b0f49529379072da566e927b86815f173e7a90b
|
|
Change-Id: I1fdbe47ed7a6e05d2cf20f4c296bffad4bbc6599
Reviewed-on: https://gerrit.libreoffice.org/13719
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
|
|
See https://bugs.freedesktop.org/show_bug.cgi?id=87123#c15
and above all https://bugs.freedesktop.org/show_bug.cgi?id=87123#c18
Thank you Noel for your help!
Change-Id: I9feb2384ff5965bab005c9a1e8803062cd9d0f94
|
|
Quoting Noel:
"
The original block of code looked like this before my changes:
MethodInvocation windowHidden = new MethodInvocation("windowHidden", this);
xWindow.addWindowListener((CommonListener) getGuiEventListener());
String dialogName = (String) Helper.getUnoPropertyValue(xDialogModel, PropertyNames.PROPERTY_NAME);
getGuiEventListener().add(dialogName, EVENT_ACTION_PERFORMED, windowHidden);
which is clearly bogus, since "actionPerformed" is not an event on the XWindowListener interface.
"
(see https://bugs.freedesktop.org/show_bug.cgi?id=87123#c14)
Change-Id: I4c4923e6cb21989fcd3e346b099a7e7b15526bf2
|
|
Change-Id: I149d36a103df51ca78324df3121f51440797e226
|
|
Change-Id: I35a89fc3a7f388be783c729c8e3414aba1c5c726
|
|
Change-Id: I91387b354d0034410819dbcb8dc1ad8889fc8f14
|
|
Change-Id: I3e79b0b34507b947ac4234bab45265027e445d7f
|
|
Change-Id: Ib91120e626f772bb52531c4a35fc70f04cc5c48f
|
|
That's what we should refer to later, not the temporary collection we made!
Change-Id: Ie288222c6aefa0f50a0b0878ad83b78909ee56d1
|
|
Change-Id: I1e913287229119276fa97f73cb249ed0a0b2c473
|
|
as a consequence, successfully delete them
Change-Id: I5dd7b329708dd13f8bfe4a38974c5f6f1202b392
|
|
this allows the rest of the code to automagically do the right stuff:
- get&set position
- group this control with its label
- set the label property to the label control
- ...
Conflicts:
wizards/com/sun/star/wizards/document/TimeStampControl.java
Change-Id: Ibf3cb0ae82ba5c8a23fde05f6466f8eec8308186
|