summaryrefslogtreecommitdiff
path: root/writerfilter
AgeCommit message (Collapse)Author
2019-09-26writerfilter: fix crash on import of tdf113230-1.docxMichael Stahl
The SvxUnoTextBase::finishParagraph() returns null because there's no GetTextForwarder(); in any case the ListId property isn't supported by SvxUnoTextRange. (regression from 7992bd73a2307edce96a145e954f8e4c3ab9f57d) Change-Id: I8f63d805a593a5950c8cb08eaeebd34e977b4700 Reviewed-on: https://gerrit.libreoffice.org/79552 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-09-25better data structures for some static const varsNoel Grandin
use compact, cache-friendly structures for some static const stuff and add a std::initialiser_list constructor to o3tl::sorted_vector Change-Id: I6a6049bf19a7f48dae1843a81cd2257944ada9d5 Reviewed-on: https://gerrit.libreoffice.org/79470 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-25Revert "tdf#117988 writerfilter: IgnoreTabsAndBlanksForLineCalculation"Justin Luth
This reverts LO 6.2 commit 49ddaad2f3ba4e17e1e41e94824fb94468d2b680. tdf#127617 proves it simply was not the correct solution. I replaced the unit test document with one that clearly demonstrates that spaces/tabs should NOT be used in line height calculations. Example document tested with Office 2003, 2010, 2016. Change-Id: I2833384a017526d665adef0cae968bc4aef0dd94 Reviewed-on: https://gerrit.libreoffice.org/79473 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Justin Luth <justin_luth@sil.org>
2019-09-24Use initializer list instead of iterating an array to construct the mapMike Kaganski
The map and set are made function-local statics instead of members, to only create them once (as comment says). This also fixes the problem with missing comma between "page number" and "TableNormal", which presumably had prevented all entries starting from "PageNumber" from working properly. Change-Id: Iddfefb05b1ffd00d16f189ddb5a679adf7561aa6 Reviewed-on: https://gerrit.libreoffice.org/79430 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-09-24tdf#104167 DOCX import: don't map Heading1 to Heading 1 para styleMiklos Vajna
This is nominally a regression from commit c12a78e42e1cbaaf4ea021c82acbec5ea177b1f6 (writerfilter: reset properties of reused styles, 2014-06-04), which assumed that style names are unique. They are not unique for the bugdoc, as it has paragraph styles named 'heading 1' and 'Heading1', both mapped to 'Heading 1'. The mapping for the style name without a space was added in commit 1d2af74e226bf44e1a0f1e1981ca965cffeaa0b2 (INTEGRATION: CWS xmlfilter02 (1.27.12); FILE MERGED, 2008-01-10), in the "2007/11/22 14:53:43 os 1.27.12.9: Tab stops almost perfect now" part, sadly without any indication on why that would be a good idea. The binary DOC import never mapped Heading1 to Heading 1, so it doesn't have this problem. Fix the problem by removing this mapping, it leads to formatting loss when a document has both HeadingN and Heading N styles. Change-Id: I26dd999f5a536e079ac351ba5d40d20c83b99310 Reviewed-on: https://gerrit.libreoffice.org/79422 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-09-23writerfilter: fix assert importing fdo77404-1.docxMichael Stahl
The problem is that StyleSheetTable::ApplyStyleSheets() inserts a SwNumRule with name "WW8Num1" and then ListDef::CreateNumberingRule() also wants to insert a SwNumRule with name "WW8Num1" but gets an exception instead, leaving ListDef::m_xNumRules null, and then finishParagraph thinks it's numbered but there's no ListId. Try to avoid collisions of the generated names in ListDef::GetStyleName(), by checking what styles actually exist in the document (which works better in the Insert->File case), and on the assumption that the initialising call always happens before the using calls. (regression from 7992bd73a2307edce96a145e954f8e4c3ab9f57d) Change-Id: I91c98aa897c12778fb214e9690da0bae99550b93 Reviewed-on: https://gerrit.libreoffice.org/79312 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-09-23do not require $(SRCDIR) in every gb_Library_set_precompiled_headerLuboš Luňák
Change-Id: I7b3a22584bb2e4d501f509ffcd80929feed23a4c Reviewed-on: https://gerrit.libreoffice.org/79360 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-09-20Related: tdf#124600 sw anchored object allow overlap: add DOCX filterMiklos Vajna
Which also made it necessary to support allow-overlap=no for not only shapes, but for shapes-with-text in the layout. Change-Id: Ibd229d21995c0a1053db6bbab0a6ccbbf75f36d3 Reviewed-on: https://gerrit.libreoffice.org/79277 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-09-18writerfilter: use '= default' to define a trivial destructorMiklos Vajna
Change-Id: I63eb9e64ce1dbacdcdaf77beb1a5a87c3a8d26e8 Reviewed-on: https://gerrit.libreoffice.org/79073 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-09-17Related: tdf#124600 DOCX import: ignore left wrap on left-aligned shapesMiklos Vajna
The DOC import does the same in SwWW8ImplReader::AdjustLRWrapForWordMargins(). This fixes one sub-problem of the bugdoc, so now the shape anchored in the header has a correct position. This made it necessary to re-visit the tdf#115719 testcases, which are minimal reproducers. The original document had from-left alignment (instead of align-to-left), but this did not matter before. Bring the test documents closer to the original large document, so the tests still pass and don't depend on LO mis-handling the above mentioned left-aligned situation. (The interesting property of tdf115719.docx, where Word 2010 and Word 2013 handles the document differently is preserved after this change.) Change-Id: I973c13df47b0867e2c4756f0c448495257b7c9d5 Reviewed-on: https://gerrit.libreoffice.org/79049 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-09-17tdf#64222 sw: better DOCX import/export of paragraph marker formattingMichael Stahl
The problem here is that Word allows formatting the paragraph end marker, and applies the same formatting to the generated numbering string; Writer has no such marker thing. This is currently represented by an empty AUTOFMT hint at the end of the paragraph, which is created almost by accident in SwXText::finishParagraph(), because the paragraph properties are set on a SwPaM that doesn't select the whole paragraph but sits at the end. This is a bit fragile and the hint may have unfortunate accidents such as being merged into a preceding AUTOFMT hint if it happens to have the same items in it. It ought to work better to have an item in SwTextNode's SwAttrSet to store these special items; has the advantage that the items will also be copied when you split the paragraph, like in Word. Add a RES_PARATR_LIST_AUTOFMT and UNO property "ListAutoFormat" (which should be considered a first draft...) and use it in preference (where possible) or in addition to (where necessary due to other missing pieces) the empty hint. Also revert the change in checkApplyParagraphMarkFormatToNumbering() to consider hints that start before the end of the paragraph, as it has unintended side effects as pointed out by Mike Kaganski. Change-Id: Ic1d5dd9db2bab0c5e4594712bb45973aa1442da3 Reviewed-on: https://gerrit.libreoffice.org/78729 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-09-06tdf#124604 DOCX import: fix indentation at numberingLászló Németh
If the actual numbering style was associated to a base paragraph style, indentation of the base paragraph style has also priority over the indentation defined in the numbering style. Change-Id: Ic57b6b854be291c75c0eb7a9dfd4c376585fe26b Reviewed-on: https://gerrit.libreoffice.org/78659 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-09-06tdf#127339 DOCX import/export: fix image hyperlink to bookmark targetTünde Tóth
Images as hyperlinks didn't work with internal bookmark targets. Change-Id: I5f3bf150f62d11837b45851e221119dcff93dcaa Reviewed-on: https://gerrit.libreoffice.org/78639 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2019-09-04tdf#95848 writerfilter: DOCX import: fix mapping of w:abstractNumMichael Stahl
The problem is that the bugdoc has multiple w:num numbering definitions that refer to the same w:abstractNum abstract numbering definition. Apparently (and i can't find this documented anywhere) w:abstractNum corresponds to a SwList in Writer, i.e. all w:num that refer to the same w:abstractNum share the same numbering tree, but they may have different numbering properties via w:lvlOverride. So i think this should be imported as a single SwList per w:abstractNum, and every use of w:lvlOverride should create a new SwNumRule, but still share the same SwList; the previous situation was a SwNumRule + SwList per w:num element. This implements simply a SwNumRule per w:num (regardless of w:lvlOverride) because that was easy; the AbstractListDef class gets a member to store the ListId of the created SwList when any of its associated w:num / ListDef is used first, and the non-first ones get this ListId set to force them into the same SwList. Unfortunately it turns out the export has the same SwNumRule->w:abstractNum problem, which remains to be fixed. Change-Id: I92ce989afd15f24e36b6be6ccaf67ba3e0128963 Reviewed-on: https://gerrit.libreoffice.org/78556 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-09-03Fix typosAndrea Gelmini
Change-Id: I71bacf86938af2b89a706c435c4f72a194ec8343 Reviewed-on: https://gerrit.libreoffice.org/78417 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-09-02tdf#55436 - Add SYMBOL_CHICAGO numbering scheme (for footnotes)Tim Bartlett
Includes adding SYMBOL_CHICAGO translations to .docx import/export filters Change-Id: I5212739d7d04ab400a3d2aa549cb7cfd8531a4b8 Reviewed-on: https://gerrit.libreoffice.org/78114 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-09-02tdf#124491 DOCX: import tracked changes of empty paragraphsLászló Németh
Formatting changes of empty paragraphs weren't imported. Change-Id: Ife7c83d52549563ab4c3a00a3daff4d8f4fa8386 Reviewed-on: https://gerrit.libreoffice.org/78233 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-09-01Fix '..'Andrea Gelmini
To complete this: https://gerrit.libreoffice.org/#/c/78312/ This is a massive replace for ".." instead of "..." between words. It passed "make check" on Linux. Change-Id: I144d8061fca9f545c762941551e59dffdd3650e8 Reviewed-on: https://gerrit.libreoffice.org/78357 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2019-09-01makes RTFSprms::set clearerAdrien Ollier
Change-Id: Ic1aab40c8a4abdd73c616b2faaf95ef183fa2e38 Signed-off-by: Adrien Ollier <adr.ollier@hotmail.fr> Reviewed-on: https://gerrit.libreoffice.org/77556 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-08-30RTFSprms: code refactorizationAdrien Ollier
Four lambda expressions were declared doing the same thing, which leads to the creation of four internal different types for the same thing. That makes no sense. Class RTFSprms_compare allows to factorize this code and makes code shorter where it is used. Change-Id: I5ed6821a67a50e96d9425064841c2b3421323001 Signed-off-by: Adrien Ollier <adr.ollier@hotmail.fr> Reviewed-on: https://gerrit.libreoffice.org/76214 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-08-27Fix typosAndrea Gelmini
Change-Id: If2fcd9aaf920f30b49a7bb828ba174939b13a3e7 Reviewed-on: https://gerrit.libreoffice.org/78091 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-26tdf#105485 DOCX: import deleted comments as deletedLászló Németh
in tracked deletions, instead of importing them as normal comments of the actual text content, ie. showing them in the Hide Changes mode, too, without crossing out. Change-Id: I7f84d2e9f2dd280bbca2236b40bab83b94d40c68 Reviewed-on: https://gerrit.libreoffice.org/78018 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-08-24loplugin:returnconstval in test..writerfilterNoel Grandin
Change-Id: Iea7d15f0a54921514cc4b71c5dc8caaa2ee573c8 Reviewed-on: https://gerrit.libreoffice.org/78063 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-24equality test functions are constAdrien Ollier
RTFSprms::equals and RTFValue::equals are mutually dependent, which is insane. Change-Id: Ib6de7954e97d5a1620ea3f8db92fe9a989ee8667 Signed-off-by: Adrien Ollier <adr.ollier@hotmail.fr> Reviewed-on: https://gerrit.libreoffice.org/76211 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-24tdf#123703 RTF import: fix length of space character sequenceLászló Németh
A default RTF space character is longer by an extra six-per-em space in a space sequence. To get the same layout of documents formatted with consecutive spaces, insert six-per-em space before every space in a space sequence. Extra spaces are removed during the RTF export. Note: This is a workaround to get the same layout in documents based on RTF templates, often used for example by bussiness applications. Instead of adding a new RTF specific core/text layout feature, with this workaround the layout will be compatible with ODT and DOCX documents, too. (In contrast, MSO's DOCX export messes up the document layout silently, shortening the length of the space sequence.) Change-Id: I620807e1d4497e86c18732e5aa3131cf817ed94a Reviewed-on: https://gerrit.libreoffice.org/77172 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2019-08-23tdf#119809: FILESAVE DOCX The combo box ActiveX control is lostTamás Zolnai
The problem was with the empty combobox. The implemenation before this commit imported a combobox only when the combobox had any item. Change-Id: I945098277d1ed34c65b43f0f6ad8eb361cf41b53 Reviewed-on: https://gerrit.libreoffice.org/78024 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-08-23tdf#103345 Import decimalEnclosedCircle correctlySamuel Mehrbrodt
Change-Id: I227d149d07ea0f7b2569e5df5a5589834374fac9 Reviewed-on: https://gerrit.libreoffice.org/77992 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-08-23RTF filter: handle tbrl section text directionMiklos Vajna
Makes no sense to support btlr, Word can't handle it. (UI is disabled.) Change-Id: I036a1e98e8b1ac07e688eedf45b4a2c21c4a8859 Reviewed-on: https://gerrit.libreoffice.org/77986 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-08-21loplugin:constvars, look for loop vars that can be constNoel Grandin
Change-Id: I67ee714739800f3718f9d3facf57474cd564d855 Reviewed-on: https://gerrit.libreoffice.org/77415 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-20tdf#76260 cache next page style numberNoel Grandin
to speed up loading document with lots of footnotes. Takes the load time from 29s to 27.3s for me Change-Id: I911e4a7d7db8a2cdff1271d04e5535e76fd137a0 Reviewed-on: https://gerrit.libreoffice.org/77778 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-16Fix typosAndrea Gelmini
Change-Id: I8ab75eb5cd54d14fda42bcdb1a251e9e2b6fefdf Reviewed-on: https://gerrit.libreoffice.org/77612 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-16use more TOOLS_WARN_EXCEPTIONNoel Grandin
Change-Id: Ic21ea11ff106e0732bb8fa600ef39a549d7bda86 Reviewed-on: https://gerrit.libreoffice.org/77569 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-15loplugin:sequenceloop in writerfilter..xmlhelpNoel Grandin
Change-Id: I7c9c911aa6b051eeab46344f25ea2919605de645 Reviewed-on: https://gerrit.libreoffice.org/77534 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-15replace ".get->" with "->"Noel Grandin
Change-Id: I327a6fda1fe0170da33e06b735f09a39421c8a58 Reviewed-on: https://gerrit.libreoffice.org/77469 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-15sw btlr writing mode: RTF filter of Writer textframesMiklos Vajna
Both import and export needed fixing. Change-Id: Ie1728c3e67d8637e3720748d7f61a69c058eafe3 Reviewed-on: https://gerrit.libreoffice.org/77474 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-08-13tdf#114854 writerfilter: EditEng URLs import different from SW URLsJustin Luth
The only example I found was comments (aka annotations/postits). No other unit tests had a URL in a draw component. Change-Id: Iad5c285090d646c495cd2a7b19e076d9e50fb58d Reviewed-on: https://gerrit.libreoffice.org/77108 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2019-08-10NFC cleanup writerfilter: reuse existing variableJustin Luth
Change-Id: Ib44d5296c7879fe872c33357ee0bf24d27c143af Reviewed-on: https://gerrit.libreoffice.org/77228 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2019-08-10tdf#118936 writerfilter: MultiPropertySet retry on exceptionJustin Luth
Applying the same logic as in PropertyMap - if the efficient multipropertyset fails, then re-apply each property one at a time. This effectively reverts 9a19a1235c301f2699157ab44049bdfd54955e8a The "assert" idea of identifying and fixing invalid properties failed spectacularly with RTF - where paragraph properties seem to be routinely applied to character styles. No docx examples were found - unless they were the novell examples which I don't have access to. Change-Id: I4b733d52de93dfb6beb1da35e0813fd1b0396da7 Reviewed-on: https://gerrit.libreoffice.org/77221 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-09tdf#126768 DOCX import: fix absolute hyperlinks to documentsTünde Tóth
file:///absolute\\path\\to\\file didn't work in Writer. Change-Id: I61135668e47bc1d67afb4ed6bec6a90744d295cf Reviewed-on: https://gerrit.libreoffice.org/77184 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-08-09tdf#126723 writerfilter::finishParagraph - me, not previousJustin Luth
In LO 6.2 commit 480ac84f2f5049fb4337b36f12fd6796e005761b the existing m_xPreviousParagraph was conveniently used to apply the changed properties. I never did like that choice, but despite looking at it, I failed to see that it is set in an inside loop, which means that it was NOT NECESSARILY reset to the current paragaph. So I'm happy to have proof that we should not use m_xPreviousParagraph. Change-Id: I5c7f1b0f097711d65ae0d0be1f0fbc40c8b96e9d Reviewed-on: https://gerrit.libreoffice.org/77185 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2019-08-07Remove some unused includesMiklos Vajna
See tdf#42949 for motivation. Change-Id: I76f3cbf866d20a3e70d06148fb42ca25998de34b Reviewed-on: https://gerrit.libreoffice.org/77063 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-08-07Fix typosAndrea Gelmini
Change-Id: Ib3ada3eb5b7d2699a86f05bb646b71f30d8a7003 Reviewed-on: https://gerrit.libreoffice.org/77041 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2019-08-06tdf#118936 writerfilter: MultiPropertySet exception lost propertiesJustin Luth
An unsupported character style property was causing the loss of some properties - anything with a higher sorting value. Another way to deal with this could be something similar to section properties which retries properties individually if multiset fails. Another option is to add CHAR_SHADING_VALUE to aCharStyleMap in unomap1.cxx, since it is already in aAutoCharStyleMap. However, this is an area I completely don't understand. Change-Id: I70676c7a35d0efc95222960609da039e26df8a58 Reviewed-on: https://gerrit.libreoffice.org/76875 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-08-06tdf#126309 RTF import: fix not needed para adjust swap for bidi textMiklos Vajna
Regression from commit 4ee2a882dddb395a816cd54004b634d57cfb2446 (tdf#86182 RTF import: fix handling of \rtlpar, 2015-04-17), now that we don't ignore \rtlpar, it turned out that dmapper should not do paragraph alignment left/right swapping for RTF. It seems this is needed for DOCX, but not for legacy DOC/RTF. See how SwWW8ImplReader::Read_Justify() doesn't do this, either, so this is one of those rare cases when dmapper has to know if the token stream is generated by the DOCX or the RTF tokenizers. Change-Id: Ibd52e3dc9e782e1d985418085b82b2e2628bc1dd Reviewed-on: https://gerrit.libreoffice.org/76995 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-08-05Fix typosAndrea Gelmini
Change-Id: I82bf62737a714f4a63af56989eb1c9c632b7d606 Reviewed-on: https://gerrit.libreoffice.org/76973 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-05tdf126701: MSForms: Fix import of date field at the end of the paragraph.Tamás Zolnai
We need to create date field before the paragraph is finished (line break is inserted). A date field can not span between paragraphs. Extend other related unit tests too. In other use cases, the field content changes to an invalid data. Change-Id: Id274649e0aaaf6e3c31e042afd126cefc368c858 Reviewed-on: https://gerrit.libreoffice.org/76971 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-08-05writerfilter comment cleanup: keep comment with codeJustin Luth
Keep the comment with the code portion that it describes. Initially the if clause only dealt with this topic, but it has since expanded to include many other things. Although it talks about a right margin, the code doesn't do anything with that. I left the comment as is in case it indicates something that OUGHT to still be done, even though the original commit does nothing to the right margin. See original commit 1d2af74e226bf44e1a0f1e1981ca965cffeaa0b2. Change-Id: I8ac21082e7a27924a108dd16fe8131ec3de92b28 Reviewed-on: https://gerrit.libreoffice.org/76898 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2019-08-05Fix typosAndrea Gelmini
Change-Id: I63ab268d908477f8847b315f44f6ffd543b17794 Reviewed-on: https://gerrit.libreoffice.org/76969 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-02tdf#123702 RTF/DOCX default 1" left/right page marginsLászló Németh
since MSO 2007: now 1440 twips = 2540 1/100 mm (it was 1800 twips = 3175 1/100 mm). Changing the default value fixes the layout of the documents based on RTF templates without explicit margins. Change-Id: I0395fb7cdd6ba176f266c8f0a9309ba48a047da3 Reviewed-on: https://gerrit.libreoffice.org/76812 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-08-02sw btlr writing mode: RTF filter of Writer tbrl textframesMiklos Vajna
Fix both import and export. Values 1 and 3 seems to be the same. Accept both on import, but write 3, as DOCX only has a single value and Word uses 3 when doing DOCX->RTF conversion. Change-Id: Ic5420091ffee9eb20c6aaac61a127e93289aa9fe Reviewed-on: https://gerrit.libreoffice.org/76823 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>