summaryrefslogtreecommitdiff
path: root/xmerge
AgeCommit message (Collapse)Author
2016-02-04coverity#1326425 Dereference null return valueCaolán McNamara
Change-Id: I3fda64e652310463e5a634341713562830babb87
2016-02-04coverity#1326426 Dereference null return valueCaolán McNamara
Change-Id: I8ac0a0df5e111b72db181ee1b8043e6f65fbaf25
2016-02-04coverity#1326427 Dereference null return valueCaolán McNamara
Change-Id: Id4ff5ab007e9ddbc28018570fe38abe9e5acb54b
2016-01-29cid#1326176, 1326270, 1326271, 1326272, 1326273, 1326274, 1326275jan iversen
null pointer used to dereference, add "if" Change-Id: I37173f252a3b3da44976581ccefd0ed54aa8aa0d Reviewed-on: https://gerrit.libreoffice.org/21735 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-01-29cid#1326280, 1326295, 1326303jan iversen
null pointer dereference, made test Change-Id: I2bd820a2eb04499ab3b518d5b5e5ccccf3ffe531 Reviewed-on: https://gerrit.libreoffice.org/21771 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-01-10Fix typosAndrea Gelmini
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86 Reviewed-on: https://gerrit.libreoffice.org/21209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2015-12-30coverity#1327008 SBSC: String concatenation in loop using + operatorCaolán McNamara
Change-Id: I2e205bd87760740e1b57647a9a3bdd928be09dfd
2015-12-30coverity#1327009 SBSC: String concatenation in loop using + operatorCaolán McNamara
Change-Id: I22eddb72ffa63549ce4361ec4e691ba2ba2bff96
2015-12-30coverity#1326717 DLS: Dead local storeCaolán McNamara
Change-Id: I3467c9cdd39c8de4d3a10e4bb19c488ae4a6b9f2
2015-11-27CID#1326472, CID#1326473, CID#1326474 use try/finalizejan iversen
Coverity requires that closeable objects (use of new) call .close(), git commit 5a29db7a9945c4cd095799451a6c563d5aeeed57 implemented a series of .close etc calls, update to use a single try{}finalize{} instead. Change-Id: Iadc9de13d6a0af4b0aaca2dfdd0e2d0940a5223d Reviewed-on: https://gerrit.libreoffice.org/19807 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2015-11-05java: remove ((unnecessary)) parenthesesNoel Grandin
Change-Id: I39fbe3a260c8dbfc203662c54eec4db064b88195
2015-11-05java: combine nested if statementsNoel Grandin
Change-Id: I0457b81668e9427a3c8d6a4af93438b7fb2bb7ba
2015-11-04Solved CID 1326472, 1326473, 1326474jan iversen
Coverity requires that allocated objects (use of new) are directly release, by foo = null; The gc will do this automatically at some point in time, so this will simply release the resource a bit earlier, which can save problems if the function is called in a tight loop. Updated to add close() before clearing the variable, this would normally be done by gc, but now a bit earlier. The assignment to null is not needed specifically, but Coverity calls it a leak if not assigned. Forgot .close(); Change-Id: Id273e7f36778c1691b260d28e741c6e32148c9d9
2015-11-04Mechanically sanitize indentationStephan Bergmann
Change-Id: Ide8817aff3a6b5d07b56b54cecb36f7dc1407743
2015-10-28coverity#1326258 Explicit null dereferencedCaolán McNamara
Change-Id: I58b07353f4dca7fc24305bd0120ed7db18339e83
2015-10-28coverity#1326465 Dereference null return valueCaolán McNamara
Change-Id: I0bb704e3f49444c7b377ac22acb52cf2dd58325f
2015-10-25coverity#1326117 Unchecked return valueCaolán McNamara
Change-Id: I448f59fd43d90d3ad42ba55dbadee0664984e53a
2015-10-20coverity#1326242 Dereference after null checkCaolán McNamara
Change-Id: I827e6967938114946193f34d7102ff9cd132a1a9
2015-10-15coverity#1326266 Explicit null dereferencedCaolán McNamara
Change-Id: Ic6971a9006f82528a9943f8d425389545403162a
2015-10-15coverity#1326237 Explicit null dereferencedCaolán McNamara
Change-Id: Ic3ab796da48e28efaf1628f28b8632dd00c041b2
2015-10-15coverity#1326285 Dereference after null checkCaolán McNamara
Change-Id: I20c0cf4ad14252fdbf9a73c7675a0704e8a03823
2015-10-15coverity#1327172 UrF: Unread fieldCaolán McNamara
Change-Id: Iad3c349b3f66a5bba281b33de9ca689dd5015a83
2015-10-15cid#1326571 and cid#1326572 Unused valueNoel Grandin
Change-Id: I0e984135a5abf918ba556c700ffa111097fd48c1
2015-10-15coverity#1326899 HE: Equal objects must have equal hashcodesCaolán McNamara
and... coverity#1326898 HE: Equal objects must have equal hashcodes coverity#1326897 HE: Equal objects must have equal hashcodes coverity#1326896 HE: Equal objects must have equal hashcodes coverity#1326895 HE: Equal objects must have equal hashcodes Change-Id: Ic9cb7542c1bf0608a97e5b4756b737cdf1bb4bd8
2015-10-15cid#1326117 Unchecked return valueNoel Grandin
Change-Id: Ieaa1875a8731b5339d4ebf032b3f724ff889903f
2015-10-15cid#1327023 to cid#1327077 SIC: Inner class could be made staticNoel Grandin
Change-Id: I41f89c4feefe4e012d72c663ebb9bbcb4aa7f163
2015-10-14cid#1326716,cid#1326717 DLS: Dead local storeNoel Grandin
and clean up the method a little Change-Id: Iaa27bcd20a5b5b1b2b14f277371c5a013ae5d339
2015-10-14cid#1326608,cid#1326609 CN: Bad implementation of cloneable idiomNoel Grandin
Change-Id: Iac74be96b47720ab105f862e7d1a69f909214294
2015-09-29Fix typosAndrea Gelmini
Change-Id: If2e4adb2ce93c02ee14d831eedf4ef31da04b92d Reviewed-on: https://gerrit.libreoffice.org/18996 Reviewed-by: Joren De Cuyper <jorendc@libreoffice.org> Tested-by: Joren De Cuyper <jorendc@libreoffice.org>
2015-07-03Fix typosAndrea Gelmini
Change-Id: I98b4dfb0f72f315065693335e2f882bb2eed3afe Reviewed-on: https://gerrit.libreoffice.org/16713 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2015-06-23Revert "Typo: iff->if"Julien Nabet
This reverts commit cf92da3d6e1de14756efe3f1ee79f393a2f3787d. iff can mean "if and only if" so not a typo
2015-06-23Typo: iff->ifJulien Nabet
Change-Id: I3fc60856b5a56e71d70b55c89323be074bdec3b3
2015-06-15java: 'final static' to 'static final'Noel Grandin
this is the canonical order, and it makes the code easier to read Change-Id: I272e7f1e140296e582702b6dbf77a03eefb65470 Reviewed-on: https://gerrit.libreoffice.org/16242 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Ostrovsky <david@ostrovsky.org>
2015-06-11java:regulatize the order of 'final' and public/privateNoel Grandin
Make the order be 'public static' or 'private static' Just makes the code nicer to read. Change-Id: I182424bda45a2d68642e5d04c6091d268ace1fe2 Reviewed-on: https://gerrit.libreoffice.org/16202 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-02-23remove unnecessary parenthesis in return statementsNoel Grandin
found with $ git grep -lP 'return\s*\(\s*\w+\s*\)\s*;' Change-Id: Ic51606877a9edcadeb647c5bf17bc928b69ab60e
2014-12-19xmerge: store the original exception in the cause field properlyNoel Grandin
Change-Id: I154b8b80aabd824edc62a7fdd831074fcf5cb21b
2014-12-12java: fix non-public UNO implementation classesNoel Grandin
which I messed up in commit 70f56bc22fe952c "java: reduce scope, make member classes private" Change-Id: I817b2a571e2124f551ccd5c0d8e1099d89f0ec46
2014-12-11java: reduce visibility of fields and methodsNoel Grandin
found by PMD Change-Id: Id6737916b68ccbdbdeec5d314747a38410923ac6 Reviewed-on: https://gerrit.libreoffice.org/13409 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-18java: make fields final where possibleNoel Grandin
found by PMD Change-Id: I87780366119c141cd2dafe6ca1bf2d9798b10aec
2014-11-12Fix common typos. No automatic tools. Handmade…Andrea Gelmini
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959 Reviewed-on: https://gerrit.libreoffice.org/12164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-12java: convert fields to local variables where possibleNoel Grandin
found by PMD Change-Id: I05b45382b8fb1b734657ce9421a20e6ef6fbe542 Reviewed-on: https://gerrit.libreoffice.org/12376 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-12java: reduce excessive code indentation levelsNoel Grandin
by using early return in some methods Change-Id: I3611c8c89b3a94ef7e1772d178acf065fd7fcdc7 Reviewed-on: https://gerrit.libreoffice.org/12374 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-18xmerge: use java.nio.ByteBuffer (JDK 1.4+)Robert Antoni Buj i Gelonch
Change-Id: I6072bb4699c9cd361e0cfe0a12b46cfc1abfe368 Reviewed-on: https://gerrit.libreoffice.org/11998 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-16java: when rethrowing, store the original exceptionNoel Grandin
Change-Id: I34ce000c48d2d79bfec854c8dd55d12f2bee29c7
2014-10-16xmerge: use String.formatRobert Antoni Buj i Gelonch
http://docs.oracle.com/javase/1.5.0/docs/api/java/lang/String.html#format(java.lang.String, java.lang.Object...) Change-Id: I98b7fca9dee870c9a1d0f9842cbb009a13537967 Reviewed-on: https://gerrit.libreoffice.org/11995 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-16java: ensure that the stream is cleaned up before the method returnsRobert Antoni Buj i Gelonch
Change-Id: Id3efeda2fd66173ba2f5662eaacb3629da54573d Reviewed-on: https://gerrit.libreoffice.org/11991 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-16java: always use braces for while loopsNoel Grandin
Change-Id: Iff896b0cace8b8305528b3b0140004ea856169ce
2014-10-16java: reduce the depth of some deeply nested if blocksNoel Grandin
Change-Id: I3c0c7f08d4d8ea594e72fc0d9b93d085d4ab4bf5
2014-10-13java: import from the same packageRobert Antoni Buj i Gelonch
Change-Id: I1bb0999783f365e20b682c3707e73c65724265c9 Reviewed-on: https://gerrit.libreoffice.org/11955 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-13xmerge: ensure that the stream is cleaned up before the method returnsRobert Antoni Buj i Gelonch
Change-Id: I377ae1a7b71c207313ad3468a51b1ab06b9fffd5 Reviewed-on: https://gerrit.libreoffice.org/11939 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
generated by cgit (git 2.34.1) at 2024-08-12 05:50:55 +0000