summaryrefslogtreecommitdiff
path: root/xmloff/qa
AgeCommit message (Collapse)Author
2021-02-10loplugin:refcounting also check OWeakObject subclassesNoel
Change-Id: I2d89085a22d7424c6f8f7662307433ce50fc61d2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110666 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-15tdf#136861 ODT export: fix writing resolved state for non-ranged commentsMiklos Vajna
It was probably not intentional to write the resolved state only in case the annotation has a name. Change-Id: Ia3a6b2320e2288528c43c832211ebfcde492881e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109354 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-01-10fix coverity parse errorsCaolán McNamara
Change-Id: I4884bfb67a061b865e8cf38b2fea6de0cb1bc3d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109057 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-29loplugin:stringviewparam: operator +Stephan Bergmann
Change-Id: I044dd21b63d7eb03224675584fa143009c6b6008 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108418 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-26New loplugin:stringliteralvarStephan Bergmann
See the comment at the top of compilerplugins/clang/stringliteralvar.cxx for details. (Turned some affected variables in included files into inline variables, to avoid GCC warnings about unused variables.) Change-Id: Ie77219e6adfdaaceaa8b4e590b08971f2f04c83a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108239 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-05clean up some temp files after running testsAndras Timar
Change-Id: Ia28e96cf1f6ec476f202e99877fa80e93d691278 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105314 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-08-16Fix typoAndrea Gelmini
Change-Id: Ie3910ffbee6f3a80f077e1c2f3e3112daa96017a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100654 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-13Remove some unused includesMiklos Vajna
Change-Id: Iea6b931b1f2328886354f70ad81a3e07367db717 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100669 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-08-12tdf#135144 xmloff textbox: fix export style name to be consitent with importMiklos Vajna
Regression from commit 28d67b792724a23015dec32fb0278b729f676736 (tdf#107776 sw ODF shape import: make is-textbox check more strict, 2019-08-26), the problem was that in case the import side in SdXMLCustomShapeContext expects a fixed "Frame" parent style name, then the export side should go with that name as well. Fix the problem by simplifying XMLShapeExport::collectShapeAutoStyles(), which initially assumed that the string may be localized, so try to look it up: instead just use the fixed string that the import side will look for. This solves all problem which may stem from a parent style name which is non-empty, but other than Frame. Change-Id: I8146440c591d3dd5a904d243d85741d704711e9c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100577 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-08-07Fix typosAndrea Gelmini
Change-Id: Iedaac490a577d3582ea9ef5a105836eff8c2eaf5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100078 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-08-04tdf#130707 xmloff: survive <text:database-display> in editeng textMiklos Vajna
Regression from commit 28d67b792724a23015dec32fb0278b729f676736 (tdf#107776 sw ODF shape import: make is-textbox check more strict, 2019-08-26), now that we correctly identify what shape text to import as "textbox" (Writer TextFrame) and what to import as editeng text, there are documents out there that try to import mailmerge fields into editeng-based shape text. Fix missing error handling there. Note that the error is not just silently ignored, we do insert the field result into the shape text, existing code provides this already. Change-Id: Ibe631ac5d94c1c7795dd00bad05fdcca0e6741a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100028 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-05-27Remove some unused includesMiklos Vajna
Change-Id: Id5a31185faf2a3a13b6ea266e058a7df41d44423 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94890 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-05-20tdf#130479 FODG import: fix handling of <draw:fill-image> in stylesMiklos Vajna
Regression from the image handling rework, the problem was that the old, URL-based code had explicit handling of mxBase64Stream, while the new, XGraphic-based code assumed that by the time we reach the end of of the bitmap style element, maAny already contains the graphic. Fix the problem by improving XMLBitmapStyleContext::EndElement(), so it loads the graphic from the base64 stream if we don't have a graphic already. Change-Id: I6d90f1470a5b797fb51789901081ccd7a6fd29e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94548 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-05-19xmloff: ODF export: additional ODF 1.3 chart featuresMichael Stahl
* OFFICE-3662 chart:interpolation additional values * OFFICE-3958 chart regression curve: polynomial * OFFICE-3959 chart regression curve: moving-average None of these are exported in ODF 1.2 extended because they require additional values for standard attributes, which isn't valid. Change-Id: I920cc44dbde46687b570c1296c7d8926f0a1a9c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94064 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-05-11Document relation between three lists that must be in syncMike Kaganski
Change-Id: I9fc44b6878450d147d21f77ff4daa6939edfa0c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93837 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-02-15convert XML_STYLE_FAMILY to scoped enumNoel Grandin
Change-Id: I5335b0190a2f5a8111993c0c9c224c8a6a8f0cfb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88723 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-03move some xmloff/ headers inside the moduleNoel Grandin
Change-Id: I57e97da952c18c33af85a8fe24ebf021fc0631d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87828 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-30tdf#42949 Fix IWYU warnings in xmloff/source/[c-m]*/*cxxGabor Kelemen
Also checked xmloff/qa Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I843917d255f841066ace8d944aa1d00f1b718108 Reviewed-on: https://gerrit.libreoffice.org/79773 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-01-22tdf#42949 Fix IWYU warnings in include/xmloff/*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Id20e0bc42e39f868a7c5d49d756f2ad5e14a86c0 Reviewed-on: https://gerrit.libreoffice.org/66637 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-01-16New loplugin:emptyStephan Bergmann
Change-Id: I8729db064573ac21dfe6b203c5ae244d79ecc4fe Reviewed-on: https://gerrit.libreoffice.org/66430 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-10-19loplugin:staticvar in xmloffNoel Grandin
Change-Id: I283d162807a906334627613be7c340af566144f1 Reviewed-on: https://gerrit.libreoffice.org/61921 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-24tdf#42949 Fix IWYU warnings in include/comphelper/[a-l]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I22ba2c8aec235e34cd7835b8a0a716bf3057db7a Reviewed-on: https://gerrit.libreoffice.org/60837 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-09-13loplugin:simplifyconstruct in writerfilter..xmlsecurityNoel Grandin
Change-Id: Ic2d901ca0dbc2d6fa96611d260c1572da8a783c0 Reviewed-on: https://gerrit.libreoffice.org/60398 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-30loplugin:useuniqueptr in XMLTextParagraphExportNoel Grandin
Change-Id: I753bbfc60172a36e1f3ba08398dc17ee14e0c551 Reviewed-on: https://gerrit.libreoffice.org/53604 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-14xmloff: ODF import: improve meta:generator checksMichael Stahl
Instead of a hard-coded check for (effectively) one project name "LibreOffice" (which is build-time configurable), check for the string "LibreOffice_project", which has been produced hard-coded ever since LO 3.3.0. This now recognises additional downstreams "LibreOffice_Vanilla" and "Collabora_Office", and also historic "BrOffice". An important point here is that the build-time configurable version numbers of any downstream that retains the hard-coded "LibreOffice_project" *MUST* be the same as the upstream's at least in their major and minor versions (micro and further digits are currently not used), and that such downstreams don't backport changes with ODF export compatibility impact further than upstream. Add a unit test too, with a representative sample of 4372 distinct generators in bugzilla attachments. This revealed that StarOffice 6 and AOO 4.0.1 were falling through the cracks and not recognised, so fix that too. Change-Id: I8105222d3428e7b20cc4a6b8e76732c697812594 Reviewed-on: https://gerrit.libreoffice.org/51171 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-10-23loplugin:includeform: xmloffStephan Bergmann
Change-Id: I9e55142a7904c426fce49f68f1790365ea490fab
2017-04-25tools: svstream.hxx needs only errcode.hxx & not errinf.hxxChris Sherlock
Change-Id: Ia28e35ae5af4f601e9a586a3deffbcd61702b0ca Reviewed-on: https://gerrit.libreoffice.org/36896 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-01-06writerperfect, xmloff: fix loplugin:cppunitassertequals warningsMiklos Vajna
Change-Id: Ie8246433a7cea0886f00d8c76cf6f7d023545417 Reviewed-on: https://gerrit.libreoffice.org/32770 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-10-07xmloff: fix --enable-mergelibs buildMichael Stahl
... by merging all object-using CppunitTests into uxmloff, which is already disabled for MERGELIBS. Change-Id: I12ad08660fd714cceba2fe9b855cdb1bbda19c2d
2016-08-22GSoC - Keeping both token lists in xmloff/ consistent:Mohammed Abdul Azeem
Added dummy tokens to keep the lists consistent and a test case to check the same. Change-Id: Ia58f1f77a5100a9fb3c7226fcad1fef1bd5aec39 Reviewed-on: https://gerrit.libreoffice.org/28183 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-19At which point, TokenmapTest::setUp/tearDown are redundant againStephan Bergmann
Change-Id: I0b3017427aa0d3cf9450734c677b442e61fdbe63
2016-08-19attempt to fix the xmloff/tokenmap tinderbox failureNoel Grandin
Change-Id: I1b70ef90de374ade858b8207802b8048b2dfd248
2016-08-18xmloff tokenmap: allocate map on heap instead of as class memberEike Rathke
Try to make the tinderbox happy.. Change-Id: I564d554739fc38d2a901d38ad676c9ba28f3c233
2016-08-18xmloff tokenmap: do not assume anything did not failEike Rathke
Change-Id: If13feffe41631b45605511fbad07965e0d5cb8d5
2016-08-17loplugin:staticcallNoel Grandin
Change-Id: I0e35e3e6b7540fb1b8a65b034095d2b1fe80715f
2016-08-16GSoC - implement global tokenhandler for odf-tokensDaniel Sikeler
This generates perfect hash for odf-tokens and use them with the tokenhandler. With added test case to check to and fro mapping between tokens. This is taken from Daniel's work in feature/fastparser branch. Change-Id: I7cf77c1eb6c9dd68fd78108c6e0726507c7672e1 Reviewed-on: https://gerrit.libreoffice.org/28073 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann
Change-Id: I8690de2cb68dcfedc9f2239ce66cea06fd94bc16
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-01-06fdo#84938: convert EXPORT_ #defines to 'enum class'Noel Grandin
Change-Id: I2ed239fa073b5fa8fb56c1af9d4b0bac89acfacf
2014-07-02drop UniReference in favour of rtl::ReferenceNoel Grandin
since they're doing the same thing. Change-Id: I76134b6b848db8628f315fe5bd9eb972a6bf0cb6
2014-04-17remove executable bitAndras Timar
Change-Id: I91f6e861f6d0dbea1b57ac73857e0c706b27f681
2014-03-26First batch of adding SAL_OVERRRIDE to overriding function declarationsStephan Bergmann
...mostly done with a rewriting Clang plugin, with just some manual tweaking necessary to fix poor macro usage. Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-01-08Consolidate XServiceInfo for classes derived from SvXMLExportStephan Bergmann
Change-Id: Ia3e2b5e682a64844bb6c713912c50c7681393d52
2013-12-20added bool bForExport parameter to XMLPropertySetMapper ctorEike Rathke
Set to true for export, false for import. If export true, an XMLPropertyMapEntry with mbImportOnly==true is not added to the mappings. This to be able to have more than one mappings for import (for example a current extension namespace and the future namespace proposed to the ODF-TC, or corrected typos in element or attribute names), but map only to one entry on export, of course. Change-Id: Ia01ea949c88eda2f8a6c10f51c59e35e7abdcaf3
2013-09-30Add hack to optionally get stable ODF output from the same inputTor Lillqvist
To be used in regression testing and similar scenarios, where the output ODF is *not* intended to be further manipulated in LibreOffice. An environment variable LIBO_ONEWAY_STABLE_ODF_EXPORT is used to toggle this behaviour. I am not 100% sure whether the generated ODF with the hack toggled on is even fully correct, but correctness is not the purpose of the hack anyway. Two classes of issues handled: 1) Automatic style names and 2) use of randomness. For class 1), when the hack toggle is in effect, we generate the names at first as strings based on all the properties of the style, and sort them based on those, and then rename them (for brevity in the output) to the "normal" form of a short prefix plus a number (like "P12"). Sure, it would have been better to just figure out *why* the automatic style naming currently is not stable in the first place, but outputs the styles in different order (with some styles being assigned different numbers) in separate invokations of LibreOffice), but I was unable to understand that. Possibly this code could be used in all cases, except that it does break some unit test (can't recall which right now). I don't know whether that is simply because the unit test assumes too much knowledge of the internal workings of the automatic style name generation, or whether the generated ODF is actually invalid. For 2), I found a handful of places where randomness was used to generated various kinds of identifiers in ODF output. I changed those to just use large (64-bit) non-overlapping integers instead. I assume there *is* a point in the original code in each case that explains why randomness is needed, so the hack definitely needs to be optional and used only for the above mentioned scenarios. Change-Id: I17b657197e38bcf24abdfe61ad4a277f4339eeae
2013-03-14xmloff: at least do something to test styles.Michael Meeks
Change-Id: I7982f162ef95a9f10501c860b6f19865bf34744b
2013-03-14xmloff: native code unit testing harness.Michael Meeks
Change-Id: I5b9133deea2aa7630752128128f1a222bef99eb1
2012-11-15re-base on ALv2 code. Includes:Michael Meeks
Patches contributed by: Armin Le Grand. #118558# Correcting OLE attributes of LO3.4 at load time by loading as OOo3.3, details see task. http://svn.apache.org/viewvc?view=revision&revision=1195906 #118485# - Styles for OLEs are not saved. http://svn.apache.org/viewvc?view=revision&revision=1182166 #118898# Adapted ImpGraphic::ImplGetBitmap to correctly convert metafiles http://svn.apache.org/viewvc?view=revision&revision=1293316 #119337# Solves the wrong get/setPropertyValue calls in SvxShapeText (and thus in SvxOle2Shape) http://svn.apache.org/viewvc?view=revision&revision=1344156 Patches contributed by Mathias Bauer (and others) gnumake4 work variously http://svn.apache.org/viewvc?view=revision&revision=1394707 http://svn.apache.org/viewvc?view=revision&revision=1394326 cws mba34issues01: #i117717#: remove wrong assertion http://svn.apache.org/viewvc?view=revision&revision=1172349 Patch contributed by Herbert Duerr goodbye Registration and License dialogs, don't let the door hit you http://svn.apache.org/viewvc?view=revision&revision=1172613 help gcc 4.6.0 on 32bit ubuntu 11.10" http://svn.apache.org/viewvc?view=revision&revision=1245357 Do not add targets for junit tests when junit is disabled. Patch contributed by Andre Fischer http://svn.apache.org/viewvc?view=revision&revision=1241508 Revert "sb140: #i117082# avoid unncessary static class data members commit 21d97438e2944861e26e4984195f959a0cce1e41. remove obsolete FreeBSD visibility special case. retain consolidated BSD bridge code, remove OS/2 pieces.
2012-06-21re-base on ALv2 code.Michael Meeks
Change-Id: Ice06e639213aeb6f7f23cbf4634947dd25613db1
2012-03-23.xcl files don't need executable bitsMichael Stahl
generated by cgit (git 2.34.1) at 2024-06-02 01:23:04 +0000