summaryrefslogtreecommitdiff
path: root/xmloff/source/draw/sdxmlexp.cxx
AgeCommit message (Collapse)Author
2020-06-03tdf#133501 xmloff: ODF export: export annotation only if extendedMichael Stahl
(regression from 7c20c3c2a9fc85c66dad9d09908b257beeedd78d which forgot to adapt this under the erroneous assumption that the feature did make it into ODF 1.3) Change-Id: Idfe37444b8287edd063fa9576e6d76a332552754 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95355 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de> (cherry picked from commit bb95d189653d73911c187227ace682ba2b98172c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95320
2020-05-12xmloff: ODF export: adapt to ODF 1.3Michael Stahl
* OFFICE-3883 legend svg:width/svg:height * OFFICE-3928 chart:coordinate-region * OFFICE-3943 draw:mime-type * OFFICE-3765 number:fill-character, number:text * OFFICE-3860 number:min-decimal-places, number:forced-exponent-sign * OFFICE-1828 number:exponent-interval * OFFICE-3695 number:max-denominator-value * OFFICE-3941 text:index-entry-link-start/text:index-entry-link-end * OFFICE-3776 meta:creator-initials * OFFICE-3789 style:header-first/style:footer-first Change-Id: I78c79231c0708c3ae9943097d162898fab71988f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92873 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-05-07replace ODFDefaultVersion usage with ODFSaneDefaultVersionMichael Stahl
Compare with ODFSVER_012 mostly works the same, except for places where namespaces are defined where the ODFSVER_EXTENDED bit should be checked. Change-Id: I86469b763bc2f903632976bc9d6ec04d543d705e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92727 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-03-16Revert "loplugin:constfields in xmloff"Noel Grandin
This reverts commit 0302c9b192c3b7ba10daabed61d6864c24c14070. Change-Id: Ib919429e22ad039d6a82fe081f4e5421fe08905d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90549 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-15convert XML_STYLE_FAMILY to scoped enumNoel Grandin
Change-Id: I5335b0190a2f5a8111993c0c9c224c8a6a8f0cfb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88723 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-24xmloff: create XMLImpressClipboardExport instances with an uno constructorMiklos Vajna
See tdf#74608 for motivation. Change-Id: Idab3996986eb38ff8b1a3765f9bf005229271728 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87294 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-01-17xmloff: create DrawingLayerExport instances with an uno constructorMiklos Vajna
See tdf#74608 for motivation. Change-Id: I1bb8e649cab67a2df4e40277758a47259f65a6c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86946 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-12-25sal_Char->char in xmloff..xmlsecurityNoel Grandin
Change-Id: I292d699ce1de10ca9341525161f5da2592102ff7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85778 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-06xmloff: create XMLDrawExportOasis instances with an uno constructorMiklos Vajna
See tdf#74608 for motivation. Change-Id: Id8cad1ed02b5fee93184e17ebf80435c01aa3618 Reviewed-on: https://gerrit.libreoffice.org/84583 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-11-22xmloff: create XMLDrawStylesExportOasis instances with an uno constructorMiklos Vajna
See tdf#74608 for motivation. Change-Id: I68db3d4969e4bd40d1029ca3302bbda0dfe6e718 Reviewed-on: https://gerrit.libreoffice.org/83432 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-11-15xmloff: create XMLDrawContentExportOasis instances with an uno constructorMiklos Vajna
See tdf#74608 for motivation. Change-Id: I4bb0ef49ef429df053af83ff0dd7d22edc2d907b Reviewed-on: https://gerrit.libreoffice.org/82742 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-11-03loplugin:stringaddNoel Grandin
tweak the plugin to be more permissive, then validate by hand afterwards Change-Id: I40c5c911fe6ff7e45baaca372abf7dac211d9654 Reviewed-on: https://gerrit.libreoffice.org/81942 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-31Fix StringAdd::isCompileTimeConstantStephan Bergmann
...to find StringLiteral on the RHS of +=. Which revealed that the VisitCompoundStmt/checkForCompoundAssign logic needed to be fixed, too, so that s += side_effect(); s += "literal"; s += side_effect(); only gets combined to s += side_effect() + "literal"; s += side_effect(); and not all the way to s += side_effect() + "literal" + side_effect(); Change-Id: I432e3458b933a7d0ad6141c747b675cc8b0f0ba4 Reviewed-on: https://gerrit.libreoffice.org/81804 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-28loplugin:stringadd improve detectionNoel Grandin
if one side of the expression is a compile-time-constant, we don't need to worry about side-effects on the other side Change-Id: Iee71ea51b327ef244bf39f128f921ac325d74e2b Reviewed-on: https://gerrit.libreoffice.org/81589 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-25xmloff: create XMLDrawMetaExportOasis instances with an uno constructorMiklos Vajna
See tdf#74608 for motivation. Change-Id: I6dc4fcd75517c137c1bd4de766f67b73eaff1788 Reviewed-on: https://gerrit.libreoffice.org/81480 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-10-18xmloff: create XMLDrawSettingsExportOasis instances with an uno constructorMiklos Vajna
See tdf#74608 for motivation. Change-Id: I25fbd841a8f91b51787cebd4b94f5a62cb0d9e07 Reviewed-on: https://gerrit.libreoffice.org/80996 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-10-16loplugin:stringadd look through a couple more known-good methodsNoel Grandin
Change-Id: Ifbdb3e41eae665f7dcaf5301aaba2b6e4662cf48 Reviewed-on: https://gerrit.libreoffice.org/80855 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-11xmloff: create XMLDrawSettingsExportOOO instances with an uno constructorMiklos Vajna
See tdf#74608 for motivation. Change-Id: I15c879fd2be820a1b6ee878149442ebb46588a30 Reviewed-on: https://gerrit.libreoffice.org/80629 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-10-04xmloff: create XMLDrawMetaExportOOO instances with an uno constructorMiklos Vajna
See tdf#74608 for motivation. Change-Id: Ia7ca975486be09acd2655c59b65e1f2a57774f32 Reviewed-on: https://gerrit.libreoffice.org/80166 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-10-02loplugin:stringadd in writerfilter..xmloffNoel Grandin
Change-Id: Ib5292f4c702cc1e2994c736250a93e6fb18d1a20 Reviewed-on: https://gerrit.libreoffice.org/79988 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-30tdf#42949 Fix IWYU warnings in xmloff/source/[c-m]*/*cxxGabor Kelemen
Also checked xmloff/qa Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I843917d255f841066ace8d944aa1d00f1b718108 Reviewed-on: https://gerrit.libreoffice.org/79773 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-09-27xmloff: create XMLDrawContentExportOOO instances with an uno constructorMiklos Vajna
See tdf#74608 for motivation. Change-Id: Ib63744f720a886cd67b4158399e6bf91c6efb128 Reviewed-on: https://gerrit.libreoffice.org/79660 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-09-20xmloff: create XMLDrawStylesExportOOO instances with an uno constructorMiklos Vajna
See tdf#74608 for motivation. Change-Id: I875cdd1f1ee4e57522d992768dfbcdb0da9f3fd3 Reviewed-on: https://gerrit.libreoffice.org/79228 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-09-13xmloff: create XMLDrawExportOOO instances with an uno constructorMiklos Vajna
See tdf#74608 for motivation. Change-Id: I3829df0f3f9d81257f06ef3c2f4fbe9af98dd953 Reviewed-on: https://gerrit.libreoffice.org/78859 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-08-29xmloff: create XMLImpressExportOOO instances with an uno constructorMiklos Vajna
See tdf#74608 for motivation. Change-Id: I44c3ac24c19f4ecd1d0d01a9a686b486f3b35c48 Reviewed-on: https://gerrit.libreoffice.org/78236 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-08-22xmloff: create XMLImpressSettingsExportOOO instances with an uno constructorMiklos Vajna
See tdf#74608 for motivation. Change-Id: Iadb687fc4d55a093cef262b1205ca6a4da89bfa3 Reviewed-on: https://gerrit.libreoffice.org/77934 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-08-20loplugin:constvars in writerfilter..xmlscriptNoel Grandin
Change-Id: I5a318632bcc575ea7e476ec0fb74c905b252ecdd Reviewed-on: https://gerrit.libreoffice.org/77829 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-16xmloff: create XMLImpressMetaExportOOO instances with an uno constructorMiklos Vajna
See tdf#74608 for motivation. Change-Id: I6c390f6cef83393b630bd0c157aff8d1359c6754 Reviewed-on: https://gerrit.libreoffice.org/77551 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-08-16loplugin:sequenceloop in xmloffNoel Grandin
Change-Id: I1fde11da5f6e97255a9140f11c298d6d525f7230 Reviewed-on: https://gerrit.libreoffice.org/77543 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-08xmloff: create XMLImpressContentExportOOO instances with an uno constructorMiklos Vajna
See tdf#74608 for motivation. Change-Id: I8a7367720d50baa95406e5e4d8df718fb3e07ac7 Reviewed-on: https://gerrit.libreoffice.org/77132 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-08-01xmloff: create XMLImpressStylesExportOOO instances with an uno constructorMiklos Vajna
See tdf#74608 for motivation. Change-Id: I6b99c5975eacbaba5dbec1ae679c9e5726bdfd6b Reviewed-on: https://gerrit.libreoffice.org/76766 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-07-31Improved loplugin:stringconstant (now that GCC 7 supports it): xmloffStephan Bergmann
Change-Id: I0791c0df1793e05900a32fcdb6d32831bbbe3f9a Reviewed-on: https://gerrit.libreoffice.org/76623 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-07-21loplugin:referencecasting in xmloffNoel Grandin
Change-Id: Iac3d56511aacec73bc38f57890c44145a4c13b85 Reviewed-on: https://gerrit.libreoffice.org/76034 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-12Simplify Sequence iterations in xmloff/source/{draw..script}Arkadiy Illarionov
Use range-based loops or replace with comphelper or STL functions Change-Id: I1d25ad2badccff476f3221829e8f1caf22ad3975 Reviewed-on: https://gerrit.libreoffice.org/72191 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-13fix wrong SET/QUERY flags passed to uno::ReferenceNoel Grandin
By creating deleted methods for the wrong calls. Avoids the compiler needing to construct a temporary Change-Id: I3b8c648d6bb22d22827bf74f21ea5a2a17fc0f6a Reviewed-on: https://gerrit.libreoffice.org/72103 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-09xmloff: create XMLImpressSettingsExportOasis instances with an uno constructorMiklos Vajna
Change-Id: Ibe4ef82cf719afd008f1be23ed4a0e953c61d73f Reviewed-on: https://gerrit.libreoffice.org/72010 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-04-25xmloff: create XMLImpressMetaExportOasis instances with an uno constructorMiklos Vajna
Change-Id: I350c2c96cd178878ae687dd5214fcabfcf7675e7 Reviewed-on: https://gerrit.libreoffice.org/71254 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-04-15loplugin:sequentialassign in writerfilter..xmlsecurityNoel Grandin
Change-Id: I41028c704eca08b71746c3c87e38926b95449775 Reviewed-on: https://gerrit.libreoffice.org/70735 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-14loplugin:unusedfields in xmloffNoel Grandin
Change-Id: I96de7fa324e3d2e3f0f133c93cf73776f4615ed3 Reviewed-on: https://gerrit.libreoffice.org/68134 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-21xmloff: create XMLImpressContentExportOasis instances with an uno constructorMiklos Vajna
Change-Id: I75301ca29794dd42a966faa36add3078c8c55211 Reviewed-on: https://gerrit.libreoffice.org/68166 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-02-15xmloff: create XMLImpressStylesExportOasis instances with an uno constructorMiklos Vajna
Change-Id: I831321bcce241bc180e22b20364137f776fee0f9 Reviewed-on: https://gerrit.libreoffice.org/67847 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-02-11loplugin:indentation in writerfilter..xmloffNoel Grandin
Change-Id: Ibda157508e92ab5fb222daf79a38941c30a8057e Reviewed-on: https://gerrit.libreoffice.org/67611 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-08xmloff: create XMLImpressExportOasis instances with an uno constructorMiklos Vajna
Change-Id: I58c689f5a1b034f64687031e24b82a3ac56e4bae Reviewed-on: https://gerrit.libreoffice.org/67519 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-01-22tdf#42949 Fix IWYU warnings in include/xmloff/*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Id20e0bc42e39f868a7c5d49d756f2ad5e14a86c0 Reviewed-on: https://gerrit.libreoffice.org/66637 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-12-18use unique_ptr in ImpXMLAutoLayoutInfoNoel Grandin
Change-Id: Iede8522988ae26a76fe5bb28491c17b76376420f Reviewed-on: https://gerrit.libreoffice.org/65145 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-29remove unnecessary "if (!empty()" checks before loopsNoel Grandin
found with git grep -n -A4 'if.*!.*empty' | grep -B3 -P '(\bfor)|(\bwhile)|(\bdo)' Change-Id: I582235b7cf977a0f9fb4099eb306fdb4a07b5334 Reviewed-on: https://gerrit.libreoffice.org/64169 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-09Revert "Fix some layout values"Julien Nabet
Nothing proves this is ok since no feedback. Moreover, since it's only of the assumption that setWidth and setHeight should have value >= 0 or -1, let's revert this one. This reverts commit d467214ac24e22818ff933d76148f3f0987c65ca. Change-Id: Ia030706d150afaebaedc0ec201814cca80db248a Reviewed-on: https://gerrit.libreoffice.org/63171 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-11-08Fix some layout valuesJulien Nabet
Cases indicated here correspond to portrait layout so use else cases from sd/source/core/sdpage.cxx:3013 switch: case 24/AUTOLAYOUT_HANDOUT3 nColCnt = 2; nRowCnt = 3; case 26/AUTOLAYOUT_HANDOUT6 nColCnt = 2; nRowCnt = 3; break; and so avoid some negative values for param given to setHeight in xmloff/source/draw/sdxmlexp.cxx during sd tests Change-Id: I5ffd9581c19f31b648775f57e270ab55f330dad5 Reviewed-on: https://gerrit.libreoffice.org/62978 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-10-28tdf#120703 PVS: V547 Expression is always true/falseMike Kaganski
Change-Id: Iaa1a1811b638aadfe6b06b3465a182cb675031b5 Reviewed-on: https://gerrit.libreoffice.org/62476 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-26tdf#42949 Fix IWYU warnings in include/unotools/*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I444c43b9d549977039f25bec2b5bf666c3e15e0e Reviewed-on: https://gerrit.libreoffice.org/62041 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>