summaryrefslogtreecommitdiff
path: root/xmloff/source/draw
AgeCommit message (Collapse)Author
2013-09-03fdo#68839: ODF import: fix name of multi-image frameMichael Stahl
When multiple image child elements are inside a frame, each one is imported and gets unique name via SwDoc::SetFlyName(). But the retained one is not necessarily the first one, which is the only one that may have the original name. Also the solveMultipleImages needs to return a smart pointer, as nothing else keeps the image contexts alive. (regression from 44cfc7cb6533d827fd2d6e586d92c61d7d7f7a70) Change-Id: I28a8a752f3eed176cc2ebb4c9af11a0dd4d18ea6
2013-08-21finish deprecation of O(U)String::valueOf()Luboš Luňák
Compiler plugin to replace with matching number(), boolean() or OUString ctor, ran it, few manual tweaks, mark as really deprecated. Change-Id: I4a79bdbcf4c460d21e73b635d2bd3725c22876b2
2013-08-19fdo#57950: Remove some chained appends in xmloffJelle van der Waa
Change-Id: Iff0c43d190e6afa26c23416db4da9843cf7f41a5 Reviewed-on: https://gerrit.libreoffice.org/5327 Reviewed-by: Petr Mladek <pmladek@suse.cz> Tested-by: Petr Mladek <pmladek@suse.cz>
2013-08-16Properly hide implementation details.Kohei Yoshida
If we are to hide, let's hide all. Change-Id: Ic68926ee099ac80d2d477d68e3769a7203dfea6c
2013-08-10fdo#62475 removed pointless commentsJelle van der Waa
Change-Id: I176886fbc9f3d9e2b8ad2308ac2b127d9c68d9a6 Reviewed-on: https://gerrit.libreoffice.org/5331 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2013-07-18Mark as static and/or constTakeshi Abe
Change-Id: I45a890bb793a6d92546c05bd75738d4dd753a01e
2013-07-15i#108348: support DateTimeWithTimezone in user defined Document PropertiesMichael Stahl
- fix interface of sax::Converter to allow passing time zones (rename the parsing methods while at it to reduce pointless overloading) - SfxDocumentMetaData supports DateWithTimezone and DateTimeWithTimezone in user-defined properties - add some ugly hacks to SfxCustomPropertiesPage to preserve existing time zones (which are not displayed in UI currently) Change-Id: Ice94112b9d79c285f80b5beda15f0ace91db97f3
2013-07-10drop useless conditionDavid Tardon
Change-Id: I31368921a7a398f55731081848f4df58663e3136
2013-06-29remove OUString wrap for string literalsThomas Arnhold
For some functions and all kinds of Exceptions. CannotConvertException CloseVetoException DisposedException EmptyUndoStackException ErrorCodeIOException Exception GridInvalidDataException GridInvalidModelException IOException IllegalAccessException IllegalArgumentException IllegalTypeException IndexOutOfBoundsException NoMasterException NoSuchElementException NoSupportException PropertyVetoException RuntimeException SAXException ScannerException StorageWrappedTargetException UnsupportedFlavorException VetoException WrappedTargetException ZipIOException throwGenericSQLException throwIllegallArgumentException createInstance createInstanceWithContext forName getByName getPackageManager getPropertyValue getUnpackedValueOrDefault getValueByName hasPropertyByName openKey setName setPropertyValue supportsService bash command: for i in `cat list`; do git grep "$i\s*(\s*OUString(\s*\"" -- '*.[hc]xx' | cut -d ':' -f1 | sort -u | xargs sed -i -e "s/\(\<$i\s*(\)\s*OUString(\s*\(\"[^\")\\]*\"\)\s*)\s*/\1\2/g" -e "s/\($i.*\)\"+ /\1\" + /g"; done Change-Id: Iaf8e641b0abf28c082906014f87a183517630535 Reviewed-on: https://gerrit.libreoffice.org/4624 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-06-29String to OUString and cleanupThomas Arnhold
Change-Id: Idc18c1a6a64edea3399c8747ec0f096a2f964b68
2013-06-23Resolves: rhbz#976304 gallery elements may not support document.SettingsCaolán McNamara
so the createInstance throws, so the element doesn't get inserted into the documents. regression since f0cd6fe9075cd0aa00162474784ad804a07ed138 Change-Id: Ie6cef7a4f0d5ac8a34d41139c3439fc04e9c7f20
2013-06-19fdo#43460 xmloff: use isEmpty()Jelle van der Waa
Change-Id: I298767cc0ec03c22d3ae687939f0f9d5ce1963c1 Reviewed-on: https://gerrit.libreoffice.org/4348 Reviewed-by: Noel Power <noel.power@suse.com> Tested-by: Noel Power <noel.power@suse.com>
2013-06-08Resolves: #i121455# Adapted from NonPrimitive to non-primitive...Armin Le Grand
as used in the spec Patch by: Regina Review by: alg (cherry picked from commit af6ada82a4634e4b64faf811eaf527c167c334bf) Conflicts: xmloff/source/draw/shapeexport4.cxx Change-Id: I2fe339ba35cf589a9d4034446c671d4f09b0c0f0
2013-06-07For backward compatibility take mirrorings in setTransformation into accountArmin Le Grand
Also found an error in SdrObjCustomShape::TRGetBaseGeometry when MirrorY was used (cherry picked from commit 4116c33b12d3787c406f0348f89efcb1cf409507) Conflicts: xmloff/source/draw/ximpshap.cxx xmloff/source/draw/ximpshap.hxx Change-Id: Id85ae4c4f5e26d53d501c72b84fc0e1b5cfe23b2
2013-05-30Resolves: #i121507# Added comma to whitespace listArmin Le Grand
(cherry picked from commit c9e446d6f79908ed4af06e7940788e91b924b793) Change-Id: I790bfada597e276f9f9e1d07f7208db6d1059f0f
2013-05-18set some bug id prefixes to indicate which tracker they are fromCaolán McNamara
Change-Id: I5df2dd44a0612da893b1afe08d0c7a9ea71f3905
2013-05-18i121972 Use svg rx/ry/cx/cy defines in draw:ellipse when used(cherry picked ↵Armin Le Grand
from commit 19abb8de7e218ba08b2fa79c0379844303da328a)
2013-05-18#121090# corrceted point reduction on svg:d export to only happen when ↵Armin Le Grand
polygon is closed(cherry picked from commit 6e114c242bb21950fd8ea01885c2269744d0fc6f)
2013-05-18i121965 Take draw:transform into account for draw:connector shapesArmin Le Grand
(cherry picked from commit 7b3f5521bd3c400cd9e08b745176b4ce40885011) Conflicts: xmloff/source/draw/ximpshap.cxx Change-Id: I973627f85ce6463c863863d6c180cb4c2cab86d0
2013-05-15sw: change pool default of RES_FOLLOW_TEXT_FLOW to "false"Michael Stahl
For a new document the default is already effectively "false" due to SwDocShell::InitNew() and the ODF and WW8 filters set it explicitly to false... which is also the appropriate value for RTF and DOCX. But only OOoXML and (perhaps) HTML (not sure) want "true" as the default. It is also mysteriously reset to "true" in SwDoc::RemoveAllFmtLanguageDependencies() (which is called after loading a template) for no apparent reason. Change-Id: If5ad33c99f97412cb3ad4f9cec32f47825ed6f6b
2013-05-15i#119922: reverse engineer 9a37613b5e8f08fae585d54a5745e887eb08f8ceMichael Stahl
It is not quite obvious what that commit attempts to do... especially since the bugdoc attachment does not actually exercise the code that was added in the commit, which changes the handling of the "IsFollowingTextFlow" property. The corresponding ODF attribute is style:flow-with-text, which has been added in OOo 2.0. Investigation revels that MSO's ODF filter does not support this attribute and acts as if it always had value "false". The code in FillBaseProperties effectively acts as a default if the value is not set; the ODF spec does not specify what the default should be. But when an ODF document was written by MSO, "false" makes more sense than the previous "true" default. Except when the document is not ODF but OOoXML format, which indicates it's likely written by OOo 1.x which did not support the attribute and acts as if it always had value "true". The Writer UNO API implementation is however not the right place for format specific handling, so replace that with an addition to the function reading the default graphic style that sets the "IsFollowingTextFlow" property to false as a default, which should have the same effect because all styles inherit from it. Note: MSO 2010 Word always writes a default graphic style into ODF docs. This has a side effect for loaded ODF documents: various newly inserted objects have the property turned off then. But it turns out this is actually an advantage, since the same behavior already exists for _new_ documents (see SwDocShell::InitNew) so it is more consistent now. Change-Id: Iba6444a0515fd583398ff052fc5018254da31c30
2013-05-15Fix fdo#64512 Handle xml:id correctly on multi-image draw:framesThorsten Behrens
Fixes a regression from the pick-best-image from draw:frame in ODF, where before sometimes the XShape got deleted that the UnoInterfaceToUniqueIdentifierMapper::registerReference stored. For that, added a UnoInterfaceToUniqueIdentifierMapper::registerReferenceAlways function, which overwrites potentially existing earlier entries with the same identifier string. This fix was originally much more messy, but then dtardon committed 30b248dfe5bfb8a0649e36f22c943b3feb2f1385 which also fixes this here bug. Now only sneaking in slightly less involved interface map handling and a safeguard in ximpshap.cxx. Change-Id: I87501e43518a5fc2fee166c45a4e2f01718f5228
2013-05-15Use upper camel case for class names in xmloff.Thorsten Behrens
Align multiimagehelper with module standard. Change-Id: I70a4dbc66a0d127b9bf04d1e8db694d3526b21d7
2013-05-15fdo#46808, Convert some XMultiServiceFactory to XComponentContextNoel Grandin
Change-Id: I2e3480bf4f616231ee50a83f440d9bb0955e4ce6
2013-05-14fdo#43157 - Clean up OSL_ASSERT, DBG_ASSERTRadu Ioan
- replaced osl_trace with sal_info - replaced dbg_* with sal_* Change-Id: I80aca85562e4a43fded5c37f9895e51f79e42c14 Reviewed-on: https://gerrit.libreoffice.org/3771 Reviewed-by: Bosdonnat Cedric <cedric.bosdonnat@free.fr> Tested-by: Bosdonnat Cedric <cedric.bosdonnat@free.fr>
2013-05-10Resolves: #i122208# introduce rtl::CStringHash and rtl::CStringEqualHerbert Dürr
unify the various c-string compares and hashes. (cherry picked from commit b7e3470a154538a92f0a21b14e726d75723f4a92) Conflicts: oox/inc/oox/export/shapes.hxx oox/source/export/shapes.cxx sal/inc/rtl/string.hxx sdext/source/minimizer/pppoptimizertoken.cxx svx/source/customshapes/EnhancedCustomShapeTypeNames.cxx vcl/source/glyphs/gcach_ftyp.cxx writerfilter/source/resourcemodel/TagLogger.cxx xmloff/source/draw/EnhancedCustomShapeToken.cxx Change-Id: Ib742744077bfb4d38a462d88b44bdef45601b4ae
2013-05-03fdo#48056 treat report chart as draw chartLionel Elie Mamane
Change-Id: I0a716b4339747f1994e5c8710e15474807aea4a2
2013-05-03janitorial: indentationLionel Elie Mamane
Change-Id: I6886f5ed011871a1c2718c9e1fadc9d0cb053098
2013-05-03fdo#60075 open drawings with connector attached to SVGDavid Tardon
This problem arises when there is a connector attached to draw:frame element with multiple draw:image elements in it. The import code expects that they are different representations of the same image (I have not found if this is specified in ODF), so it only selects the most "suitable" for import. To do that, it imports them all and then removes all but the selected one. The image import context, SdXMLGraphicObjectShapeContext, shares the parent frame's attributes, which means that all the images in a frame have got the same ID. in SdXMLGraphicObjectShapeContext::AddShape, the created css::draw::XShape is registered with its ID... That means that anything that refers to the frame's ID, like a draw:connector, will always get the _first_ image in the frame. Solution is to extend comphelper::UnoInterfaceToUniqueIdentifierMapper to allow reserving an identifier and setting an interface for it later. That way, SdXMLFrameShapeContext can reserve its own ID before it starts importing the first draw:image, and then set the selected XShape at the end. Change-Id: I2e11cfd38e1e3534df2b3c01d85da0d755a266c3
2013-05-03the var. must be persistent over multiple callsDavid Tardon
Change-Id: Ieb48dfe85ed16a8123917b30873f301d523ea381
2013-04-20Remove pass-through header file sot/inc/sot/clsids.hxxMichael Dunphy
Change-Id: I122669d4ffaf72fb1d5f6fccc98e8a648f31aa23 Reviewed-on: https://gerrit.libreoffice.org/3490 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2013-04-20fdo#63154: Change Min/Max/Abs for std::min/max/absMarcos Paulo de Souza
Now all these usages were removed from LO. Change-Id: I8a7233db20abdcdbb18428ad4004c78cc516a0e6 Reviewed-on: https://gerrit.libreoffice.org/3326 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2013-04-18date/time IDL datatypes incompatible changeLionel Elie Mamane
- nanosecond precision - signed (allowed negative) year Also: assorted improvements / bugfixes in date/time handling code. Some factorisation of copy/pasted code. Change-Id: I761a1b0b8731c82f19a0c37acbcf43d3c06d6cd6
2013-04-10fdo#39066: using UNO_QUERY instead of UNO_QUERY_THROW displays hyperlinksChr. Rossmanith
Change-Id: Iafa9e273c009fe0772a9401b47b51738dc235a13 Reviewed-on: https://gerrit.libreoffice.org/3296 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2013-04-07mass removal of rtl:: prefixes for O(U)String*Luboš Luňák
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk have kept them, in order not to break external API (the automatic using declaration is LO-internal). Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-05fdo#59071 Slideshow: allow automatic transitions with sub-secondCao Cuong Ngo
Enable slide transition each 0.25 second instead of whole second. Change-Id: I1907a1baf30cede91a0438d021e003204ea06651
2013-03-27-Wunused-macrosStephan Bergmann
Change-Id: Ifaa1637122d6f9cae1e29b77ac36ca5d1f220aed
2013-03-25remove external include guardsThomas Arnhold
Change-Id: If5758e02baa8e019923355b6c97043b306223fdd
2013-03-22SdXMLExport::CreateFontAutoStylePool: "EmbedFonts": ignore exceptionsMichael Stahl
(regression from f0cd6fe9075cd0aa00162474784ad804a07ed138) Change-Id: Ia86c0d168e9dd24555e7431666c0d783daef3b6a
2013-03-18fdo#61256 - the Get.*Export methods also create and register stylesMichael Meeks
unwind problem introduced by cleanup in: fd226710fef768543a3ad0fe5081f79dc875dcf3
2013-03-11use startsWith() instead of compareToAscii()Thomas Arnhold
brain damage... Change-Id: I4dc63c7346f724eded9ac7b82cda25c2bb60beff
2013-03-09Resolves: #i120663# The SvXMLImportContext is always leakedJian Fang Zhang
The slave SvXMLImportContext object for SdXMLNumberFormatMemberImportContext is always leaked Found by: zhangjf Patch by: zhangjf (cherry picked from commit e440770de29e96ce3e45792c0e94f133ade83680) Change-Id: Ic0585bbb8e0e315548586ea1e49f55d0cc7ed2c4
2013-03-09fdo#43460: use isEmpty()Thomas Arnhold
Change-Id: I47b35af71277fdda19767a553c960bf12164b92f
2013-03-08simplify compareTo (now correct)Thomas Arnhold
Change-Id: Ia4fd2f54d0bda71d472f46949500c0b23ff8e1b7 Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2013-03-08Revert "simplify some compareTo"Stephan Bergmann
This reverts commit 19020191cbf3e3c7a7bf98d0958d86d931ae687b, s1.compareTo(s2, length-of-s2) is *not* equivalent to s1 == s2
2013-03-08simplify some compareToThomas Arnhold
Change-Id: Ib63cfac8b5f129f31534020fd634750e846e3b98
2013-03-08some further OUString cleanupThomas Arnhold
Change-Id: I13eb94092e29ececc9fbf494074acde5f893b605
2013-03-03binfilter: remove some tracesThomas Arnhold
Change-Id: I5b03dcb5d1f8c73c7a308e7ae209cc7872f18c61
2013-03-03Related to fdo#60724: correct spellingThomas Arnhold
Using the autocorrect list of LibreOffice extras/source/autotext/lang/en-US/acor/DocumentList.xml Change-Id: I8b93969bc0742c2e95b8b7db3c4c37691e8d3657 Script: http://pastebin.ca/2327716
2013-03-02Typo fix: informations -> information and a few other adjacent typos.Gregg King
FDO:60724 Change-Id: I73ad9f1c37cbbcf28d996ed73c75cf09553e499b Reviewed-on: https://gerrit.libreoffice.org/2479 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
generated by cgit (git 2.34.1) at 2025-01-31 02:06:30 +0000