summaryrefslogtreecommitdiff
path: root/xmloff/source/text
AgeCommit message (Collapse)Author
2020-08-29use fastparser in SvXMLPropertySetContext subclassesNoel Grandin
Change-Id: I977f1cf198652d3c73e5a0f473794975a5647617 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101564 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-28Change OUStringLiteral from char[] to char16_t[]Stephan Bergmann
This is a prerequisite for making conversion from OUStringLiteral to OUString more efficient at least for C++20 (by replacing its internals with a constexpr- generated sal_uString-compatible layout with a SAL_STRING_STATIC_FLAG refCount, conditionally for C++20 for now). For a configure-wise bare-bones build on Linux, size reported by `du -bs instdir` grew by 118792 bytes from 1155636636 to 1155755428. In most places just a u"..." string literal prefix had to be added. In some places char const a[] = "..."; variables have been changed to char16_t, and a few places required even further changes to code (which prompted the addition of include/o3tl/string_view.hxx helper function o3tl::equalsIgnoreAsciiCase and the additional OUString::createFromAscii overload). For all uses of macros expanding to string literals, the relevant uses have been rewritten as u"" MACRO instead of changing the macro definitions. It should be possible to change at least some of those macro definitions (and drop the u"" from their call sites) in follow-up commits. Change-Id: Iec4ef1a057d412d22443312d40c6a8a290dc6144 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101483 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-27Fix typos in codeAndrea Gelmini
It passe "make check" on Linux Change-Id: I9e663ac6fc4818d74cb4b239387ba8b1d7db0ee4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101470 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-08-27use fastparser in CreateHeaderFooterContextNoel Grandin
Change-Id: Ic0a4e4911bb56fd9731e0e9d3850387b1f26b1d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101474 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-27xmloff: prefix members of XMLTextFieldImportContextJulien Nabet
Change-Id: I8a67d0c1c24e6c82803198fe343d4ee1c095b9b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101484 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-08-27Fix typosAndrea Gelmini
It passed "make check" on Linux Change-Id: I5f39984f1c30fcde46ed411faac3f8d637d10d6f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101449 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-08-27convert remaining XMLPropStyleContext subclasses to fastparserNoel Grandin
Change-Id: If78be8caf1b1a87ef16abf04a29bc30762ddb90b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101440 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-26use more fastparser in SdXMLMasterPageContextNoel Grandin
and drop some unused code Change-Id: I4ed57ab843759e2214ad2b679003fcc329c073ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101382 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-26remove slowparser stuff from SvXMLStyleContextNoel Grandin
Change-Id: Ic4efc2eba7d1cdd71df76b535811c706bab3860e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101347 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-26use fastparser in SwXMLStylesContext_ImplNoel Grandin
Change-Id: I81075b44ec8417bf0126aa5a64389b434c1247f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101345 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-26use more fastparser in XMLTableStyleContextNoel Grandin
Change-Id: I558459138f3d4191b6ecdcf726d022497dbb9f06 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101321 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-23use fastparser in XMLTextMasterStylesContextNoel Grandin
Change-Id: I2eaae244264ca9ab726d8e69a3e53a76481b5a36 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101173 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-21Fix typo in codeAndrea Gelmini
Change-Id: Id4df6228804bb31bde0a11327c69eb939cc57ccf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101101 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-08-21use fastparser in XMLLineNumberingImportContextNoel Grandin
Change-Id: Ib6e590eccffea94dccc4b943d3cf92124882c064 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101170 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-21use fast-parser in XMLFootnoteConfigurationImportContextNoel Grandin
Change-Id: Ic139ef9956f59178582a344f65926f95a6423f14 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101149 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-21no need to call superclass hereNoel Grandin
there is no CreateChildContext in the superclass (and the next implementation of that method that is actually called is not going to do anything useful here) Change-Id: I503924eaaef8f450549c2eaa2195661ce0de8c2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101136 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-21use fast-parser in XMLIndexBibliographyConfigurationContextNoel Grandin
Change-Id: If83d582978803c0e79bf59f4e0576410a1849289 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101133 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-21tdf#135942: avoid collecting autostyles during writing themMike Kaganski
This modifies the container over which iteration is performed. Additionally, make sure that all nested table autostyles are collected on the first phase. Change-Id: I74c0bb1aaacad095226c21e6bf51cc8668133bb3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101096 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-08-18Fix typosAndrea Gelmini
Change-Id: I85a91d24943430b42217ac91611f182059d8ec69 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100919 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-08-18loplugin:unusedvarsglobalNoel Grandin
tackle some read-only vars. Mark some of them const to make it obvious they are not really used, and to make the constantparam plugin see more data. Change-Id: Ia25927745866746aa1aa9d5affd5857ad9f9ee24 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100895 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-14loplugin:simplifybool moreNoel Grandin
look for expressions like !(a && !b) which can be expanded out Change-Id: I72515a9638762b050f9a258c08da39ebfa2ef8e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100579 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-14rename xmlnmspe -> xmlnamespaceNoel Grandin
Change-Id: I8fdf9833dede6f4c9ba4bbb76b9ab9b6b419f155 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100722 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-14rename nmspmap.hxx -> namespacemap.hxxNoel Grandin
we're not in DOS anymore, Dorothy Change-Id: I79926e0d694163940ba7ebf20419724dd0a486f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100721 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-07cid#1465671 Unchecked return valueCaolán McNamara
Change-Id: I796799f2964f70f107acc53d376379a79e044472 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100294 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-06loplugin:flatten in xmloff/textNoel Grandin
Change-Id: Iffadbe50a3b1e8263725b8f22395c5eaac11534d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100199 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-05tdf#124470: Split export of table autostyles out from collection phaseMike Kaganski
This allows to call collectAutoStyles where required (e.g. when enumerating used fonts), without side effect of writing table styles XML inside the call, out of place. Change-Id: Ida05e373eb8502590c43e2b0e85c3b0c1107c551 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100153 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-08-05Simplify this a littleMike Kaganski
Change-Id: I81298ad97ef2161fb9e52466b7e17cd5a142067b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100065 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-08-04tdf#130707 xmloff: survive <text:database-display> in editeng textMiklos Vajna
Regression from commit 28d67b792724a23015dec32fb0278b729f676736 (tdf#107776 sw ODF shape import: make is-textbox check more strict, 2019-08-26), now that we correctly identify what shape text to import as "textbox" (Writer TextFrame) and what to import as editeng text, there are documents out there that try to import mailmerge fields into editeng-based shape text. Fix missing error handling there. Note that the error is not just silently ignored, we do insert the field result into the shape text, existing code provides this already. Change-Id: Ibe631ac5d94c1c7795dd00bad05fdcca0e6741a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100028 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-08-03use more explicit types in xmloffNoel Grandin
instead of declaring them as a base-type, and then static-casting everwhere Change-Id: I53b901c5353bb39ca9a0357aa442f50d2f475e7d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99995 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-03rename Clear() to dispose() in SvXMLStylesContextNoel Grandin
to make it "clearer" this is part of the memory cleanup on destruction process Change-Id: I789bdfa0323cf759ed4db2e2a657e73e581d9eed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99990 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-03fix leak in SvXMLImportNoel Grandin
caused by a ref-counting cycle. to reproduce the leak do make CppunitTest_editeng_core \ VALGRIND='memcheck --leak-check=full \ --suppressions=$$BUILDDIR/solenv/sanitizers/valgrind-suppressions' \ CPPUNIT_TEST_NAME="testBoldItalicCopyPaste" Change-Id: I94dca092a75db8ddfaae4a210e1158fa066ed609 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99989 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-30tdf#38093 Writer outline folding - persistenceJim Raykowski
Patch 6/6 that breaks down https://gerrit.libreoffice.org/c/core/+/96672 Adds persistence attribute loext:outline-content-visible Change-Id: Ide3eeee0f127a05def4d4f493bb4b469e0877b00 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99657 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-07-29Remove some unused includesMiklos Vajna
Change-Id: I9af7e2fa0a450ebe396c0f049831a20100dbdc9c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99659 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-07-02Upcoming improved loplugin:staticanonymous -> redundantstatic: xmloffStephan Bergmann
Change-Id: I47bd2f4b6bbe47b8a6c0aa8102186bf25a3804f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97772 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-01reorder parameters of SvXMLExport::SvXMLExportNoel Grandin
so they all have similar order Change-Id: Id8baef058d52f6cce9d9be41b0341eec8ad648b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97628 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-06-10xmloff: create XMLAutoTextEventExportOOO instances with an uno constructorMiklos Vajna
See tdf#74608 for motivation. Change-Id: Ibb3bc2afba00ff962e3ed4f14a5e5a3c735a1a29 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95963 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-06-05Upcoming loplugin:elidestringvar: xmloffStephan Bergmann
Change-Id: I42210925cc560fa32316c2ad7b7732c7624b1a05 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95606 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-05xmloff: create XMLAutoTextEventImport instances with an uno constructorMiklos Vajna
See tdf#74608 for motivation. Change-Id: I24f64c9ebc2c86a574f3a76f1e739f61bc458dc7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95536 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-06-02tdf#133555 xmloff: ODF export: don't produce text:drop-down in ODF 1.2Michael Stahl
This was added in ODF 1.3 as OFFICE-3881, but it's actually ancient and was written by OOo 2 already, just somehow forgotten to add it to ODF. Change-Id: I322fac471c940334f886a7c61769922ae03ee89b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95359 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-05-29xmloff: create XMLAutoTextEventExport instances with an uno constructorMiklos Vajna
See tdf#74608 for motivation. Change-Id: I068b45302d200ccbde082a748a110324bbbbbaec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95065 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-05-22[API CHANGE] officecfg,xmloff: remove SaveBackwardCompatibleODFMichael Stahl
org.openoffice.Office.Common.Save.Document.SaveBackwardCompatibleODF was added in 2007 and apparently enables storing invalid ODF (or OOoXML) to workaround bugs in OOo <= 2.3; nobody should need it in this day and age, and the OOoXML export has been removed anyway. bce5e157785745a6729db62b15fb98bc396cddee 2007 c7a3859693971bf7103bfb0d05d64712e724fa37 2007 7477a65e09b20917adf025550c550f8822b508ee 2007 77baabe992c77018a0467ffec8f9482f8d76b66b 2007 575222083e058a740f5ad69e14e18622c3d4f7af 2007 66b908b45cde78af020b35e817e67bc40b8493f0 2007 Change-Id: Ib3f730c7c9ac6fbbbbae9fb4a42c1bd65f6c93df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94571 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-05-19tdf#103602 xmloff,sw: ODF 1.3 import: PageStyle with drawing-page styleMichael Stahl
Associate a style of family "drawing-page" with a style:master-page. This fixes the small part of the draw:fill attribute problem that is covered by OFFICE-3937 in ODF 1.3. This is the import part. Change-Id: I4c86fa24c36407b64ce33f0890e5da8c26c5292a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93670 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-05-19tdf#91306 xmloff: ODF export: allow style:page-number="0" in ODF 1.3Michael Stahl
See OFFICE-3923. Change-Id: I619d9efe3eb17feaf84f7dd21f5b2197c30bc6aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93225 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-05-15replace hard-coded "1.2" ODF version stringsMichael Stahl
Most of these are calls to DocumentDigitalSignatures::createWithVersion(), where it doesn't make a difference if "1.2" or "1.3" is passed in but maybe it will be different with "1.4". There is another ctor createDefault() which looks appropriate for non-ODF contexts and can also be used when no actual signing or verifying is done. In cases where there's an actual document its Storage has the version. Change-Id: Id636bbf965d9f96c7ed5f50774c509032525b2b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93091 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-05-12xmloff: ODF export: adapt to ODF 1.3Michael Stahl
* OFFICE-3883 legend svg:width/svg:height * OFFICE-3928 chart:coordinate-region * OFFICE-3943 draw:mime-type * OFFICE-3765 number:fill-character, number:text * OFFICE-3860 number:min-decimal-places, number:forced-exponent-sign * OFFICE-1828 number:exponent-interval * OFFICE-3695 number:max-denominator-value * OFFICE-3941 text:index-entry-link-start/text:index-entry-link-end * OFFICE-3776 meta:creator-initials * OFFICE-3789 style:header-first/style:footer-first Change-Id: I78c79231c0708c3ae9943097d162898fab71988f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92873 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-05-10compact namespace in xmlhelp..xmlsecurityNoel Grandin
Change-Id: I54f0a47a4b7a1f85481fd1e643ac55459d0383ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93907 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-10new loplugin:simplifypointertoboolNoel Grandin
Change-Id: Iff68e8f379614a6ab6a6e0d1bad18e70bc76d76a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91907 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-09xmloff: ODF export: adapt all checks of ODFSVER_012 etc.Michael Stahl
Most of these actually want to check ODFSVER_EXTENDED because the extension didn't get into ODF 1.3. Change-Id: I1b625a329f7a3d146c616c62c15b56e2c314c2c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92872 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Jenkins
2020-05-09sc,xmloff: ODF 1.3: adapt XMLPropertyMapEntryMichael Stahl
Map the following property attributes to ODFSVER_013: * OFFICE-2173 table:tab-color * OFFICE-3767 text:contextual-spacing * OFFICE-3857 table:scale-to-X/table:scale-to-Y Change-Id: I3585560a3654c71353bbcaf66da20eacba8ebd1f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92861 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Jenkins
2020-05-08xmloff: ODF export: rework version checks in SvXMLExportPropertyMapperMichael Stahl
There's some issues with the version checks here: * The requirement is to retain support for ODF 1.2 extended, but some attributes are in ODF 1.3, while others require ODF 1.3 extended, so a single version number can't be used to compare * A recurring problem is that new extension attributes are erroneously exported to standard namespaces; there is the pre-existing buggy case of style:hyperlink to consider... * Currently it's possible to distinguish multiple extended version but the only minimum version that's actually used is the minimum one ODFSVER_012_EXT_COMPAT Rework this to use a different check, by: * distinguishing extension attributes from standard attributes via their namespace, to avoid such bugs by construction * interpreting the version number always as a standard ODF version number: if the attribute is in extension namespace: if the minimum standard version is met, ignore else: if the minimum standard version is met, export * adapting all XMLPropertyMapEntry to use ODFSVER_FUTURE_EXTENDED for extension attributes (TODO: check which of these should be ODFSVER_013) This should have an effect on the drawext:fontwork* attributes, which need ODFSVER_FUTURE_EXTENDED to be exported now. Change-Id: I986c8064e578a61d69ed5fdb261f23e7582a7d75 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92856 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Jenkins
generated by cgit (git 2.34.1) at 2025-01-06 10:19:57 +0000