summaryrefslogtreecommitdiff
path: root/xmloff/source
AgeCommit message (Collapse)Author
2016-11-04update loplugin:unnnecessaryvirtual to handler destructorsNoel Grandin
and update modules writerfilter..xmloff with the resulting changes Change-Id: I54d19c22ddb0ff579b32e4934d266c925b19305c Reviewed-on: https://gerrit.libreoffice.org/30530 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-31This apparently always wanted to check that _rChars.trim() is non-emptyStephan Bergmann
...and d3e89269304c623e3b52a097e9e270f1bf1f09b8 "initial checkin - implementations for formlayer import/export - still under construction" just forgot the '.getLength()' in OSL_ENSURE(0 == _rChars.trim(), ... that is present in other, similar code. (And the current code happend to use the operator ==(sal_Unicode const *, OUString const &) overload that happens to treat a null first argument like an empty string.) Change-Id: I9d74b6ae29ca5f5f80391de50e4898add6bf6fe2
2016-10-31loplugin:oncevar in xmloff..xmlsecurityNoel Grandin
Change-Id: I2353d3c73130ed9420e8d803a9a96a06549bb6bd Reviewed-on: https://gerrit.libreoffice.org/30429 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-31Omit comparator which is the same as default std::less<key_type>Takeshi Abe
Change-Id: I72a0b618577caececaaf3eb4df53d4cb192251da Reviewed-on: https://gerrit.libreoffice.org/30369 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-10-28update unnecessaryoverride plugin to find pure forwarding methodsNoel Grandin
which can be replaced with using declarations. Is there a more efficient way to code the search? Seems to slow the build down a little. Change-Id: I08cda21fa70dce6572e1acc71bf5e6df36bb951f Reviewed-on: https://gerrit.libreoffice.org/30157 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-24loplugin:expandablemethods in xmloffNoel Grandin
Change-Id: I995a4167ac4df5ca35d963dcf68ae802a997e1e1
2016-10-24Simplify code furtherStephan Bergmann
...after 9ad0e56be46df46b021109acfd6ece9d17ce84f8 "fixes for >>= with rhs Any" Change-Id: Idf7b7033bd0ef5501e2884841ba897f8691a5f77
2016-10-24fixes for >>= with rhs AnyJochen Nitschke
this changes behaviour because >>= always returned true Change-Id: Ia7bbce1696e5c23f6e1e6f1a7e60b3c462cf0086 Reviewed-on: https://gerrit.libreoffice.org/30141 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-21loplugin:expandablemethodds in include/xmloffNoel Grandin
Change-Id: I6b1430220adaf240ef873ff908e3a767dfc278bf Reviewed-on: https://gerrit.libreoffice.org/30106 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-18replace <<= with assign for <<= with rhs AnyJochen Nitschke
found by deleting specialization of '<<=' template Change-Id: I253f15177ab20fd3ef9baf4158da8c662cb47e6c Reviewed-on: https://gerrit.libreoffice.org/29956 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-10-18loplugin:inlineablemethods in xmloffNoel Grandin
Change-Id: I22202f85c65a862ccdafe1d521e2945e3d99252a
2016-10-17replace <<= with assign for <<= with rhs AnyJochen Nitschke
makeAny and Any ctor return an Any Change-Id: Iaa361bc315d785f80153acf1009bf47d109728ec Reviewed-on: https://gerrit.libreoffice.org/29914 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-10-14tdf#64038 ODF import: fix handling of space following <text:s>Michael Stahl
The whitespace collapse algorithm given in ODF 1.2 part 1, "6.1.2 White Space Characters", was not implemented as well as it could be. Although the problematic case is arguably invalid, because "6.1.3 <text:s>" says: This element shall be used to represent the second and all following “ “ (U+0020, SPACE) characters in a sequence of “ “ (U+0020, SPACE) characters. Hence it is probably irrelevant in practice that a space following <text:s> was ignored, because a conforming document cannot have such content. Change-Id: Ic30347fff27176c511ea317d46a1011b410e57d5
2016-10-13loplugin:unnecessaryoverrideNoel Grandin
Change-Id: I08c55a3023ec2e8990098eeb60e91cd18556e7ae Reviewed-on: https://gerrit.libreoffice.org/29656 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-11loplugin:constantfunctionNoel Grandin
update the plugin similarly to commit 3ee3b36ae0c064fb5c81268d8d63444309d1b970 Author: Stephan Bergmann <sbergman@redhat.com> Date: Fri Oct 7 12:05:49 2016 +0200 loplugin:staticmethods: Don't be fooled by decls starting with macros Change-Id: I98ac3216d5acf89a49a26feb089ae2fd34e6e510 Reviewed-on: https://gerrit.libreoffice.org/29665 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-11loplugin:unnnecessaryoverride in xmloffNoel Grandin
Change-Id: Iad519bd61ce1d1bf4ef4e12543b0d485249db36b Reviewed-on: https://gerrit.libreoffice.org/29672 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-11catch the exception to prevent broken charts, tdf#98690Markus Mohrhard
Change-Id: I5958c87ca793c19d5c78dc829eb0ff0a1e04dffa
2016-10-07tdf#102370 Correctly export to Excel exponent without signLaurent Balland-Poirier
Exponent without sign in scientific notation is coded in Excel with a minus sign replacing plus sign: 0.00E-00 for instance This format is already correctly treated in Calc but was not correctly exported to Excel or ODF Change-Id: Ide117b04e0eb887c6cdd6699ae8ec723d1d29d50 Reviewed-on: https://gerrit.libreoffice.org/29198 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2016-10-07loplugin:staticmethods: xmloffStephan Bergmann
Change-Id: Iad001ce011cd6aff4af9bb2e9129abee7fb935dc
2016-10-06xmloff: fix crash in ~XMLParaContext on fdo72541-1.fodtMichael Stahl
Change-Id: I3310699020bfea085eb62c50a7d5de25af51c1b1
2016-10-06rtl::math::approxEqual(value,0.0) never yields true for value!=0.0Eike Rathke
... so replace with a simple value == 0.0 also in other modules than sc. Change-Id: Ie7316505a1cf9c15100114b45d300facceb03b7e Reviewed-on: https://gerrit.libreoffice.org/29575 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2016-10-04this is used as a stack, so convert to std::stackCaolán McNamara
Change-Id: I248617ccbb985615f936ecd607ab7c8246ff8e71
2016-10-04we just care about empty vs nonempty hereCaolán McNamara
Change-Id: Ie7888f611f804ed1bd235e32e21560981f116c9a
2016-10-03Fix typosAndrea Gelmini
Change-Id: Iad27d1f87568890180c142774c238a14d022946d Reviewed-on: https://gerrit.libreoffice.org/29441 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-26implement prototype for more stable calc cell style namesMarkus Mohrhard
This should ensure that as long as the style does not change the cell style name is the same after an import export cycle. Each ScPatternAttr stores a unique ID and we store the ID to name mapping during import. During export if we find a ScPatternAttr that has a key that is also stored in the map we write back the style name from the map. To avoid name collisions we block the style names from the import for the export. The missing piece to make this completely awesome is now to make sure that styles are sorted by name during export. That way we can reduce the diff between import and export even more. Change-Id: Ie4fe2aa00f07efec27ea129e314ac0b6b7e0d8c0 Reviewed-on: https://gerrit.libreoffice.org/29255 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-09-26soon is nowMarkus Mohrhard
Change-Id: Ib4b8b949f00609149f9134fb2f286cd7e0dc0255 Reviewed-on: https://gerrit.libreoffice.org/29254 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-09-25tdf#101935 and tdf#102201:Mohammed Abdul Azeem
This fixes both the bugs. Change-Id: I7a64abc0cb12b5195a3b955549ce4f72f3530d57 Reviewed-on: https://gerrit.libreoffice.org/29263 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-21Resolves: tdf#101708 only export loext table attributes in 'extended' variantCaolán McNamara
Change-Id: I35f297e94e1eb6ed56020cf69102fad4c4d1e7f4
2016-09-18loplugin:unusedenumvaluesNoel Grandin
Change-Id: Icf17f936ce6d07d0e152252833c8645cf9b1163b Reviewed-on: https://gerrit.libreoffice.org/28942 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-16coverity#1372990 xmloff: use unique_ptr for RewindMapsMichael Stahl
Change-Id: I51e67607d94a465ce39e822f01a0c60efbf1a0f0
2016-09-14loplugin:countusersofdefaultparams in xmloffNoel Grandin
Change-Id: Ia92a878ac97b3cc668594946e77a718f27a3e3ed Reviewed-on: https://gerrit.libreoffice.org/28890 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-13unconditionally replacing Y after G (era) with E was always wrongEike Rathke
For example, in en-US locale G MM/DD/YYYY saved and reloaded lead to G MM/DD/EE using the Hebrew calendar. Use E or EE only if a secondary calendar was given. Change-Id: I6db22e89f435342aa4a1bce7fa13711c138007f5
2016-09-13do not add calendar modifier to format code when importing as E or EE keywordEike Rathke
... with implicit calendar switch. Change-Id: Ie4d848e261fe86bbe504954b2e0c7cf24bc181bc
2016-09-13that copypasta comment fragment makes no senseEike Rathke
Change-Id: I835fd6045e5ab5aeb93c91edb07037b1ed3ea4a9
2016-09-13xmloff: invoke SvXMLImportContext destructor with proper namespace mapMichael Stahl
The recent pRewindMap fix revealed that the xContext object is destroyed too late so the destructors containing half the import code (because where else would you put complex logic that can fail?) are invoked with the namespace map of the parent element, which breaks RDFa import and JunitTest_sfx2_complex. (regression from 32ccb4ea863651c22bf33cc15012971d2a2d2810) Change-Id: I0c897ea0cae2db4d35f2ba19ba2f6e8026f1b3ec
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-09-13switch to using LocaleDataWrapper::doesSecondaryCalendarUseEC()Eike Rathke
Change-Id: I6621e82249feeed3d88ee463447d08c4f812259c
2016-09-13coverity#1372877 I'm guessing this is what might have been the intentCaolán McNamara
warning is 'Constant' variable guards dead code Change-Id: I06e65f576180d7ff62417828c26f969982788b55
2016-09-10Blind fix for MSVCStephan Bergmann
Change-Id: I53e01f3c76cf1e52fbf5f95f525cfc3b643b9e77
2016-09-09use std::unique_ptrDavid Tardon
Change-Id: I8ba37267e8a7058ade54783ea0e117a8f8816c45
2016-09-09use std::unique_ptrDavid Tardon
Change-Id: I642486578190ed5e74a917c60153cac084f35fe8
2016-09-09avoid manual memory managementDavid Tardon
Change-Id: Ibc4e7191e5cbc5a14c32b32bab99116173070a87
2016-09-09use std::unique_ptrDavid Tardon
Change-Id: I39475538ed838e4210e256d85c6dd46232f8dc50
2016-09-09use std::unique_ptrDavid Tardon
Change-Id: I52713ea0015a5f0118c337279f37bc38b1121f1e
2016-09-09use std::unique_ptrDavid Tardon
Change-Id: I507b19dfd7445144258554b08bbf2fea0ed1698f
2016-09-09use std::unique_ptrDavid Tardon
Change-Id: I3d7a8a8296e1d107b1f364b5c0785fc9f19cbed5
2016-09-09use std::unique_ptrDavid Tardon
Change-Id: I55c6282c7b60cceb702a5f2f0f24b8ad288ec716
2016-09-09use std::unique_ptrDavid Tardon
Change-Id: Ic0cb9399e5cfc7237a3cda666b1d4f926761a9ca
2016-09-09Blind fix for MSVCStephan Bergmann
Change-Id: I1b3e21e9fdf1ac14e095df203cb48fdd1b4fd028
2016-09-09use std::unique_ptrDavid Tardon
Change-Id: I46dd045b2648f711b3e29ffea0c2e264c141293c
generated by cgit (git 2.34.1) at 2025-02-02 08:06:41 +0000