summaryrefslogtreecommitdiff
path: root/xmloff
AgeCommit message (Collapse)Author
2020-03-25Remove unused using declarations in oox...xmlsecurityGabor Kelemen
Found by: run-clang-tidy-10 -checks=-*,misc-unused-using-decls Change-Id: I3e95791e223ef01e140a6217e29a9efae428a784 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90876 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-03-20xmloff: create SchXMLExport_Oasis_Meta instances with an uno constructorMiklos Vajna
See tdf#74608 for motivation. Change-Id: I7881850e264f421e72389cd51ad1e38e625fb334 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90766 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-03-18Avoid -Werror=unused-but-set-variableStephan Bergmann
...in --enable-debug --enable-werror --disable-assert-always-abort builds like <https://ci.libreoffice.org//job/lo_tb_random_config_linux/2279/>: > /lo/home/tdf/lode/jenkins/workspace/lo_tb_random_config_linux/xmloff/source/core/xmltoken.cxx:3368:18: error: variable ‘foundDuplicate’ set but not used [-Werror=unused-but-set-variable] > 3368 | bool foundDuplicate = false; > | ^~~~~~~~~~~~~~ Change-Id: If9d433082de84c433132276e171ba5c42c24b61c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90699 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-03-16Revert "loplugin:constfields in xmloff"Noel Grandin
This reverts commit 0302c9b192c3b7ba10daabed61d6864c24c14070. Change-Id: Ib919429e22ad039d6a82fe081f4e5421fe08905d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90549 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-16Avoid -Werror=maybe-uninitializedStephan Bergmann
...as seen at least with GCC 10 trunk and --enable-optimized, when bMirroredX/Y were used without checking that reading them with >>= had succeeded. Assuming that in this code (added with b4a6977e05d87fe0a79b266ec30e4f403404f1b4 "tdf#129532 tdf#98839 fixes for mirror of custom shapes") it cannot be guaranteed that rItem.Value is of the right type (so o3tl::forceAccess, which uses assert to verify the right type, would not be appropriate), but that it is an exception-worthy error if rItem.Value is not of the right type (so o3tl::doAccess, which throws a css::uno::RuntimeException upon a wrong type, is appropriate). Change-Id: Ibe6991d69a1d6a0c2c41c839c240050a6355e98b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90337 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-03-14tdf#130975 replace `rtl::math::isNan` with `std::isnan`.Yukio Siraichi
Change-Id: I5d53e6369d35093445b2efd8936bbf8c6775ff47 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90451 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-03-13xmloff: create SchXMLExport_Oasis instances with an uno constructorMiklos Vajna
See tdf#74608 for motivation. Change-Id: Ia4fed34fe8b5e89d2e70950f2939941c96bb5f65 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90445 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-03-10use FastParser in DrawAnnotationContextNoel Grandin
Change-Id: I4228a5ccbd738d2e51473ded511cf4bfd2b6617d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90244 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-09use FastParser in XMLAnimationsContextNoel Grandin
Change-Id: Ib6c99e7aa9d2797a04b9590c69008f6895f13780 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90217 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-09StartElement/EndElement in SdXMLGenericPageContext are superfluous nowNoel Grandin
after commit 2176aed0e3a79bd457ad3678490262dae9ea1361 (HEAD -> master) Date: Mon Mar 9 10:09:48 2020 +0200 convert SdXMLGenericPageContext to fastparser Change-Id: I5b1b8dff1a667e4e916b6625a1fca2d0a6b9b9c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90216 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-09improve loplugin:unusedfieldsNoel Grandin
noticed something that wasn't being picked up, wrote some tests, and found an unhandled case in Plugin::getParentFunctionDecl Change-Id: I52b4ea273be6614e197392dfc4d6053bbc1704de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90141 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-09convert SdXMLGenericPageContext to fastparserNoel Grandin
Change-Id: I225fcd104252a32715259b85614298d8a2ffd110 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90202 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-07clang-format xmloff with under 5-percent lines of changeMuhammet Kara
Files which could become clang-format conformant with under 5-percent lines of change relative to the total count of lines in the file are found by using bin/find-clang-format.py, and fixed with /opt/lo/bin/clang-format -i <path-of-the-file> There will be follow-up patches to fix all 'under-5-percent' files. Change-Id: Ia2b85f00fc182798176d0af686b37f0df59ecb3c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90151 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-03-06loplugin:unusedmethodsNoel Grandin
Change-Id: I698981490eb1391930cdd06821a80a5f770e000e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90109 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-06xmloff: create SchXMLImport_Content instances with an uno constructorMiklos Vajna
See tdf#74608 for motivation. Change-Id: I27826e04adbf8ae22c0ce026413c58eb1c6d7db8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90067 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-03-06use more FastParser in ScXMLContentValidationContextNoel Grandin
Change-Id: I958d2ad1a8dc6c2a3da1c1a4fc6bd4f0011367fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90055 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-05tdf#75330 chart: implement ODF import/export of legend overlay featureTünde Tóth
Follow-up of commit 9fab1ba8ddc59924c633aa17c65f7330a4762726 (tdf#75330 add a new overlay/no-overlay feature for the legend). Change-Id: I7781fd8b926d4add56f3db0d56dceab8e27e5f85 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89836 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-03-04ofz#21045 Invalid-enum-valueCaolán McNamara
runtime error: load of value 65535, which is not a valid value for type 'enum LineNumberingToken' Change-Id: I432ba6f46838b499c690f717216b61b127dc2dda Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89977 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-03tdf#101181 Implement glow effect on shapesTamas Bunth
Glow effect is a color-blurred outline outside of the shape. In ooxml document it is specified with the <a:glow> element. The commit contains the following: - Add support for importing and exporting <a:glow> from ooxml documents. - Assign new properties to XShape which stores glow-related attributes. - A new 2D primitive is introduced in module 'drawinglayer' which is responsible for representing the glow primitive which is to be rendered. + A glow primitive is a clone of the original shape which has been scaled up slightly and a new color has been assigned to it. The radius of the glow effect and the color is defined in the <a:glow> element being imported. - A blur algorithm is introduced in module 'vcl', which is called during rendering the primitive. + The blur algorithm works on a bitmap. + Since the algorithm is CPU-intensive, the result is cached in the processor and it is recalculated only if needed. - Add support for importing and exporting glow effect to ODF format. For that, new attributes of element <style:graphic-properties> has been added: + loext:glow, which can have the values "visible" or "hidden" + loext:glow-radius: which holds the radius of the glow effect in cm. + loext:glow-color: holds the color of the glow effect - Tests have been added to assert properties after pptx import and export. Change-Id: I836aeb5e0f24e2c8d5725834c8c0f98083bc82e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89125 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2020-03-03move some headers inside their moduleNoel Grandin
Change-Id: I026f920d475c4ce56a12d6b29a702673e8bd7a1c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89866 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-02don't rely on parser ::characters callback only firing onceNoel Grandin
which is true for the old parser, but not always so for the FastParser. So pre-emptively fix some stuff Change-Id: I405834f1dfd28c98cae87b6de38d238f723edafd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89712 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-01use the SetAttribute override in SvXMLStyleContext subclasses consistentlyNoel Grandin
Change-Id: Ibdbf73c5e54fbbb051e4898fd8b3a7a155647b15 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89702 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-29tdf#130955 chart export: fix repeated custom labelsBalazs Varga
Do not add mCustomLabelText to aDataPointVector when we write leading empty data points, it is enough to add them, when we write data-point with style. Note: this fixes also DOCX import, when the embedded charts are imported by using ODF export in the background. Regression from commit: 7d2c7e7af04d9604d86d2d605ef95b9abb10966c (tdf#123206 Store custom label as chart:data-label) Change-Id: Ib3b370236323a57ac6800035d71321f7ee5dbe41 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89504 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-02-29tdf#130878 Report does not show label-fieldsNoel Grandin
The critical part was (1) calling m_pFixedContent->Characters instead of m_pFixedContent->characters in OXMLCharContent (2) calling OXMLReportElementBase::EndElement instead of OXMLReportElementBase::endFastElement in OXMLFixedContent Also (3) add a bunch of debugging logging to help find this (4) fix various characters() methods that can no longer rely on being called once for text content in a node Change-Id: Ib8ea88c5ff377311ca70e4292cad6d1f7f7c7323 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89589 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-29reduce some pointer chasingNoel Grandin
can usd std::optional here Change-Id: I613131a00d64b7a226fe5b0d0f47a7db6ba41599 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89713 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-28tdf#130917 Invalid document after odt->docx with signaturelineSamuel Mehrbrodt
Change-Id: Idf80c41f1315e0690dabd5e8566b62fc64c3ee1a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89692 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-02-28Removed duplicated includeAndrea Gelmini
Change-Id: I25024d035bb534d504b5f1a85205957926fa866a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89652 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-02-28Fix typoAndrea Gelmini
Change-Id: I6cf5da5de456eeab5b482ba71bd7d612aabe1e2b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89655 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-02-28Fix typoAndrea Gelmini
Change-Id: I72b70641c83d5d2b43b44990b5e3ed286f2e3e53 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89654 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-02-28xmloff: create SchXMLImport_Styles instances with an uno constructorMiklos Vajna
See tdf#74608 for motivation. Change-Id: I517ee5a3b22ea90cbbd1eb82f08b69b2964898a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89649 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-02-27tdf#101710 Fix invalid style:data-style-name attributeMaxim Monastirsky
There were two problems with this attribute: 1. It was written in style:table-cell-properties instead of in style:style. 2. It was referencing a number format id, instead of a style name. Moreover, the data style wasn't even exported as part of office:styles (if at all). Both import and export were affected. For export, it was easily possible to reuse some related stuff from Calc, so that stuff was moved into xmloff and used from there (there are no logic changes for Calc). For import, loading of the invalid attribute was kept for compat reasons. Although it's only useful for automatic number formats, as the data styles weren't exported properly anyway (e.g. see the document attached in bugzilla). Change-Id: I8b70ad205972fada6f3845837d6ed5928d7d6406 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89551 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-02-27convert AnimationImport to fast-parser APIsNoel Grandin
And... (*) space out the namespace constant values so I dont keep forgetting and making them overlap. (*) Remove CreateDocumentContext from SvXMLImport since it is now unused. Change-Id: I30f54bfc1389e91b18e4fee8b83e1b297419899b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88938 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-27remove duplicate tokens from xmloffNoel Grandin
Which causes trouble when converting stuff to use FastParser APIs. I see we used to use dummy entries to avoid perfhash complaining, which is fine for exporting, but doesn't work when we use these constants for fast-parser importing, because the imported element/attribute ends up mapped to what looks like the "wrong" constant. So let's just make the constants match their textual representation. Change-Id: I173d4b1e5fedede18375a6f7c15b1f36a48e4063 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89627 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-27tdf#108110 ODF chart: import/export of custom position of data point labelsBalazs Varga
using new attributes loext:custom-label-pos-x and loext:custom-label-pos-y of chart:data-point. This fixes also *import* of DOCX documents with embedded charts, related to the ODF usage in the background. Follow-up of commit 4223ff2be69f03e571464b0b09ad0d278918631b (tdf#48436 Chart: add CustomLabelPosition UNO API property) Change-Id: I985ce27cb6ce988948258d9eab0de13d01c72b97 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89446 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-02-27tdf#130908 Chapter Numbering can't load custom styleNoel Grandin
regression from commit 83e97fef3fa4de900eda35d02168fcae01c85eed convert ImportStoredChapterNumberingRules to XFastParser and add some more debugging trace Change-Id: I224b9c442369a4c6a7746d7ff419f069d3430513 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89633 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-27loplugin:constantparamNoel Grandin
Change-Id: I62a0b760e49e38a4565eebf272492159047dda5b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89613 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-26tdf#129532 tdf#98839 fixes for mirror of custom shapesRegina Henschel
tdf#98839 In case a sheared custom shape was mirrored, the shear angle in draw:transform had a wrong sign in the saved file. tdf#129532 Mirroring given in draw:transform in file or via macro was wrongly applied. Errors: 1)Mirroring from draw:transform attribute had overwritten already existing mirroring in the enhanced-geometry. 2)Mirroring from draw:transform attribute was set in enhanced- geometry attributes but not really applied. Change-Id: Ifa52f3606b5a33e6492a02d6e19c883d28752da8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85670 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-02-26new loplugin:xmlimportNoel Grandin
to help me maintain the invariants when updating code to use the FastParser APIs. One weird invariant is that you need to override startFastElement or the createFastChildContext will not get called. Not all of these changes are probably necessary - some of the classes are never constructured themselves, only their subclasses are constructed, and their subclasses maintain the invariants, but it is just easier to scatter a few more startFastElement around Change-Id: I3f70fb5a1e44c311cf4926fa7b0fcda605709eac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89473 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-22Resolves: tdf#130563 Add predefined 4-digit year date+time formatEike Rathke
Add a predefined NF_DATETIME_SYS_DDMMYYYY_HHMM format code with formatindex="50" to all locale data files, which shifts all reserved area internally generated built-in formats up by one. Reserved area was filled already so that boundary has to be increased as well. Add some flexibility for future additions by setting the new boundary to 65, free first format index to be used by additional locale data formats is 66 now. Adapt all locales to the new boundary. The existing predefined NF_DATETIME_SYSTEM_SHORT_HHMM format code with formatindex="46" mostly was and is used with 2-digit years (stemming back from the old binary format and Excel compatibility), some locales that don't use 2-digit years at all already defined it to 4-digit years. Keep those but move the default="true" attribute (if so) to the new "50" format. Modify populating the format list such that resulting duplicates will be suppressed there as well. Also try to match the new format in ODF import if a long year was requested with date+time. Finally set the new format as default for all *_IT locales. In future changing the default date+time format to 4-digit year is just a matter of moving the default="true" attribute to the new format. Change-Id: Ib16aa9fda0e71b2d03f78e3dd013785de03cd288 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89265 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-02-21xmloff: create SchXMLImport_Meta instances with an uno constructorMiklos Vajna
See tdf#74608 for motivation. Change-Id: I7f783161c190940b10d9acd971a008c17f4f7dbc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89158 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-02-20use fast-parser APIs for embedded script parsingNoel Grandin
essentially, this duplicates and converts the service in xmlscript/source/xmlflat_impexp/ and then converts it to use SvXMLImport APIs, stripping about 3 layers of unnecessary indirection in the process. Also improve some exception throwing in sax/ to make the next programmers life easier when finding the source of exceptions. Change-Id: I1ac552ee0565349e8322a55f6f609cf9f4521cab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89084 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-18rename XML_OLD_NAMESPACE_ constantsNoel Grandin
so I can use them with the XML_ELEMENT macro, which expects them to start with "XML_NAMESPACE" Change-Id: If8098448f451675aaff8ca2dcf9544e765cda965 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88928 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-15convert XML_STYLE_FAMILY to scoped enumNoel Grandin
Change-Id: I5335b0190a2f5a8111993c0c9c224c8a6a8f0cfb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88723 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-14convert XMLEventsImportContext to fastparserNoel Grandin
for now, it supports both fast and non-fast methods, since it is constructed by both contexts Change-Id: I925c50be161b95ecebd951cb7038a938c848a15d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88715 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-14xmloff: create SchXMLImport instances with an uno constructorMiklos Vajna
See tdf#74608 for motivation. Change-Id: I6b4a78317e2b228296c8e4794c776b617920ccfd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88630 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-02-13chart: don't export LO_EXT hide-legend in ODF 1.2László Németh
Regressions from commit 7869b3d6e4b24a0567ad2e492038d74c03b06b7d (related tdf#51671, store new "hide legend" feature also in ODF) and commit a96ec04a07c35338f5f9a0cb361b9322e5ca9cec (tdf#130225 implement ODF export of deleted legend entries of pie charts) Change-Id: I1d2847ae3e3ab7ccfbdb3841d94a0c1d79ded31f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88593 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2020-02-13tdf#130225 implement ODF export of deleted legend entries of pie chartsTünde Tóth
Follow-up of the following commits related to the new UNO property DeletedLegendEntries for pie charts: commit 86be3422cd55fa9e44104f1628648061bb6a3495 (tdf#129857 Chart OOXML export: fix deleted legend entries) commit 6e847aa817999ab18acd534f9e6a86685bb268fc (tdf#129859 XLSX import: don't show deleted legend entries) Change-Id: Id24cddefa83e50dde1ec6555d02891753483dd5f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88018 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-02-12crashtesting: remove assert in SvXMLImportContext::SvXMLImportContextNoel Grandin
which came from commit 813118bfbb453f812be9e1a30f84908b4e0bfb51 Date: Fri Dec 20 14:34:56 2019 +0200 add checks to optional fields in SvXMLImportContext but it turns out various places abuse this field and pass stuff that is not a element name, including empty strings Change-Id: I33cfc7e44e0aafe0fdb084482a199d5cffde6a76 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88523 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-09Fix typoAndrea Gelmini
Change-Id: If04bde50d7471d4c5a42e204f34a4d08115dbf95 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88331 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-02-09Fix typoAndrea Gelmini
Change-Id: I5c350c44ded0ca1eafc6e7c7d05386d06c71f0ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88332 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
generated by cgit (git 2.34.1) at 2024-08-21 22:46:53 +0000