summaryrefslogtreecommitdiff
path: root/xmloff
AgeCommit message (Collapse)Author
2021-01-16tdf#136861 ODT export: fix writing resolved state for non-ranged commentsMiklos Vajna
It was probably not intentional to write the resolved state only in case the annotation has a name. (cherry picked from commit f3b5356bdc51b03f9910ed544b8c17d6f919bc12) Change-Id: Ia3a6b2320e2288528c43c832211ebfcde492881e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109379 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-12xmloff: "form:datasource" vs. "db:data-source"Michael Stahl
Recently xmloff started to use XML_DATASOURCE for "form:datasource" but it actually means "data-source". Add XML_DATA_SOURCE and use it for "db:data-source". (regression from 3de38e95561ab7ca114d9f3307702ba89c4e3e9a) Change-Id: I893efd3fb0fb7c19ae998442459bf36cb1da0b20 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109019 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit db283d2e3f5cd8be412c5204f358cd06af761b13) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109000 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Michael Stahl <michael.stahl@allotropia.de>
2020-11-27tdf#138507 error in loading formNoel Grandin
regression from commit 3de38e95561ab7ca114d9f3307702ba89c4e3e9a Author: Noel Grandin <noelgrandin@gmail.com> Date: Tue Nov 10 19:20:06 2020 +0200 use fastparser in forms Change-Id: I995677d4e381e8229e7f052cf54a134bdf49d378 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106708 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 3faf503b1a389affcff1bcbd63630963f634e486) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106734 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-11-26save properly fadecolor also for fadeovercolor (tdf#138353)Luboš Luňák
As far as I can tell .odp spec doesn't recognize 'fadeovercolor' as a subtype of 'fade' (it's an LO extension?). But it's already saved by LO if used, so save the color properly as well. Reading it already works too. Change-Id: I30e464123f17d513fd0eaa32797f06e76a91d532 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106505 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> (cherry picked from commit 21d36af1fd3037f1f425dd8303b50b8848d729ce) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106528
2020-11-23tdf#134059 Always include hidden cells in chart series labelOuyang Leyan
Change-Id: I92ff60b26af713a49fefd8b2ce8042f4e8e4d179 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106317 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit fd5f3b212a38ec6ef35d2686ce5a7cc39cb7d377) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106240 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-22fastparser in XMLStringBufferImportContextNoel Grandin
Change-Id: I1474bcd98c87ab4a3bfe3cc0e9b8e434e7ce4144 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106280 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-21remove some prefix and local params from constructorsNoel Grandin
Change-Id: Iaffbefe98ced97610b99a00b1b3011c6a79a7859 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106300 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-21fastparser in XMLChangeInfoContextNoel Grandin
Change-Id: I8e3e2bfc94f59b19b99299a7696b435f8d39b290 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106279 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-21fastparser in XMLAutoTextContainerEventImportNoel Grandin
Change-Id: I1f4003166185fca67bc6ce8abe967e7c99d2237a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106278 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-21fastparser in XMLEventsImportContextNoel Grandin
Change-Id: Ifeeb2220ec6dfe6ec91f238137796d7d9e517465 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106261 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-20fastparser in XMLEnhancedCustomShapeContextNoel Grandin
Change-Id: Id5f6466fd62e15b354b2dc11a0dc610cbfb75c27 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106250 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-20fastparser in SdXMLLayerContextNoel Grandin
Change-Id: I1912d8d5a5f3ea6865d7425be8edb4f24b27e61f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106229 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-20fastparser in SdXMLLayerContextNoel Grandin
Change-Id: I807c9028fa197079da79270f8d7ad9339d7bedf4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106228 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-20fastparser in SdXMLEventsContextNoel Grandin
Change-Id: I7c9a43c0323c1f278f329c51f14d9c273d334741 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106227 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-20fastparser in SdXMLEventContextNoel Grandin
Change-Id: I52eb0ef77c54386a9774f746caba4b05785937aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106214 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-20simplify CreateTableContextNoel
Change-Id: I1700d17d6f3aa29fcc4a1ea33d8d797e67c301d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106168 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-19fastparser in SchXMLSeries2ContextNoel Grandin
Change-Id: I609333f732cb8c428f1c9e3fca24e2df3146de12 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106075 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-19fastparser in XMLChangedRegionImportContextNoel
Change-Id: Id5da48e4c47acbc0052799e8be6b88edd6dce099 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106167 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-19fastparser in dropdownfieldNoel
Change-Id: I4b09f78b0f4d2ad40a7aec8e2d5d722b7a1ee18b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106166 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-19fastparser in formsNoel
Change-Id: Ia5274bf6c200a5077bc9b7fdf16b7723337d353d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106165 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-19fastparser in TokenContextNoel
Change-Id: I3e3bdc30f0313288201a77741e55aa89fea2be6b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106164 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-19fastparser in TokenContextNoel
Change-Id: I12c2af505d4bf19d94fb127cda2403f0b6618b07 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106159 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-19tdf#123936 Formatting files in module xmloff with clang-formatPhilipp Hofer
Change-Id: I4d9016a0e646da5d9f0044762f6ecce86ce1242b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105732 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2020-11-19fastparser in DomBuilderContextNoel
Change-Id: I126db3987f491c1753ec6c169e42503137e4fa86 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106152 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-19fastparser in SchXMLTextListContextNoel Grandin
Change-Id: I27c4bcdc9c2e6131b651332301e01ead3393025d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106077 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-19fastparser in SchXMLTableContextNoel Grandin
Change-Id: I6cccd109218a9f3adea311df86408ee1d1fe332f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106076 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-19fastparser in DomBuilderContextNoel
Change-Id: I77a41dbb16b34601e559a56d58af14404ac8cbbf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106126 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-19fastparser in SchXMLRegressionCurveObjectContextNoel Grandin
Change-Id: If630576d7583031a56960d2ddc87c2d0e37aa8ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106074 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-19Fix SAL_WARN_IF in elementimport (xmloff)Julien Nabet
Wrong from: 2012-05-17 5e0b52c1893ffe04a68333026afa7a557c48d534 - (0 == _rPropValue.Name.compareToAscii(PROPERTY_EFFECTIVE_VALUE)) - || (0 == _rPropValue.Name.compareToAscii(PROPERTY_EFFECTIVE_DEFAULT)), + (0 == _rPropValue.Name.equalsAsciiL(PROPERTY_EFFECTIVE_VALUE.ascii, PROPERTY_EFFECTIVE_VALUE.length)) + || (0 == _rPropValue.Name.equalsAsciiL(PROPERTY_EFFECTIVE_DEFAULT.ascii, PROPERTY_EFFECTIVE_DEFAULT.length)), since '"compareToAscii" returned 0 if both strings are equal' whereas "equalsAsciiL" returned sal_Bool (so sal_True if both strings equal) there have been different changes during some years. But c2d808a5ddf89ce40939d166e67dd0271852104f (2019-02-01) did also wrongly this: - OSL_ENSURE( - _rPropValue.Name != PROPERTY_EFFECTIVE_VALUE - && _rPropValue.Name != PROPERTY_EFFECTIVE_DEFAULT, - "OControlImport::implTranslateValueProperty: invalid property type/name combination!"); + SAL_WARN_IF( + _rPropValue.Name == PROPERTY_EFFECTIVE_VALUE + || _rPropValue.Name == PROPERTY_EFFECTIVE_DEFAULT, "xmloff", + "OControlImport::implTranslateValueProperty: invalid property type/name combination, Any and " + _rPropValue.Name); Indeed the comment (which has never changed since 2001) above indicates: "we have exactly 2 properties where this type class is allowed" In brief, we want to warn if "_rPropValue.Name" different from "PROPERTY_EFFECTIVE_VALUE" and "PROPERTY_EFFECTIVE_DEFAULT" Change-Id: I576b2af2eaf96c53ae7950b352239ce1510ff03c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106080 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2020-11-19fastparser in SchXMLDataPointContextNoel Grandin
Change-Id: I086f3b8abc9abae88ef2a6afcd032eb088f20008 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106073 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-19Avoid wrong warning in OElementImport::implApplyGenericProperties (xmloff)Julien Nabet
When empty sequence, there's nothing to convert so no need to spend time here and to indicate the following warning: Avoid warn:legacy.osl:93722:93722:xmloff/source/forms/elementimport.cxx:364: OElementImport::implApplyGenericProperties: conversion to sequences other than 'sequence< short >' not implemented, yet! + avoid these in the same time: warn:xmloff.forms:88800:88800:xmloff/source/forms/elementimport.cxx:428: DBG_UNHANDLED_EXCEPTION in implApplyGenericProperties exception: com.sun.star.lang.IllegalArgumentException message: /home/julien/lo/libreoffice/include/cppuhelper/proptypehlp.hxx:35 ArgumentPosition: 0 In addition, convert 2 OSL_ENSURE of this block in SAL_WARN_IF Change-Id: I047eb5afba6fd22249010791aa61ebd1f83f3c67 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106082 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-19fastparser in SchXMLParagraphContextNoel Grandin
Change-Id: I612e888d364e31457aea8e66accdf1a2230ed870 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106071 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-19fastparser in SchXMLPlotAreaContextNoel Grandin
Change-Id: I77eab3ebacaca4c3327f60fac0970330fc9fe10b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106072 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-19fastparser in SchXMLLegendContextNoel Grandin
Change-Id: I9fe41436f4a5dd15867e172d4a43775ca49d29df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106070 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-18Remove unused XMLTableImportContext::ImportColumn nPrefix, rLocalName paramsStephan Bergmann
unused since f3797630be6ab21179e2496cc56a6d41f0ee8144 "return nullptr from CreateChildContext methods in subclasses" Change-Id: I5c4c820500b98444c9f24641d6e45ea9b830ec3b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106052 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2020-11-18fastparser in SchXMLTitleContextNoel Grandin
Change-Id: Ie11234a520f344e775d6ae4c030cef5c741233a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106026 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-18missing include (XMLOFF_WARN_UNKNOWN -> SAL_WARN)Stephan Bergmann
Change-Id: I5137deca44f842eef8789d37b0c21850d6665e5e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106040 Tested-by: Stephan Bergmann <sbergman@redhat.com> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-18fastparser in SchXMLCalculationSettingsContextNoel Grandin
Change-Id: Ic1365da6453c8cf02c518b576997784c928d7f2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106023 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-18fix XMLOFF_WARN_UNKNOWNNoel
since (doh!) having it as a function does not correctly log the actual caller source line information. Change-Id: Iae1007414259dea372f761765e090e1ed2ddbea9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105972 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-17fastparser in SchXMLChartContextNoel Grandin
Change-Id: Ie1b0ec1a17c959de6e0a837bf5eb200fc0be1dfd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105958 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-17loplugin:stringviewparam check methods tooNoel
not just functions Change-Id: Icca295dd159002b428b73f2c95d40725434f04d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105789 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-16tdf#138144 Form wizard fails to saveNoel
fallout from commit 3de38e95561ab7ca114d9f3307702ba89c4e3e9a Date: Tue Nov 10 19:20:06 2020 +0200 use fastparser in forms Change-Id: I4691786525132ef0cf98b6b177a2c022c4d7d032 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105932 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-16simplify CreateChartContext, remove unused paramsNoel
Change-Id: I91db68fa20e00ac6b7ec0c991016f4155c6ed70c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105915 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-15fastparser in SchXMLAxisContextNoel Grandin
Change-Id: Ia4d0f55ea3cf4845386dacc0e30ee7d949e6f501 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105901 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-15fastparser in XMLMacroFieldImportContextNoel Grandin
Change-Id: Ib0bfda67558476c84c86fa9f4bd4b8f18f6c5c4b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105896 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-15fastparser in XMLDatabaseFieldImportContextNoel Grandin
Change-Id: I83aba0cfcf2f280750b43e4782ec376572dacba7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105895 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-15fastparser in SchXMLAxisContextNoel Grandin
Change-Id: Idcc6426707f8f2019b4af0a5ef5979aa60944d11 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105893 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-15fastparser in XMLReplacementImageContextNoel Grandin
Change-Id: I206782ce50249ac29f511f10ca39a9bcf075cdd4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105891 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-15more fastparser in imagemapNoel Grandin
Change-Id: I057502d7244e707caa1e296d345f7353ceed6f37 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105842 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-14use fastparser in XMLImageMapObjectContextNoel Grandin
Change-Id: Iefe6acbbacf308144372fb664943bd978225a0f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105839 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2024-08-06 09:15:28 +0000