summaryrefslogtreecommitdiff
path: root/xmloff
AgeCommit message (Collapse)Author
2020-12-23Directly create strings in *::MapTokenToServiceNameStephan Bergmann
...and pass them into XMLTextFieldImportContext and derived ctors. The assert in the XMLTextFieldImportContext ctor is moved up to the two MapTokenToServiceName functions. Change-Id: I75c76cd6129e79ad54ea87e7d3419ca49679875d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108235 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-23Fix dubious OUStringLiteral with automatic storage durationStephan Bergmann
Change-Id: I0c80ce6efbbc950ce975e55663a5643ea8fb37f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108215 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-22use string_view in ProcessAttributeNoel
Change-Id: I81feb01bf6823d1d8fb5a7da08490959484ef533 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108095 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-21use std::u16string_view in SvXMLTokenEnumeratorNoel
Change-Id: I1194441063047637adc20c8e37bb717fdb787714 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108073 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-19make *String(string_view) constructors explicitNoel Grandin
to make it more obvious when we are constructing heap OUStrings code and potentially inadvertently throwing away performance. And fix a handful of places so revealed. Change-Id: I0cf390f78026f8a670aaab53424cd31510633051 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107923 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-18use more string_view in IsXMLTokenNoel
Change-Id: Ib84e2e7db4b4e6e2486dd024d60057d9d42ff4b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107932 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-18use more string_view in convertEnumNoel
Change-Id: I859de4b908672722e1873c5b41cb456b42258ddd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107885 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-17use more string_view in SvXMLUnitConverterNoel
Change-Id: Id40a071e1abf0bf2e13217e8745fdf266010c1c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107872 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-17use views to parseNoel
Change-Id: I5fe1b6523a3d0b0d42c3ab5b7d0db3e30082efcd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107762 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-17use views to parseNoel
Change-Id: I1e6678e18e5ef298021c818036b44c5b71b180fa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107760 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-17use views to parseNoel
Change-Id: I6c396d37df3c0c823e9cf61738825a126e1a2cb7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107763 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-17use views to parseNoel
Change-Id: I9c0b89c9463065323b1a86aee21163c97b75bb25 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107761 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-16use views to parseNoel
Change-Id: Iedb72f3586bf78a0da7e1b629a0ecf8994bb2eb6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107754 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-16use views to parseNoel
Change-Id: I4cdf09f4ce8dc399fa5ae4620191a2ad2e7f78da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107759 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-15use views to parseNoel
Change-Id: Ib40597b101c8b236e8426cbc0b43dcad1a01bc48 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107753 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-15remove assert which crashes ooo119798-1.pptNoel
with command line ./instdir/program/soffice --headless --convert-to odp ooo119798-1.ppt Added with commit 5080bb930de3ecfce8ab78bbd23a9d48c2f2bfa0 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Sat Aug 29 11:19:28 2020 +0200 convert SvXMLImport to fastparser, drop slowparser paths which helped me track down a problem, but apparently this happens with some broken files Change-Id: I2866daa2c93ffe01f89120f19e0ea0056ee50605 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107742 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-15use views to parse rather than allocating OUStringNoel
Change-Id: If0a848c64ce8077d1681661873629c83307cf8b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107736 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-14use more direct parsing on FastAttributeListNoel
instead of first allocating an OUString Change-Id: I796b1b2d47eb3cb9bebb00ae1bbd465010ebf494 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107691 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-14loplugin:unusedfieldsNoel
Change-Id: I73c49b83f5c1ef17fbff18af675e95d2f2a7b243 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107685 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-14loplugin:unusedmethodsNoel
Change-Id: I442d99e8f6a7df11dc950c5073f683bffc41a852 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107661 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-13Get rid of wrong warning in propertyexport (forms)Julien Nabet
Create a brand new odt file, add an image with form Control then save You'll notice this on console: warn:legacy.osl:20299:20299:xmloff/source/forms/propertyexport.cxx:680: OPropertyExport::dbg_implCheckProperty: invalid property type! it's wrong since most of the type the exported property should be a OUString (internal "string") but it may also be a graphic::XGraphic and this case isn't dealt by DBG_CHECK_PROPERTY since we only gave it "OUString()" Change-Id: I268b8d5f79c84ea73acdac245ee1705ddd009ae9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107653 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-12-11Adapt the remaining OUString functions to std string_viewStephan Bergmann
...for LIBO_INTERNAL_ONLY. These had been missed by 1b43cceaea2084a0489db68cd0113508f34b6643 "Make many OUString functions take std::u16string_view parameters" because they did not match the multi-overload pattern that was addressed there, but they nevertheless benefit from being changed just as well (witness e.g. the various resulting changes from copy() to subView()). This showed a conversion from OStringChar to std::string_view to be missing (while the corresponding conversion form OUStringChar to std::u16string_view was already present). The improvement to loplugin:stringadd became necessary to fix > [CPT] compilerplugins/clang/test/stringadd.cxx > error: 'error' diagnostics expected but not seen: > File ~/lo/core/compilerplugins/clang/test/stringadd.cxx Line 43 (directive at ~/lo/core/compilerplugins/clang/test/stringadd.cxx:42): simplify by merging with the preceding assignment [loplugin:stringadd] > File ~/lo/core/compilerplugins/clang/test/stringadd.cxx Line 61 (directive at ~/lo/core/compilerplugins/clang/test/stringadd.cxx:60): simplify by merging with the preceding assignment [loplugin:stringadd] > 2 errors generated. Change-Id: Ie40de0616a66e60e289c1af0ca60aed6f9ecc279 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107602 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-09Fix loplugin:stringviewparam handling of comparison operatorsStephan Bergmann
Change-Id: I58456efb9588b544d998ac6a4c27d55457280742 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107510 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-08remove now unused XML_TOK_ constantsNoel
Change-Id: I73da015abc824194b88c53b87170c987d24080a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107411 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-08remove unused SvXMLTokenMap from XMLFontStylesContextNoel
Change-Id: I0e75bd2a65259659c31bbc721649b266fbaa3c8e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107369 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-08remove unused SvXMLTokenMapEntryNoel
Change-Id: Idc3005e5604a0c346740a81746fd35b45955afed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107371 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-08fastparser in stylesNoel Grandin
Change-Id: I39d285f1dd7dd18c396db96863f77f511741951c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107364 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-07Fix typoAndrea Gelmini
Change-Id: I0c9b522cdbdefa8bd3698f1c1b31a963adf6c00d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107345 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-12-07Removed duplicated includesAndrea Gelmini
Change-Id: Id7eedadd7d6c4a939abca138b7dd00436182d86b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107344 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-12-07loplugin:unusedmethodsNoel
Change-Id: Ib51fd610c5188fe95872d509f004ae88f38c5417 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107351 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-07loplugin:unusedfieldsNoel
Change-Id: Ia02d8359e0158c7658ac3abcaf2b6c19a3b33131 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107348 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-07convert SvXMLImport to fastparser, drop slowparser pathsNoel Grandin
Change-Id: I0f880a7680373043fecf083cdf4de8b0bb7041a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103775 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-06fastparser in XMLImpSpanContext_ImplNoel Grandin
Change-Id: Iba1b61c607f5f748f5acf4ce16d2c0cce8dee72e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107281 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-06fastparser in XMLTextFrameContext_ImplNoel Grandin
Change-Id: I69ca9141ccbedeb92909c782dcacd791d3517c2e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107276 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-05fastparser in XMLTextFrameContextNoel Grandin
Change-Id: I1d0038546d47b850aecee9e3a675a44ce6c7c5fa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107248 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-05fastparser in SdXMLTableShapeContextNoel Grandin
Change-Id: Ia27408ff3f640de942f42718e2ee497350f48785 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107237 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-04no need to use GetLocalName hereNoel
Change-Id: Iafd55f0a7d12c6833cae82d49350a5642b637764 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107224 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-04fastparser in SdXMLChartShapeContextNoel Grandin
Change-Id: I06ad1abb3795dae9ddcc0d68e6ffb627c85fc039 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107236 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-04call createFastChildContextFallback in more placesNoel Grandin
to make my fastparser work easier to manage Change-Id: If98592f016cd35ca13b48d9df363e32fb1095b55 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107233 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-04move some logic inside createFastChildContextFallbackNoel
Change-Id: I5e73b4b24e4782bb0740c0abd817b38b47c3e9c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107220 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-04fastparser in a couple of random placesNoel
Change-Id: I9c88c826cfffa71f389f78f9d18d46e097e540ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107217 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-04update pchesCaolán McNamara
Change-Id: I3e22c2000da03f6f3345353846213203993aa865 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107192 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-04fastparser in CreateGroupChildContextNoel
Change-Id: I3e3e6785fdedb27353e4d97a9a2bea71c6f2b24a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107189 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-03tdf#96505: Get rid of cargo cult long integer literalsGökhan Özeloğlu
Change-Id: I7226f93a87e0b31634a3c0942f3f5ec8778161fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106843 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-12-03Pass key by const& to the various addEmbeddedFont functionsStephan Bergmann
Change-Id: Id6e36a4acf34a6b8d5b7202231650066ae6cb6cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107170 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-03fastparser in XMLFootnoteBodyImportContextNoel
Change-Id: Iebb11d1a8a27bda894870bd6701faea923ab3927 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107148 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-03fastparser in XMLCellImportContextNoel
Change-Id: I62d5953d26ea37ba2c40ed1b778f71b85c304b9d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107147 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-03fastparser in DrawAnnotationContextNoel
Change-Id: Ie629e24e78d69456d1ec5276f3695d42d556ef1f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107146 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-03fastparser in XMLIndexBodyContextNoel
Change-Id: I4fd0342f8d008ec9dfd3f148d5cdfb3a27c1753e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107130 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-03fastparser in XMLSectionImportContextNoel
Change-Id: If6d2b5a73265acecc7947e11b1107ef72f075836 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107129 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2024-07-15 02:31:05 +0000