summaryrefslogtreecommitdiff
path: root/xmloff
AgeCommit message (Collapse)Author
2019-07-21cid#1448305 silence Out-of-bounds accessCaolán McNamara
Change-Id: I7a25cc0c30f06ec146bdc205c51d5cad70e713b1 Reviewed-on: https://gerrit.libreoffice.org/76014 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-21loplugin:referencecasting in xmloffNoel Grandin
Change-Id: Iac3d56511aacec73bc38f57890c44145a4c13b85 Reviewed-on: https://gerrit.libreoffice.org/76034 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-19cid#1448264 silence Out-of-bounds accessCaolán McNamara
Change-Id: I12267e8709d8f36acbbd6c70bfdb80a2a500e5d3 Reviewed-on: https://gerrit.libreoffice.org/75910 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18xmloff: create XMLImportContentImportOasis instances with an uno constructorMiklos Vajna
See tdf#74608 for motivation. Change-Id: I3b52830ece6fae82af1bc57eb93e3a9ad1eb2aff Reviewed-on: https://gerrit.libreoffice.org/75809 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-07-16cid#1448448 Unchecked return valueCaolán McNamara
Change-Id: I195cc073ff7557d30fbffcb97778751908634303 Reviewed-on: https://gerrit.libreoffice.org/75660 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-15ofz#15797 Integer-overflowCaolán McNamara
Change-Id: I623c934f5bb031d383dcf1ce779521a942f99bdf Reviewed-on: https://gerrit.libreoffice.org/75634 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-12MSForms: Rework text-based date form field's representationTamás Zolnai
* Better to represent it similar to text form field with two marking characters selecting a text range * So the text between the two marks can be anything (not only a well formatted date) and also have any character formatting. * With this we handle the case when the user needs a placeholder text in the date field or when the user needs time values (hour, minute, sec) next to the date. Change-Id: Id60a50a2028058f8a6a080e265c0730d88b98543 Reviewed-on: https://gerrit.libreoffice.org/75459 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-07-12MSForms: ODF import / export of text-based date fieldTamás Zolnai
Change-Id: Ib535f1ce065a7f298fcccf95e82d1ffab4d1e1e2 Reviewed-on: https://gerrit.libreoffice.org/75445 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-07-04xmloff: create XMLImportMetaImportOasis instances with an uno constructorMiklos Vajna
See tdf#74608 for motivation. Change-Id: Iaa42d09df5322e8fb23d96e7ff2c298951684c6c Reviewed-on: https://gerrit.libreoffice.org/75058 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-06-20xmloff: create XMLImportSettingsImportOasis instances with an uno constructorMiklos Vajna
See tdf#74608 for motivation. Change-Id: I3e2afe5184f686180b287078477f095792c9ac12 Reviewed-on: https://gerrit.libreoffice.org/74384 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-06-19Use for loop with explicit number of iterationsArkadiy Illarionov
96be3821f7dad19004a43696555eaa4fa2e1aef5 follow-up Change-Id: I1e585a1f4bcd68757cce7b6327757cd7e9ee660f Reviewed-on: https://gerrit.libreoffice.org/74306 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-18loplugin:logexceptionnicely in xmlhelp..xmlsecurityNoel Grandin
Change-Id: Idbf0de3f953b08f98144241346533ad30f49269e Reviewed-on: https://gerrit.libreoffice.org/74285 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-17xmloff: prefix members of XMLIndexSimpleEntryContextMiklos Vajna
Change-Id: I90950ebbb78c53a24960b007ddf53fb02e5cfb9a Reviewed-on: https://gerrit.libreoffice.org/74144 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-06-17Add comphelper::getUnoTunnelImplementation templateArkadiy Illarionov
Use it instead of classname::getImplementation from UNO3_GETIMPLEMENTATION_* Change-Id: Ifcc8cfcd6369c576250008c76ce31ba79ea3a596 Reviewed-on: https://gerrit.libreoffice.org/74107 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-06-16crashtesting: failure on export to odt of ooo33851-1.sxwCaolán McNamara
since... commit 79d58ee14da8fbf636fb087453834abb7173d3fc Date: Sun May 12 16:07:58 2019 +0300 Simplify Sequence iterations in xmloff/source/{style..xforms} Use range-based loops or replace with comphelper or STL functions Change-Id: I0e00ea30a45d0ba3aa00fcb20b80fdc4931fe14d Reviewed-on: https://gerrit.libreoffice.org/74116 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-13Simplify Sequence iterations in xmloff/source/{chart..core}Arkadiy Illarionov
Use range-based loops or replace with comphelper or STL functions Change-Id: I131b77ad7d68897fcfe07284edcf38397589278f Reviewed-on: https://gerrit.libreoffice.org/72192 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-13xmloff: create XMLDrawSettingsImportOasis instances with an uno constructorMiklos Vajna
Change-Id: I811c48578053e2ea87956340bcad45f6d27d59df Reviewed-on: https://gerrit.libreoffice.org/73911 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-06-12Simplify Sequence iterations in xmloff/source/{draw..script}Arkadiy Illarionov
Use range-based loops or replace with comphelper or STL functions Change-Id: I1d25ad2badccff476f3221829e8f1caf22ad3975 Reviewed-on: https://gerrit.libreoffice.org/72191 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-11Simplify Sequence iterations in xmloff/source/{style..xforms}Arkadiy Illarionov
Use range-based loops or replace with comphelper or STL functions Change-Id: Ie268d80b9c01d38c745c14a81c219d9930860562 Reviewed-on: https://gerrit.libreoffice.org/72189 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-08Typo xEqationProperties->xEquationPropertiesJulien Nabet
Change-Id: I960506d2aaf0cf3f36f7af4bfa43169bb0afda5a Reviewed-on: https://gerrit.libreoffice.org/73720 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-08loplugin:unusedmethodsNoel Grandin
Change-Id: I52efd8d843d0e4cc7a6adefb0eb95aa50469af38 Reviewed-on: https://gerrit.libreoffice.org/73693 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-06xmloff: create XMLDrawMetaImportOasis instances with an uno constructorMiklos Vajna
Change-Id: I6793d227fd5e7f358904083f37ccae825f733fd4 Reviewed-on: https://gerrit.libreoffice.org/73570 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-06-03tdf#120412 char formatting UI: clean-up DFLT_ESC_AUTOLászló Németh
Default auto values must be outside of the new enlarged range of the superscript/subscript percent values. Note: the raising limit was modified to 13999 from 14400, because the RTF unit test tdf112208_hangingIndent.rtf lost its hanging from the bigger value. Change-Id: I3a7e9715a27570278ee4ee70f9fc9ad29457e100 Reviewed-on: https://gerrit.libreoffice.org/73166 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-06-03tdf#39593 use UNO3_GETIMPLEMENTATION* macrosArkadiy Illarionov
Change-Id: I4e9af3b43a5baf19e100f42b3f37a2ade89ada5d Reviewed-on: https://gerrit.libreoffice.org/73320 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-05-30xmloff: create XMLDrawContentImportOasis instances with an uno constructorMiklos Vajna
Change-Id: I2d0bcc8d48ce0a4253b5deff11736b292e4f9e69 Reviewed-on: https://gerrit.libreoffice.org/73188 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-05-30ODT export: fix lost <text:user-field-decl> for fields in tables in headersMiklos Vajna
The problem was that XMLTextFieldExport::ExportFieldAutoStyle() assumed that the text of a field anchor is always the toplevel XText, which is true in case of body vs header text, but false in case header text vs text-in-table-in-header. So add an UNO property which exposes the parent of a table cell, this way text in header (regardless of it's in a table or not) will have the same XText, leading to writing the necessary <text:user-field-decl> element for the matching <text:user-field-get> definition. Change-Id: I077b8d7e9dfae4062539894318637e266b925382 Reviewed-on: https://gerrit.libreoffice.org/73176 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-05-25tdf#125372 writer, file with lots of hints very slow to open, part1Noel Grandin
Remove a chunk of O(n^2) work in XMLHints_Impl Change-Id: I6b391af630d83ddd563b66bc1ad1640cd78debc7 Reviewed-on: https://gerrit.libreoffice.org/72948 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-23xmloff: create XMLDrawStylesImportOasis instances with an uno constructorMiklos Vajna
Change-Id: I677c3b184e225c3bac1c56efd5ea46aaa2497d69 Reviewed-on: https://gerrit.libreoffice.org/72810 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-05-18tdf#125254 Performance: A spreadsheet opens too slow, NameSpaceEntryNoel Grandin
NameSpaceEntry does not need to be a weak object, it is sufficient to be ref-counted. The empty string in SvXMLNamespaceMap can be statically allocated. Don't allocate a NameSpaceEntry in GetKeyByAttrName_ if we don't intend to cache it. Takes the load time from 39.5s to 38.5s. Change-Id: I4a9a1296af84c12d44e9b3ff354297f37d29f1e8 Reviewed-on: https://gerrit.libreoffice.org/72515 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-18Fix typoAndrea Gelmini
Change-Id: I0b7a2b4945124e5c8f3e89b5cdc4a2e5bc68d2bf Reviewed-on: https://gerrit.libreoffice.org/72502 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-16xmloff: create XMLDrawImportOasis instances with an uno constructorMiklos Vajna
Change-Id: I4e4e0b56306a6e0e1b61f432e487a47d700e5e9f Reviewed-on: https://gerrit.libreoffice.org/72379 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-05-13tdf#107592 Impress PPS save to ODP slowNoel Grandin
Takes the time from 20s to 5s on my PC. Change-Id: Iea7a94ee9fbe068b69a770fd9201e73646be59b9 Reviewed-on: https://gerrit.libreoffice.org/72140 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-13fix wrong SET/QUERY flags passed to uno::ReferenceNoel Grandin
By creating deleted methods for the wrong calls. Avoids the compiler needing to construct a temporary Change-Id: I3b8c648d6bb22d22827bf74f21ea5a2a17fc0f6a Reviewed-on: https://gerrit.libreoffice.org/72103 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-12regenerate PCH headersLuboš Luňák
Change-Id: I4894023e42cbfa32916ee3ddfb2cfb5426cfc69f Reviewed-on: https://gerrit.libreoffice.org/72195 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-05-10an is used before a vowel soundCaolán McNamara
not before vowels with a consonant sound so its a url not an url Change-Id: Ic27ff3bee67469284d460c31ced6f63cb3633db2 Reviewed-on: https://gerrit.libreoffice.org/72062 Reviewed-by: Jens Carl <j.carl43@gmx.de> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-09regenerate PCH headers for the 4 new levelsLuboš Luňák
Plus some build fixes triggered by this. Change-Id: I59b21def706598ceffd45ae5b1f0262ec9c1ad50 Reviewed-on: https://gerrit.libreoffice.org/71581 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-05-09xmloff: create XMLImpressSettingsExportOasis instances with an uno constructorMiklos Vajna
Change-Id: Ibe4ef82cf719afd008f1be23ed4a0e953c61d73f Reviewed-on: https://gerrit.libreoffice.org/72010 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-05-07Get properties from both setsArkadiy Illarionov
Fix copypaste typo Change-Id: I59fe87a8739b968404012b41796f1092dc0e0f7f Reviewed-on: https://gerrit.libreoffice.org/71890 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-05-07Use comphelper::concatSequences to reduce copypasteArkadiy Illarionov
Change-Id: I15aafc657680d476abdba621ec6c3288beafc55f Reviewed-on: https://gerrit.libreoffice.org/71847 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-05Drop lcl_SequenceToVector in favor of comphelper::sequenceToContainerArkadiy Illarionov
Change-Id: I86284553e1b0229d0b576ef1d92efd040b524a1b Reviewed-on: https://gerrit.libreoffice.org/71825 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-02Use hasElements to check Sequence emptiness in [v-x]*Arkadiy Illarionov
Similar to clang-tidy readability-container-size-empty Change-Id: I71e7af4ac3043d8d40922e99f8a4798f0993294c Reviewed-on: https://gerrit.libreoffice.org/71603 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-30sw btlr writing mode: implement ODF filter for textframesMiklos Vajna
Layout is still not yet correct right after the import, though. Change-Id: Icdba2e8d608f35b6b5b43b88ffb223f779af1b89 Reviewed-on: https://gerrit.libreoffice.org/71552 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-04-30improve loplugin:stringconstantNoel Grandin
to find more places we can elide the OUString() constructor at call sites Change-Id: Ie09f3c61f2c4b4959c97dc98ebcbaf7c51d5d713 Reviewed-on: https://gerrit.libreoffice.org/71514 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-30implement std::hash for css::uno::Reference and rtl::ReferenceNoel Grandin
The declaration in BarChart.cxx is particularly suspicious, because it was using a < for the KeyEqual template parameter. Been there since: commit b2c3233e5f267b5d244d722a94424a3b224b3314 Date: Thu Dec 21 20:08:33 2017 +0900 chart2: suspend/resume setting rects dirty for 3D shapes comphelper::OInterfaceCompare is no longer necessary Change-Id: I8278c4a3d9113a18570ca237cd05d553ec8f3975 Reviewed-on: https://gerrit.libreoffice.org/71537 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-29tdf#63640 FILEOPEN/FILESAVE: particular .odt loads/saves very slow, part4Noel Grandin
cache the XMLTokenMap data in static const vars, so we only need to initialise them once Change-Id: Ib63bedc5af5d5927fed189a6b1a86a5db6865c72 Reviewed-on: https://gerrit.libreoffice.org/71466 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-25xmloff: create XMLImpressMetaExportOasis instances with an uno constructorMiklos Vajna
Change-Id: I350c2c96cd178878ae687dd5214fcabfcf7675e7 Reviewed-on: https://gerrit.libreoffice.org/71254 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-04-19optimise find/insert patternNoel Grandin
if we're doing a find/insert on a set or a map, it is better to just do a conditional insert/emplace operation than triggering two lookups. Change-Id: I80da5097f5a89fe30fa348ce5b6e747c34287a8d Reviewed-on: https://gerrit.libreoffice.org/70937 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-15xmloff: fix loplugin:simplifyconstruct warningMiklos Vajna
Change-Id: Iab32f67f911157c5d7c0db8f36ea638576cfd0bf
2019-04-15loplugin:sequentialassign in writerfilter..xmlsecurityNoel Grandin
Change-Id: I41028c704eca08b71746c3c87e38926b95449775 Reviewed-on: https://gerrit.libreoffice.org/70735 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-14tdf#120703 PVS: Silence V522 warningsMike Kaganski
V522 There might be dereferencing of a potential null pointer. Change-Id: Ie4bc74a734a6d5a73838a27e0d80cc8e51595839 Reviewed-on: https://gerrit.libreoffice.org/70730 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
generated by cgit (git 2.34.1) at 2024-07-18 09:08:36 +0000