summaryrefslogtreecommitdiff
path: root/xmloff
AgeCommit message (Collapse)Author
2014-12-18xmloff: Use appropriate OUString functions on string constantsStephan Bergmann
Change-Id: I349e0c2575d9a5154ac7002d129a1851a3df7687
2014-12-17Introduce rtl::OUStringLiteral1Stephan Bergmann
...to use single ASCII character literals "more directly" in the OUString API (instead of having to go via an intermediary OUString ctor call). Especially useful for character literals that are defined as const variables or via macros ("direct" uses of character literals in the OUString API can often simply be replaced with single-character string literals, for improved readability). (The functions overloaded for OUStringLiteral1 are those that are actually used by the existing LO code; more could potentially be added. The asymmetry in the operator ==/!= parameter types is by design, though---writing code like 'x' == s is an abomination that shall not be abetted.) Change-Id: Ic5264714be7439eed56b5dfca6ccaee277306f1f
2014-12-12xmloff: Use appropriate OUString functions on string constantsStephan Bergmann
Change-Id: Idbe6ac27a4125bd9d9acb01ac42b60396abf0c81
2014-12-10xmloff: make the export of the horrible field marks aware of auto-stylesMichael Stahl
When exporting the .DOC bugdoc of fdo#87110 to ODF, the auto-styles export will iterate over the fieldmarks in the page header and add the attributes for them but not export the elements, so the first auto-style gets a bunch of duplicate attributes. Change-Id: I3fcf39f03e3d9ae5fca661efa7eb4bbb3eab9f5c
2014-12-10fdo#87110: xmloff: don't catch IllegalArgumentException hereMichael Stahl
There are at least 2 callers of InsertTextContent() that have non-trivial catch handlers for this exception, which aren't called now. (regression from bebf8ccfba37f77d6a43c7874249b31736467b17) Change-Id: I085b710dfd5877e9b7e71610951543eddf6a6e46
2014-12-09Resolves: fdo#87108 crash on saving fodgCaolán McNamara
Change-Id: Ib88f0e9b0a3ba229c9e9f6cf20831c16051e3e29
2014-12-08fdo#38835 strip out OUString globalsNoel Grandin
Change-Id: I1a435214af102461e02217f7d95248dac14e5f1a
2014-12-07export to extension namespace instead of odf namespaceMarkus Mohrhard
Change-Id: Ica66112199d6f81d1e8ddf8d78ddde49a3ea6037
2014-12-07remove invalid attribute that is not read anywayMarkus Mohrhard
Change-Id: Id7770ffda49ba7bc0ebc780c67c56b81152213f7
2014-12-07use correct xml element name, related fdo#45266Markus Mohrhard
Below data-pilot-groups the correct element name is data-pilot-group-member and not data-pilot-member. Change-Id: I41aecb7f85a881d13b3eaaa7be8de737b47ea312
2014-12-07don't write extension elements into ODF namespaces, related fdo#45266Markus Mohrhard
We will still import the old elements but only write them into the lo-ext namespace. Also it will only be exported for ODF 1.2 extended. Change-Id: I1c41716b8b16e186ec84767b4b3a636d083162b8
2014-12-07last inconsitently named data table valueMarkus Mohrhard
Change-Id: I1a558616156f5217e309c5957967a69d81c20b8e
2014-12-07more fixes for inconsistent namingMarkus Mohrhard
Change-Id: Iedb1b30d4e3905f884bc3bb39d4703a883e95c46
2014-12-07use a consistent naming schemeMarkus Mohrhard
Change-Id: Ia420779fd875cb2a81b90871b26940f8a0258b4d
2014-12-06the xlink:type attribute is mandatory, related fdo#79449Markus Mohrhard
Change-Id: I03c4217f786bc10aa915780dc10ea52d94019b6e
2014-12-05xmloff: remove pointless branch that does the same as the next oneMichael Stahl
Change-Id: Ib39ec9c045461590767a29ccdd28f39b2a623e88
2014-12-05fdo#86795: xmloff: ODF import: do not import checkbox fieldmark ...Michael Stahl
... if it has start/end, because Writer will become grumpy and crash. Change-Id: I6024051249eeac6ed9e43856fa77db969287f888
2014-12-01fdo#85496: add some asserts to detect this sort of problemMichael Stahl
Change-Id: Iff787c8d2a71bc3082192cc98e3d916badee65dd
2014-11-28xmloff: avoid assertion because AutoCorrect document doesn't ...Michael Stahl
... have a proper outline numbering rule. Change-Id: I7f73176fae6d181ec398c81daf492f4de08e0ae8
2014-11-27Resolves: fdo#84043 don't create duplicate Mirrored[X|Y] propertiesCaolán McNamara
regression from 13ef16423e78d3ea825172594f08c47d2f9bfd09 commit 13ef16423e78d3ea825172594f08c47d2f9bfd09 Author: Armin Le Grand <alg@apache.org> Date: Wed Nov 21 13:23:01 2012 +0000 For backward compatibility take mirrorings in setTransformation into account Also found an error in SdrObjCustomShape::TRGetBaseGeometry when MirrorY was used (cherry picked from commit 4116c33b12d3787c406f0348f89efcb1cf409507) Change-Id: I7bfb5dea32b8ab8498e3d92975c49b830c81e6fb
2014-11-26simplifyStephan Bergmann
Change-Id: I6cb7c66a8dbac1a887d4f218f5de9d73310c809b
2014-11-25Remove ptr_vector header include in favor of forward declaration.Kohei Yoshida
Change-Id: I0aed7ec1bd8ac30ef18147b385c8649a413e4e3a
2014-11-25xmloff: clean up some debug printfsMichael Stahl
Change-Id: I208bbe47d1134b6a362e50d54093e6d35e85f51b
2014-11-25xmloff: replace DBG_ASSERTs in txtlists.cxxMichael Stahl
Change-Id: I0b7ab0ed27ba23f9ad924819193dd30c70e48fed
2014-11-25xmloff: replace DBG_ASSERTs in txtimppr.cxxMichael Stahl
Also tweak some of the assertions so they don't fire for character borders. Change-Id: Id63631864ab3e5f0366a514adc1ff73f01f57a84
2014-11-25xmloff: replace DBG_ASSERTs in txtimp.cxxMichael Stahl
Change-Id: I7f3ed82652e98da767cf7021bc5fc42e31e80b73
2014-11-18cppuhelper: clean up public headers with include-what-you-useMichael Stahl
Change-Id: I41ba46831f24b2960a1fe982b74a2b623e682e0b
2014-11-18cppu: clean up public headers with include-what-you-useMichael Stahl
Unfortunately iwyu gets quite confused by the weird cyclic dependencies between various foo.h/foo.hxx and cppumaker generated headers, so it's not obvious if any improvement here is realistic... Change-Id: I0bc66f98b146712e28cabc18d56c11c08418c721
2014-11-17sal: clean up public headers with include-what-you-useMichael Stahl
Sadly cannot forward declare "struct {...} TimeValue;". rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h was painful enough for now... Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
2014-11-16Remove now useless setTextEmbeddedGraphicURL()Zolnai Tamás
Since this commit: 286e2f5c6ec829bc0987b1be7016699f7ef03e5e it's not necessary to update the package URL. Change-Id: I25c829e9bc0c666838baf19cd60f19938ebb430c
2014-11-14more catch by referenceCaolán McNamara
Change-Id: I2db9f94a517f814ef0854190e6f1194501070409
2014-11-14fdo#86023 - O[U]String needs a 'clear' methodBrij Mohan Lal Srivastava
Added clear() method to OString and OUString class, Updated appropriate call-sites. Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-11-12Fix common typos. No automatic tools. Handmade…Andrea Gelmini
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959 Reviewed-on: https://gerrit.libreoffice.org/12164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-11xmloff: XML_DROPDOWN should be XML_DROP_DOWNMichael Stahl
Change-Id: I47247289bb4367faa9a07f3568270718b5423353
2014-11-08xmloff: [loplugin:unusedvariablecheck]Michael Stahl
Change-Id: I5b141d35ab05e1a3f225a980aad1280102a80ee0
2014-11-08xmloff: remove unused parameter of SvxXMLListStyleContext::FillUnoNumRule()Michael Stahl
Change-Id: I359f37ce778d55e6868bd1c78c0ff0d452f36088
2014-11-07Removed #includes including themselvesAndrea Gelmini
Change-Id: I3fe3227967e07b6b0c82dccf3c9400bfe6e1d729 Reviewed-on: https://gerrit.libreoffice.org/12292 Reviewed-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com> Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-11-05markup with event type not checker typeCaolán McNamara
Change-Id: I14c0c5d90b67000cb4fe9e6be647854abfe784da
2014-11-05fdo#38835 strip out OUString globalsNoel Grandin
they are largely unnecessary these days, since our OUString infrastructure gained optimised handling for static char constants. Change-Id: I07f73484f82d0582252cb4324d4107c998432c37
2014-11-03coverity#705391: xmloff: XMLMergeElemTransformerContext misuse of enumMichael Stahl
The enum types XMLElemTransformerAction and XMLAttrTransformerAction use the same integer values so a mixture of values from these 2 in one switch is very suspicious. In the various *ActionTable arrays in OOo2Oasis/Oasis2OOo there is just one such array that mixes values from the 2 enums, and that is just the values that coverity complains about. The XML_ETACTION_EXTRACT_CHARACTERS was added at a later date in commits 8d374c039e7d349141befe3c9ef97f82f42bfa7 2685b93a6a23867baa4df265bb0cc35abaf76c0e 7d2405a54d13f68a35dfc5f619ad4bdb0b761856 c276550e07f8078fe9345985f70e8384d930a83f ...but it turns out that the XMLAttrTransformerAction ones are handled in StartElement() and ProcessAttrs() methods but the XMLElemTransformerAction ones are handled in CreateChildContext() methods so probably the XML_ATACTION_MOVE_FROM_ELEM* values are in the wrong enum. Change-Id: Ib1791f6eafac4fb1e99334f41c17a90cfb076359
2014-11-03coverity#1250700 Uninitialized scalar fieldCaolán McNamara
Change-Id: I5db51e7864017f0d0e474ed3e253657288245850
2014-10-31Removed duplicated includesAndrea Gelmini
Change-Id: I5362d997bfa086c9fb1726efcb15132a966684f6 Reviewed-on: https://gerrit.libreoffice.org/12160 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-10-31coverity#705348 Missing break in switchEike Rathke
Change-Id: I23e03e45ba4f6d259128bc5e4c2fd5952be05c2f
2014-10-31fdo#80403: Import baseclasses implement FastParser interfacesDaniel Sikeler
SvXMLImportContext implements XFastContextHandler SvXMLImport implements XFastDocumentHandler Change-Id: Id400260af112f4a448fe469c9580f0ebacec4ab6
2014-10-30Fixed typos. No automatic tools (sed, and so on).Andrea Gelmini
Change-Id: Ia43976d84eede6f699381bc4f3daf89b95e4cb4f Reviewed-on: https://gerrit.libreoffice.org/12150 Reviewed-by: Bryan Quigley <gquigs@gmail.com> Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-10-29coverity#735663 Division or modulo by zeroCaolán McNamara
Change-Id: I69410ebe3dcded9951bfa9e83844644147f4416a
2014-10-24XM_TOK_UNKNOWN needs to be in the value range of XMLImageMapToken (ubsan)Stephan Bergmann
Change-Id: Ief14b775851f457becb6f42b9a74e423bb73ed32
2014-10-23coverity#705781 Resource leakCaolán McNamara
Change-Id: Ia802df9c36b59a0130931436be7f5dbea07c0c8c
2014-10-15More -Werror,-Wunused-private-fieldStephan Bergmann
...detected with a modified trunk Clang with > Index: lib/Sema/SemaDeclCXX.cpp > =================================================================== > --- lib/Sema/SemaDeclCXX.cpp (revision 219190) > +++ lib/Sema/SemaDeclCXX.cpp (working copy) > @@ -1917,9 +1917,10 @@ > const Type *T = FD.getType()->getBaseElementTypeUnsafe(); > // FIXME: Destruction of ObjC lifetime types has side-effects. > if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl()) > - return !RD->isCompleteDefinition() || > - !RD->hasTrivialDefaultConstructor() || > - !RD->hasTrivialDestructor(); > + return !RD->hasAttr<WarnUnusedAttr>() && > + (!RD->isCompleteDefinition() || > + !RD->hasTrivialDefaultConstructor() || > + !RD->hasTrivialDestructor()); > return false; > } > > @@ -3517,9 +3518,11 @@ > bool addFieldInitializer(CXXCtorInitializer *Init) { > AllToInit.push_back(Init); > > +#if 0 > // Check whether this initializer makes the field "used". > if (Init->getInit()->HasSideEffects(S.Context)) > S.UnusedPrivateFields.remove(Init->getAnyMember()); > +#endif > > return false; > } to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about initializations with side effects (cf. <http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html> "-Wunused-private-field distracted by side effects"). Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
2014-10-11coverity#735353 Unchecked return valueCaolán McNamara
Change-Id: Iab54019d07ac27b4d8247d789c29165d24e2288f
generated by cgit (git 2.34.1) at 2025-02-19 21:32:58 +0000