summaryrefslogtreecommitdiff
path: root/xmloff
AgeCommit message (Collapse)Author
2013-06-13Introduce O[U]String::toUInt32Stephan Bergmann
...which has become necessary since bd60d41176da540b01d7583cfe00637431967f39 "Handle oveflow in O(U)String::toInt() functions" reduces values in the range (SAL_MAX_INT32 .. SAL_MAX_UINT32] to zero, but some calls of toInt32(16) relied on getting a correct (unsigned) value for the whole input range ["0" .. "FFFFFFFF"] (see libreoffice-4-1 commit 9bf6c83367cedb7be81bf67f30d2147d26c7a8c3 "Revert overflow checks in O[U]String::toInt{32,64} again"). Audited all uses of toInt32/64 with non-decimal radix. (There is still a TODO comment in oox/source/helper/attributelist.cxx, and stoc/source/typeconv/convert.cxx will still need some love and test code.) Change-Id: Iadaca1c0e41dab553687d0ce41c20c10cd657a95
2013-06-13remove method without definitionMarkus Mohrhard
Change-Id: Ia41f28ed31fc254a6785c6444a78822eb969f2f9
2013-06-08Resolves: #i121455# Adapted from NonPrimitive to non-primitive...Armin Le Grand
as used in the spec Patch by: Regina Review by: alg (cherry picked from commit af6ada82a4634e4b64faf811eaf527c167c334bf) Conflicts: xmloff/source/draw/shapeexport4.cxx Change-Id: I2fe339ba35cf589a9d4034446c671d4f09b0c0f0
2013-06-07For backward compatibility take mirrorings in setTransformation into accountArmin Le Grand
Also found an error in SdrObjCustomShape::TRGetBaseGeometry when MirrorY was used (cherry picked from commit 4116c33b12d3787c406f0348f89efcb1cf409507) Conflicts: xmloff/source/draw/ximpshap.cxx xmloff/source/draw/ximpshap.hxx Change-Id: Id85ae4c4f5e26d53d501c72b84fc0e1b5cfe23b2
2013-06-07Resolves: #i49853# comment the DTD to emphasize that this DTD is...Dennis E. Hamilton
for OpenOffice.org 1.x XML Documents and is not a DTD for any ODF document. (cherry picked from commit 7061d6dbf8d446e96d0ad13ea308f421ea6a424b) Conflicts: xmloff/dtd/office.dtd Change-Id: If2a084e86f935c9dddfbd3a4aa5e2d76473b7d9d
2013-06-05remove unused componentcontext.hxx includesNoel Grandin
Change-Id: I598926b72c5540b472f9607e2f3df134a8c50048
2013-06-03fix for unused return value.Noel Grandin
This code was introduced by: commit d09dd8986436f17717443823ef18bd8552fdf408 Author: Frank Schoenheit [fs] <frank.schoenheit@sun.com> Date: Wed Sep 15 13:55:34 2010 +0200 dba34a: export/import min-/max-/default-/value for date/time as XML-Schema conformant strings It looks like it intended to use determineDefaultServiceName(), but neglected to store the return value. Change-Id: I1607f39cf771b594389492785c7e72478d44843a Reviewed-on: https://gerrit.libreoffice.org/4140 Reviewed-by: Luboš Luňák <l.lunak@suse.cz> Tested-by: Luboš Luňák <l.lunak@suse.cz>
2013-05-30Resolves: #i121507# Added comma to whitespace listArmin Le Grand
(cherry picked from commit c9e446d6f79908ed4af06e7940788e91b924b793) Change-Id: I790bfada597e276f9f9e1d07f7208db6d1059f0f
2013-05-24WaE: implicit conversion of NULL constant to nullptr_tTor Lillqvist
Change-Id: I2eefbca1ef986219f04504cba4ca09a22972e8cb
2013-05-23prevent invalid files if file contains currency formatsMarkus Mohrhard
A regression from writing error cell information into the file. Change-Id: Idb55646094fcd76912bdcd2102370681bcc8703d
2013-05-22WaE: function will cause runtime stack overflowTor Lillqvist
Revert misguided changes from 6a043e9c0acff20e1618ca8ec15c21d5d0fd0d37 that obviously would cause endless recursion if these functions were ever entered. Thanks to MSVC2012 for the nice warning. Change-Id: I8504aa8ac141164ec6e026cc4fa873f8273f92bd
2013-05-22Use the new type-checking Reference constructor to reduce code noiseNoel Grandin
Also create a Clang compiler plugin to detect such cases. Change-Id: I61ad1a1d6b1c017eeb51f226d2dde0e9bb7f1752 Reviewed-on: https://gerrit.libreoffice.org/4001 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2013-05-18set some bug id prefixes to indicate which tracker they are fromCaolán McNamara
Change-Id: I5df2dd44a0612da893b1afe08d0c7a9ea71f3905
2013-05-18i121972 Use svg rx/ry/cx/cy defines in draw:ellipse when used(cherry picked ↵Armin Le Grand
from commit 19abb8de7e218ba08b2fa79c0379844303da328a)
2013-05-18#121090# corrceted point reduction on svg:d export to only happen when ↵Armin Le Grand
polygon is closed(cherry picked from commit 6e114c242bb21950fd8ea01885c2269744d0fc6f)
2013-05-18i121965 Take draw:transform into account for draw:connector shapesArmin Le Grand
(cherry picked from commit 7b3f5521bd3c400cd9e08b745176b4ce40885011) Conflicts: xmloff/source/draw/ximpshap.cxx Change-Id: I973627f85ce6463c863863d6c180cb4c2cab86d0
2013-05-15sw: change pool default of RES_FOLLOW_TEXT_FLOW to "false"Michael Stahl
For a new document the default is already effectively "false" due to SwDocShell::InitNew() and the ODF and WW8 filters set it explicitly to false... which is also the appropriate value for RTF and DOCX. But only OOoXML and (perhaps) HTML (not sure) want "true" as the default. It is also mysteriously reset to "true" in SwDoc::RemoveAllFmtLanguageDependencies() (which is called after loading a template) for no apparent reason. Change-Id: If5ad33c99f97412cb3ad4f9cec32f47825ed6f6b
2013-05-15i#119922: reverse engineer 9a37613b5e8f08fae585d54a5745e887eb08f8ceMichael Stahl
It is not quite obvious what that commit attempts to do... especially since the bugdoc attachment does not actually exercise the code that was added in the commit, which changes the handling of the "IsFollowingTextFlow" property. The corresponding ODF attribute is style:flow-with-text, which has been added in OOo 2.0. Investigation revels that MSO's ODF filter does not support this attribute and acts as if it always had value "false". The code in FillBaseProperties effectively acts as a default if the value is not set; the ODF spec does not specify what the default should be. But when an ODF document was written by MSO, "false" makes more sense than the previous "true" default. Except when the document is not ODF but OOoXML format, which indicates it's likely written by OOo 1.x which did not support the attribute and acts as if it always had value "true". The Writer UNO API implementation is however not the right place for format specific handling, so replace that with an addition to the function reading the default graphic style that sets the "IsFollowingTextFlow" property to false as a default, which should have the same effect because all styles inherit from it. Note: MSO 2010 Word always writes a default graphic style into ODF docs. This has a side effect for loaded ODF documents: various newly inserted objects have the property turned off then. But it turns out this is actually an advantage, since the same behavior already exists for _new_ documents (see SwDocShell::InitNew) so it is more consistent now. Change-Id: Iba6444a0515fd583398ff052fc5018254da31c30
2013-05-15factor out SvXMLImport::IsOOoXML()Michael Stahl
Change-Id: I9ccfe565bde1112f9f3cb8c666e901bf121862dc
2013-05-15Fix build.Thorsten Behrens
Change-Id: I5b2de61407924cdde5d74a7ea639365a876de74e
2013-05-15Fix fdo#64512 Handle xml:id correctly on multi-image draw:framesThorsten Behrens
Fixes a regression from the pick-best-image from draw:frame in ODF, where before sometimes the XShape got deleted that the UnoInterfaceToUniqueIdentifierMapper::registerReference stored. For that, added a UnoInterfaceToUniqueIdentifierMapper::registerReferenceAlways function, which overwrites potentially existing earlier entries with the same identifier string. This fix was originally much more messy, but then dtardon committed 30b248dfe5bfb8a0649e36f22c943b3feb2f1385 which also fixes this here bug. Now only sneaking in slightly less involved interface map handling and a safeguard in ximpshap.cxx. Change-Id: I87501e43518a5fc2fee166c45a4e2f01718f5228
2013-05-15Remove redundant doxygen doc strings.Thorsten Behrens
This is already (identically) documented in the header file. Change-Id: I4a10cb0c1d1b1eee80fd828ab95829fb8128433f
2013-05-15Use upper camel case for class names in xmloff.Thorsten Behrens
Align multiimagehelper with module standard. Change-Id: I70a4dbc66a0d127b9bf04d1e8db694d3526b21d7
2013-05-15Spelling "separate" (etc) correctly is hardTor Lillqvist
2013-05-15fdo#46808, Convert chart2::RegressionEquation service to new styleNoel Grandin
The service already existed, it just needed an IDL file Change-Id: I56b7079b098a7615dfb24598d15fe7d57691f317
2013-05-15fdo#46808, Convert some XMultiServiceFactory to XComponentContextNoel Grandin
Change-Id: I2e3480bf4f616231ee50a83f440d9bb0955e4ce6
2013-05-14typo fix: s/inavlid/invalid/Andras Timar
Change-Id: If75cad038f35033be6dcad6f051673bd795accf3
2013-05-14fdo#43157 - Clean up OSL_ASSERT, DBG_ASSERTRadu Ioan
- replaced osl_trace with sal_info - replaced dbg_* with sal_* Change-Id: I80aca85562e4a43fded5c37f9895e51f79e42c14 Reviewed-on: https://gerrit.libreoffice.org/3771 Reviewed-by: Bosdonnat Cedric <cedric.bosdonnat@free.fr> Tested-by: Bosdonnat Cedric <cedric.bosdonnat@free.fr>
2013-05-10Resolves: #i122208# introduce rtl::CStringHash and rtl::CStringEqualHerbert Dürr
unify the various c-string compares and hashes. (cherry picked from commit b7e3470a154538a92f0a21b14e726d75723f4a92) Conflicts: oox/inc/oox/export/shapes.hxx oox/source/export/shapes.cxx sal/inc/rtl/string.hxx sdext/source/minimizer/pppoptimizertoken.cxx svx/source/customshapes/EnhancedCustomShapeTypeNames.cxx vcl/source/glyphs/gcach_ftyp.cxx writerfilter/source/resourcemodel/TagLogger.cxx xmloff/source/draw/EnhancedCustomShapeToken.cxx Change-Id: Ib742744077bfb4d38a462d88b44bdef45601b4ae
2013-05-09Update pchAurimas Fišeras
Change-Id: I7c0c9158eb17cb79ffceae6770b4c513d57b3817 Reviewed-on: https://gerrit.libreoffice.org/3831 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-05-07officecfg: remove Package_cppheaderMichael Stahl
Instead include generated headers directly from workdir. Change-Id: I9d2bcc07175d2bbc16d3cc548c2245e7a4fb0c65
2013-05-06fix typos (wich instead of which)Philipp Riemer
2013-05-04install openoffice 1.0 DTD files using filelistDavid Tardon
Do we need to install them? Or even have them in the sources, FWIW? The old XML format has been superceded by ODF 10 years ago... Change-Id: I909afcf86ae808441c7dbc6182512bedb9789c1c
2013-05-03fdo#48056 treat report chart as draw chartLionel Elie Mamane
Change-Id: I0a716b4339747f1994e5c8710e15474807aea4a2
2013-05-03janitorial: indentationLionel Elie Mamane
Change-Id: I6886f5ed011871a1c2718c9e1fadc9d0cb053098
2013-05-03add a warningDavid Tardon
Change-Id: I0baf90cfe8d3caa96f826695c1be4bc563864c00
2013-05-03fdo#60075 need to return context when availableDavid Tardon
Change-Id: I53a83a3f2234dc061c23344116b0e294594f1c90
2013-05-03fdo#60075 open drawings with connector attached to SVGDavid Tardon
This problem arises when there is a connector attached to draw:frame element with multiple draw:image elements in it. The import code expects that they are different representations of the same image (I have not found if this is specified in ODF), so it only selects the most "suitable" for import. To do that, it imports them all and then removes all but the selected one. The image import context, SdXMLGraphicObjectShapeContext, shares the parent frame's attributes, which means that all the images in a frame have got the same ID. in SdXMLGraphicObjectShapeContext::AddShape, the created css::draw::XShape is registered with its ID... That means that anything that refers to the frame's ID, like a draw:connector, will always get the _first_ image in the frame. Solution is to extend comphelper::UnoInterfaceToUniqueIdentifierMapper to allow reserving an identifier and setting an interface for it later. That way, SdXMLFrameShapeContext can reserve its own ID before it starts importing the first draw:image, and then set the selected XShape at the end. Change-Id: I2e11cfd38e1e3534df2b3c01d85da0d755a266c3
2013-05-03the var. must be persistent over multiple callsDavid Tardon
Change-Id: Ieb48dfe85ed16a8123917b30873f301d523ea381
2013-05-02ditch explicit char arrays for string literalsLuboš Luňák
Change-Id: I77a4f6d338751c00942f091f4267e5f7d1d1742f
2013-04-30Move to MPLv2 license headers, with ESC decision and author's permission.Michael Meeks
2013-04-30Fix fdo#64062 - can't assume para styles to be there.Thorsten Behrens
Change-Id: I5da53ff44fdf00ec6c0fdf1a722f806971b6683a
2013-04-26some more namespace cleanupThomas Arnhold
Change-Id: Ib1e80d717f199db8f8ac4181d4377a86d88e3244
2013-04-25add error to office:value-type for calc cells and fdo#51810Markus Mohrhard
For cached value import we need the information which cells are error cells. For ODF 1.2 extended we therefore export now calcext:office-value with the additional value "error". Change-Id: I9bc988ea4924bea767ba5e504b77f6a16e51a82e
2013-04-25update pchThomas Arnhold
Change-Id: I67e73438312f2a672e71762ee6707ec5d425bb47
2013-04-25comments and code reformatMaxime de Roucy
Change-Id: Ib4e45cb85c9e5e5ffa6476c939300c6795412b1a Reviewed-on: https://gerrit.libreoffice.org/3582 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-04-24x error bars are also defined in ODF 1.2Markus Mohrhard
I suppose they were deactivated in ODF 1.2 because of the invalid ODF files produced by the old code Change-Id: I42624a3e0f57405b38110bef86a0aa533f491c6c
2013-04-24fix a problem with error bar weightMarkus Mohrhard
Change-Id: I812bbcdc346bffd2f0c968077a3fe86a241cf231
2013-04-24gbuild: drop uses of removed packagesDavid Tardon
Change-Id: I400fad08c0ae7b6b34bad63693f54856867e4dac Reviewed-on: https://gerrit.libreoffice.org/3502 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2013-04-23execute move of global headersBjoern Michaelsen
see https://gerrit.libreoffice.org/#/c/3367/ and Change-Id: I00c96fa77d04b33a6f8c8cd3490dfcd9bdc9e84a for details Change-Id: I199a75bc4042af20817265d5ef85b1134a96ff5a
generated by cgit (git 2.34.1) at 2024-07-31 11:15:59 +0000