summaryrefslogtreecommitdiff
path: root/xmloff
AgeCommit message (Collapse)Author
2014-03-07fdo#75260: Correctly draw double lines for both Writer and Calc.Kohei Yoshida
Fix all sorts of incorrect double line handling in drawinglayer in order to draw thick-thin double line types correctly. Also change handling of border lines in writer tables. There are still some outstanding issues but it's much better than how it was before. Also realized that Word and Excel handle simple thin double lines differently; Word varies widths of all of the lines and the gap whereas Excel only has one fixed size for its double line. For this reason I decided to add a separate double line type (DOUBLE_THIN) to handle Excel's double line. (cherry picked from commit 2c62596cf264ef10749d8bfdb2bb2ebef2d98fbc) Conflicts: cui/source/tabpages/border.cxx sc/qa/unit/subsequent_export-test.cxx sc/source/ui/view/tabvwsha.cxx sw/source/core/layout/paintfrm.cxx xmloff/source/style/bordrhdl.cxx Change-Id: Iaaa353b6e4f998b524262bea59260b4333e0cdb4 Reviewed-on: https://gerrit.libreoffice.org/8464 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2014-02-09fdo#74230: ODF export: write stroke and fill color in graphic defaultsMichael Stahl
The pool defaults for svg:stroke-color and draw:fill-color were changed and while previously (effective, manually overridden) defaults were written into ODF files, this was lost with the change; restore that. (regression from c0eb5e7772c848806db8ab461f77f9549c1d8b2b) Change-Id: Ibcd863260976aa42116175c7f19cb33760af986f (cherry picked from commit 45d3577bc5726eee44f491fd30a7f11dc428431a) Reviewed-on: https://gerrit.libreoffice.org/7929 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2014-02-08fdo#73281: Why!?Kohei Yoshida
This restriction makes absolutely no sense. It was likely someone's temporarily hack that was totally forgotten in the past 10 years... Not to mention removing this fixes my bug. Change-Id: I7394cccdc9fe486fda6cdd9b7eaf98fd291895a9 (cherry picked from commit 503b7191737eafa5621dc0aa552092793676c998) Reviewed-on: https://gerrit.libreoffice.org/7942 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-01-27Resolves: fdo#73814 wrong name for drawing::PointSequenceSequence propertyCaolán McNamara
examining svx/source/unodraw/unoprov.cxx "Geometry" is a indeed a drawing::PolyPolygonBezierCoords for the BezierShapes and a drawing::PointSequenceSequence for the PolyShapes regression since e44335abe006d05f0f915279605a03ef084116d6 because after 223f6b631c1b087754c0f9051fb55f029f2503ce we started getting drawing::PointSequenceSequences in maPath which is the wrong type for the argument to property "PolyPolygonBezier" for those shapes. Which led me to incorrectly assume that the all PolyPolygonBezier properties were named "PolyPolygonBezier" which isn't the case. so reverting the non maPath hunks of e44335abe006d05f0f915279605a03ef084116d6 Change-Id: I013a66778d11a472fc4567e53a9e17e73e2b91ce (cherry picked from commit df2ad69d5df350636c1eb1772b16a2e203a88fa7) Reviewed-on: https://gerrit.libreoffice.org/7685 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-01-24Resolves: fdo#73355 reconcile legacy path bug detectionCaolán McNamara
reconcile "223f6b631c1b087754c0f9051fb55f029f2503ce Resolves: #i123433# Detect pseudo-vertices at svg import..." with "7a19798c73fd39d8d69ff6364f0696e68cdd1381" Compatibility option for incorrect relative moves after closePath (fdo#47406) and "a2ee8055e9c136923f0244fe289cac6377933c31" Fix fdo#47406 incorrect relative moves after closePath Change-Id: I1221099a40500aeb4165a3350d8ae2df1fd3111b (cherry picked from commit b663316e83ec6b19b8fc33ade38086b22ab04b67) Reviewed-on: https://gerrit.libreoffice.org/7628 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-12-20prepare to accept loext:contextual-spacing, fdo#58112Eike Rathke
Change-Id: I58e151743bf910b8b51f1b453e0bfcb4ed767d9d (cherry picked from commit ef5e7b69440baa9f222d1ec870668d31d08268f0)
2013-12-20added bool bForExport parameter to XMLPropertySetMapper ctorEike Rathke
Set to true for export, false for import. If export true, an XMLPropertyMapEntry with mbImportOnly==true is not added to the mappings. This to be able to have more than one mappings for import (for example a current extension namespace and the future namespace proposed to the ODF-TC, or corrected typos in element or attribute names), but map only to one entry on export, of course. Change-Id: Ia01ea949c88eda2f8a6c10f51c59e35e7abdcaf3 (cherry picked from commit ebc1b2fe50c7ed1002ed8431410b8e2ac6e795b9)
2013-12-20prepared XMLPropertyMapEntry with mbImportOnly flagEike Rathke
Change-Id: Id5a54a591a42c836884af1fd09dc055f2fce6db5 (cherry picked from commit 9dd7ee88bd9835ae2bae36093100fcd651fd3aeb)
2013-12-20reordered member variables for 4 byte alignmentEike Rathke
Change-Id: Iaae7689d1ed3c74e261fcc90fa88b5521468e376 (cherry picked from commit dd902b8e256867b5d5fed06b52995f14d969f67d)
2013-12-19Backport Calc's data stream massive cleanup effort.Kohei Yoshida
Change-Id: Ifbeb7c2d90d87a7cffe9a752f9e8b4910d55fcd9
2013-12-18fdo#72850: ODF export: don't export spurious style:display="false"Michael Stahl
... on style:header-left, style:header-first, style:footer-left, style:footer-first. (regression from d92345561c998f7382cf9ef0fdcd29096f978435) Change-Id: I48c51fcd2b07ae8b0e3ec2c1087a388c6900b366 (cherry picked from commit 8f73c7615ebe60ef71d6e8b49a0f19ddac6f03a0)
2013-12-18fdo#72452: ODF import/export: fix handling of style:page-numberMichael Stahl
Class XMLNumberWithAutoInsteadZeroPropHdl (which appears to be used only for this attribute) needs to be adapted to the change that "PageNumberOffset" value 0 is no longer invalid; use "void" value for invalid instead, which appears more appropriate anyway. Unfortunately the type of style:page-number is positiveInteger so writing 0 would be invalid; write "auto" instead for now. Change-Id: I9621ea201fd928087b863c562607c3d77a3b0269 (cherry picked from commit 22355042a6fc7aecf3caab69b3fa3be1430b697f)
2013-12-14fdo#72697 actually write this only in ODF 1.2 extendedEike Rathke
(cherry picked from commit 49f9694e34d07468cff4a7e4de332f11be3e0dd8) Conflicts: xmloff/source/text/txtflde.cxx Change-Id: I32097cc4b8a67615b0b6d6172cafd0edad7469b6
2013-12-13fdo#72697 accept future <loext:sender-initials>Eike Rathke
... of to-be <text:sender-initials> Change-Id: Ia601c0debc5d66682aa92e14fb063395f9f48ab5 (cherry picked from commit 1379294741ff85d4c09d9ded7579ad50dea88fb7)
2013-12-10sax, xmloff: fix ODF import/export of text:time/text:time-valueMichael Stahl
The value written for an Impress time field is something like text:time-value="0000-00-00T23:28:07" (in LO 3.5+) or text:time-value="0-00-00T23:28:07" (in OOo 3.3) which contains an invalid all-zero date. Such values are actually rejected by the ODF import since commit ae3e2f170045a1525f67e9f3e9b7e03d94f2b56b. Actually there was no real support to read the RelaxNG type timeOrDateTime before. So fix that by: - adding convertTimeOrDateTime/parseTimeOrDateTime functions to sax::Converter - recognizing and ignoring the 2 invalid all-zero values written by LO 3.5 and historic OOo respectively - writing a bare "time" in text:time-value if the DateTime struct contains zero Date members (Older OOo versions and AOO cannot actually read that, but everything they _can_ read is invalid ODF...) Change-Id: I754076caee74a5163ed3f972af0f23796aa14f9f (cherry picked from commit cc407e50e8a1a74f9d1ed29d444dce9bd2e9167a)
2013-12-09resolved fdo#72537 write <loext:fill-character>Eike Rathke
... instead of <number:fill-character> but read both. Change-Id: Ia620fad575782f6174a9ee5fbbd8b396b21948e3 (cherry picked from commit 9f87de91cee05656808a98ab1bd65ad9509ef7df)
2013-12-09fix equalsAscii conversion. Noticed in fdo#72391Noel Grandin
In commit 363cc397172f2b0a94d9c4dc44fc8d95072795a3 "convert equalsAsciiL calls to startWith calls where possible" I incorrectly converted equalsAsciiL calls to startsWith calls. This commit fixes those places to use the == OUString operator. Change-Id: If76993baf73e3d8fb3bbcf6e8314e59fdc1207b6 Reviewed-on: https://gerrit.libreoffice.org/7008 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-12-03Support regression curve name in ODF.Tomaž Vajngerl
Change-Id: Ic065d63eee507906febfa15eb6d5ae1e7de58280 Reviewed-on: https://gerrit.libreoffice.org/6874 Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com> Reviewed-by: Thorsten Behrens <thb@documentfoundation.org> Tested-by: Thorsten Behrens <thb@documentfoundation.org>
2013-12-02fdo#71450 fdo#71698: ODF import: fix frame name corner casesMichael Stahl
Trying to set a name that is already in use will throw an exception (and set a different, generated name); if there is actually no name in the file then there's no point trying to set anything. (regression from b69d152cfa1da868ba960345d72ba78f9f8e1b35) Change-Id: Ie54d4a830cc23e2853a6efeb81f77dcc788192ea (cherry picked from commit 8171e713e74e3d09e86592c28abfe05d0400c071)
2013-11-20avmedia: Implement "block untrusted referer links" featureStephan Bergmann
See f0a9ca24fd4bf79cac908bf0d6fdb8905dc504db "rhbz#887420 Implement 'block untrusted referer links' feature" for details. This adds some further /*TODO?*/ comments, and one known problem (marked /*TODO!*/) is that movies/sounds are not blocked during a slideshow presentation. Change-Id: Ib2d0c7e4f7b02c4bdec0d8a90cee5e7e1bee8325
2013-11-19convert equalsAsciiL calls to startWith calls where possibleNoel Grandin
Simplify code like: aStr.equalsAsciiL( "%", 1 ) to aStr.startsWith( "%" ) Change-Id: Iee0e4e60b0ae6d567fa8f72db5d616fffbec3c00
2013-11-19remove unnecessary use of OUString constructor when assigningNoel Grandin
change code like aStr = OUString("xxxx"); to aStr = "xxxx"; Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
2013-11-15Resolves: fdo#62461 put preferred image firstCaolán McNamara
with fallback after. "Each child element of a frame is a different representation of the same content. The order of content elements reflects the document author's preference for rendering, with the first child element being preferred. That means that consumers should render the first child element that they support. A frame may contain multiple content elements, but shall contain at least one content element." Change-Id: If50062cad58f5b8561ad6bd8dc1a06956d2f444b
2013-11-14SAL_WARN_UNUSED com::sun::star::uno::AnyStephan Bergmann
Change-Id: I9058044d13f696e07667dce706f6c311af6dbea0
2013-11-14rhbz#887420 Implement "block untrusted referer links" featureStephan Bergmann
For now, this checks for a trusted referer (if the BlockUntrustedRefererLinks configuration prop is set) in utl::MediaDescriptor::impl_openStreamWithURL and SvxBrushItem::GetGraphicObject. Checking in additional places will probably be necessary to block /all/ unwanted communication. Also, some places marked /*TODO?*/ currently pass in an empty referer (which is always considered trusted) and will probably need to be adapted. Ideally, Referer URIs would never be empty (and consistently use something like <private:user> for cases where access is explicitly initiated by the user and should never be blocked), but that's a very daunting task, so start small by identifying the places that potentially need blocking and adding appropriate Referer URIs there. Also, Referer information should always be computed as freshly as possible from the context in which an access attempt is made, but, again, always carrying the information from the context all the way to the relevant functions is a very daunting task, so for now store the information upon object instantiation in some cases (SvxBrushItem, SdrGrafObj, ...). The Referer URI (css.document.MediaDescriptor property; SID_REFERER) was already used to track macro execution, and there is one place in SfxApplication::OpenDocExec_Impl where opening of hyperlinks (explicitly clicked by the user) is done that needs the current document's URI as Referer to check execution of macro URIs but needs an empty (or <private:user>, see above) Referer to not block non-macro URIs. Special code has been added there to handle that. Change-Id: Iafbdc07a9fe925d9ee580d4f5778448f18f2ebd9
2013-11-14Move MediaDescriptor from comphelper to unotoolsStephan Bergmann
...so it will be able to use SvtSecurityOptions internally. Change-Id: Id7433247e8fc53651935578510bedbcca5aa2ac9
2013-11-14-Werror,-Wunused-member-functionStephan Bergmann
Change-Id: Ibfc721a819c044b5e6ec06e5bbad694662fe9e3f
2013-11-14-Werror,-Wunused-member-functionStephan Bergmann
Change-Id: Ied485bebaee36107178acee33eea1eecef70315e
2013-11-14remove unnecessary sal_Unicode casts in XMLOFF moduleNoel Grandin
Change-Id: I836c7a28d5ec9039c0b185e8db2aa6d01ac62566 Reviewed-on: https://gerrit.libreoffice.org/6665 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2013-11-13clear c++11ishCaolán McNamara
Change-Id: I4eea774206a5bd1de1c10a69aceb6476c5feecbf
2013-11-13Respect svg:font-face-format element.Brennan Vincent
Call libeot to parse font if value "embedded-opentype" is found. Change-Id: I03a072fd4db47d151a3934e959ad17c1e24fcf09 Reviewed-on: https://gerrit.libreoffice.org/6144 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-11-11xmloff: include <> for external includesNorbert Thiebaud
Change-Id: Ic92d0121e928041bcff00b12706f794a4d8e25c8
2013-11-11convert OUString compareToAscii == 0 to equalsAsciiNoel Grandin
Convert code like aStr.compareToAscii("XXX") == 0 to aStr.equalsAscii("XXX") which is both easier to read and faster. Change-Id: I448abf58f2fa0e7715dba53f8e8825ca0587c83f
2013-11-11convert OUString !compareToAscii to equalsAsciiNoel Grandin
Convert code like if( ! aStr.compareToAscii("XXX") ) to if( aStr.equalsAscii("XXX") ) which is both clearer and faster. Change-Id: I267511bccab52f5225b291acbfa4e388b5a5302b
2013-11-11convert OUString 0==compareToAscii to equalsAsciiNoel Grandin
Convert code like: 0 == aStr.compareToAscii("XXX") to aStr.equalsAscii("XXX") which is both clearer and faster. Change-Id: I2e906d7d38494db38eb292702fadb781b1251e07
2013-11-11remove unnecessary use of OUString constructorNoel Grandin
Change-Id: Ifb220af71857ddacd64e8204fb6d3e4aad8eef71
2013-11-10cppcheck: reduce scopeJulien Nabet
Change-Id: I7a20f89e5a113c6c8760d51475d8198e28ad6aac
2013-11-07remove misleading commentAndras Timar
Change-Id: I8c4187f3f50c4675ab4fe392ef0f0736109788da
2013-11-07fdo#63020: Replace ::comphelper::stl_begin()...Marcos Paulo de Souza
And use some templates inside include/com/sun/star/uno/Sequence.hxx Change-Id: I48875fa1517751fc4cb0cf2b6c08b88975a29b47 Reviewed-on: https://gerrit.libreoffice.org/6599 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2013-11-07remove unnecessary use of OUString constructor in XMLOFF moduleNoel Grandin
Change-Id: I3bb704d2b1063cd8c2c903cbfa237a7723c321d2
2013-11-06Remove #ifdef TIMELOG'ed SAL_INFOsStephan Bergmann
...the code doesn't make much sense that way. Change-Id: I506e37b44924701255431f6d20d4610f7f52287d
2013-11-06check for empty stringCaolán McNamara
as demonstrated by kde246118-4.odp Change-Id: Idf1224555e0d7be9a679862da9ff256cf7a4d128
2013-11-05Resolves: #i123542# corrected ODF XML export of 3D cube and sphereArmin Le Grand
(cherry picked from commit a8cc15c001ac76c0d320837cc4cdf65ecb7fc923) Conflicts: xmloff/source/draw/shapeexport2.cxx xmloff/source/draw/shapeexport3.cxx Change-Id: I35f7817f3ea95177dd3aa633b9cbb1b5703f08a0
2013-11-05corrected export of polygons with textArmin Le Grand
(cherry picked from commit c0f65b29f8028ab750c8caac033645c3da3cf2f5) Conflicts: xmloff/source/draw/shapeexport2.cxx Change-Id: Ic8da384d094ce735ecba51b282de7a697558e51f
2013-11-05update pchThomas Arnhold
Change-Id: I10f3dbd9513052b3bbe30ddc6523cd231f26ded3
2013-11-04remove redundant calls to OUString constructor in if expressionNoel Grandin
Convert code like: if( aStr == OUString("xxxx") ) to this: if( aStr == "xxxx" ) Change-Id: I8d201f048477731eff590fb988259ef0935c080c
2013-11-04remove redundant calls to OUString constructorNoel Grandin
Change code like this: aStr = OUString("xxxx"); into this: aStr = "xxxx"; Change-Id: I31cb92e21658d57bb9e14b65c179536eae8096f6
2013-11-04Convert code that calls OUString::getStr()[] to use the [] operatorNoel Grandin
This also means that this code now gets bounds checked in debug builds. Change-Id: Id777f85eaee6a737bbcb84625e6e110abe0e0f27
2013-11-02Revert "transpose "data in rows" ranges for internal data provider, fdo#62057"Markus Mohrhard
This reverts commit 14fa5488a829936275f79a7693b13da55114220e. Conflicts: xmloff/source/chart/SchXMLTableContext.cxx
2013-11-01Directly use OUStringStephan Bergmann
Change-Id: I9029bab2b0ab98a2d78166145a35792e298c9115