summaryrefslogtreecommitdiff
path: root/xmloff
AgeCommit message (Collapse)Author
2017-12-20Fix typosAndrea Gelmini
Change-Id: I6f0eb93ec654e629c8fbe761f000190ea9343103 Reviewed-on: https://gerrit.libreoffice.org/46824 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-19wrap scoped enum around css::util::NumberFormatNoel Grandin
Change-Id: Icab5ded8bccdb95f79b3fa35ea164f47919c68fa Reviewed-on: https://gerrit.libreoffice.org/46339 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-12-19inline use-once typedefsNoel Grandin
Change-Id: I5c3ffc03c26b3428f1f336e6ecba7838a1cf1157 Reviewed-on: https://gerrit.libreoffice.org/46764 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-19loplugin:unusedenumconstantsNoel Grandin
Change-Id: I9dc4b369872a7c6c076ae9be1dcdf2f8385af8a7 Reviewed-on: https://gerrit.libreoffice.org/46684 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-19Fix typosAndrea Gelmini
Change-Id: Ibffe19c1dfda9d0f4ba8d2a0761ad1222491007f Reviewed-on: https://gerrit.libreoffice.org/46599 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-15-Werror,-Wsign-compare (clang-cl)Stephan Bergmann
Change-Id: I4ef3bbcbf93eb2ba6a622b69fefed06321d82cf9 Reviewed-on: https://gerrit.libreoffice.org/46517 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-12-13Related: tdf#71737 xmloff: import of user-defined hyperlink was missingMichael Stahl
... from commit 6ca6d6ac912588a8f62d7e6b668ebec333752ebc. Change-Id: I7f604df3ae83fcc11d148e64c5fc6f7bc229d873
2017-12-13tools: remove unused #include from solar.hMichael Stahl
Change-Id: I214e13add371380701ae39403d90a574a63e495d
2017-12-13Related: tdf#71737 xmloff: adapt XMLSectionExportMichael Stahl
6ca6d6ac912588a8f62d7e6b668ebec333752ebc enabled hyperlinks on 3 more index types. Change-Id: I6be99443965541183d531ad7dca57ab5d4c73a9b
2017-12-13Make loplugin:salcall look into macros tooStephan Bergmann
"Indirect" calls to isSallCallFunction (for canonic and overridden FunctionDecls) already needed to handle many cases of FunctionDecls spanning macros, so it isn't that much more work to make that also work for cases called directly from VisitFunctionDecl. Change-Id: I529f148c8872b86aa1ef082c6cb73db8ab1866e7 Reviewed-on: https://gerrit.libreoffice.org/46367 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-12-13Related: tdf#71737: allows links in more indexesCaolán McNamara
tables, objects and user-defined Change-Id: I081446832ee86453227f4838552c88fd9e5cf75f Reviewed-on: https://gerrit.libreoffice.org/46326 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-12Related tdf#83877 Add signatureline element to draw:frame, not draw:imageSamuel Mehrbrodt
Because a frame can have multiple (fallback) images, so this would have been added only to the first one. Change-Id: I1c41c5e6fd3959fb5cfb5afb5d4fe98b2e5e3c73 Reviewed-on: https://gerrit.libreoffice.org/46243 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-12-11loplugin:salcall fix functionsNoel Grandin
since cdecl is the default calling convention on Windows for such functions, the annotation is redundant. Change-Id: I1a85fa27e5ac65ce0e04a19bde74c90800ffaa2d Reviewed-on: https://gerrit.libreoffice.org/46164 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-08tdf#71737 xmloff: ODF 1.2 doesn't allow hyperlinks in ...Michael Stahl
... text:illustration-index-entry-template, so store these elements only in ODF 1.2 extended, and in loext namespace. Change-Id: Icf919e91114f5c9aed2adc3f5359b9df61eb3433 Reviewed-on: https://gerrit.libreoffice.org/46088 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-12-08tdf#71737: save allows links in illustration index, but load doesn'tCaolán McNamara
since illustration index links were initially implemented by commit 2c10d784deb86501b5488044a61d9fc2efc6321a Date: Tue Jul 16 15:49:44 2013 +0200 fdo#39904, n#825976: implement hyperlinks for Illustrations index (cherry picked from commit 8bb2c7f1556c10508c8ac451c579539ccf5dacfb) Change-Id: I679fb9c40cd5dc55a5d546ef7c533faf9de2e483 Reviewed-on: https://gerrit.libreoffice.org/45967 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-12-05Bin a typedef used just onceTor Lillqvist
Change-Id: I8591b1d872a729402ea6045d2a17dc691fa66788 Reviewed-on: https://gerrit.libreoffice.org/45841 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2017-12-05loplugin:salcall fix non-virtual methodsNoel Grandin
first, since those are safer to change than virtual methods Change-Id: Ie3b624019d75ee2b793cee33b3c5f64e994e8bfe Reviewed-on: https://gerrit.libreoffice.org/45798 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-04tdf#83877 ODF extension to write signature linesSamuel Mehrbrodt
This adds a <loext:signatureline> element to draw:image if the image is a signatureline. Example: <draw:image xlink:href="..."> <loext:signatureline loext:id="..." loext:suggested-signer-name="..." loext:suggested-signer-title="..." loext:suggested-signer-email="..." loext:signing-instructions="..." loext:show-sign-date="true" loext:can-add-comment="false"/> </draw:image> Change-Id: I4d77acec528175fba66556661ab74462f5bd875f Reviewed-on: https://gerrit.libreoffice.org/45153 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-12-04Related tdf#113696 Write fallback graphic for fodf files alsoSamuel Mehrbrodt
Change-Id: I2db10b6a3bf14837160a56813681ba40fa253447 Reviewed-on: https://gerrit.libreoffice.org/45777 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-12-03Use for-range loops in xmlexppr (xmloff)Julien Nabet
Change-Id: I65b20b98082db6cd2bda17f527f7ade7a1123a97 Reviewed-on: https://gerrit.libreoffice.org/45743 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-03Replace list by vector in SchXMLExport (xmloff)Julien Nabet
Change-Id: I279c878891fccddacdc5b8154173105250f39a05 Reviewed-on: https://gerrit.libreoffice.org/45726 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-02Replace list by vector in property_description (xmloff)Julien Nabet
Change-Id: I1290e559f17eb1efbfec09419b4e5283263497fb Reviewed-on: https://gerrit.libreoffice.org/45725 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-02Replace list by vector in xmlexp (xmloff/sw)Julien Nabet
Use for-range loop with "auto" to modernize a bit Change-Id: I9efd7ad2d60eac6a6ce0f79af6ccb02ec235c35d Reviewed-on: https://gerrit.libreoffice.org/45711 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-02Replace list by vector in XMLEventImportHelper (xmloff)Julien Nabet
Change-Id: I5c8ac0a1cad628bd80550d7d0f5cec46d0f66dae Reviewed-on: https://gerrit.libreoffice.org/45724 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-02Replace list by vector in DocumentSettingsContext (xmloff)Julien Nabet
Use for-range loops with "auto" to modernize a bit use return of back() instead of retrieving the reverse iterator Change-Id: Ia1236ec19940a30591c3793516a77e686eee6d01 Reviewed-on: https://gerrit.libreoffice.org/45710 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-01tdf#113696 Add mimetype also to fallback graphicSamuel Mehrbrodt
Change-Id: I6eb7bb66aa688b5668d0eacd2ec7131bec2b6955 Reviewed-on: https://gerrit.libreoffice.org/45585 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-12-01Use isEmpty() instead of getLength()Samuel Mehrbrodt
Change-Id: I2b67c3eebea09d8bebe045ca98341e3347b08fc7 Reviewed-on: https://gerrit.libreoffice.org/45569 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-12-01tdf#113696 Write replacement graphic also to flat odfSamuel Mehrbrodt
Not only to zipped ODF Change-Id: Ic86656aea31c9fc20862628cdd31698b9904e999 Reviewed-on: https://gerrit.libreoffice.org/45568 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-11-30xmloff: turn SvXMLImportContext into a no-op base classMichael Stahl
Fix the non-obvious and potentially dangerous recursion that is implicit in xmloff's context code. SvXMLImportContext::CreateChildContext() now always creates a SvXMLImportContext, does not delegate to SvXMLImport. Rename CreateContext to CreateDocumentContext, to make its purpose of creating only the top-level context more obvious. With the previous changes to CreateContext overrides in sw, reportdesign and dbaccess, this hopefully shouldn't break anything. Change-Id: I9e147bf6297bbac9e8470454881da73f6e39db0a
2017-11-30tdf#113696 Add mimetype to image elementSamuel Mehrbrodt
Otherwise browsers don't recognize base64 encoded svg files. Change-Id: I54d0b87c52a1ca9da1d820751ae32159b88ed28f Reviewed-on: https://gerrit.libreoffice.org/45528 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-11-28ODF export: expose font style and weight of embedded fontsMiklos Vajna
We don't need this info ourselves, but when converting the flat ODF output to other formats, this information is hard to find out, so state them explicitly. Names correspond to existing CSS ones, where it's necessary to state these explicitly. The EPUB export will make use of these attributes. (It is unclear why the test fails on the windows_msc_dbgutil_32 slave, it works for me locally.) Change-Id: I05030b6a14aca842e5a740786f3743e9ae838293 Reviewed-on: https://gerrit.libreoffice.org/45384 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-11-28tdf#109202: Convert images to desired format in (f)odt filterKatarina Behrens
Pass down mimetype to SvXMLGraphicHelper Change-Id: I9c81c06d2a1d6168704440094081e99d0bcbbff9 Reviewed-on: https://gerrit.libreoffice.org/41893 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-11-27loplugin:unnecessaryparen check for (f1()).f2Noel Grandin
Change-Id: I93257b0ddd41c649875124d6d5c5faeaa431bae3 Reviewed-on: https://gerrit.libreoffice.org/45218 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-26No need to test seriesStyle.m_xOldAPISeries n times (xmloff/chart)Julien Nabet
so move it out from the inner loop Change-Id: I367dc428b10ff4554b63ee3cdabfe65ddfb61ea7 Reviewed-on: https://gerrit.libreoffice.org/45291 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-26Modernize by using for-range loops (xmloff/chart)Julien Nabet
Change-Id: I505ac79e76738ce39d1768451e7c213246eec88d Reviewed-on: https://gerrit.libreoffice.org/45289 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-26Replace some lists by vectors in xmloffJulien Nabet
Change-Id: Ib321b4716ee95507b9d51ad8320bc7eb7cf35c93 Reviewed-on: https://gerrit.libreoffice.org/45284 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-24loplugin:countusersofdefaultparams in sw (1)Noel Grandin
Change-Id: I0d14f9c375f93079aef21ca4f1132adc4e1fe06c Reviewed-on: https://gerrit.libreoffice.org/45207 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-23xmloff: Drop non-existent XMLTextPropertyHandlerFactory_ImplTakeshi Abe
Change-Id: I9cef470e0592e1b90d2cc0f2830c60938daf873e Reviewed-on: https://gerrit.libreoffice.org/45126 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-23loplugin:simplifybool for negation of comparison operatorNoel Grandin
Change-Id: Ie56daf560185274754afbc7a09c432b5c2793791 Reviewed-on: https://gerrit.libreoffice.org/45068 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-22Make loplugin:unnecessaryparen warn about (x) ? ... : ... after allStephan Bergmann
...which had been left out because "lots of our code uses this style, which I'm loathe to bulk-fix as yet", but now in <https://gerrit.libreoffice.org/#/c/45060/1/> "use std::unique_ptr" would have caused an otherwise innocent-looking code change to trigger a loplugin:unnecessaryparen warning for pFormat = (pGrfObj) ? ... (barring a change to ignoreAllImplicit in compilerplugins/clang/unnecessaryparen.cxx similar to that in <https://gerrit.libreoffice.org/#/c/45083/2> "Make not warning about !! in loplugin:simplifybool consistent", which should also have caused the warning to disappear for the modified code, IIUC). Change-Id: I8bff0cc11bbb839ef06d07b8d9237f150804fec2 Reviewed-on: https://gerrit.libreoffice.org/45088 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-22xmloff: These arrays are constantTakeshi Abe
Change-Id: I834e23610facb8b4b35f0a377e33b744e7725d1f Reviewed-on: https://gerrit.libreoffice.org/45066 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-21Fix typosAndrea Gelmini
Change-Id: I40b3a46d46f0586d086bdbe41876c088f8c1cb58 Reviewed-on: https://gerrit.libreoffice.org/45007 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2017-11-20look for =() in loplugin:unnecessaryparenNoel Grandin
Change-Id: I4f9b71ff7767e90987bb40358fc46ed5d1d571d0 Reviewed-on: https://gerrit.libreoffice.org/44944 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-16Replace some lists by vectors (xmloff)Julien Nabet
Change-Id: Ide0270ae0b6a17d7c48c0a9ff7901145e00dca6b Reviewed-on: https://gerrit.libreoffice.org/44792 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-15loplugin:flatten in xmloffNoel Grandin
Change-Id: I782278b8a633094b96788f81ae7066a45d45b5fe Reviewed-on: https://gerrit.libreoffice.org/44750 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-13Fix typosAndrea Gelmini
Change-Id: I2a10e087a776ac96b3193226610577227d2492a8 Reviewed-on: https://gerrit.libreoffice.org/44655 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mark Page <aptitude@btconnect.com>
2017-11-13Fix typosAndrea Gelmini
Change-Id: Ia544298334364ece3b3963a4adc00c5e01189b91 Reviewed-on: https://gerrit.libreoffice.org/44654 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mark Page <aptitude@btconnect.com>
2017-11-09rename AvoidConfig to FuzzingCaolán McNamara
cause that's what its really used for and a couple of cases are not specifically about avoiding config but avoiding uninteresting disk acccess and what not Change-Id: I4c6454f98388579fcd0bf9798321d30408ab65ee Reviewed-on: https://gerrit.libreoffice.org/44491 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-06tdf#112547 element p to draw:object, import expects it thereRegina Henschel
There exists no documents produced by LibreOffice, where text on OLE objects has worked, because import expects the paragraphs inside the draw:object element, but LO has written them outside. The patch changes LO to write the paragraphs inside the draw:object element. The patch does not enable LibreOffice to read the paragraphs in old documents. But versions at least since 5.1 will be able to read text on OLE objects from documents which were produced by versions with applied patch. Change-Id: I879135f1a869e46c32361db653ede05227bab95e Reviewed-on: https://gerrit.libreoffice.org/43696 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-11-05ofz#4057 Integer-overflowCaolán McNamara
Change-Id: I6a7ef3ca4c26ce4965deeea27ae47a03169bcf12 Reviewed-on: https://gerrit.libreoffice.org/44320 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>