summaryrefslogtreecommitdiff
path: root/xmloff
AgeCommit message (Collapse)Author
2019-09-06Fixing '....' and '..'Andrea Gelmini
Change-Id: I926069d6c1f2712e5020d930f7ff6c62fd00e912 Reviewed-on: https://gerrit.libreoffice.org/78667 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-09-03loplugin:constmethod in xmloffNoel Grandin
Change-Id: I79ff1001a3ac8fde10de1ab391772e2bfeb6a314 Reviewed-on: https://gerrit.libreoffice.org/78546 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-01Fix '..'Andrea Gelmini
To complete this: https://gerrit.libreoffice.org/#/c/78312/ This is a massive replace for lines ending with ".." instead of "..." It passed "make check" on Linux. Change-Id: I07fa7b2e30ba9ea17a1f9a5e21c57216ba958efe Reviewed-on: https://gerrit.libreoffice.org/78356 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2019-08-29xmloff: create XMLImpressExportOOO instances with an uno constructorMiklos Vajna
See tdf#74608 for motivation. Change-Id: I44c3ac24c19f4ecd1d0d01a9a686b486f3b35c48 Reviewed-on: https://gerrit.libreoffice.org/78236 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-08-27tdf#107776 sw ODF shape import: make is-textbox check more strictMiklos Vajna
Regression from commit 9835a5823e0f559aabbc0e15ea126c82229c4bc7 (sw textboxes: reimplement ODF import/export, 2014-10-04), the problem was that we assumed graphic autostyles look like: <style:style style:name="gr2" style:family="graphic"> for simple (non-text-box) content, and look like: <style:style style:name="gr1" style:family="graphic" style:parent-style-name="Frame"> for complex (text-box) content. Turns out it's valid to have other parent styles as well, e.g. Graphics, which should not be imported as sw textboxes. With this, the arrow at the bottom of page 3 of the bugdoc is now again on top of the image, i.e. layout compatibility is restored. Change-Id: Icbba8a23c5f66e63090f90e6581ebc98948cb80b Reviewed-on: https://gerrit.libreoffice.org/78155 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-08-25cid#1448241 silence Explicit null deferenced false positiveCaolán McNamara
Change-Id: Iaf20e2c7c6f8502d902b41f2c109589aaa490a10 Reviewed-on: https://gerrit.libreoffice.org/78075 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-25cid#1452763 Unchecked return valueCaolán McNamara
Change-Id: Ib2fa604f7c7635892221db4efa4c44f4f542b622 Reviewed-on: https://gerrit.libreoffice.org/78067 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-23loplugin:returnconstval in xmloffNoel Grandin
Change-Id: I200080ff1c44544fdb8211e58228fd62465f3732 Reviewed-on: https://gerrit.libreoffice.org/78020 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-23loplugin:returnconstval in saxNoel Grandin
Change-Id: Icf5c337164b71aab10dd960815eee516822c276c Reviewed-on: https://gerrit.libreoffice.org/77990 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-23tdf#39593 extract UnoTunnelId comparison to template functionArkadiy Illarionov
Change-Id: Ia2b5dea273c8de7b8c54e74780193a8d4cba7b45 Reviewed-on: https://gerrit.libreoffice.org/73874 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-22QR Code : ODF import/exportShubham Goyal
Change-Id: I6c1ae63a89d5ed34d2fa245279d4552949bb64a7 Reviewed-on: https://gerrit.libreoffice.org/74853 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-08-22xmloff: create XMLImpressSettingsExportOOO instances with an uno constructorMiklos Vajna
See tdf#74608 for motivation. Change-Id: Iadb687fc4d55a093cef262b1205ca6a4da89bfa3 Reviewed-on: https://gerrit.libreoffice.org/77934 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-08-20loplugin:constvars in writerfilter..xmlscriptNoel Grandin
Change-Id: I5a318632bcc575ea7e476ec0fb74c905b252ecdd Reviewed-on: https://gerrit.libreoffice.org/77829 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-20Simplify iteration over XMLFontAutoStylePool_ImplMike Kaganski
... which has begin() and end(). Change-Id: I3de0abdcdfc31825693e594d67318a7267bb8d83 Reviewed-on: https://gerrit.libreoffice.org/77810 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-08-19Fix typosAndrea Gelmini
Change-Id: I33a99be34f41c3583fc6684fc68ba6b76ef2f056 Reviewed-on: https://gerrit.libreoffice.org/77682 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-17tdf#88205 Adapt uses of css::uno::Sequence to use initializer_list ctorJulien Nabet
in xmloff Change-Id: Id76c050f4e67bbcada29e78b938cc03ba5d0f6dd Reviewed-on: https://gerrit.libreoffice.org/77622 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-16Fix typosAndrea Gelmini
Change-Id: I8ab75eb5cd54d14fda42bcdb1a251e9e2b6fefdf Reviewed-on: https://gerrit.libreoffice.org/77612 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-16use more TOOLS_WARN_EXCEPTIONNoel Grandin
Change-Id: Ic21ea11ff106e0732bb8fa600ef39a549d7bda86 Reviewed-on: https://gerrit.libreoffice.org/77569 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-16xmloff: create XMLImpressMetaExportOOO instances with an uno constructorMiklos Vajna
See tdf#74608 for motivation. Change-Id: I6c390f6cef83393b630bd0c157aff8d1359c6754 Reviewed-on: https://gerrit.libreoffice.org/77551 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-08-16loplugin:sequenceloop in xmloffNoel Grandin
Change-Id: I1fde11da5f6e97255a9140f11c298d6d525f7230 Reviewed-on: https://gerrit.libreoffice.org/77543 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-14Change some handling for resolved commentsScott Clarke
Changed the way the lcl_CommentNotification method is called when a comment is resolved such that resolution is distinct from other changes. Resolved flag is now only stored in the top annotation of a thread when saved as ODT. Change-Id: I5ef36718fd7e1dfcc16c077871653a70476e8804 Reviewed-on: https://gerrit.libreoffice.org/77411 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-08-14tdf#124243 fix import of deleted X axis of 3D chartsBalazs Varga
3D charts imported from ODF and DOCX showed the deleted X axis. Change-Id: I3316d08af3acd122e5f75fbf0031dda6a337edbd Reviewed-on: https://gerrit.libreoffice.org/77432 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2019-08-13warn on load when a document binds an event to a macroCaolán McNamara
a) treat shared/Scripts equivalently to document scripts This doesn't automatically warn/block running those scripts when used in a freshly loaded document on its own however because DocumentMacroMode::checkMacrosOnLoading will see at... if ( m_xData->m_rDocumentAccess.documentStorageHasMacros() || hasMacroLibrary() ) that the document contains no macros and flip the allow macros flag to true so that potentially new uses of macros added by the user during the edit are allowed to run b) so, add an additional flag to indicate existence of use of macros in a document c) for odf import, set it when a script:event-listener tag is encountered d) for html import when registerScriptEvents or SwFormatINetFormat::SetMacroTable is called e) for doc import when Read_F_Macro or StoreMacroCmds is called as well for good measure f) for xls import when registerScriptEvent or ScMacroInfo::SetMacro is called g) for oox import when VbaProject::attachMacros is called Change-Id: Ic1203d8ec7dfc217aa217135033ae9db2888e19b Reviewed-on: https://gerrit.libreoffice.org/77131 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-12Fix typosAndrea Gelmini
Change-Id: I359ac987daa01e624bdf889c319eeb660f88bbfd Reviewed-on: https://gerrit.libreoffice.org/77260 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-12Fix typosAndrea Gelmini
Change-Id: I52ac067c200b02bc8513033b249863f67b245528 Reviewed-on: https://gerrit.libreoffice.org/77271 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-12Fix typosAndrea Gelmini
Change-Id: I4bd004af206813b9dc01c50ab20f2e8b954b8dca Reviewed-on: https://gerrit.libreoffice.org/77323 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-09Fix typosAndrea Gelmini
"its really" Change-Id: Ic0b41597c83be6c1c66b9cdf6ccbf80b0c2bc9ef Reviewed-on: https://gerrit.libreoffice.org/77204 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-08xmloff: create XMLImpressContentExportOOO instances with an uno constructorMiklos Vajna
See tdf#74608 for motivation. Change-Id: I8a7367720d50baa95406e5e4d8df718fb3e07ac7 Reviewed-on: https://gerrit.libreoffice.org/77132 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-08-07tdf#125628: FORMATTING: Part of text loose yellow highlight reopening documentTamás Zolnai
Change-Id: Id42c33857537451c2dec17d24f65b10f9c16dfa2 Reviewed-on: https://gerrit.libreoffice.org/77135 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-08-01xmloff: create XMLImpressStylesExportOOO instances with an uno constructorMiklos Vajna
See tdf#74608 for motivation. Change-Id: I6b99c5975eacbaba5dbec1ae679c9e5726bdfd6b Reviewed-on: https://gerrit.libreoffice.org/76766 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-07-31Improved loplugin:stringconstant (now that GCC 7 supports it): xmloffStephan Bergmann
Change-Id: I0791c0df1793e05900a32fcdb6d32831bbbe3f9a Reviewed-on: https://gerrit.libreoffice.org/76623 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-07-26Fix typosAndrea Gelmini
Change-Id: I60261b937215340d2eb6f439234e99a300b0e189 Reviewed-on: https://gerrit.libreoffice.org/76380 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2019-07-26cid#1452040 silence Unchecked return valueCaolán McNamara
Change-Id: I4b59245b457def5479ad20363181f538b3b49a69 Reviewed-on: https://gerrit.libreoffice.org/76349 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-26HACK to survive missing target storageStephan Bergmann
...during e.g. `convert-to fodt doc/ooo108999-1.doc` (i.e., the attachment tytret2010.doc at <https://bz.apache.org/ooo/show_bug.cgi?id=108999#c2>). It appears that the call to SwXMLWriter::Write_ to set the "TargetStorage" property is missing in this scenario (which is done for convert-to odt), but it is unclear what a proper fix should look like. Change-Id: I4beab4d8891fc0222bc0867ea53c3d9307be20dd Reviewed-on: https://gerrit.libreoffice.org/76314 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-07-25tdf#119228 Add storage and serialisation for the Resolved flagScott Clarke
Change-Id: I0278588dc533378104e544d05b60583c85271f6a Co-authored-by: Jim MacArthur <jim.macarthur@codethink.co.uk> Reviewed-on: https://gerrit.libreoffice.org/75858 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-07-25xmloff: create XMLImportStylesImportOasis instances with an uno constructorMiklos Vajna
See tdf#74608 for motivation. Change-Id: I7e56486339d5fd436d4dba723bac8bb9bbed170b Reviewed-on: https://gerrit.libreoffice.org/76275 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-07-25Fix typosAndrea Gelmini
Change-Id: I59a0fd175fa5185c15d093d2d9bed9f95bb4cfd5 Reviewed-on: https://gerrit.libreoffice.org/76280 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2019-07-24Fix typoAndrea Gelmini
"an URI", to complete: https://gerrit.libreoffice.org/#/c/75985/ Change-Id: I57489b05117fd12ae6aa22544437ab5bc6b5154f Reviewed-on: https://gerrit.libreoffice.org/76037 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2019-07-24Fix typosAndrea Gelmini
Change-Id: Ib778a6598f3797fe871a25b56b7b4b7761889296 Reviewed-on: https://gerrit.libreoffice.org/76269 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2019-07-21cid#1448305 silence Out-of-bounds accessCaolán McNamara
Change-Id: I7a25cc0c30f06ec146bdc205c51d5cad70e713b1 Reviewed-on: https://gerrit.libreoffice.org/76014 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-21loplugin:referencecasting in xmloffNoel Grandin
Change-Id: Iac3d56511aacec73bc38f57890c44145a4c13b85 Reviewed-on: https://gerrit.libreoffice.org/76034 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-19cid#1448264 silence Out-of-bounds accessCaolán McNamara
Change-Id: I12267e8709d8f36acbbd6c70bfdb80a2a500e5d3 Reviewed-on: https://gerrit.libreoffice.org/75910 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18xmloff: create XMLImportContentImportOasis instances with an uno constructorMiklos Vajna
See tdf#74608 for motivation. Change-Id: I3b52830ece6fae82af1bc57eb93e3a9ad1eb2aff Reviewed-on: https://gerrit.libreoffice.org/75809 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-07-16cid#1448448 Unchecked return valueCaolán McNamara
Change-Id: I195cc073ff7557d30fbffcb97778751908634303 Reviewed-on: https://gerrit.libreoffice.org/75660 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-15ofz#15797 Integer-overflowCaolán McNamara
Change-Id: I623c934f5bb031d383dcf1ce779521a942f99bdf Reviewed-on: https://gerrit.libreoffice.org/75634 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-12MSForms: Rework text-based date form field's representationTamás Zolnai
* Better to represent it similar to text form field with two marking characters selecting a text range * So the text between the two marks can be anything (not only a well formatted date) and also have any character formatting. * With this we handle the case when the user needs a placeholder text in the date field or when the user needs time values (hour, minute, sec) next to the date. Change-Id: Id60a50a2028058f8a6a080e265c0730d88b98543 Reviewed-on: https://gerrit.libreoffice.org/75459 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-07-12MSForms: ODF import / export of text-based date fieldTamás Zolnai
Change-Id: Ib535f1ce065a7f298fcccf95e82d1ffab4d1e1e2 Reviewed-on: https://gerrit.libreoffice.org/75445 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-07-04xmloff: create XMLImportMetaImportOasis instances with an uno constructorMiklos Vajna
See tdf#74608 for motivation. Change-Id: Iaa42d09df5322e8fb23d96e7ff2c298951684c6c Reviewed-on: https://gerrit.libreoffice.org/75058 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-06-20xmloff: create XMLImportSettingsImportOasis instances with an uno constructorMiklos Vajna
See tdf#74608 for motivation. Change-Id: I3e2afe5184f686180b287078477f095792c9ac12 Reviewed-on: https://gerrit.libreoffice.org/74384 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-06-19Use for loop with explicit number of iterationsArkadiy Illarionov
96be3821f7dad19004a43696555eaa4fa2e1aef5 follow-up Change-Id: I1e585a1f4bcd68757cce7b6327757cd7e9ee660f Reviewed-on: https://gerrit.libreoffice.org/74306 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>