summaryrefslogtreecommitdiff
path: root/xmloff
AgeCommit message (Collapse)Author
2015-08-12cppcheck: variableScopeCaolán McNamara
Change-Id: If24e86a0bdc0c5bdce02bed9981232070b38393c
2015-08-12cppcheck: redundantAssignmentCaolán McNamara
Change-Id: I0dcbe0d2afe3741c146027569a906b19abdfdc06
2015-08-12cppcheck: silence redundantAssignmentCaolán McNamara
Change-Id: If1080d99357b45486739120b9ba43c0f14f39ea8
2015-08-11loplugin: defaultparamsNoel Grandin
Change-Id: I7989a91d8d67a15d3fef13391c5dbf06233f75e9
2015-08-07stupid warningMichael Stahl
Change-Id: I1ec30be94ebfc7449a1bd946a73a52eafbe67264
2015-08-07xmloff: replace boost::ptr_set with std::set<std::unique_ptr>Michael Stahl
boost::ptr_set was actually quite nice here, pity about the obnoxious warnings... Change-Id: I46973635fd26e4f1db96f2806c211b83436bef5e
2015-08-07xmloff: replace boost::ptr_set with std::set<std::unqiue_ptr>Michael Stahl
Change-Id: Iaacebe5d88ad8b124f0891f5a7763b9868a6022a
2015-08-07xmloff: replace boost::ptr_set with std::mapMichael Stahl
Change-Id: Ib4effa78cba72954c21ebadf0c5286b2d5207b4f
2015-08-07xmloff: replace boost::ptr_set with std::setMichael Stahl
Change-Id: Idc03bf695d94f47f2057629b4175c2bdf3a83f22
2015-08-05improve refcounting loplugin to check SvRef-based classesNoel Grandin
Change-Id: I2b3c8eedabeaecd8dcae9fe69c951353a5686883 Reviewed-on: https://gerrit.libreoffice.org/17521 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-05loplugin:unusedmethodsNoel Grandin
Change-Id: I6801618efb5a66d24156fa429e026acb6ca03aba Reviewed-on: https://gerrit.libreoffice.org/17506 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-03inline some use-once typedefsNoel Grandin
Change-Id: I02cbbba56a2ad83e0ac3d806265a7e0d6a29594d Reviewed-on: https://gerrit.libreoffice.org/17495 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-03new loplugin: refcountingNoel Grandin
This was a feature requested by mmeeks, as a result of tdf#92611. It validates that things that extend XInterface are not directly heap/stack-allocated, but have their lifecycle managed via css::uno::Reference or rtl::Reference. Change-Id: I28e3b8b236f6a4a56d0a6d6f26ad54e44b36e692 Reviewed-on: https://gerrit.libreoffice.org/16924 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-26Resolves: tdf#91950 optional entries may not be presentCaolán McNamara
here we appear to check if the preceding optional entries are of certain types. Presumably if they are optional then its legal for them not to exist at all, just that if they are there they should be in the right order. Change-Id: Id147b91d7d375d7985d901cda112c7757dc3fb19 Reviewed-on: https://gerrit.libreoffice.org/17336 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-07-19Fix typosAndrea Gelmini
Change-Id: I52cbaad71560d73f5e24f3de3cd62b00d678dd6c Reviewed-on: https://gerrit.libreoffice.org/17187 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2015-07-17formatting of public/private/protected section qualifiersNoel Grandin
make it consistent across the codebase, no space between keyword and the colon Change-Id: Idca61ddfc74ad2460fb05fe417499324b05e5de5 Reviewed-on: https://gerrit.libreoffice.org/17148 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-16loplugin:simplifyboolStephan Bergmann
Change-Id: I06df26c474689126f80236866bd547332e293969
2015-07-15xmloff: ODF import: fix spelling of "extrusion-first-light-level"Andrea Gelmini
The attribute is not imported currently due to the typo, but is exported with the correct spelling from shapeexport.cxx:4377 with XML_EXTRUSION_FIRST_LIGHT_LEVEL. Change-Id: I83d77e7eabbbc961fa4f7faf8e20b47601ba071b Reviewed-on: https://gerrit.libreoffice.org/16641 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-07-15xmloff: document that AOO 4.1 has fixed the svg:d 'z' relative bugMichael Stahl
Change-Id: I0f62101b7bc9de2281ade3eaaa0a38b16f4ccede
2015-07-15-Werror,-Wunused-private-fieldStephan Bergmann
Change-Id: I7dc6c1db75d38d0fe5ee333d4f6a8697abf59e4b
2015-07-15WaE: 'HAVE_FEATURE_GLTF' is not defined, evaluates to 0Tor Lillqvist
Change-Id: I8fec50dcd380fd6bb77672a898c107483298c027
2015-07-15fix Android buildNoel Grandin
I removed the method in commit a62129aa632c2d574a6560efc19f9de84aed1670 "loplugin:unusedmethods xmloff" Change-Id: I0e543b4b9b572f843f68023396d9344c455c2bc1
2015-07-15loplugin:unusedmethods xmloffNoel Grandin
Change-Id: I9d15d8edcc6746c055336bf31e5b0c15cb971ffe Reviewed-on: https://gerrit.libreoffice.org/17061 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-13Make content of OSL_ASSERT, DBG_ASSERT, etc. visiblie in non-debug buildsStephan Bergmann
...to avoid lots of loplugin:staticmethods warnings. Also enables DBG_ASSERT etc. also for --enable-debug builds in addition to --enable-dbgutil builds. Change-Id: Ib89ecd9ab8ce7abb2c64790ace248b31f9d2b64d
2015-07-13tdf#90133 Comply attributes name with OASIS#3860Laurent Balland-Poirier
See https://issues.oasis-open.org/browse/OFFICE-3860 Change-Id: I707b2e86633bc66df03dba8c43879aa6d5153062 Reviewed-on: https://gerrit.libreoffice.org/16905 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2015-07-13use the DBL_MAX constant that we also use elsewhere, tdf#92457Eike Rathke
Change-Id: Ibc48d12ca6b8eb33b2be29f485aa906c513f0591
2015-07-11write trailing text subformat also to Excel .xls and .xlsx, tdf#92457Eike Rathke
... without generating 0;;;@ from 0;@ that has different semantics. Introduce css::util::NumberFormat::EMPTY to properly flag empty subformats and distinguish from UNDEFINED, everything else would be an ugly hack. SvNumberformat::GetMappedFormatstring() now correctly supports the trailing text subformat, so exports using it should get that automatically. Change-Id: If9a1bcc5ec5dfcf46688035e2b1428ab4747a68d
2015-07-11store trailing text format in ODF, e.g. 0;@ tdf#92457Eike Rathke
A clumsy kludge, but since there is no "all others" condition.. Change-Id: Ie89b786585fdee6688f66f5a7af47ec84409eefa
2015-07-11the last condition is "all other numbers", not the third, tdf#92457Eike Rathke
Change-Id: Ic9571d938c4a8837c5712bafbfb2ebf9f32011df
2015-07-10do not include boost/utility.hppMichael Stahl
It just includes a bunch of other boost headers; mostly we need boost/noncopyable.hpp so include that directly. This eliminates 831 MB(!) of boost/preprocessor/seq/fold_left.hpp completely, which is the 2nd biggest header after ustring.hxx. Change-Id: I3df55770adcb46e56f389af828e8ba80da2dc1f2
2015-07-08Avoid loplugin:staticmethods in non-debug buildStephan Bergmann
Change-Id: I9f98e86556ed4435d24f49b32b848eb9f9a66008
2015-07-08Fix typosAndrea Gelmini
Change-Id: I020c7ce4d9aa93cb0292378a410cdb9f7788e920 Signed-off-by: Michael Stahl <mstahl@redhat.com>
2015-07-03Fix typosAndrea Gelmini
Change-Id: I98b4dfb0f72f315065693335e2f882bb2eed3afe Reviewed-on: https://gerrit.libreoffice.org/16713 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2015-06-30coverity#1308431 wiggle code to see if this silences coverityCaolán McNamara
Change-Id: I44eae735b710332d87f2f642911e988c796457cd
2015-06-30Fix typosAndrea Gelmini
Change-Id: I1c5e4970d4e90bdea68a901294594104de5e189e Reviewed-on: https://gerrit.libreoffice.org/16582 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2015-06-28Fix typosAndrea Gelmini
Change-Id: I80995af6459af9f647e66d1c85da2eedad2647b9 Reviewed-on: https://gerrit.libreoffice.org/16523 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2015-06-28Fix typosAndrea Gelmini
Change-Id: Ifd126a535f18db79a18aaec61b76cdf26ab33dff Reviewed-on: https://gerrit.libreoffice.org/16522 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2015-06-27coverity#1308433 Uncaught exceptionCaolán McNamara
Change-Id: I32750eebbcd5a54d3767d77f4f4b8c54c0888078
2015-06-26loplugin:stringconstant: handle OUString+=OUString(literal)Stephan Bergmann
Change-Id: I44c30ef19661d3274a4131dd05a5c786263fae59
2015-06-25loplugin:stringconstant: Flag more inefficienciesStephan Bergmann
Change-Id: I81a60eb512356d19cb746145fdf0dc1a3c676ba1
2015-06-25remove our custom RTTI from xmloff moduleNoel Grandin
not being used, anyhow Change-Id: I0eb0d6377efe324d9a442a70fc2046a58ed2f3c4
2015-06-24Simplify uses of comphelper::string::equals with constant argumentStephan Bergmann
Change-Id: I7b12dd04f6811f71b776ee9168703434217b59c8
2015-06-23Revert "Typo: iff->if"Julien Nabet
This reverts commit cf92da3d6e1de14756efe3f1ee79f393a2f3787d. iff can mean "if and only if" so not a typo
2015-06-23Typo: iff->ifJulien Nabet
Change-Id: I3fc60856b5a56e71d70b55c89323be074bdec3b3
2015-06-23move sorting code closer togetherNoel Grandin
to make it easier to understand. Also switch iteration to range-based for loops. Change-Id: I39a3f565f40458fd5598bb2e97fe71a0fec1c09c
2015-06-22Fix typosAndrea Gelmini
Change-Id: I60ed5eb658d50cbc7dc572facb5463b7527b4d9b Reviewed-on: https://gerrit.libreoffice.org/16408 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-19tdf#42374 some small optimisations for opening this PDF fileNoel Grandin
makes it about 10% faster Change-Id: I145faed5aa7c312372f08cc651df5afcf10c70ab
2015-06-18Fix typosAndrea Gelmini
Change-Id: Ibfa971952cd330ddf430e7e951c5c235d2ae6bd8 Reviewed-on: https://gerrit.libreoffice.org/16314 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-06-17Replace boost::scoped_array<T> with std::unique_ptr<T[]>Takeshi Abe
This may reduce some degree of dependency on boost. Done by running a script like: git grep -l '#include *.boost/scoped_array.hpp.' \ | xargs sed -i -e 's@#include *.boost/scoped_array.hpp.@#include <memory>@' git grep -l '\(boost::\)\?scoped_array<\([^<>]*\)>' \ | xargs sed -i -e 's/\(boost::\)\?scoped_array<\([^<>]*\)>/std::unique_ptr<\2[]>/' ... and then killing duplicate or unnecessary includes, while changing manually m_xOutlineStylesCandidates in xmloff/source/text/txtimp.cxx, extensions/source/ole/unoconversionutilities.hxx, and extensions/source/ole/oleobjw.cxx. Change-Id: I3955ed3ad99b94499a7bd0e6e3a09078771f9bfd Reviewed-on: https://gerrit.libreoffice.org/16289 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-06-16Fix typosAndrea Gelmini
Change-Id: Id8c7cf460cba5af89891c470e1aaa61b227d356e Reviewed-on: https://gerrit.libreoffice.org/16310 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>