summaryrefslogtreecommitdiff
path: root/xmloff
AgeCommit message (Collapse)Author
2013-12-08this assert is wrongMarkus Mohrhard
In calc it seems that shapes can have no autostyle. e.g. exporting fdo60469-74405.xlsx to ods Change-Id: Ie0b2888094ba40a89748a070ca2d14f4078da619
2013-12-06Clean up includes of comphelper/stl_types.hxxStephan Bergmann
Change-Id: I00a8e794189d17ad91a90beb9ce6cb89b7bab2aa
2013-12-06Get rid of unnecessary comphelper::UStringEqualStephan Bergmann
Change-Id: Ia8718e49f21ccec239b2769eafa6bef90e0e9e40
2013-12-06Get rid of DECLARE_STL_MAPStephan Bergmann
Change-Id: Ifbda934a89087fcc1c031978d3e5b5783722b328
2013-12-06Get rid of DECLARE_STL_VECTORStephan Bergmann
Change-Id: If4588034fc09e4663b5217669c71f26c0a3b8c8a
2013-12-06Get rid of DECLARE_STL_USTRINGACCESS_MAPStephan Bergmann
Change-Id: I00d02eaeff3eaa5f49550eb9c1d4e4e7e0b2203c
2013-12-05Get rid of comphelper::UStringLessStephan Bergmann
...default std::less<OUString> is just fine. Change-Id: Ib9d3c10f2817d757f3c19eb3d4607095883af91a
2013-12-05Get rid of DECLARE_STL_STDKEY_SETStephan Bergmann
Change-Id: I4817694d183d525fa5a29eb9693a20d491549e5d
2013-12-02fdo#71450 fdo#71698: ODF import: fix frame name corner casesMichael Stahl
Trying to set a name that is already in use will throw an exception (and set a different, generated name); if there is actually no name in the file then there's no point trying to set anything. (regression from b69d152cfa1da868ba960345d72ba78f9f8e1b35) Change-Id: Ie54d4a830cc23e2853a6efeb81f77dcc788192ea
2013-12-02typo: intarnal -> internalAndras Timar
Change-Id: Ib7803de02d41440668b1e7410dfe0fa40ca2a536
2013-11-25Fix some typos for "height"Julien Nabet
Change-Id: Ibe1fdd7a63ff09097cfe053279d779592d389539
2013-11-24Support regression curve name in ODF.Tomaž Vajngerl
Change-Id: Ic065d63eee507906febfa15eb6d5ae1e7de58280
2013-11-23rigth -> right (other occurences)Julien Nabet
Change-Id: Ic899aa36b1b18237f90295eaa04ea83450958c87
2013-11-22replace OUString::reverseCompareTo("xxx") with operator==Noel Grandin
operator== with OUString and literal internally does a reverse-compare (via OUString::equalsAsciiL) anyway, so no need to keep explicit calls to OUString::reverseCompareTo with literal argument Change-Id: I799d9bcd0d5c308a9547ce7cacb2db6042fdb643
2013-11-20avmedia: Implement "block untrusted referer links" featureStephan Bergmann
See f0a9ca24fd4bf79cac908bf0d6fdb8905dc504db "rhbz#887420 Implement 'block untrusted referer links' feature" for details. This adds some further /*TODO?*/ comments, and one known problem (marked /*TODO!*/) is that movies/sounds are not blocked during a slideshow presentation. Change-Id: Ib2d0c7e4f7b02c4bdec0d8a90cee5e7e1bee8325
2013-11-19convert equalsAsciiL calls to startWith calls where possibleNoel Grandin
Simplify code like: aStr.equalsAsciiL( "%", 1 ) to aStr.startsWith( "%" ) Change-Id: Iee0e4e60b0ae6d567fa8f72db5d616fffbec3c00
2013-11-19remove unnecessary use of OUString constructor when assigningNoel Grandin
change code like aStr = OUString("xxxx"); to aStr = "xxxx"; Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
2013-11-15Resolves: fdo#62461 put preferred image firstCaolán McNamara
with fallback after. "Each child element of a frame is a different representation of the same content. The order of content elements reflects the document author's preference for rendering, with the first child element being preferred. That means that consumers should render the first child element that they support. A frame may contain multiple content elements, but shall contain at least one content element." Change-Id: If50062cad58f5b8561ad6bd8dc1a06956d2f444b
2013-11-14SAL_WARN_UNUSED com::sun::star::uno::AnyStephan Bergmann
Change-Id: I9058044d13f696e07667dce706f6c311af6dbea0
2013-11-14rhbz#887420 Implement "block untrusted referer links" featureStephan Bergmann
For now, this checks for a trusted referer (if the BlockUntrustedRefererLinks configuration prop is set) in utl::MediaDescriptor::impl_openStreamWithURL and SvxBrushItem::GetGraphicObject. Checking in additional places will probably be necessary to block /all/ unwanted communication. Also, some places marked /*TODO?*/ currently pass in an empty referer (which is always considered trusted) and will probably need to be adapted. Ideally, Referer URIs would never be empty (and consistently use something like <private:user> for cases where access is explicitly initiated by the user and should never be blocked), but that's a very daunting task, so start small by identifying the places that potentially need blocking and adding appropriate Referer URIs there. Also, Referer information should always be computed as freshly as possible from the context in which an access attempt is made, but, again, always carrying the information from the context all the way to the relevant functions is a very daunting task, so for now store the information upon object instantiation in some cases (SvxBrushItem, SdrGrafObj, ...). The Referer URI (css.document.MediaDescriptor property; SID_REFERER) was already used to track macro execution, and there is one place in SfxApplication::OpenDocExec_Impl where opening of hyperlinks (explicitly clicked by the user) is done that needs the current document's URI as Referer to check execution of macro URIs but needs an empty (or <private:user>, see above) Referer to not block non-macro URIs. Special code has been added there to handle that. Change-Id: Iafbdc07a9fe925d9ee580d4f5778448f18f2ebd9
2013-11-14Move MediaDescriptor from comphelper to unotoolsStephan Bergmann
...so it will be able to use SvtSecurityOptions internally. Change-Id: Id7433247e8fc53651935578510bedbcca5aa2ac9
2013-11-14-Werror,-Wunused-member-functionStephan Bergmann
Change-Id: Ibfc721a819c044b5e6ec06e5bbad694662fe9e3f
2013-11-14-Werror,-Wunused-member-functionStephan Bergmann
Change-Id: Ied485bebaee36107178acee33eea1eecef70315e
2013-11-14remove unnecessary sal_Unicode casts in XMLOFF moduleNoel Grandin
Change-Id: I836c7a28d5ec9039c0b185e8db2aa6d01ac62566 Reviewed-on: https://gerrit.libreoffice.org/6665 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2013-11-13clear c++11ishCaolán McNamara
Change-Id: I4eea774206a5bd1de1c10a69aceb6476c5feecbf
2013-11-13Respect svg:font-face-format element.Brennan Vincent
Call libeot to parse font if value "embedded-opentype" is found. Change-Id: I03a072fd4db47d151a3934e959ad17c1e24fcf09 Reviewed-on: https://gerrit.libreoffice.org/6144 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-11-11xmloff: include <> for external includesNorbert Thiebaud
Change-Id: Ic92d0121e928041bcff00b12706f794a4d8e25c8
2013-11-11convert OUString compareToAscii == 0 to equalsAsciiNoel Grandin
Convert code like aStr.compareToAscii("XXX") == 0 to aStr.equalsAscii("XXX") which is both easier to read and faster. Change-Id: I448abf58f2fa0e7715dba53f8e8825ca0587c83f
2013-11-11convert OUString !compareToAscii to equalsAsciiNoel Grandin
Convert code like if( ! aStr.compareToAscii("XXX") ) to if( aStr.equalsAscii("XXX") ) which is both clearer and faster. Change-Id: I267511bccab52f5225b291acbfa4e388b5a5302b
2013-11-11convert OUString 0==compareToAscii to equalsAsciiNoel Grandin
Convert code like: 0 == aStr.compareToAscii("XXX") to aStr.equalsAscii("XXX") which is both clearer and faster. Change-Id: I2e906d7d38494db38eb292702fadb781b1251e07
2013-11-11remove unnecessary use of OUString constructorNoel Grandin
Change-Id: Ifb220af71857ddacd64e8204fb6d3e4aad8eef71
2013-11-10cppcheck: reduce scopeJulien Nabet
Change-Id: I7a20f89e5a113c6c8760d51475d8198e28ad6aac
2013-11-07remove misleading commentAndras Timar
Change-Id: I8c4187f3f50c4675ab4fe392ef0f0736109788da
2013-11-07fdo#63020: Replace ::comphelper::stl_begin()...Marcos Paulo de Souza
And use some templates inside include/com/sun/star/uno/Sequence.hxx Change-Id: I48875fa1517751fc4cb0cf2b6c08b88975a29b47 Reviewed-on: https://gerrit.libreoffice.org/6599 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2013-11-07remove unnecessary use of OUString constructor in XMLOFF moduleNoel Grandin
Change-Id: I3bb704d2b1063cd8c2c903cbfa237a7723c321d2
2013-11-06Remove #ifdef TIMELOG'ed SAL_INFOsStephan Bergmann
...the code doesn't make much sense that way. Change-Id: I506e37b44924701255431f6d20d4610f7f52287d
2013-11-06check for empty stringCaolán McNamara
as demonstrated by kde246118-4.odp Change-Id: Idf1224555e0d7be9a679862da9ff256cf7a4d128
2013-11-05Resolves: #i123542# corrected ODF XML export of 3D cube and sphereArmin Le Grand
(cherry picked from commit a8cc15c001ac76c0d320837cc4cdf65ecb7fc923) Conflicts: xmloff/source/draw/shapeexport2.cxx xmloff/source/draw/shapeexport3.cxx Change-Id: I35f7817f3ea95177dd3aa633b9cbb1b5703f08a0
2013-11-05corrected export of polygons with textArmin Le Grand
(cherry picked from commit c0f65b29f8028ab750c8caac033645c3da3cf2f5) Conflicts: xmloff/source/draw/shapeexport2.cxx Change-Id: Ic8da384d094ce735ecba51b282de7a697558e51f
2013-11-05update pchThomas Arnhold
Change-Id: I10f3dbd9513052b3bbe30ddc6523cd231f26ded3
2013-11-04remove redundant calls to OUString constructor in if expressionNoel Grandin
Convert code like: if( aStr == OUString("xxxx") ) to this: if( aStr == "xxxx" ) Change-Id: I8d201f048477731eff590fb988259ef0935c080c
2013-11-04remove redundant calls to OUString constructorNoel Grandin
Change code like this: aStr = OUString("xxxx"); into this: aStr = "xxxx"; Change-Id: I31cb92e21658d57bb9e14b65c179536eae8096f6
2013-11-04Convert code that calls OUString::getStr()[] to use the [] operatorNoel Grandin
This also means that this code now gets bounds checked in debug builds. Change-Id: Id777f85eaee6a737bbcb84625e6e110abe0e0f27
2013-11-02Revert "transpose "data in rows" ranges for internal data provider, fdo#62057"Markus Mohrhard
This reverts commit 14fa5488a829936275f79a7693b13da55114220e. Conflicts: xmloff/source/chart/SchXMLTableContext.cxx
2013-11-01Directly use OUStringStephan Bergmann
Change-Id: I9029bab2b0ab98a2d78166145a35792e298c9115
2013-10-31I assume this is missingStephan Bergmann
...from the changes to xmloff/source/draw/shapeexport2.cxx of f15874d8f976f3874bdbcb53429eeefa65c28841 "i123433 Detect pseudo-vertices at svg import, unify svg:d handling, correct svg:d import for relative sub-polygons in svg import [...]," given how other changes in that file that introduce aPolygonString use it. Found by -Werror,-Wunused-variable. Change-Id: I915b53ed74e03f84f240f1fa1f17768148f030d6
2013-10-31Related #i123433# PolyPolygonBezier must be drawing::PolyPolygonBezierCoordsCaolán McNamara
Change-Id: Idc7e0a2651f2e0b499bbf8b8443ffb84b54a45b6
2013-10-31Resolves: #i123433# Detect pseudo-vertices at svg import...Armin Le Grand
unify svg:d handling, correct svg:d import for relative sub-polygons in svg import; changed default for moveto writes for svg:d in ODF to absolute (cherry picked from commit f15874d8f976f3874bdbcb53429eeefa65c28841) Conflicts: basegfx/inc/basegfx/polygon/b2dpolygontools.hxx basegfx/inc/basegfx/polygon/b2dpolypolygontools.hxx basegfx/inc/basegfx/polygon/b3dpolypolygontools.hxx basegfx/source/polygon/b2dpolypolygontools.cxx basegfx/source/polygon/b2dsvgpolypolygon.cxx basegfx/source/polygon/b3dpolypolygontools.cxx basegfx/source/tools/makefile.mk basegfx/test/boxclipper.cxx basegfx/test/clipstate.cxx basegfx/test/genericclipper.cxx canvas/source/tools/surfaceproxy.cxx sdext/source/pdfimport/tree/drawtreevisiting.cxx sdext/source/pdfimport/tree/writertreevisiting.cxx xmloff/inc/xexptran.hxx xmloff/source/draw/XMLImageMapContext.cxx xmloff/source/draw/XMLImageMapExport.cxx xmloff/source/draw/shapeexport2.cxx xmloff/source/draw/shapeexport3.cxx xmloff/source/draw/xexptran.cxx xmloff/source/draw/ximp3dobject.cxx xmloff/source/draw/ximpshap.cxx xmloff/source/style/MarkerStyle.cxx xmloff/source/text/XMLTextFrameContext.cxx xmloff/source/text/txtparae.cxx Change-Id: I5171b4a3559ea116bea45152e1f2685666463635
2013-10-31Remove the xmloff::token::ResetTokens race conditionStephan Bergmann
...where multiple parallel calls to xmloff::token::ResetTokens or xmloff::token::GetXMLToken can see dangling pOUString pointers. There is no point in releasing this (bounded) amount of memory referenced from global aTokenList, anyway. There is still a race when parallel calls to xmloff::token::GetXMLToken write to a pOUString pointer in parallel, but that's more harmless, and maybe calls to GetXMLToken are synchronized by Solar Mutex? Calls to ResetTokens (e.g., via URP remote release request -> ~ScXMLExport -> ~SvXMLExport) were definitely /not/ synchronized via any mutex. The xmloff::token::Inc/DecRescheduleCount functions are now pointless and have been removed, too. Change-Id: I85905d4de1f042ed5c9a37589f942910d8ef80fd
2013-10-31Convert indexOf->startsWith and lastIndexOf->endsWithNoel Grandin
This is both an optimisation and a cleanup. This converts code like aStr.indexOf("XX") == 0 to aStr.startsWith("XX") and converts code like aStr.lastIndexOf("XXX") == aStr.getLength() - 3 to aStr.endsWith("XXX") Note that in general aStr.lastIndexOf("X") == aStr.getLength() - 1 converts to aStr.isEmpty() || aStr.endsWith("X") so I used the surrounding context to determine if aStr could be empty when modifying the code. Change-Id: I22cb8ca7c2a4d0288b001f72adb27fd63af87669