Age | Commit message (Collapse) | Author |
|
Change-Id: I79f20f67e623b8d9607374e8be9a78fa10dc9af6
|
|
At least moz406390-1.odt has an unreferenced (so uninteresting in
practice) <form:form> block. Till there is a real benefit of it, better
not add form/database components to the Android component list but teach
the user of such code to fail gracefully.
Change-Id: I165a09fefa887da7b78a917c43ecc17d8f0ba3e2
|
|
Deprecated comphelper/sequenceasvector.hxx.
Rewritten code using it. Using instead the functions containerToSequence and
sequenceToContainer, found in include/comphelper/sequence.hxx.
One class that inherits from it (in framework/inc/stdtypes.h), and
the code using that has been left.
Signed-off-by: Michael Stahl <mstahl@redhat.com>
Conflicts:
writerfilter/source/dmapper/DomainMapper.cxx
writerfilter/source/dmapper/TblStylePrHandler.hxx
writerfilter/source/dmapper/WrapPolygonHandler.hxx
Change-Id: Ice61c94ffb052e389281aebb7cdf185134221061
|
|
This reverts commit 2d4b87f0c1bfd97185a89c18d5b7680d11a958d6.
The reverted commit leads to the following regressions:
- Basic dialogs
(which were not targeted, but impacted, by the reverted commit)
with several RadioButtons sharing a group-name (as they will have a
tendency to do) cannot be loaded anymore, since the implementation
assumes (and checks) that names are unique.
- Even in forms, where a RadioButton had both a form:name and a
form:group-name attribute, the form:name attribute wins and thus
RadioButtons that has the same group-name but different form:name
(as they will tend to do) will not anymore be mutually exclusive,
which defeats their point.
Additionally, since it did not change the UI parts (property editor
window), the user was still presented with two different editable
properties "Name" and "Group Name", where "Group Name" was empty...
Change-Id: I1bff532a5a7336cf2eb0579bcd4e2d16be6480fe
|
|
This reverts commit 29e1b2f1ca6e2dcbf9a04c63a3ac1d554cfdcb52
in preparation for reverting 2d4b87f0c1bfd97185a89c18d5b7680d11a958d6
|
|
Change-Id: I955c8ac4dbe002d23531df7eb10fb4444d6b5157
Reviewed-on: https://gerrit.libreoffice.org/14292
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Ia112cf626126149ea9cf09c5d6ff812d5d5ffec5
|
|
if failed to detect the control-implementation
(cherry picked from commit 23e16b91ad69a123e795d63f2d4862d94412d582)
Conflicts:
xmloff/source/forms/elementimport.cxx
xmloff/source/forms/elementimport.hxx
Change-Id: I0ab4f9ff909ceba18a74d38488f6d0bdb3126110
|
|
...in some places where it is obvious that it does not hurt that for an empty
vector the obtained pointer is not necessarily a nullptr.
Change-Id: Id5d66b1559ca8b8955d379bcdbfae6986ef46a51
|
|
found with some minor modifications to find/find-unused-defines.sh
Change-Id: I18cc479adedc7a0dada68a4aeef08300e62631dd
Reviewed-on: https://gerrit.libreoffice.org/14194
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
...by adding some further SAL_DLLPUBLIC_RTTI type annotations (cf.
b4f6b26b5a1a78fecfa95ec2eb7ac8b80495d8aa "SAL_DLLPUBLIC_RTTI for proper RTTI
visibility for LLVM") and by making sure relevant function types do not use
incomplete types in their parameter and return types (which would make the RTTI
hidden).
Change-Id: Id7aadcbc0704b9759968ae36266fc9ce11a2e340
|
|
Where we can prove that the virtual method is never overriden.
In the case of pure-virtual methods, we remove the method entirely.
Sometimes this leads to entire methods and fields being
eliminated.
Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
|
|
Change-Id: I6c5295110292ae48ff0cb3472e4dbea287645d2a
|
|
... to avoid bugs like commit f0d6e0e1e21afd0adf5bd01d771b2d83d8f13a48.
Change-Id: I1e41d421609e09bf62a7a04ba34f3a8e8d118fd3
|
|
Change-Id: I45cb9467c618eed929c84656a26293c8d6087378
|
|
This addresses some cppcheck warnings.
Change-Id: If7ad3584b3124ed0b337836071af1a5bd0451d85
Reviewed-on: https://gerrit.libreoffice.org/13972
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: Ifdd98068762762316dbfd50fb465ed3c970f53d9
|
|
Would be nicer to fix it though.
Change-Id: Ia5f49a69374e9e79a9a16542bc44f279b9e5a6f7
|
|
Change-Id: I4d0e1de89d0bbdbea23bc5a46bf75ae0ce4e2796
|
|
This reverts commit 66c7dbbf7dfba8cfab63f8d1df72ace87e5bf7ca.
See https://gerrit.libreoffice.org/#/c/13554/ .
Conflicts:
include/xmloff/shapeexport.hxx
reportdesign/source/filter/xml/xmlExport.cxx
sc/source/filter/xml/xmlexprt.cxx
xmloff/source/draw/shapeexport.cxx
Change-Id: I14fed9ad043a756a9e2d390c76fa907c349c3a2e
|
|
Change-Id: I9d8614a5c20bab8e3b3d7c40e2504348c4386b64
|
|
Change-Id: I7165d0f1b6b4af4de5e5b39a21f36d726a1b0e30
|
|
Change-Id: Ie76bac6b91a9faa4f9ff7dbdf2b455ea9016cf72
|
|
Change-Id: I2ed239fa073b5fa8fb56c1af9d4b0bac89acfacf
|
|
Change-Id: I43d778e0eee19a56ea37898ec1c4309d3407775e
|
|
Change-Id: Idaa8f07c62b3ba93c27ca5fe286720254baac10d
|
|
Change-Id: Ia8c5913c60e3d509a906965d813c8d1380396dc6
|
|
Change-Id: Ife7dbb298861a71987501f3847d3b931c7e83715
|
|
Change-Id: Ic94608f4afac9d8ac05ec3140d195b0526e9420a
|
|
Change-Id: I1fdbe47ed7a6e05d2cf20f4c296bffad4bbc6599
Reviewed-on: https://gerrit.libreoffice.org/13719
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
|
|
you can get debug stl this way
Change-Id: Ia70a3e7c7c452390e8bee34975d296c9318e4a19
|
|
This reverts commit c6e316f52021cc26d4c5ec9a7b87a07fbf595b62.
The bug #i124452# was in AOO only, no need to fix it in LibreOffice.
Especially when the "fix" causes regression. The related fdo#76334
should be fixed one day, but that is a different issue.
Conflicts:
xmloff/source/draw/ximpcustomshape.cxx
Change-Id: Ice0bf378f97e2caf0ee8386d0b5c0b8abcbcd1c2
|
|
A later version of ODF will hopefully allow <table:table> here as well,
but read <loext:table> in the meantime.
Change-Id: I42a461e0a6e9eff9387379acbab9660a155ecefe
|
|
Change-Id: Ia528bd301e2f2ee1f7f3b009e3b9c3f395a4dcdb
|
|
Change-Id: I9c02fdd99504bdee6654d1072559a4afac6532a3
|
|
Change-Id: Iebed41cfcc5899387e3defb8d8a0792276349098
|
|
...at least when we can easily not assume it.
shapes = shapes of the same XShapes
an enumeration = it is the sequence 0, 1, 2, 3, ..., XShapes->getCount()-1
We replace the ZOrder property by the index of the XShape in the
XShapes (the same XShapes that is passed to seekShapes()... when that
is easy to find. Else, use ZOrder and hope for the best.
ZOrders are not always an enumeration. For example, in documents
(forms) created by the Base forms wizard, it is not the case.
The wrong assumptions was leading to the following bugs in the Base
form wizard:
- Only the first two controls in the form were successfully saved. The
others were just dropped.
- Whereas the labels had the proper style (background and text
colour) applied while creating the document, these were not saved
successfully
Change-Id: I15b9a3ef3b16eafa9698332e35d82d51d51627f8
|
|
resolves a shitload of warnings like
warn:legacy.osl:941:1:xmloff/source/forms/elementimport.cxx:426: OElementImport::implImportGenericProperties: unsupported value type!
warn:legacy.osl:941:1:xmloff/source/forms/elementimport.cxx:443: OElementImport::EndElement: could not set the property "ObjIDinMSO"!
warn:legacy.osl:941:1:xmloff/source/forms/elementimport.cxx:444: caught an exception!
in function:void xmloff::OElementImport::implApplyGenericProperties()
type: com.sun.star.lang.IllegalArgumentException
Change-Id: Ia598d12e7d9429fe4ad3b1e7173e11e75060a613
|
|
Change-Id: I2db8842411e39d7d100d0627f8c930bb3f633d77
|
|
Change-Id: Iccb98e50a678e5c53b69fb1052e3dac83cdcf5f5
|
|
Change-Id: I349e0c2575d9a5154ac7002d129a1851a3df7687
|
|
...to use single ASCII character literals "more directly" in the OUString API
(instead of having to go via an intermediary OUString ctor call). Especially
useful for character literals that are defined as const variables or via macros
("direct" uses of character literals in the OUString API can often simply be
replaced with single-character string literals, for improved readability).
(The functions overloaded for OUStringLiteral1 are those that are actually used
by the existing LO code; more could potentially be added. The asymmetry in the
operator ==/!= parameter types is by design, though---writing code like
'x' == s
is an abomination that shall not be abetted.)
Change-Id: Ic5264714be7439eed56b5dfca6ccaee277306f1f
|
|
Change-Id: Idbe6ac27a4125bd9d9acb01ac42b60396abf0c81
|
|
When exporting the .DOC bugdoc of fdo#87110 to ODF, the auto-styles
export will iterate over the fieldmarks in the page header and add the
attributes for them but not export the elements, so the first auto-style
gets a bunch of duplicate attributes.
Change-Id: I3fcf39f03e3d9ae5fca661efa7eb4bbb3eab9f5c
|
|
There are at least 2 callers of InsertTextContent() that have
non-trivial catch handlers for this exception, which aren't called now.
(regression from bebf8ccfba37f77d6a43c7874249b31736467b17)
Change-Id: I085b710dfd5877e9b7e71610951543eddf6a6e46
|
|
Change-Id: Ib88f0e9b0a3ba229c9e9f6cf20831c16051e3e29
|
|
Change-Id: I1a435214af102461e02217f7d95248dac14e5f1a
|
|
Change-Id: Ica66112199d6f81d1e8ddf8d78ddde49a3ea6037
|
|
Change-Id: Id7770ffda49ba7bc0ebc780c67c56b81152213f7
|
|
Below data-pilot-groups the correct element name is
data-pilot-group-member and not data-pilot-member.
Change-Id: I41aecb7f85a881d13b3eaaa7be8de737b47ea312
|