summaryrefslogtreecommitdiff
path: root/xmloff
AgeCommit message (Collapse)Author
2016-12-12coverity#704108 Unchecked return valueCaolán McNamara
Change-Id: I5bd58f94fbea3d59849f60f2096e5191dbb0d810
2016-12-09xmloff: XMLChangeImportContext: replace boolean pair with proper enumMichael Stahl
Change-Id: I82ec75058a2309b8bcf0f8e78d8ef0db367014b0
2016-12-09xmloff: convert some DBG_ASSERT in txtparae.cxxMichael Stahl
Change-Id: I7b53726e3bb16ff1d9a6cdb05ce4cf4273eb5ac4
2016-12-05convert DecodeMechanism to scoped enumNoel Grandin
Change-Id: I5c56634b1bca8e37fa73d02d2428645301b6c547
2016-12-02Remove dup line in aGroupShapeElemTokenMap (xmloff)Julien Nabet
Change-Id: Iac0194046a9a2aae25f7976df6f845f6f909425f Reviewed-on: https://gerrit.libreoffice.org/31507 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-02inline some constant strings in xmloff (part1)Noel Grandin
Change-Id: I7971f210ffb30bdd80a1adde2c286b4d092bd053 Reviewed-on: https://gerrit.libreoffice.org/31433 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-01crashtesting: a gadzillion failures on export to odpCaolán McNamara
e.g. fdo35235-1.odp Change-Id: I259cdc9ed073be2ad7d5208cd943d4f193f09c16
2016-12-01loplugin:unnecessaryoverride (dtors) in xmloffStephan Bergmann
Change-Id: I351ff5955d766118e3a6b2234181774af0d1f522
2016-11-29tdf#102479 ODF export: ignore exceptions when checking shape textMichael Stahl
The bugdoc contains a SwXShape-SwXTextFrame aggregate which contains only a table, no top-level paragraph. Because of that, SwXTextFrame::createTextCursor() throws a RuntimeException. Assuming that the exception itself is intentional, work around it in XMLShapeExport::collectShapeAutoStyles() and assume that the getString() check that was added there in commit 73fcb052edf1a21d785583bc53e8b4323b577bb1 is just a performance optimization; the actual export of auto styles and content uses XEnumerationAccess anyway. Change-Id: I7c23164b1e692ce16e5b4e03dd945e46768677de Reviewed-on: https://gerrit.libreoffice.org/31218 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-11-25add exception context to error log messageEike Rathke
Change-Id: Iae8a0c8e7ed4c8bec6497f1636a943bd6f79d5c8
2016-11-25replace useless OSL_FAIL with DBG_UNHANDLED_EXCEPTION_WHENEike Rathke
Change-Id: I7eebb09d1725eff4793330362e5bfba84a237195
2016-11-25replace meaningless OSL_FAIL with DBG_UNHANDLED_EXCEPTION_WHENEike Rathke
Change-Id: I8aceb106339d879455bd96b2f84b54306f13d062
2016-11-23loplugin field-can-be-private in include/vcl..xmlscriptNoel Grandin
Change-Id: Ia03f7cccb256d825daa4dc6f4c0598448e46e6cf Reviewed-on: https://gerrit.libreoffice.org/31069 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-18includes should be at the top of the fileNoel Grandin
not randomly scattered through the code found with something like: git ls-files *.cpp | xargs grep -Pzl "(?s){.*#include" Change-Id: I9c242fa4ef99e8677f2800d7ec9f16d16e488351 Reviewed-on: https://gerrit.libreoffice.org/30952 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-17ODF: do not write an empty style:text-position="" attribute for CharEscapementEike Rathke
... and CharEscapementHeight if the Any is void. This was a real error complained about in the officeotron validation https://bugs.documentfoundation.org/attachment.cgi?id=128411 https://bugs.documentfoundation.org/show_bug.cgi?id=103493 Also showed up as console warning warn:legacy.osl:3269:1:xmloff/source/core/xmlerror.cxx:178: An error or a warning has occurred during XML import/export! Error-Id: 0x20040003 Flags: 2 ERROR Class: 4 API Number: 3 Parameters: 0: CharEscapement Exception-Message: UNKNOWN_PROPERTY Position: Public Identifier: System Identifier: file:///.../103493-LotroPlan%203.8.ods Row, Column: 2,1850164 Change-Id: Ifc634cc6b3d5d6dfa43741005ef0c9a1f7ff71fe
2016-11-17clearly a wrong offset is worth an assert() instead of OSL_ENSURE()Eike Rathke
Change-Id: I2a4a8f054269df3ee085b9373f00bd749667665e
2016-11-17loplugin:datamembershadow in xmloffNoel Grandin
Change-Id: Ibea23b1757be1ec007f48261130aad74ce750cfc Reviewed-on: https://gerrit.libreoffice.org/30925 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-16This condition has been checked beforeSamuel Mehrbrodt
Change-Id: I8a2d4f3cce3e286432a100f82b5d22f588fb95b8 Reviewed-on: https://gerrit.libreoffice.org/30773 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-16Small housekeeping: merged two if's with same result into oneMike Kaganski
Change-Id: I63e038173338055b5b4003e1a6040b8680b8bbd6 Reviewed-on: https://gerrit.libreoffice.org/30901 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2016-11-16new loplugin finalprotectedNoel Grandin
look for final classes, and make sure they don't have protected members Change-Id: I1fa810659bba02b61a5160dbfd8e24185ec9abf4 Reviewed-on: https://gerrit.libreoffice.org/30895 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-15fix typoDavid Tardon
Change-Id: I2dd093a12518c2c23d9f1610fb8a4b45a94656ab
2016-11-15remove prop. name variableDavid Tardon
It is not used consistently anyway. Change-Id: Ia842668dfb36dc2a8fbf3b938758b81c78d5c868
2016-11-15loplugin:constantparamNoel Grandin
Change-Id: Iced8ff99d52d55e6b6c3126affafbea6786e94f0 Reviewed-on: https://gerrit.libreoffice.org/30858 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-11xmloff: print a warning if we drop a style on the floorMichael Stahl
Turns out we do not support section styles. Change-Id: I2858c639c1c9743f53836548b4c73645fa32d87b
2016-11-11tdf#67544 Embed slide transition sound in the presentationSamuel Mehrbrodt
This is only the filter part, UI is still missing Change-Id: Ic2ee0196c6b501abb244397cb14bb70626b45ae8 Reviewed-on: https://gerrit.libreoffice.org/30772 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-09make comphelper::containerToSequence a little smarterNoel Grandin
So we don't have to specify the source and destination type as often. Change-Id: Id9e286417a1cb246d163cbc3c536b231a4a92624 Reviewed-on: https://gerrit.libreoffice.org/30700 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-04update loplugin:unnnecessaryvirtual to handler destructorsNoel Grandin
and update modules writerfilter..xmloff with the resulting changes Change-Id: I54d19c22ddb0ff579b32e4934d266c925b19305c Reviewed-on: https://gerrit.libreoffice.org/30530 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-31This apparently always wanted to check that _rChars.trim() is non-emptyStephan Bergmann
...and d3e89269304c623e3b52a097e9e270f1bf1f09b8 "initial checkin - implementations for formlayer import/export - still under construction" just forgot the '.getLength()' in OSL_ENSURE(0 == _rChars.trim(), ... that is present in other, similar code. (And the current code happend to use the operator ==(sal_Unicode const *, OUString const &) overload that happens to treat a null first argument like an empty string.) Change-Id: I9d74b6ae29ca5f5f80391de50e4898add6bf6fe2
2016-10-31loplugin:oncevar in xmloff..xmlsecurityNoel Grandin
Change-Id: I2353d3c73130ed9420e8d803a9a96a06549bb6bd Reviewed-on: https://gerrit.libreoffice.org/30429 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-31Omit comparator which is the same as default std::less<key_type>Takeshi Abe
Change-Id: I72a0b618577caececaaf3eb4df53d4cb192251da Reviewed-on: https://gerrit.libreoffice.org/30369 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-10-28update unnecessaryoverride plugin to find pure forwarding methodsNoel Grandin
which can be replaced with using declarations. Is there a more efficient way to code the search? Seems to slow the build down a little. Change-Id: I08cda21fa70dce6572e1acc71bf5e6df36bb951f Reviewed-on: https://gerrit.libreoffice.org/30157 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-24loplugin:expandablemethods in xmloffNoel Grandin
Change-Id: I995a4167ac4df5ca35d963dcf68ae802a997e1e1
2016-10-24Simplify code furtherStephan Bergmann
...after 9ad0e56be46df46b021109acfd6ece9d17ce84f8 "fixes for >>= with rhs Any" Change-Id: Idf7b7033bd0ef5501e2884841ba897f8691a5f77
2016-10-24fixes for >>= with rhs AnyJochen Nitschke
this changes behaviour because >>= always returned true Change-Id: Ia7bbce1696e5c23f6e1e6f1a7e60b3c462cf0086 Reviewed-on: https://gerrit.libreoffice.org/30141 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-21loplugin:expandablemethodds in include/xmloffNoel Grandin
Change-Id: I6b1430220adaf240ef873ff908e3a767dfc278bf Reviewed-on: https://gerrit.libreoffice.org/30106 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-18replace <<= with assign for <<= with rhs AnyJochen Nitschke
found by deleting specialization of '<<=' template Change-Id: I253f15177ab20fd3ef9baf4158da8c662cb47e6c Reviewed-on: https://gerrit.libreoffice.org/29956 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-10-18loplugin:inlineablemethods in xmloffNoel Grandin
Change-Id: I22202f85c65a862ccdafe1d521e2945e3d99252a
2016-10-17replace <<= with assign for <<= with rhs AnyJochen Nitschke
makeAny and Any ctor return an Any Change-Id: Iaa361bc315d785f80153acf1009bf47d109728ec Reviewed-on: https://gerrit.libreoffice.org/29914 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-10-14tdf#64038 ODF import: fix handling of space following <text:s>Michael Stahl
The whitespace collapse algorithm given in ODF 1.2 part 1, "6.1.2 White Space Characters", was not implemented as well as it could be. Although the problematic case is arguably invalid, because "6.1.3 <text:s>" says: This element shall be used to represent the second and all following “ “ (U+0020, SPACE) characters in a sequence of “ “ (U+0020, SPACE) characters. Hence it is probably irrelevant in practice that a space following <text:s> was ignored, because a conforming document cannot have such content. Change-Id: Ic30347fff27176c511ea317d46a1011b410e57d5
2016-10-13loplugin:unnecessaryoverrideNoel Grandin
Change-Id: I08c55a3023ec2e8990098eeb60e91cd18556e7ae Reviewed-on: https://gerrit.libreoffice.org/29656 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-11loplugin:constantfunctionNoel Grandin
update the plugin similarly to commit 3ee3b36ae0c064fb5c81268d8d63444309d1b970 Author: Stephan Bergmann <sbergman@redhat.com> Date: Fri Oct 7 12:05:49 2016 +0200 loplugin:staticmethods: Don't be fooled by decls starting with macros Change-Id: I98ac3216d5acf89a49a26feb089ae2fd34e6e510 Reviewed-on: https://gerrit.libreoffice.org/29665 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-11loplugin:unnnecessaryoverride in xmloffNoel Grandin
Change-Id: Iad519bd61ce1d1bf4ef4e12543b0d485249db36b Reviewed-on: https://gerrit.libreoffice.org/29672 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-11catch the exception to prevent broken charts, tdf#98690Markus Mohrhard
Change-Id: I5958c87ca793c19d5c78dc829eb0ff0a1e04dffa
2016-10-07xmloff: fix --enable-mergelibs buildMichael Stahl
... by merging all object-using CppunitTests into uxmloff, which is already disabled for MERGELIBS. Change-Id: I12ad08660fd714cceba2fe9b855cdb1bbda19c2d
2016-10-07tdf#102370 Correctly export to Excel exponent without signLaurent Balland-Poirier
Exponent without sign in scientific notation is coded in Excel with a minus sign replacing plus sign: 0.00E-00 for instance This format is already correctly treated in Calc but was not correctly exported to Excel or ODF Change-Id: Ide117b04e0eb887c6cdd6699ae8ec723d1d29d50 Reviewed-on: https://gerrit.libreoffice.org/29198 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2016-10-07loplugin:staticmethods: xmloffStephan Bergmann
Change-Id: Iad001ce011cd6aff4af9bb2e9129abee7fb935dc
2016-10-06xmloff: fix crash in ~XMLParaContext on fdo72541-1.fodtMichael Stahl
Change-Id: I3310699020bfea085eb62c50a7d5de25af51c1b1
2016-10-06rtl::math::approxEqual(value,0.0) never yields true for value!=0.0Eike Rathke
... so replace with a simple value == 0.0 also in other modules than sc. Change-Id: Ie7316505a1cf9c15100114b45d300facceb03b7e Reviewed-on: https://gerrit.libreoffice.org/29575 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2016-10-04this is used as a stack, so convert to std::stackCaolán McNamara
Change-Id: I248617ccbb985615f936ecd607ab7c8246ff8e71
2016-10-04we just care about empty vs nonempty hereCaolán McNamara
Change-Id: Ie7888f611f804ed1bd235e32e21560981f116c9a
generated by cgit (git 2.34.1) at 2025-01-14 18:29:09 +0000