summaryrefslogtreecommitdiff
path: root/xmloff
AgeCommit message (Collapse)Author
2016-01-12xmloff: SvXMLExport::mbExtended is dead nowMichael Stahl
Change-Id: Ie679259deccce87949d7bf8767af707827b4134c
2016-01-12xmloff: there is no reason why office:version should be omittedMichael Stahl
... if a document contains foreign elements or attributes. In fact since ODF 1.2 the office:version attribute is mandatory and any document that omits it is therefore invalid, while "extended conforming" documents are allowed to contain foreign elements and attributes. This mysterious check was there since CVS initial import, but without any justification. Change-Id: Ifeafad2b7af41f06356461adb7ae65dbf7bae11d
2016-01-12typosMichael Stahl
Change-Id: I970429c266cc1a8cf36cfba379b447899b5dbce9
2016-01-11tdf#40517 Export/Import in ODF decimal replacement with spaceLaurent Balland-Poirier
Number format such as "0.???" is saved in ODF with number:decimal-replacement=" " Change-Id: I0dd19b5ea126f380bcf17a3ccc5d8c355119e23b Reviewed-on: https://gerrit.libreoffice.org/21021 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-01-10Fix typosAndrea Gelmini
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86 Reviewed-on: https://gerrit.libreoffice.org/21209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-01-08tdf#96480: ODF import: eliminate duplicate cross reference heading bookmarksMichael Stahl
7c3c3006deaaaf1bb3f2f4eeeaf11da3bcebe53c is apparently worse than it appeared at first glance since there are numerous assumptions about bookmarks, such as that if they were inserted successfully they may be copied successfully, which isn't the case for duplicate cross reference bookmarks. So fix this differently, by eliminating the duplicates and mapping all reference fields to refer to the surviving bookmark. It was not possible to do this in SwXBookmark by checking the makeMark() return as that would raise interesting problems such as it's currently guaranteed to have 1:1 SwXBoomarks to core Marks so we can't just connect 2 SwXBookmarks to the same core Mark, and we also can't leave the SwXBookmark unconnected after attach. Another alternative would be to temporarily allow inserting the duplicate bookmarks and then eliminate them after the import, but what is implemented now is to check from xmloff for duplicates, which is reasonably simple. Change-Id: I7ee4854d1c9d8bf74201089cbb7287b1bd8ee3b9
2016-01-08indentation fixesMarkus Mohrhard
Change-Id: Ibc652519d7ccc9a1ec483f19d443c9b5303e0f92
2016-01-05tdf#94205: Use o3tl::make_unique insted of new+std::move.Sheikha AL-Hinai
Change-Id: I9ff14760479d2ac882546e2e5b74ab750ba2fa4b Reviewed-on: https://gerrit.libreoffice.org/20984 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2015-12-29cppcheck: noExplicitConstructorCaolán McNamara
Change-Id: Ib43e53d5b6c9c130adb765ac9b769f58060ac640
2015-12-26xmloff: indent cleanup in headerChris Sherlock
Change-Id: Ibcd03dcdc8936ce95feada20c72a358d5021a1d9 Reviewed-on: https://gerrit.libreoffice.org/20962 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2015-12-26xmloff: change instances of maName to more descriptive namesChris Sherlock
Change-Id: I7ff771f78481677ae65f933608e484714cd43f4f Reviewed-on: https://gerrit.libreoffice.org/20961 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2015-12-22tdf#96181 SVG: Add support for <use> elementXisco Fauli
Change-Id: Ia95c7e35158f8a4c6a597662524c74e1909983bb Reviewed-on: https://gerrit.libreoffice.org/20483 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2015-12-22loplugin:unusedfields in include/vclNoel Grandin
Change-Id: I61fc04e00970ea0d398ff80f6b1f81ec2f62dd5e Reviewed-on: https://gerrit.libreoffice.org/20868 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-12-21loplugin:unusedfields in xmlhelp,xmloffNoel Grandin
Change-Id: I4d2f0ff95da5abaa3d0a0a5223616e09e0c476fc
2015-12-19xmloff: one more missing includeMiklos Vajna
Change-Id: I92080eefa485dec86c3a10f978831157b04a0c53
2015-12-19coverity#1343637 Double freeCaolán McNamara
and coverity#1343638 Double free coverity#1343639 Double free coverity#1343640 Double free coverity#1343641 Double free Change-Id: I8ce42f03d40fe514f73b3a7eabdb4f323b2239e6
2015-12-17Avoid memory leaksStephan Bergmann
...when exceptions get thrown while a context owns an rewind map Change-Id: I90d26caa57ef2ff508e6eae05ddbc62cdb3f01ea
2015-12-17Remove trivial class XMLTransformerContextVectorStephan Bergmann
Change-Id: I140614895d5727ffd97681ddd06bf7439fe7a443
2015-12-17Hold XMLTransformerContext by rtl::ReferenceStephan Bergmann
Change-Id: I60b8d422d53d47537996756aa1b7fb3c26f8383a
2015-12-17tdf#32248 SVG: first attempt to support tspan elementsXisco Fauli
it's not perfect but at least we can already display the text, which is better than displaying nothing Change-Id: I89627010ac8071c106b41c1de6b183a619f8158b Reviewed-on: https://gerrit.libreoffice.org/20642 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2015-12-11Resolves: tdf#93994 flush API objects at load timeArmin Le Grand
When importing SdrObjCustomShape for each an Outliner and a VirtualDevice as RefDevice are created and held. On 32bit systems this breaks the import with many such objects (in the bugdoc around 4300). On 64bit it works, but more memory as necessary is used. To avoid this, flush the UNO API implementations at these objects after one page is imported. Do not do this for each single object, that will break the connector import which does some processing later. Change-Id: I7296edd40f01c1a40258808d78bf39e6d4fe29bf Reviewed-on: https://gerrit.libreoffice.org/19990 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-12-10loplugin:nullptr: More NULL -> nullptr automatic rewriteStephan Bergmann
Change-Id: Ie83819e2bcdc5fa160b39296b005ca9a5ff74b1d
2015-11-26-Werror,-Wunused-private-fieldStephan Bergmann
Change-Id: I3f328023d99d3505ab2ce2a80eef82d84d81446e
2015-11-26mark UNO structs as SAL_WARN_UNUSED, where possibleNoel Grandin
Change-Id: Ie3de518f60c9f1313c68df54dbdc1fb2804f1f0d
2015-11-26loplugin:unusedfields variousNoel Grandin
Change-Id: I18f94269a1172cf195ee402384f7144610e1e82d
2015-11-26com::sun::star->css in xmloff/Noel Grandin
Change-Id: Iee6e21e093fb1383f19a0716dbc1c341f446b8c2 Reviewed-on: https://gerrit.libreoffice.org/20192 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-25loplugin:unusedfields in include/xmloffNoel Grandin
Change-Id: I979743671e9a2e868d815f917427588b7b0320ba
2015-11-25store custom icon set info into ODFMarkus Mohrhard
Change-Id: I1581b28237d2b9f9c22d3f3b0436dc281508aafa Reviewed-on: https://gerrit.libreoffice.org/20118 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2015-11-24crashtesting: ooo72999-1.ods NaNs found in light directionCaolán McNamara
and NaN != NaN so busted logic propogates, drop invalid directions on initial read Change-Id: Ic76c714666df14d37a4c68f43b817327675bd0e0
2015-11-24loplugin:unusedfields in xmloff/Noel Grandin
Change-Id: I1fb9cb1bc04fb0886d6080f62899a04e8fd4429e
2015-11-20add mapKeysToSequence/mapValuesToSequence methods to comphelperNoel Grandin
and use them Change-Id: If4dc9df63db37185228aeaaab2979498d61304ec Reviewed-on: https://gerrit.libreoffice.org/20055 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-19Incredible slowness and crashes with document with vast num of frame dupsCaolán McNamara
it looks like draw:name values are supposed to be unique in ODF, even if it's not spelled out explicitly, since it exists so the frame can be referenced, which sort of implies that it has to be unique, so a document where the values aren't unique can be considered invalid 19.197.10 <draw:frame> The draw:name attribute specifies a name by which a <draw:frame> element can be referenced. So reject duplicate frames Change-Id: I83f6d72fd969f667f0a8c2c85d2ffeeed672387a
2015-11-19use comphelper::containerToSequenceNoel Grandin
Change-Id: I223ff4af01ab2da92da0c26d32457204a5008c4a
2015-11-18xmloff: add meta:generator constants LO_43x and LO_44xMichael Stahl
Change-Id: I1d962ad637f19b02855616edebcedbad719689c5
2015-11-18xmloff: legacy assert to SAL_INFO as it can only be triggered byMichael Stahl
... invalid input files. Change-Id: I351302253169d32cd6a83ff63eb497d0069ab49b
2015-11-18xmloff: document potential pitfall with SvI18NMap usageMichael Stahl
Change-Id: I37050203f9d7b4f04b6d0b0dc5c4e04855d017f7
2015-11-18remove unused typedefs and inline use-once typedefsNoel Grandin
and improve the script a little Change-Id: I2792ea4dd5df3a50736fbe209225c3f16fb86b84 Reviewed-on: https://gerrit.libreoffice.org/20033 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-17use unique_ptr for pImpl's in xmloff/Noel Grandin
Change-Id: Ib95118941938af83fed566a085837e17f092017a
2015-11-16use initialiser list for Sequence<OUString>Noel Grandin
Change-Id: Ia5e47261d1fc6fac2d046656c05a1c5eedb07e02 Reviewed-on: https://gerrit.libreoffice.org/19978 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-15Fast PCH generator and optimized PCH filesAshod Nakashian
Ported update_pch.sh to Python with improved performance and features. The new script is invoked from the same update_pch.sh which calls it for each library in parallel, although it can be invoked directly. The ported script (update_pch) updates all PCH files in ~15 seconds where the old script took ~4500 seconds. In addition, the new script supports 3-tiered headers (system, module, and local) and is very flexible to support other improvement. It has a per-library optimal configuration settings that can be updated using another new scripts (update_pch_autotune.sh) which finds optimal per-PCH settings. PCH files have been generated using the new scripts which builds significantly faster (2-3x, depending on module and configuration) and the intermediate binaries are noticably smaller (by several GBs). The new script stamps each generated PCH file with the command that generated it to make it trivial for users to update them, and also adds the command to invoke another script (update_pch_bisect) that helps find missing headers or conflicting headers that may break the build after updating the PCH. Finally update_pch has built-in unit-tests for makefile parsing and other core functionality. Change-Id: Ib933b50e50374d7e2e7e3e95ba8799b0cc8a27fa Reviewed-on: https://gerrit.libreoffice.org/19965 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-11-15use initialiser for Sequence<OUString>Noel Grandin
using variations of: git grep -lP 'Sequence.*OUString.*\(\s*1\s*\)' | xargs perl -0777 -pi -e "s/Sequence<OUString> (\w+)\(1\)\; \s*OUString\* pArray.*; .*\[0\]\s*=\s*(\S+)\;/Sequence<OUString> \1 { \2 };/g" Change-Id: I03c64334ff30ee14dce0d17b67f5122a3893bbe3 Reviewed-on: https://gerrit.libreoffice.org/19971 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-15use initialiser for Sequence<OUString>Noel Grandin
replaced using: git grep -lP 'Sequence.*OUString.*\(\s*1\s*\)' | xargs perl -0777 -pi -e "s/Sequence<\s*OUString\s*> (\w+)\(\s*1\s*\); .*\[0\] = (\S+);/Sequence<OUString> \1 { \2 };/g" Change-Id: I20ad0489da887a9712982531c3b127339bb8b3b9 Reviewed-on: https://gerrit.libreoffice.org/19969 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-15use initialiser for Sequence<OUString>Noel Grandin
performed using: git grep -lP 'Sequence.*OUString.*\(1\)' | xargs perl -0777 -pi -e "s/Sequence<OUString> (\w+)\(1\); .*\[0\] = (\S+);/Sequence<OUString> \1 { \2 };/g" Change-Id: I4da56c80fa09bfc1e8f868794001e9921431e09f Reviewed-on: https://gerrit.libreoffice.org/19968 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-13tdf#95744: saving shape names re-enabledOliver Specht
commit c29657e0d6bb707345584ac7a7f5ae5016f37297 inverted one of the tests for SvXMLExportFlags::OASIS Change-Id: I523cecd4203c91d82a4e3e82b8457d2c55a5fff0 Reviewed-on: https://gerrit.libreoffice.org/19931 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2015-11-115th step to remove tools/rtti.hxxOliver Specht
tools/rtti.hxx removed completed the interface of some Sdr.* Items and removed pseudo items Change-Id: I0cdcd01494be35b97a27d5985aa908affa96048a Reviewed-on: https://gerrit.libreoffice.org/19837 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2015-11-11new loplugin: memoryvarNoel Grandin
detect when we can convert a new/delete sequence on a local variable to use std::unique_ptr Change-Id: Iecae4e4197eccdfacfce2eed39aa4a69e4a660bc Reviewed-on: https://gerrit.libreoffice.org/19884 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann
Change-Id: I8690de2cb68dcfedc9f2239ce66cea06fd94bc16
2015-11-09new loplugin: oncevarNoel Grandin
Change-Id: If57390510dde4d166be3141b9f658a7453755d3f Reviewed-on: https://gerrit.libreoffice.org/19815 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-06loplugin:stringconstant: elide explicit ctor usage (automatic rewrite)Stephan Bergmann
Change-Id: Ibb9372bc45a0bc0b9083ad0e405440bbbe5ef678
2015-11-05use uno::Reference::set method instead of assignmentNoel Grandin
Change-Id: I60e52ef2abc3107ba77e81811dfe1bffbfd77218