summaryrefslogtreecommitdiff
path: root/xmloff
AgeCommit message (Collapse)Author
2014-07-10fdo#79358: ODF export: fix index boolean property exportMichael Stahl
Due to inverted conditional, only the default values were exported, not the non-default ones... (regression from 8a81f542a6ca566661305c53899b7e422cbaa432) Change-Id: I0b1fc828230695709db49e1643801842d947403c
2014-07-08use SimpleReferenceObject in xmloff moduleNoel Grandin
to replace hand-rolled version Change-Id: I36d4ce14d0c0c8a4b224a240c6e25c8df99b78aa
2014-07-03coverity#704112 Unchecked return valueCaolán McNamara
Change-Id: Ic1147662012426126c1cfcf7cb496a3d03cab794
2014-07-03coverity#736024 help coverity out hereCaolán McNamara
Change-Id: Ia89ed6792bbe84eb20a4b560b0dab4557ad6e8f9
2014-07-03coverity#1223084 Unchecked return valueNorbert Thiebaud
Change-Id: I1573d14412b9e01fe7382796275b83405a3bb994
2014-07-02fix ODF validation errorsMarkus Mohrhard
Introduced by 7d9bb549d498d6beed2c4050c402d09643febdfa Change-Id: I09411486b93a031a0c405579d34d9e744b8002a7
2014-07-02drop UniReference in favour of rtl::ReferenceNoel Grandin
since they're doing the same thing. Change-Id: I76134b6b848db8628f315fe5bd9eb972a6bf0cb6
2014-07-02coverity#705353 Missing break in switch, probably intentionalCaolán McNamara
Change-Id: I17d22443f24de5b4bf5c259e38912abc2c14ab94
2014-07-01-Werror,-Wtautological-constant-out-of-range-compareStephan Bergmann
Looks like 7d9bb549d498d6beed2c4050c402d09643febdfa "Related: #i124638# Second step of DrawingLayer FillAttributes..." accidentally garbled this. Change-Id: I4cdaad4fdebb8b9947e79afbec4a6e0973c55cac
2014-07-01Resolves: #i125045# For XMLPropertyMapper using TEXT_PROP_MAP_SHAPE_PARA...Armin Le Grand
hide the DrawingLayer FillStyle entries by moving them to the front of aXMLParaPropMap and using a higher index for construction (cherry picked from commit 35f3ceaf60f109f45aa7fef7077aead398bed53f) Change-Id: I8244e4dc685a2aa35e4154a43455ff62c8ee58fe
2014-07-01Related: #i124638# Second step of DrawingLayer FillAttributes...Armin Le Grand
for Writer objects, now added support for Paragraph and PageStyle (including Header and Footer) for direct attributes and style attributes (cherry picked from commit cc25c58f7052827bfebdc9fbeec668c8fa29ed1b) Conflicts: cui/source/factory/dlgfact.cxx cui/source/factory/dlgfact.hxx cui/source/inc/bbdlg.hxx cui/source/inc/cuires.hrc cui/source/tabpages/bbdlg.cxx cui/source/tabpages/bbdlg.src cui/source/tabpages/page.cxx cui/source/tabpages/tparea.cxx include/svx/pagectrl.hxx include/svx/svxdlg.hxx include/svx/svxids.hrc include/xmloff/PageMasterStyleMap.hxx include/xmloff/prstylei.hxx include/xmloff/txtprmap.hxx svx/Package_inc.mk svx/inc/svx/hdft.hxx svx/source/dialog/hdft.cxx svx/source/dialog/pagectrl.cxx svx/source/tbxctrls/tbxcolorupdate.cxx svx/source/unodraw/unobrushitemhelper.cxx sw/Library_sw.mk sw/inc/fillattributes.hxx sw/inc/format.hxx sw/inc/frmatr.hxx sw/inc/frmfmt.hxx sw/inc/hintids.hxx sw/inc/hints.hxx sw/inc/ndtxt.hxx sw/inc/node.hxx sw/inc/swunohelper.hxx sw/inc/unobrushitemhelper.hxx sw/inc/unoprnms.hxx sw/source/core/attr/format.cxx sw/source/core/attr/hints.cxx sw/source/core/doc/docdesc.cxx sw/source/core/doc/docdraw.cxx sw/source/core/doc/docfmt.cxx sw/source/core/doc/docnew.cxx sw/source/core/doc/docredln.cxx sw/source/core/doc/poolfmt.cxx sw/source/core/doc/visiturl.cxx sw/source/core/docnode/node.cxx sw/source/core/inc/frame.hxx sw/source/core/inc/frmtool.hxx sw/source/core/inc/rolbck.hxx sw/source/core/layout/atrfrm.cxx sw/source/core/layout/fillattributes.cxx sw/source/core/layout/findfrm.cxx sw/source/core/layout/paintfrm.cxx sw/source/core/txtnode/ndtxt.cxx sw/source/core/txtnode/thints.cxx sw/source/core/txtnode/txtedt.cxx sw/source/core/undo/rolbck.cxx sw/source/core/unocore/swunohelper.cxx sw/source/core/unocore/unoframe.cxx sw/source/core/unocore/unomap.cxx sw/source/core/unocore/unoparagraph.cxx sw/source/core/unocore/unoprnms.cxx sw/source/core/unocore/unostyle.cxx sw/source/ui/chrdlg/paradlg.src sw/source/ui/chrdlg/pardlg.cxx sw/source/ui/fmtui/tmpdlg.cxx sw/source/ui/fmtui/tmpdlg.src sw/source/uibase/app/docst.cxx sw/source/uibase/app/docstyle.cxx sw/source/uibase/frmdlg/colex.cxx sw/source/uibase/shells/basesh.cxx sw/source/uibase/shells/textsh1.cxx sw/source/uibase/uiview/viewstat.cxx sw/source/uibase/utlui/uitool.cxx xmloff/inc/PageMasterImportContext.hxx xmloff/inc/xmloff/XMLShapeStyleContext.hxx xmloff/source/draw/XMLShapeStyleContext.cxx xmloff/source/draw/sdpropls.hxx xmloff/source/style/PageMasterExportPropMapper.cxx xmloff/source/style/PageMasterImportContext.cxx xmloff/source/style/PageMasterPropHdlFactory.cxx xmloff/source/style/PageMasterStyleMap.cxx xmloff/source/style/prstylei.cxx xmloff/source/text/txtexppr.cxx xmloff/source/text/txtprhdl.cxx xmloff/source/text/txtprmap.cxx xmloff/source/text/txtstyli.cxx Conflicts: svx/source/dialog/hdft.cxx sw/source/core/doc/visiturl.cxx sw/source/core/txtnode/thints.cxx sw/source/core/txtnode/txtatr2.cxx sw/source/core/unocore/unostyle.cxx Change-Id: I7e8779db6c0cbd1e242b63eab888f468f2de509a
2014-06-29Typo: beeing->beingJulien Nabet
Change-Id: I34937e400ac8576154d33e1e11b80690222f532c
2014-06-28fdo#80009: xmloff: ignore excessive fo:clip valuesMichael Stahl
These cause problems in drawinglayer, and nobody needs a 5km clip. Change-Id: Ic485250413194adbcd0ccf855f12e89e532d7120
2014-06-27loplugin:unreffun: also warn about redundant redeclarationsStephan Bergmann
Change-Id: I9a812220b58cf6da00d854e65794f7c673ab239d
2014-06-27tweak assert so comment appears in abort messageCaolán McNamara
Change-Id: Ibf78e5cd1620f0b61cae030e3870be4a6f87e71d
2014-06-25fixes for up-casting to Reference<XInterface>Noel Grandin
Fix regressions introduced with 6a043e9c0acff20e1618ca8ec15c21d5d0fd0d37 "Use the new type-checking Reference constructor to reduce code noise" Change-Id: I85662856f21c810a7db497fe3b0e116f075b1687 Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-06-24new compilerplugin returnbyrefNoel Grandin
Find places where we are returning a pointer to something, where we can be returning a reference. e.g. class A { struct X x; public X* getX() { return &x; } } which can be: public X& getX() { return x; } Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7
2014-06-21Create SvtSaveOptions() outside of for loop.Matúš Kukan
Helps to save few cycles. Change-Id: Iea908bd84fa1201f05ec698f8de51ea78d841eb6
2014-06-19fdo#71076, fdo#71767: Preserve number formats when charts are copied.Kohei Yoshida
Change-Id: If5ae8852152012483237e7602e56a0c46ea8748a
2014-06-19Do not dereference null pointerStephan Bergmann
...and XMLTextCharStyleNamesElementExport only requires a non-null rPropSet arg when its bDoSomething arg is true. Reported by CppunitTest_sw_odfexport under -sanitize=undefined. Change-Id: Ia45fa7db250f83d746829c7f411e78bbc50bf721
2014-06-17improve the inlinesimplememberfunctions clang pluginNoel Grandin
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-06-16Revert "Make glTF support an experimental feature"Zolnai Tamás
Actually make it experimental mode was unecessary on master. This reverts commit 653bac184f579524bc25a9f40281763a736ae6fd. Conflicts: sd/qa/unit/import-tests.cxx xmloff/source/draw/ximpshap.cxx Change-Id: Ie8747745a9a89ce4d6500a35d15a98e28bda840a
2014-06-16Fix gltf export: close plugin element before export fallbackZolnai Tamás
Change-Id: I2e1f27e535ee45259f7bdf783ea5224b2ad559ef
2014-06-16glTF import/export: fallback must be the second one inside the frameZolnai Tamás
The previous solution was good because older LO versions import the fallback image without changing their code, but it came out it does not fit to ODF standard so export fallback image as the second object after the glTF model. Change-Id: Ib9b2044b1f36b32d980cb79f6dac8dcf94d6209b
2014-06-16glTF export: Use plural folder namesZolnai Tamás
Change-Id: If17628395ede512c00b666efc5511d9711edfb5a
2014-06-13loplugin:staticcallStephan Bergmann
Change-Id: I7691a6d267ea572e3fdd028c1cfae7b721a76da7
2014-06-12Change glTF mime type: {application -> model}/vnd.gltf+jsonZolnai Tamás
There is no an accepted mime type for glTF models yet, so follow collada's mime type: model/vnd.collada+xml. Change-Id: I1e23a95dbb0caea781dade819f8e08235cb5c1dc
2014-06-12Make glTF support an experimental featureZolnai Tamás
Change-Id: I75e69ba1acafbab8362536f02f4d39a8fc2deed1
2014-06-12Introduce HAVE_FEATURE_GLTF to enable/disable gltf related codeZolnai Tamás
When it is a release build then enable it only on Windows and Linux. Change-Id: I7c462aeb75e6ab60eeaa0fa42ca7853a6369b742
2014-06-12WaE: unused function 'isString'Tor Lillqvist
Change-Id: I991cbf4a0203debaa98887d2db3fec9654dc1c5b
2014-06-12fdo#77506: More reliable way to determine label strings.Kohei Yoshida
Not beautiful, but doable. Change-Id: I6f3b00d620e7d7d19cc05ec4239deeb14d0d5201
2014-06-09loplugin: inlinesimplememberfunctionsNoel Grandin
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
2014-06-08avoid memory leak and invalid documentsMarkus Mohrhard
See e.g. fdo54757-1.xlsx exported to ods. Change-Id: I81fb9a18519c5770b52dfb8131211e440ad9682f
2014-06-06fixincludeguards: fix include guardsThomas Arnhold
Change-Id: Ie6e8d4272b0b1d0d2ce93bcbc2e818a9eac1a56b Reviewed-on: https://gerrit.libreoffice.org/9629 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-06-05fdo#72727: Revert "-Werror=unused-but-set-variable second try"Kohei Yoshida
This reverts commit ccf7b15c0a5776c6431fdcb0c0e2b0f3935ae3dc.
2014-06-05fdo#72727: Revert "fdo#68663 don't blindly force categories when there are none"Kohei Yoshida
This reverts commit b090cbdf82e0827234caf5969124f6631311ef35.
2014-06-05various: remove SAL_THROW macroNoel Grandin
Change-Id: I9464179a736b91f5bc32eb5e5e89b3b4e3da3494
2014-06-04DeInitVCL at end of testsStephan Bergmann
This required some changes to the framework: * Init-/DeInitVCL is no longer done per individual test in BootstrapFixture, but once per CppunitTest invocation in a new vclbootstrapprotector (similarly to the exisiting unobootstrapprotector). CppunitTests that need VCL now need to declare gb_CppunitTest_use_vcl. * For things to work properly, the UNO component context needs to be disposed from within DeInitVCL (cf. Desktop's Application::DeInit called from DeInitVCL). The easiest solution was to introduce an Application::setDeInitHook (where the hook is called from DeInitVCL) specifically for vclbootstrapprotector to call. * PythonTests don't (yet) call DeInitVCL; they still hook into BootstrapFixture's original test_init functionality (to call InitVCL), and do not make use of the vclbootstrapprotector. Change-Id: I4f3a3c75db30b58c1cd49d81c51db14902ed68b2
2014-06-02xmloff: fix import of tables inside textboxes inside shapesMiklos Vajna
We already had the concept of having a XML_TEXT_TYPE_SHAPE type (for editeng-based text) and a XML_TEXT_TYPE_TEXTBOX (for Writer-based text), but in case of draw:custom-shape, the previous was always assumed, implicitly. Check if the shape is marked as having a textbox, and if so, use the XML_TEXT_TYPE_TEXTBOX handler, which makes e.g. the table import work. Change-Id: I45f28b36df1836eeba89e9eef44c7abd87fcbd56
2014-06-02sw textboxes: implement ODF import/exportMiklos Vajna
Map Writer shapes' new TextBox property to an loext:text-box boolean attribute. Change-Id: Ie47e15130adc1c480666c689c55a6c9e8460e385
2014-05-30fdo#76324: Use one static SvXMLTokenMap object, it's faster.Matúš Kukan
For me it saves ~10% of load time for calc document with 2000 comments. Thanks to Michael for noticing this oddity. Change-Id: Id44f44c02df2ae9360d02c28081601f5f7a8ea27
2014-05-29remove more unnecesary OUString constructor useNoel Grandin
when throwing exceptions Change-Id: I6edfb6b6745499f802b0e3c0e096a36fb7c32aac
2014-05-27Remove unnecessary semicolonsPeter Senna Tschudin
A simplified version of the semantic match that finds this problem is follows: (http://coccinelle.lip6.fr/) // <smpl> @r1@ statement S; position p,p1; @@ S@p1;@p @script:python r2@ p << r1.p; p1 << r1.p1; @@ if p[0].line != p1[0].line_end: cocci.include_match(False) @@ position r1.p; @@ -;@p // </smpl> Change-Id: Ib9708d37fbb4c6060f88d5dae3814a2d37b2091e Reviewed-on: https://gerrit.libreoffice.org/9493 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-05-23Resolves: #i114361# provide and accept changed URL...Oliver-Rainer Wittmann
of embedded graphic file during save (ODF export) (cherry picked from commit a90c007908eb3f66e28a9ea525729065db652b6f) Conflicts: sw/inc/ndgrf.hxx sw/source/core/graphic/ndgrf.cxx sw/source/core/unocore/unoframe.cxx sw/source/filter/xml/xmltexte.cxx xmloff/source/draw/shapeexport2.cxx Change-Id: I9d4a02af2561467fe1a66f036b55d6dcf2429986
2014-05-23coverity#1213120 Unchecked dynamic_castCaolán McNamara
Change-Id: I170e392fa883936f835f60ec4798548701f2a3d8
2014-05-23remove boilerplate in UNO Exception constructor callsNoel Grandin
Now that we have default values for Exception constructor params, remove lots of boilerplate code. Change-Id: I620bd641eecfed38e6123873b3b94aaf47922e74
2014-05-22update_pch: add xmloffThomas Arnhold
Change-Id: I66c53040509668cf33da7f486b1c328bbea08b0a
2014-05-21fdo#78921 Don't crash when there is no storage specifiedMaxim Monastirsky
Not sure it's a good idea to get here at all when exporting as flat xml, but anyway it shouldn't crash. Change-Id: Ib2ce6b044b4395222a394312d49f5a01d157f9f3
2014-05-20Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part18Julien Nabet
Change-Id: Ibf958dbfbf7cdbe6ad31d390138be8d4d468c225
2014-05-19fix import issue with property mappingMarkus Mohrhard
Change-Id: Iab06c8676569121f6def631fed07eaa57ffb07a2