summaryrefslogtreecommitdiff
path: root/xmloff
AgeCommit message (Collapse)Author
4 daystdf#126154 sw offapi xmloff cui: add min/max word spacingLászló Németh
To avoid of rivers and too much hyphenation, add minimum and maximum word spacing options, similar to XSL-FO/CSS and DTP software. Only limiting hyphenation was implemented: hyphenation of the words are disabled, if it's possible to expand or shrink the spaces of the line within the values specified by the maximum and minimum word spacing. First try to apply the minimum word spacing, and if not possible, then the maximum word spacing. Note: maximum allowed shrinking has been applied for the hyphenated lines instead of the minimum to remove the hyphenation, yet. With the suggested default word spacing values, this results no or minimal differences. New UNO paragraph properties: com::sun::star::text::ParaWordSpacingMinimum com::sun::star::text::ParaWordSpacingMaximum New ODF paragraph attributes: loext:word-spacing-minimum loext:word-spacing-maximum New paragraph settings on Text Align pane: Minimum word spacing Maximum word spacing While the desired word spacing got "Desired" label. Note: suggested values of minimum, desired and maximum word spacing are 80%, 100% and 133% (default values e.g. in Adobe InDesign), in narrow columns e.g. 60%, 100% and 150%. Follow-up to commit 7d6696757dcdfa3cee481ac7795a91b2b47da363 "tdf#159923 sw cui offapi xmloff: add custom word spacing". Change-Id: I7f2a07f7fdb634cb16cdd8c2c937ca911b968405 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184595 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: Jenkins
13 daystdf#159923 sw cui offapi xmloff: add custom word spacingLászló Németh
Add com::sun::star::text::ParaWordSpacing UNO and loext:word-spacing ODF extensions to set desired word spacing of a justified paragraph relative to the width of the space character, like DTP software do. Add Justification section and "Word spacing" spin box to the Text Align pane of paragraph settings. This extends not only the smart justify interoperability feature for custom shrinking (until 0%), but for custom expansion, too, until 1000%, like Adobe InDesign do. Note: this value hasn't been applied in the last paragraph line, yet. See also XSL-FO/CSS word-spacing and commit 7d08767b890e723cd502b1c61d250924f695eb98 "tdf#130088 tdf#119908 smart justify: fix DOCX line count + compat opt." Change-Id: I06f771335135e4682a1d1abfc9a247dbe4bc6b66 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184187 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: Jenkins
14 daysloplugin:unusedfieldsNoel Grandin
Change-Id: I2bbf1c093c5aed75939e9cc51935c8febd9aff04 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184160 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2025-04-09fix warning C6011: Dereferencing NULL pointer 'pImpPrMap' (take 2)Xisco Fauli
after commit 8009183a7a4cd1f5b2b6e78e480ade3f10d0eff2 Author: Noel Grandin <noelgrandin@gmail.com> Date: Sat Apr 5 22:03:18 2025 +0200 tdf#151876 shave some time off chart load (2) Change-Id: I687d939813e50f78eec92e15ea8aa9606316ea1e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183870 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2025-04-08fix warning C6011: Dereferencing NULL pointer 'pImpPrMap'Noel Grandin
from the MSVC analyser, after commit 8009183a7a4cd1f5b2b6e78e480ade3f10d0eff2 Author: Noel Grandin <noelgrandin@gmail.com> Date: Sat Apr 5 22:03:18 2025 +0200 tdf#151876 shave some time off chart load (2) exposed this issue Change-Id: Ie64f8f4cc8cefa4c47167274c3f54b29e69725a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183835 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2025-04-06crashtesting: unable to reimport odp export of fdo72444-1.pptxCaolán McNamara
There is a smil:values / smil:keyTimes count mismatch where the original pppx has: <p:tavLst><p:tav tm="0"><p:val></p:val></p:tav> so p:val is present but empty which results in an empty Any so the matching smil:values at export of the odp is empty while a smil:keyValues is exported, resulting in AnimationNodeContext::init_node throwing css::io::WrongFormatException from the mismatch of xAnimate->getValues().getLength() != xAnimate->getKeyTimes().getLength() exporting to pptx and then converting that to odp just drops the smil:values + smil:keyTimes, so solve this by only exporting smil:keyTimes if there was a successful export of smil:values. Change-Id: I5577a6671bfcebecf995afeea90e2d701f33eab1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183761 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2025-04-06tdf#151876 shave some time off chart load (2)Noel Grandin
manage SvXMLImportPropertyMapper with unique_ptr instead of rtl::Reference, which avoids a bunch of ref-counting traffic Change-Id: I1e0e95408cdd5dc4271fa72178e57087737eb062 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183751 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2025-04-02tdf#165984 xmloff: don't export default end zone value "no-limit"László Németh
They inherit the value of the hyphenation-zone or their ancestor (paragraph -> column -> page -> spread), so no need to export the default value "no-limit". Follow-up to commit 7d384fb1c232f7aa720436bc68dc1de334bf7297 "tdf#165984 sw cui xmloff: add Paragraph/Column/Page/Spread end zone". Change-Id: I50a3bb9801402b000fe9861e592958a946953056 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183602 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2025-04-01tdf#165984 sw cui xmloff: add Paragraph/Column/Page/Spread end zoneLászló Németh
Add new hyphenation options to adjust hyphenation, like DTP software do in accordance with typographic requirements: – Paragraph/Column/Page/Spread end zone spin boxes to Hyphenate Across section of Text Flow pane of paragraph settings; – loext:hyphenation-zone-always, loext:hyphenation-zone-column, loext:hyphenation-zone-page and loext:hyphenation-zone-spread ODF extensions; – widorp.cxx, guess.cxx: handle Column/Page/Spread end zones; – guess.cxx: handle Paragraph end zone (without portions, yet). According to their typography, languages with long words need better adjustment of line break of the last full paragraph/column/page/spread lines, than simply disabling hyphenation by the recent ODF hyphenation- keep or its equivalent MS Word OOXML extension. DTP software use paragraph and column/page/spread end zones to adjust the hyphenation zones in the last lines, for example, setting Column end zone to the 150% percent of the Hyphenation zone, resulting less hyphenation, also less short words parts at the end of the columns, pages and spreads, increasing readability. Note: the default OOXML hyphenation zone 18 pt (or its MS Word variants, for example 21.25 pt) disables single letter or narrow 2-letter (li-, fi-, i.e. fi ligature) hyphenations at 12 pt font height. Setting 27 pt for Column end zone, all 2-letter hyphenation is disabled in last lines of columns and pages. Note: textflow.ui needs multiple adjustment definitions for correct work of the multiple spin boxes. Change-Id: I37bbb4da30de0ec75eb8636f70d8e16588c56ed1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183565 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2025-03-28cool#11320 xmloff: warn, but not fail when can't export a numbering styleMiklos Vajna
It's not clear how to reproduce this problem, but when it happens, an ODT file can't be saved because of an unhandled exception while producing styles.xml. Digging deeper, a container::NoSuchElementException is thrown in XStyleFamily::getByName(), and when that happens the backtrace is: #0 (anonymous namespace)::XStyleFamily::getByName (this=0x28fb8740, rName=...) at sw/source/core/unocore/unostyle.cxx:1031 #1 0x000075ae461d5d8c in (anonymous namespace)::XStyleFamily::getByIndex (this=0x28fb8740, nIndex=0) at sw/source/core/unocore/unostyle.cxx:1027 #2 0x000075ae541c4d77 in XMLTextListAutoStylePool::XMLTextListAutoStylePool (this=0x75ae243c1318, rExp=...) at include/com/sun/star/uno/Reference.h:384 I.e. the XMLTextListAutoStylePool gets the NumberingStyles style family, nStyles is 15, we try to get each numbering style by index, but already the first fails, because 0 gets turned into a 'Keine Liste' (no list) name, but getting that internally by name then fails. Fix the direct problem by catching container::NoSuchElementException in the XMLTextListAutoStylePool_Impl ctor, not expoting a list style is better than not being able to save the document at all. Almost certainly this is an effect of a problem earlier, but this should improve things till reproducer steps are found for that problem. Change-Id: Ia9fbe8db9dfe5f90f2583111c3d59b98a914798d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183445 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2025-03-27tdf#165918: Avoid bookmarks correction when removing temporary nodesMike Kaganski
When loading a table, each cell contains an extra node, which is dropped when finalizing the cell. The removal of the node calls SwDoc::CorrAbs, which it turn calls MarkManager::correctMarksAbsolute. The latter looks through all existing bookmarks, checking if they need to be corrected. In documents with lots of tables and lots of bookmarks, the time taken by eack following call to SwDoc::CorrAbs grows quadratically. We know, that these extra nodes in cells do not affect bookmarks, and it is safe to just skip these specific nodes from bookmark correction. This speeds up loading bugdoc by 40% in my testing. Change-Id: I61b587d04c9ae2301d9fef497885fb76c2d3ae74 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183348 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2025-03-25loplugin:constparam in xmloffNoel Grandin
Change-Id: I24c536279c5b02b32d564893793fa15672c6f73c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183288 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2025-03-22tdf#141415 reduce time spent loading language dataNoel Grandin
cache LocaleDataWrapper because otherwise we spend quite a bit of time doing function-pointer-symbol lookups. Change-Id: Ic1bd07dabac95a2e1bdad70cffbc2b4cabdc62ed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183221 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2025-03-13tdf#165315 Store field:fieldmark in a text::spanOliver Specht
Store automatic style around fieldmark to keep character attributes Change-Id: I902c90d9bfbbc964c3f0567042ea7f7bc993471f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182582 Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2025-03-12cool#11320 xmloff lok: improve error reportingMiklos Vajna
When processing a report on failed ODF save, it can be tricky to find reproduction steps. A typical source of errors is some uncaught exception. Currently we just report which stream failed to save: 0x70c23(Error Area:Sw Class:Write Code:35) arg1=SfxBaseModel::storeSelf: 0x70c23(Error Area:Sw Class:Write Code:35) arg1=styles.xml at sfx2/source/doc/sfxbasemodel.cxx:1735 Improve this to also report what would appear on stderr in a dbgutil build: com.sun.star.lang.IllegalArgumentException: "SwXMLExport::exportTheme() failed at sw/source/filter/xml/xmlfmte.cxx:189" In case e.g. the theme export throws an exception for testing purposes. Change-Id: I85ec1ac4f932851401aa3b25a753219eb20638a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182831 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2025-03-11tdf#163691 Use std::copy() instead of memcpy()Kukee Thoo
Change-Id: I55df00e2625cf42a7e2662850e8cc272ceb70152 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182787 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2025-03-09Fix typoAndrea Gelmini
Change-Id: I54017fe34bd4f71006ca83dca33c23473f852dea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182692 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2025-03-08tdf#71583 Add page count of ranges with consecutive page numberingOliver Specht
Adds a field that counts the pages in ranges defined by page number restarts Change-Id: Ie0727ab20c81464918ad5fb9aa42046bf00aa63c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178141 Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Tested-by: Jenkins
2025-03-03tdf#165354 sw xmloff: implement HyphenationKeepLine – part 2László Németh
Add loext:hyphenation-keep-line to the ODF export/import to support HyphenationKeepLine, i.e. MS DOCX compatibility option useWord2013TrackBottomHyphenation=false, where not the full hyphenated line, but only the hyphenated word is shifted to the next text block. Add unit tests for hyphenation-keep-type="page" and "spread" with hyphenation-keep-line="true" support. Follow-up to commit 3e02ffb76c484a05cdc140d8a10bc3d993fe8320 "tdf#i165354 sw offapi DOCX: implement HyphenationKeepLine – part 1". Fix unit test testTdf132599_spread, which loaded tdf132599_page.fodt instead of tdf132599_spread.fodt (duplicating testTdf132599_page). Restore unit test testTdf160518_auto_in_text_body_style, which was removed by accident in commit 3e02ffb76c484a05cdc140d8a10bc3d993fe8320. Silence the linguistic warning of HyphKeepLine, according to the commit d25de4a04671c2f380fc86a58259b073c49dfe19 "silence unknown property 'HyphNoLastWord'... etc warnings". Change-Id: Ibb9643f8e20ee2a1456c4d62b901e4c66b57c341 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182424 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: Jenkins
2025-02-28loplugin:constantparamNoel Grandin
Change-Id: I8184c75ea6f35538eb68faa9eaf18b6d053f843c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182309 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2025-02-26use more concrete UNO types in some local varsNoel Grandin
found by a little plugin I created. Plugin parked into store/ folder because it needs hand-holding when run. Change-Id: I2b4da7378f0becbc5f020ac9e78cd765aa0119b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181768 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2025-02-25loplugin:constantparamNoel Grandin
Change-Id: Iba5ce1d44e52610e985e97d299571cf3387d938a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182180 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2025-02-17Simplify some uses of basegfx::utils::create*B2DHomMatrixMike Kaganski
The additional zero checks are unneeded (the creation functions do that internally). And in one case, a simpler function exists. Change-Id: I481b3d22b8081cbfad545c343b04f7f3330b0eba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181769 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2025-02-12tdf#165181 Don't overwrite guessed media MIME type with default on loadAron Budea
MIME types for media can be the default one, 'application/vnd.sun.star.media'. In ODFs coming from old versions, for media unsupported at the time, this default MIME type was used, and is read when opening them in new versions. MIME type is also guessed more accurately from the URI (file name and extension), but was overwritten by the saved MIME type. When using the UI, it is again overwritten by the guessed MIME type, but not when using '--convert-to'. This can cause a problem when saving ODPs to PPTX, PP will consider these files corrupted. Started happening after bc72514f90d90e1ab3fed8167663e835edf03508. Change-Id: Icd95b06d54154f3b533840f8a5f381400f2e6108 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181399 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2025-02-07tdf#120397 - odf export fix missing texts in text box controlBalazs Varga
(Ab)use a call to XTextRange::getText to flush edits and restore the selection of the textcontent in the textfields. TODO: unit/UItest Change-Id: If8e1c85f3565ae1b80fd0645c0905aae16404379 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181245 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2025-02-04[API CHANGE] sd pdfium: add page number when saving/loading pdf pages as imagesJaume Pujantell
When a pdf file is opened with pdfium and then saved as odg, each page is saved as a draw:image of the pdf. But since no page number info was given, when opening the odg file, all the pages are shown as the first one. This adds a loext:page-number to the saved odg and the logic to load a specific page from an embedded pdf. Added loadGraphicAtPage to XGraphicStorageHandler. Change-Id: I398b7ad7f03cc7fb930a4e7b7620c6f238b41c0d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181066 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2025-01-30tdf#151278 tdf#164724 tdf#164728 tdf#164729 switch off charts number format ↵Oliver Specht
from source Labels get their number format usually from source. When copy/pasted the chart has no connection to a source format anymore. The related LinkNumberFormatToSource flag is therefore reset. The label (data series) number format used is now also saved. Change-Id: I640083ec0036f116dec94cc982317e1e7992328b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180600 Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Tested-by: Jenkins
2025-01-23tdf#121119 master docs at-page anchor: fix duplicated imagesLászló Németh
Skip saving images anchored at page in the master document, if they are imported from subdocuments to avoid their duplication during the round-trip/update of the linked subdocuments. Follow-up to commit 2f135fa82c5d78ddafc14f38c0ee33358075b266 "tdf#121119 master docs at-page anchor: fix missing images". Change-Id: I731026bee01576fe66c9d677b53c7f85a53230fa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180627 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2025-01-20remove code duplication - conversion hex char to valueTomaž Vajngerl
We use the same funciton all over the place, so create a common function in o3tl and use that in all instances where we duplicated the code. Change-Id: I74091fbbde8c2ba8c7e4ab30194ab53e2a338e52 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180372 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2025-01-13Slightly more informative loggingAron Budea
Change-Id: Ia474a208d5a562e424df76ff389cfcc4e3f2b1fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179817 Tested-by: Jenkins Reviewed-by: Aron Budea <aron.budea@collabora.com>
2024-12-22tdf#152299 - Remove unused define(s) from C/C++ filesBogdan Buzea
Change-Id: I32c8a4c8dd56ef781f40db1d3ca66823dd9b995f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177185 Tested-by: Jenkins Reviewed-by: David Gilbert <freedesktop@treblig.org>
2024-12-14Simplify OOo2OasisTransformerMike Kaganski
Change-Id: I212c3196060e4038cb265d10c841ebbbeb736ec4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178478 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-12-11crashtesting: fix assert while parsing tdf94588-1.odtJonathan Clark
Some ODF parsing code uses relative indices into XMLPropertyMapEntry arrays to enumerate related attributes. This change moves some recently-added paragraph property entries to the end of the respective array, fixing an assertion caused by accessing unexpected attributes via these hard-coded relative indices. Problem since: commit 7e4f4a0ccd3c56093dec44c7dcdd14c8b34623c3 tdf#163913 Implement font-relative margins Change-Id: Ia2671372f0152e4efb98bd25b390638e4458a1b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178318 Tested-by: Jenkins Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
2024-12-03don't bother passing const std::[u16]string_view by referenceCaolán McNamara
Change-Id: I49477c20849dd99118d5935c0f1576429648bfca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177734 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-11-30cid#1607542 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1606986 COPY_INSTEAD_OF_MOVE cid#1557969 COPY_INSTEAD_OF_MOVE cid#1557837 COPY_INSTEAD_OF_MOVE cid#1557772 COPY_INSTEAD_OF_MOVE cid#1557735 COPY_INSTEAD_OF_MOVE cid#1557672 COPY_INSTEAD_OF_MOVE cid#1557664 COPY_INSTEAD_OF_MOVE cid#1557650 COPY_INSTEAD_OF_MOVE cid#1557642 COPY_INSTEAD_OF_MOVE cid#1557639 COPY_INSTEAD_OF_MOVE cid#1557628 COPY_INSTEAD_OF_MOVE cid#1557623 COPY_INSTEAD_OF_MOVE cid#1557581 COPY_INSTEAD_OF_MOVE cid#1557489 COPY_INSTEAD_OF_MOVE cid#1557473 COPY_INSTEAD_OF_MOVE cid#1557317 COPY_INSTEAD_OF_MOVE cid#1557261 COPY_INSTEAD_OF_MOVE cid#1557146 COPY_INSTEAD_OF_MOVE cid#1557135 COPY_INSTEAD_OF_MOVE cid#1557134 COPY_INSTEAD_OF_MOVE cid#1557079 COPY_INSTEAD_OF_MOVE cid#1557063 COPY_INSTEAD_OF_MOVE cid#1557052 COPY_INSTEAD_OF_MOVE cid#1556982 COPY_INSTEAD_OF_MOVE cid#1556977 COPY_INSTEAD_OF_MOVE cid#1556950 COPY_INSTEAD_OF_MOVE cid#1556943 COPY_INSTEAD_OF_MOVE cid#1556804 COPY_INSTEAD_OF_MOVE cid#1556736 COPY_INSTEAD_OF_MOVE cid#1556658 COPY_INSTEAD_OF_MOVE cid#1556621 COPY_INSTEAD_OF_MOVE cid#1556590 COPY_INSTEAD_OF_MOVE cid#1556579 COPY_INSTEAD_OF_MOVE cid#1556534 COPY_INSTEAD_OF_MOVE cid#1556524 COPY_INSTEAD_OF_MOVE cid#1556478 COPY_INSTEAD_OF_MOVE cid#1556467 COPY_INSTEAD_OF_MOVE cid#1556422 COPY_INSTEAD_OF_MOVE cid#1556314 COPY_INSTEAD_OF_MOVE cid#1556309 COPY_INSTEAD_OF_MOVE cid#1556258 COPY_INSTEAD_OF_MOVE cid#1556143 COPY_INSTEAD_OF_MOVE cid#1556119 COPY_INSTEAD_OF_MOVE cid#1556101 COPY_INSTEAD_OF_MOVE cid#1556097 COPY_INSTEAD_OF_MOVE cid#1556039 COPY_INSTEAD_OF_MOVE cid#1555966 COPY_INSTEAD_OF_MOVE cid#1555948 COPY_INSTEAD_OF_MOVE cid#1555915 COPY_INSTEAD_OF_MOVE cid#1555836 COPY_INSTEAD_OF_MOVE cid#1555748 COPY_INSTEAD_OF_MOVE cid#1555644 COPY_INSTEAD_OF_MOVE cid#1555582 COPY_INSTEAD_OF_MOVE cid#1555478 COPY_INSTEAD_OF_MOVE cid#1555475 COPY_INSTEAD_OF_MOVE cid#1555409 COPY_INSTEAD_OF_MOVE cid#1555372 COPY_INSTEAD_OF_MOVE cid#1555334 COPY_INSTEAD_OF_MOVE cid#1555330 COPY_INSTEAD_OF_MOVE cid#1555310 COPY_INSTEAD_OF_MOVE cid#1555257 COPY_INSTEAD_OF_MOVE cid#1555247 COPY_INSTEAD_OF_MOVE cid#1555147 COPY_INSTEAD_OF_MOVE cid#1555120 COPY_INSTEAD_OF_MOVE cid#1555059 COPY_INSTEAD_OF_MOVE cid#1555016 COPY_INSTEAD_OF_MOVE cid#1554880 COPY_INSTEAD_OF_MOVE cid#1554824 COPY_INSTEAD_OF_MOVE cid#1554808 COPY_INSTEAD_OF_MOVE cid#1546189 COPY_INSTEAD_OF_MOVE Change-Id: I2d2f33c603f1596228c9ecb169472ba6751e7826 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177593 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-11-30tdf#164101: avoid incorrect OLE object scaling during loadingMike Kaganski
Use an internal property for that, alowing to pass the option from the import site to SdrOle2Obj::AddOwnLightClient. Maybe there is some more proper way to do this, but I couldn't find it. Change-Id: I74c881c5c35689a7b58d44d8d65c1010d202c98d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177586 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-11-29tdf#164046 style searching improvement breaks Impress layoutNoel Grandin
regression from commit 6c2f827697b898c9d351b79c2dbb5aefc8b70dcc Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Sun Oct 20 15:07:41 2024 +0200 improve style searching in SvXMLStylesContext Two problems - the original code was searching by DisplayName, not Name, so add another index for DisplayName, and the prefix matching was not properly matching. Change-Id: Ifd43bdb89d33067954298115c8700b87c7f93050 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177488 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-11-29tdf#158237 Use C++20 contains() instead of find() and end()Simon Chenery
Change-Id: I596245603c0945438a940465122cb4c3e6954e81 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177140 Tested-by: Jenkins Reviewed-by: David Gilbert <freedesktop@treblig.org>
2024-11-28tdf#163913 Implement font-relative marginsJonathan Clark
This change adds loext:margin-left and loext:margin-right, which implement margins that support font-relative units. See tdf#36709 for additional details. Change-Id: I31b0dd2b6f98cb5b02fd4dca3608db6fdee4054c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177473 Tested-by: Jenkins Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
2024-11-27tdf#131862 No table:cell-range-address in ODF 1.4Regina Henschel
ODF 1.4 has removed the attribute table:cell-range-address from the chart:plot-area element. So we may write it only in versions < 1.4. The attribute was used to distinguish whether a chart has internal data. The same information is given by the href attribute of the chart:chart element. The actual used cell-range-address values are already given in the chart:axis and chart:series child elements and evaluated from there. A global setting is not needed. The attributes chart:data-source-has-labels, chart:column-mapping and chart:row-mapping are related to the table:cell-range-address attribute. These three attributes are deprecated already in ODF 1.2. Thus we will not write them in ODF 1.4. Their information is given in the chart:axis and chart:series child elements. The order of series is given by the order of the chart:series child elements. Change-Id: I08886723b1c8eb27489a7f44b5f8321572defdff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177323 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de> Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2024-11-26Fix typoAndrea Gelmini
Change-Id: Ifdd5f7cce7006b824397525f3a698df3f30ee17e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177327 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-11-26tdf#161800 - I/O of '# of values in second plot' parameter not supportedKurt Nordback
Add support for input and output of 'split position' parameter (number of entries in second plot) for of-pie charts. In OOXML this uses the supported split-pos tag. For ODF I added an extension in loext namespace for this parameter. This commit also includes simple tests for the I/O functionality in OOXML and ODF. Change-Id: I00ff59db721867fa836eb99b6677350040d005dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170666 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-11-22Related: tdf#160517 - chart odf: import/export formatted chart titlesBalazs Varga
No need to check chart title paragraph style name and ID, since its never exists. follow-up of: d7214aba95bbdcbd40e87ef50fc66f2e2ec4f5ff 6fdad723729a458eaff7ca509cb202ad355832be Change-Id: Ieffe3026adc848cfbf3a847b4f876b5aa2e2a026 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177011 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de> Tested-by: Jenkins
2024-11-22PVS: V547 Expression '!aPropertyStates.empty()' is always true.Xisco Fauli
Identified by M. Kaganski Change-Id: I02c3ab0ec29367ebc2e73586044d729eab24231d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177029 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-11-22PVS: V547 Expression '!aPropertyStates.empty()' is always true.Xisco Fauli
Change-Id: Id71d10060c79d36095bbd952b89aa6af68a29a6c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176999 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-11-21tdf#163974: ignore nested footnotes on ODF importMike Kaganski
That is a valid, but unsupported, markup, that is explicitly mentioned in ODF 1.4 part 3 "Schema" sect. 6.3.4 "<text:note-body>": Note: The schema allows for the inclusion of <text:note> elements as a descendant of a child of the <text:note-body> element. While this may be reasonable for note types, it is not reasonable for footnotes and endnotes. Conforming consumers need not support notes inside notes. (The "reasonable for note types" is obviously an editorial error from the time when ODF 1.1 text "reasonable for some future note types" was reviewed for ODF 1.2.) As the ODF also specifies, that a conforming consumer "need not interpret the semantics of all elements, attributes and attribute values" (ibid., sect. 2.4 "Consumer"), it is OK to silently drop this data, just as done for other similar cases. Change-Id: I0a417981087ebf225565628f14409661058d100d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176906 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-11-14tdf#160404 tdf#160535 tdf#160536 - sc improve sheet protectionBalazs Varga
tdf#160404: Fix FILEOPEN XLSX Pivot table is not imported if sheet protection has Pivot table editing enabled - Import correctly the pivot tables, even if the tab protection is not allowing to use them. tdf#160535: Support sheet protection option: Use AutoFilter - Add new option for tab protection to enable/disable to use autofilter on the sheet. Import/export correctly to odf/ooxml. Add new ext-odf attribute: XML_USE_AUTOFILTER tdf#160536: Support sheet protection option: Use PivotTable&PivotChart - Add new option for tab protection to enable/disable to use Pivot table on the sheet. Import/export correctly to odf/ooxml. Add new ext-odf attribute: XML_USE_PIVOT Change-Id: I5d34e3608aed1a3d004ec553f6125b6428e9c05e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176274 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2024-11-13tdf#36709 sw: Writer layout for font-relative first-line indentJonathan Clark
This change implements layout for font-relative paragraph first-line indentation in Writer. Change-Id: Ie8f386bcc13a43ab92d5c15654c24bfdfc62bd69 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176216 Tested-by: Jenkins Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
2024-11-13loplugin:reftotemp in xmloffNoel Grandin
Change-Id: I121307865a576b8d0bced6098fae37051bd531b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176503 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-12tdf#162691: ODF 1.4 Add support for xy and polar handle new attributesXisco Fauli
Co-author: Regina Henschel This implements the new draw:handle attributes of ODF 1.4. For reasons for new attributes see https://issues.oasis-open.org/browse/OFFICE-4110 The old attributes are deprecated but may still be written. So we keep them to be backward compatible. Change-Id: I0b3443d000b2b163363f9070e5e276af2b018cbb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174966 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
generated by cgit (git 2.34.1) at 2025-04-28 23:29:59 +0000