summaryrefslogtreecommitdiff
path: root/xmlsecurity
AgeCommit message (Collapse)Author
2017-07-12strip some linefeeds from the end of debug outputNoel Grandin
Change-Id: I2821969d86b7f8cee53404e6a0acfbebbe53b3ac Reviewed-on: https://gerrit.libreoffice.org/39824 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-10tdf#109046 Show correct signature type for OpenPGPSamuel Mehrbrodt
gpg4libre Change-Id: I9c05f68e16928d14a29058f5bb9aa35c90b8f48b Reviewed-on: https://gerrit.libreoffice.org/39744 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-07-10Related tdf#108977 Fix crash when vieweing non-existing certificateSamuel Mehrbrodt
gpg4libre Change-Id: If72c2ee818b67b48753ee293de4f02b4832b9d96 Reviewed-on: https://gerrit.libreoffice.org/39743 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-07-10tdf#108977 Show signature info also for keys we don't have locallySamuel Mehrbrodt
gpg4libre Change-Id: I89593224590007e61bce95c14922c08551282067 Reviewed-on: https://gerrit.libreoffice.org/39742 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-07-06use OString::operator== in preference to ::equalsNoel Grandin
Change-Id: Ib291521963a791a9c6175964571e9d9895072acf Reviewed-on: https://gerrit.libreoffice.org/39646 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-06loplugin unnecessaryparan improvementsNoel Grandin
Change-Id: I73e945d6ec53537a0da45f6b6291018c7f251a7e Reviewed-on: https://gerrit.libreoffice.org/39587 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-03loplugin:oncevar (clang-cl): xmlsecurityStephan Bergmann
Change-Id: Ic5e4dac2626474dd3d44ef5097522bc7e2207cd1
2017-07-02xmlsecurity: avoid crash on empty security contextThorsten Behrens
This should prevent 8cf224c2-f9b9-44e1-9cb0-fc452e570886 Change-Id: I1ad4d8437923eb677d574c2c469cc62378c9c7a6 Reviewed-on: https://gerrit.libreoffice.org/39430 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-06-30loplugin:staticmethodsStephan Bergmann
Change-Id: I68d02b89a2c55e41ad0d86392ed3994fa5410fac
2017-06-29loplugin:oncevar variousNoel Grandin
Change-Id: I8b82d46d4688b1a59d6fe1b05da7d5c8dfc13ca6 Reviewed-on: https://gerrit.libreoffice.org/38766 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-28Fix typosAndrea Gelmini
Change-Id: I59777c29fe20f112327ce28a1c0b9cdd2f60857c Reviewed-on: https://gerrit.libreoffice.org/39354 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-06-28gpg4libre: Don't call production code inside an assert()Samuel Mehrbrodt
Won't work in non-debug builds Change-Id: I64f9c416890ddd02ec8efc0f59ded145cc17896a Reviewed-on: https://gerrit.libreoffice.org/39345 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-06-28tdf#108794 gpg4libre: Use key id to get the right keySamuel Mehrbrodt
Change-Id: I5950d192e19e652cbb7680db426bfbd28907a1cb Reviewed-on: https://gerrit.libreoffice.org/39308 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-06-28tdf#108798 Make CanSignWithGPG work with PDF docsSamuel Mehrbrodt
Change-Id: I09aa030bed3d6ce51ef71d8bab905b01fab5b699 Reviewed-on: https://gerrit.libreoffice.org/39309 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-06-27gpg4libre: Show message when no cert manager foundSamuel Mehrbrodt
Change-Id: I0da5f20b049ab2d8c992cb2a04dcf544f0b35aa1 Reviewed-on: https://gerrit.libreoffice.org/39289 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-06-27gpg4libre: Add seahorse to list of certificate managersSamuel Mehrbrodt
which is the Gnome default app for ḱey management Change-Id: I4c27074f83538640fb1729c5cfddd96981d35f40 Reviewed-on: https://gerrit.libreoffice.org/39288 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-06-27tdf#108711 GPG key selection should only be possible for ODF >= 1.2 documentsSamuel Mehrbrodt
gpg4libre Change-Id: I6dbdaefddacf55c9381d156ada20cb3f25d4b3cb Reviewed-on: https://gerrit.libreoffice.org/39263 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-06-27gpg4libre: Show error message when signing failsSamuel Mehrbrodt
Change-Id: I58f3febaaaaa225952e87ad3f092950ace37d15d Reviewed-on: https://gerrit.libreoffice.org/39283 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-06-26Remove nonsense TODOSamuel Mehrbrodt
Change-Id: I97fd74c664e125f6c04f585e20c84ce702927e50 Reviewed-on: https://gerrit.libreoffice.org/39277 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-06-26Cleanup commentSamuel Mehrbrodt
Change-Id: I218675bcb832c158171f87bb7c52a658ceaa7a67 Reviewed-on: https://gerrit.libreoffice.org/39278 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-06-25gpg4libre: import public key payload if initial validation failsThorsten Behrens
Since maybe we don't know the key yet? Change-Id: I8b7e3f472d4731d9fb8bb675d81bdad257aa9230 Reviewed-on: https://gerrit.libreoffice.org/39194 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-06-25gpg4libre: save some space, extract binary key/sign dataThorsten Behrens
Since callers will base64-encode this anyway, again Change-Id: I0962d102fa0f2b95eaa2e608539cc291125f0321 Reviewed-on: https://gerrit.libreoffice.org/39193 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-06-25gpg4libre: base64-encode and decode SignatureValueThorsten Behrens
which xmldsig-core actually requires Change-Id: I92a6e192865919d844009be042dad36106a19fc8 Reviewed-on: https://gerrit.libreoffice.org/39192 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-06-24gpp4libre: error handling, proper key extractionThorsten Behrens
Change-Id: I1cb219f825393309219a4ebfb406482050b91228 Reviewed-on: https://gerrit.libreoffice.org/39191 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-06-23XMLSignature_GpgImpl: Use cppu::supportsServiceSamuel Mehrbrodt
Change-Id: Ic093462c957aa445aab43f95ac22af3a3df1d709
2017-06-23XMLSignature_GpgImpl: Clean up namespacesSamuel Mehrbrodt
Change-Id: I34aa59171b5d440bdd6bdec80badf7a3eb42bd3f
2017-06-23Gpg key listing: Use range based for loopSamuel Mehrbrodt
Change-Id: Idc7b39f751b2572f5ddd077aaad86a1f7b4b9a5d
2017-06-23tdf#108692 gpg4libre: List all gpg keysSamuel Mehrbrodt
Change-Id: I7300da36215233fa91b7a04a42b1c9bf907ad78b
2017-06-23gpg4libre: Handle error when retrieving public keySamuel Mehrbrodt
Change-Id: I9543e47fb3302a5ca146a606305b24733f015a5d
2017-06-23gpg4libre: Warn before removing document signaturesKatarina Behrens
simple version, no "do not show this message again" checkbox Change-Id: Iba8ac8cda51acac748174c864aa5c205f2efcc8f Reviewed-on: https://gerrit.libreoffice.org/38962 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-06-23gpg4libre: Show certificate kind OpenPGP vs. X509 as 1 table columnKatarina Behrens
Shuffled the columns around a little bit Change-Id: Ib0a979458db680d712737ff997e1c3b4e4564f3f Reviewed-on: https://gerrit.libreoffice.org/38984 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-06-22xmlsecurity: implement support for building against system-xmlsecMiklos Vajna
The only remaining difference is that in the system-xmlsec case we work with the default key manager, not with the one that's only added by our xmlsec patches. This works for me for the uses I know of (see <https://lists.freedesktop.org/archives/libreoffice/2017-February/076947.html> for the motivation): signing and verifying of different signatures (bad signature, good with non-trusted CA, good with trusted CA) with software-based certificates all behave as expected. Change-Id: If3f3e2b8373ab7397db3f98070a5a2ce51fa7c06 Reviewed-on: https://gerrit.libreoffice.org/39075 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-06-22related: gpg4libre: Init xmlsec in one place before creating the servicesThorsten Behrens
Last holdout for separate xmlSec init removed, cf. ed92db7a50be36fcfe6e9b316f4b7f7570060c0d Change-Id: I46a05074706bba77ebc488f0df296e35e2b7d553
2017-06-22xmlsecurity: remove newly introduced redundant namespace alias, used only onceMiklos Vajna
Change-Id: Ia93ec62863d16d3cc60878968b79ed0ccc5fba9b
2017-06-22xmlsecurity: fix loplugin:passstuffbyref warningsMiklos Vajna
Change-Id: I627abfe33e9c2fc4243276706c1624ce19943678
2017-06-22xmlsecurity: fix loplugin:unusedvariablecheck warningMiklos Vajna
Change-Id: Ia59a1f00203fbbaad6df460c7cba4a984e206a1c
2017-06-21gpg4libre: fix build for windows and macThorsten Behrens
Change-Id: I3e36b22cefba4c6195bcf8b85b3f7a2cc101b845
2017-06-21gpg4libre: actually take key from user selectionThorsten Behrens
Change-Id: I6b18865913492d41a8e0206a430e267fe78c553a
2017-06-21gpg4libre: make signature impl swappable in-situ during validationThorsten Behrens
Sadly we only know whether its a OpenPGP or X509 signature during parsing, so we need to switch the implementation mid-way Change-Id: Ib48a9da0105de62cfecda095df8c154b59ba8c40
2017-06-21gpg4libre: some code improvements, add metadata for OpenPGP keysThorsten Behrens
Change-Id: I1beb692b9a9a34b5f0cf743ba9e4a145ac582184
2017-06-21gpg4libre: Make viewing signatures work for gpg signaturesSamuel Mehrbrodt
Change-Id: Ic10846cb87e23ca9ffa0eb0d64c56fcf79c73a9d
2017-06-21gpg4libre: Fixup unit tests, now that SecurityContext is neededKatarina Behrens
Change-Id: Ifa43fa735c8b0d58ff3d3deca2ad4eca6560494a
2017-06-21gpg4libre: write PGPData info, get more metadata out for gpg keyThorsten Behrens
Change-Id: Ia560869ec02fca7fe4219136e1fe939e13f1e4c2
2017-06-21gpg4libre: Init xmlsec in one place before creating the gpg/x509 servicesSamuel Mehrbrodt
Change-Id: I0308d586344b5e52ad327f6650b62ac0eac7ecb9
2017-06-21gpg4libre: List both (x509 and gpg) existing signaturesSamuel Mehrbrodt
Change-Id: I57ae79f7632885bf5c5aadcad3fb5ad4a5a9413d
2017-06-21gpg4libre: [API-CHANGE] add certificate kind (X509 vs. OpenPGP)Katarina Behrens
Change-Id: I423bef41f93af9d1b78ee9795be7ec33c3c7ae0c
2017-06-21gpg4libre: now use the gpg security envThorsten Behrens
Change-Id: I84e4d6872aab27f5b11ec727787a2eab80ef6a66
2017-06-21gpg4libre: fix build, explicit ctor callThorsten Behrens
Change-Id: Iec7ca4e37d6f5c4f63aaa22acfa0bdd395747471
2017-06-21gpg4libre: Having this dllpublic should be fine now since it's in inc/Samuel Mehrbrodt
Change-Id: I79c132e717a62c6274eeafe33d732616cbd6a5a6
2017-06-21gpg4libre: Make signature dialog work with two signing servicesSamuel Mehrbrodt
Change-Id: I0b47e6dba38222bb6b4f778c4206d3b37bc93089