summaryrefslogtreecommitdiff
path: root/xmlsecurity
AgeCommit message (Collapse)Author
2017-06-25gpg4libre: import public key payload if initial validation failsThorsten Behrens
Since maybe we don't know the key yet? Change-Id: I8b7e3f472d4731d9fb8bb675d81bdad257aa9230 Reviewed-on: https://gerrit.libreoffice.org/39194 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-06-25gpg4libre: save some space, extract binary key/sign dataThorsten Behrens
Since callers will base64-encode this anyway, again Change-Id: I0962d102fa0f2b95eaa2e608539cc291125f0321 Reviewed-on: https://gerrit.libreoffice.org/39193 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-06-25gpg4libre: base64-encode and decode SignatureValueThorsten Behrens
which xmldsig-core actually requires Change-Id: I92a6e192865919d844009be042dad36106a19fc8 Reviewed-on: https://gerrit.libreoffice.org/39192 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-06-24gpp4libre: error handling, proper key extractionThorsten Behrens
Change-Id: I1cb219f825393309219a4ebfb406482050b91228 Reviewed-on: https://gerrit.libreoffice.org/39191 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-06-23XMLSignature_GpgImpl: Use cppu::supportsServiceSamuel Mehrbrodt
Change-Id: Ic093462c957aa445aab43f95ac22af3a3df1d709
2017-06-23XMLSignature_GpgImpl: Clean up namespacesSamuel Mehrbrodt
Change-Id: I34aa59171b5d440bdd6bdec80badf7a3eb42bd3f
2017-06-23Gpg key listing: Use range based for loopSamuel Mehrbrodt
Change-Id: Idc7b39f751b2572f5ddd077aaad86a1f7b4b9a5d
2017-06-23tdf#108692 gpg4libre: List all gpg keysSamuel Mehrbrodt
Change-Id: I7300da36215233fa91b7a04a42b1c9bf907ad78b
2017-06-23gpg4libre: Handle error when retrieving public keySamuel Mehrbrodt
Change-Id: I9543e47fb3302a5ca146a606305b24733f015a5d
2017-06-23gpg4libre: Warn before removing document signaturesKatarina Behrens
simple version, no "do not show this message again" checkbox Change-Id: Iba8ac8cda51acac748174c864aa5c205f2efcc8f Reviewed-on: https://gerrit.libreoffice.org/38962 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-06-23gpg4libre: Show certificate kind OpenPGP vs. X509 as 1 table columnKatarina Behrens
Shuffled the columns around a little bit Change-Id: Ib0a979458db680d712737ff997e1c3b4e4564f3f Reviewed-on: https://gerrit.libreoffice.org/38984 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-06-22xmlsecurity: implement support for building against system-xmlsecMiklos Vajna
The only remaining difference is that in the system-xmlsec case we work with the default key manager, not with the one that's only added by our xmlsec patches. This works for me for the uses I know of (see <https://lists.freedesktop.org/archives/libreoffice/2017-February/076947.html> for the motivation): signing and verifying of different signatures (bad signature, good with non-trusted CA, good with trusted CA) with software-based certificates all behave as expected. Change-Id: If3f3e2b8373ab7397db3f98070a5a2ce51fa7c06 Reviewed-on: https://gerrit.libreoffice.org/39075 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-06-22related: gpg4libre: Init xmlsec in one place before creating the servicesThorsten Behrens
Last holdout for separate xmlSec init removed, cf. ed92db7a50be36fcfe6e9b316f4b7f7570060c0d Change-Id: I46a05074706bba77ebc488f0df296e35e2b7d553
2017-06-22xmlsecurity: remove newly introduced redundant namespace alias, used only onceMiklos Vajna
Change-Id: Ia93ec62863d16d3cc60878968b79ed0ccc5fba9b
2017-06-22xmlsecurity: fix loplugin:passstuffbyref warningsMiklos Vajna
Change-Id: I627abfe33e9c2fc4243276706c1624ce19943678
2017-06-22xmlsecurity: fix loplugin:unusedvariablecheck warningMiklos Vajna
Change-Id: Ia59a1f00203fbbaad6df460c7cba4a984e206a1c
2017-06-21gpg4libre: fix build for windows and macThorsten Behrens
Change-Id: I3e36b22cefba4c6195bcf8b85b3f7a2cc101b845
2017-06-21gpg4libre: actually take key from user selectionThorsten Behrens
Change-Id: I6b18865913492d41a8e0206a430e267fe78c553a
2017-06-21gpg4libre: make signature impl swappable in-situ during validationThorsten Behrens
Sadly we only know whether its a OpenPGP or X509 signature during parsing, so we need to switch the implementation mid-way Change-Id: Ib48a9da0105de62cfecda095df8c154b59ba8c40
2017-06-21gpg4libre: some code improvements, add metadata for OpenPGP keysThorsten Behrens
Change-Id: I1beb692b9a9a34b5f0cf743ba9e4a145ac582184
2017-06-21gpg4libre: Make viewing signatures work for gpg signaturesSamuel Mehrbrodt
Change-Id: Ic10846cb87e23ca9ffa0eb0d64c56fcf79c73a9d
2017-06-21gpg4libre: Fixup unit tests, now that SecurityContext is neededKatarina Behrens
Change-Id: Ifa43fa735c8b0d58ff3d3deca2ad4eca6560494a
2017-06-21gpg4libre: write PGPData info, get more metadata out for gpg keyThorsten Behrens
Change-Id: Ia560869ec02fca7fe4219136e1fe939e13f1e4c2
2017-06-21gpg4libre: Init xmlsec in one place before creating the gpg/x509 servicesSamuel Mehrbrodt
Change-Id: I0308d586344b5e52ad327f6650b62ac0eac7ecb9
2017-06-21gpg4libre: List both (x509 and gpg) existing signaturesSamuel Mehrbrodt
Change-Id: I57ae79f7632885bf5c5aadcad3fb5ad4a5a9413d
2017-06-21gpg4libre: [API-CHANGE] add certificate kind (X509 vs. OpenPGP)Katarina Behrens
Change-Id: I423bef41f93af9d1b78ee9795be7ec33c3c7ae0c
2017-06-21gpg4libre: now use the gpg security envThorsten Behrens
Change-Id: I84e4d6872aab27f5b11ec727787a2eab80ef6a66
2017-06-21gpg4libre: fix build, explicit ctor callThorsten Behrens
Change-Id: Iec7ca4e37d6f5c4f63aaa22acfa0bdd395747471
2017-06-21gpg4libre: Having this dllpublic should be fine now since it's in inc/Samuel Mehrbrodt
Change-Id: I79c132e717a62c6274eeafe33d732616cbd6a5a6
2017-06-21gpg4libre: Make signature dialog work with two signing servicesSamuel Mehrbrodt
Change-Id: I0b47e6dba38222bb6b4f778c4206d3b37bc93089
2017-06-21gpg4libre: initial GPG signature validationThorsten Behrens
Change-Id: I80afd77f74a6cb3f3fb7da03a6a4b74b132360d2
2017-06-21gpg4libre: fix gpg signature generationThorsten Behrens
Change-Id: I6eb95c948b6c8c9b8dee21215b430921bf454bb9
2017-06-21gpg4libre: share static xmlsec lib between nss and gpgThorsten Behrens
In the end, the gpgme implementation uses enough of xmlsec functionality that splitting those (and ending up with two copies) was just not worth it. Change-Id: Ida87c848e4e6a770e3c697add9ceb589a9ec3930
2017-06-21xmlsecurity nss: adopt the private key of the signing certificate explicitlyMiklos Vajna
xmlsec1-customkeymanage.patch.1 of our bundled xmlsec extends xmlSecNssKeyDataX509VerifyAndExtractKey(), so that it calls xmlSecNssPKIAdoptKey() for the private key of the signing certificate. Make this explicit in xmlsecurity/ code, so we don't depend on the patched xmlSecNssKeyDataX509VerifyAndExtractKey(). This is harmless for the patched xmlsec, but it prevents this error: warn:xmlsecurity.xmlsec:26221:1:xmlsecurity/source/xmlsec/errorcallback.cxx:48: keys.c:1246: xmlSecKeysMngrGetKey() '' 'xmlSecKeysMngrFindKey' 1 ' ' warn:xmlsecurity.xmlsec:26221:1:xmlsecurity/source/xmlsec/errorcallback.cxx:48: xmldsig.c:790: xmlSecDSigCtxProcessKeyInfoNode() '' '' 45 'details=NULL' warn:xmlsecurity.xmlsec:26221:1:xmlsecurity/source/xmlsec/errorcallback.cxx:48: xmldsig.c:503: xmlSecDSigCtxProcessSignatureNode() '' 'xmlSecDSigCtxProcessKeyInfoNode' 1 ' ' warn:xmlsecurity.xmlsec:26221:1:xmlsecurity/source/xmlsec/errorcallback.cxx:48: xmldsig.c:286: xmlSecDSigCtxSign() '' 'xmlSecDSigCtxSignatureProcessNode' 1 ' ' when xmlsec is not patched. (This is needed, but not enough to build against system xmlsec.) Change-Id: I5d68a8be7aefcb529566213f9b9c2985eab6a80a Reviewed-on: https://gerrit.libreoffice.org/39023 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-06-19xmlsecurity: make static var localJochen Nitschke
Change-Id: Ia36941e3ec32bcc4255be523203cf65f7d7b4273 Reviewed-on: https://gerrit.libreoffice.org/38935 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-18remove unused osl/mutex.hxx includesJochen Nitschke
Change-Id: I3b50e45fdb99e9cd8bfda07356ee3ddb4dd0f8bb Reviewed-on: https://gerrit.libreoffice.org/38905 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-06-16loplugin:unusedfields xmlhelp..xmlsecurityNoel Grandin
Change-Id: I7e680e1913c787ce0adad5be1f84668d57ad00b3 Reviewed-on: https://gerrit.libreoffice.org/38821 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-13use local statics for getUnoTunnelImplementationIdJochen Nitschke
replace uses of double checked locking pattern and rtl::Static Change-Id: I479d9d94f652b4fb4c67388405823a5f4e2b6ed4 Reviewed-on: https://gerrit.libreoffice.org/38690 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-12sw, xmlsecurity: indentation fixesMiklos Vajna
Change-Id: I3bc916c8318b63a829ec391a72976829815fa987
2017-06-09clang-tidy readability-non-const-parameterNoel Grandin
Change-Id: I7b2680898dbfc49185fb949349d81f4ac615a470 Reviewed-on: https://gerrit.libreoffice.org/38593 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-09use comphelper::InitPropertySequence in more placesNoel Grandin
Change-Id: I72d7b13a23ce306b752b39187a0e9fbb7028643a Reviewed-on: https://gerrit.libreoffice.org/38606 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-07gpg4libre: add 'Start certificate manager' buttonKatarina Behrens
Change-Id: Ief3239fd1b3ff1f4e2e95e4413aa9f707f3dfb50 Reviewed-on: https://gerrit.libreoffice.org/36689 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-06-05clang-tidy performance-unnecessary-value-paramNoel Grandin
Change-Id: I6ed8c54c7c45931d91709cc818f2483c70197192 Reviewed-on: https://gerrit.libreoffice.org/38400 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-02convert GRFILTER constants to ERRCODE_GRFILTER_Noel Grandin
since various code mixes these constants in with ErrCode values from other code, let us just make it into real ErrCode values. Change-Id: Ifa3d0f7526172609a44e6749bed9f730ab6b1a95 Reviewed-on: https://gerrit.libreoffice.org/38313 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-31xmlsecurity: try to appease --as-needed default ldMichael Stahl
Change-Id: I11a7894cb71732e613ae430c128ce06becb4defb
2017-05-28remove unnecessary use of OString::getStrNoel Grandin
Change-Id: I0490efedf459190521f4339854b3394d57765fdb Reviewed-on: https://gerrit.libreoffice.org/38058 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-26create SAL_RETURNS_NONNULL annotationNoel Grandin
and apply it to some methods in OString and OUString Change-Id: I30e91f961b6d310799d3641f68b7ed54b3080f3a Reviewed-on: https://gerrit.libreoffice.org/38020 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-19loplugin:stringcopy: xmlsecurityStephan Bergmann
Change-Id: Ib5b6e2b2a03eec14a81e1f8ba8833611047c83f0
2017-05-19make string translation loading more uniformCaolán McNamara
change various ResId classes that use conversion operator to OUString to functions that return a OUString drop various defines drop unnecessary toString calls Change-Id: Ibeccdf2b91a46a2ed5b4b74e6024e301a023bc92 Reviewed-on: https://gerrit.libreoffice.org/37817 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-05-19xmlsecurity: remove unused parameter in XSecParser ctorMiklos Vajna
Change-Id: I91caacf6476003477a76e583c2aa512c1446f9e4 Reviewed-on: https://gerrit.libreoffice.org/37804 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
generated by cgit (git 2.34.1) at 2025-01-19 23:27:00 +0000