summaryrefslogtreecommitdiff
path: root/xmlsecurity
AgeCommit message (Collapse)Author
2017-03-11Fix typosAndrea Gelmini
Change-Id: I23b16792005d66588e3439eb6482adda96c45673 Reviewed-on: https://gerrit.libreoffice.org/35064 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-10gpgme: change gb_LinkTarget__use_gpgmepp to depend on packageMichael Stahl
This replaces f764d67da42caa71fd5e02146b1ca32680ae2f6e with a better fix, no point in littering the makefiles with manual dependencies when we can just avoid the problem in one place with a tiny performance cost. Change-Id: Ic7e91ee4c99deb12a9544cf691c0995de6ae2bad
2017-03-10xmlsecurity: remove unused XMLEncryptionTemplateImplMiklos Vajna
Not needed since commit 0649622956431e0a1955cb80d1175025401ab5e5 (loplugin:unusedmethods, 2017-02-21). Change-Id: I5e8699174202c17309198e541dc904dc1b47a534 Reviewed-on: https://gerrit.libreoffice.org/35031 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-03-08gpg4libre: Remove deprecated dynamic exception specificationsSamuel Mehrbrodt
Change-Id: I3bec4570149af50fad5eef33bafb9842ab598798 Reviewed-on: https://gerrit.libreoffice.org/34967 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-03-07coverity#1402074 Resource leakCaolán McNamara
and coverity#1402075 Resource leak coverity#1402076 Resource leak Change-Id: I41f2ad480a43e3563b08a6316d4e74bfe8efd378
2017-03-05Fix Executable_pdfverify dependencies on LinuxStephan Bergmann
Change-Id: Idf5561baaa714834e8e763e379a79d084e21dc80
2017-03-04-Werror,-Wunused-private-fieldStephan Bergmann
Change-Id: I8e39763e781121932a0200e59760b49d7edcbfdd
2017-03-04-Werror,-Wunused-private-fieldStephan Bergmann
Change-Id: Id846ace3c16719b4ce5f1c9e24b7f76cc7753683
2017-03-04Fix build for mobileThorsten Behrens
Change-Id: I2f133306b57798e2e828c4bd504a795331bdaf34
2017-03-04Fix build for mobileThorsten Behrens
Change-Id: I420035cec4f3d5f56363eab1fabff5c053c60cd6
2017-03-04gpg4libre: List and view GPG keysSamuel Mehrbrodt
* Add GPG implementation of css::xml::crypto UNO interfaces (part of that is only stub atm) * List gpg keys along with other certificates * Viewing gpg certificates: Not all properties are implemented yet Change-Id: I7f60b26efe949a94bf8fe1b8d4d428002c2995b1 Reviewed-on: https://gerrit.libreoffice.org/33843 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Siegmund Gorr <siegmund.gorr@cib.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-03-03Remove redundant 'inline' keywordStephan Bergmann
...from function definitions occurring within class definitions. Done with a rewriting Clang plugin (to be pushed later). Change-Id: I9c6f2818a57ccdb361548895a7743107cbacdff8 Reviewed-on: https://gerrit.libreoffice.org/34874 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-02xmlsecurity: avoid using the SerialNumberAdapter wrapperMiklos Vajna
This service is only used in xmlsecurity and it's a wrapper around two free functions in the same module. Change-Id: Ibc5a026b51eda6c2b4b27b7254dedc220dbf909a Reviewed-on: https://gerrit.libreoffice.org/34772 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-03-01CertificateViewer: Don't crash with empty certificate pathSamuel Mehrbrodt
gpg4libre Change-Id: I4e3d59331a93c0bee98bcc493c2a6aca11005ec4 Reviewed-on: https://gerrit.libreoffice.org/34741 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-03-01Add missing includeSamuel Mehrbrodt
Change-Id: If4fa588ac7508edc886c93be7e870677b7dfeae0 Reviewed-on: https://gerrit.libreoffice.org/34742 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-02-28new loplugin unoanyNoel Grandin
Change-Id: I5d6c4a67cb2a09e7cd5bd620c6b262d188701b89 Reviewed-on: https://gerrit.libreoffice.org/34714 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-27tdf#105093 vcl PDF export: add embedded video testcaseMiklos Vajna
Fails with commit 4ad249af88d15f2c8a09f0721a59d82718fcc201 (tdf#105093 sd PDF export: handle embedded videos, 2017-01-04) reverted. Change-Id: I413ec9a5da3c0783541dcd28fb9a62dd896f955b Reviewed-on: https://gerrit.libreoffice.org/34681 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-02-27xmlsecurity PDF verify: fix parsing of nested dictionariesMiklos Vajna
This is triggered by an upcoming unit test for tdf#105093. Change-Id: I3c8e8662fcadaea1f6e19bf6194d8159916f368b Reviewed-on: https://gerrit.libreoffice.org/34678 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-02-27tdf#105461 vcl: add text highlight textcaseMiklos Vajna
Fails with commit ee32c7d8083ae1449d6b379034be92995c142da9 (tdf#105461 PDF export: handle text fill color, 2017-02-01) reverted. Change-Id: I3628a16d0810e3be3fb352340d06cdba472dcd3f Reviewed-on: https://gerrit.libreoffice.org/34621 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-02-24vcl: add initial CppunitTest_vcl_pdfexportMiklos Vajna
Invoke the PDF export filter and then use the PDF tokenizer from xmlsecurity to assert the contents of created PDF file. The testcase fails with commit 6db0f1feb1d9931d2726dd11a889c58815710ce0 (tdf#106059 PDF export: create a reference XObject for PDF images, 2017-02-22) reverted. Change-Id: I90526fef41d9560ae447f586df766bc50a491c43 Reviewed-on: https://gerrit.libreoffice.org/34609 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-02-24xmlsecurity PDF verify: handle multiple startxref in the last 1024 bytesMiklos Vajna
Usually this is not a problem, but it's easy to construct a document manually that contains multiple startxref tokens at the last 1024 bytes. Make sure we read the last of those, not the first one. This is triggered by an upcoming unit test for tdf#106059. Change-Id: I94fbb5d407c4a03b7c2c6e207200127bb374e750 Reviewed-on: https://gerrit.libreoffice.org/34607 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-02-23Remove commented out codeSamuel Mehrbrodt
Change-Id: I1da07c52380e543b80c7725a8420c1927743257d Reviewed-on: https://gerrit.libreoffice.org/34587 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-02-23Remove commented out codeSamuel Mehrbrodt
Change-Id: I36e5f4072ac52a3073d13e4ad5185ead7611e722 Reviewed-on: https://gerrit.libreoffice.org/34586 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-02-23Reduce indentationSamuel Mehrbrodt
Change-Id: Ie4578e45205ebf206a752651901f488a7edd648d Reviewed-on: https://gerrit.libreoffice.org/34541 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-02-23xmlsecurity: clean up leftover signaturetestMiklos Vajna
Which is not even built since gbuildification. Change-Id: I5fbacc32289c4a534d49ca9042cca4e40fa53815 Reviewed-on: https://gerrit.libreoffice.org/34565 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-02-21loplugin:unusedmethodsNoel Grandin
Change-Id: I52a9f16f3ed543a3c83ca111df70e3f7ae1ef33c Reviewed-on: https://gerrit.libreoffice.org/34508 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-21loplugin:subtlezeroinit: xmlsecurityStephan Bergmann
Change-Id: Ife06c74e1665273350b497a1a584d7f76297c13d
2017-02-20cppcheck: redundantAssignmentJochen Nitschke
Change-Id: I4537ced9dafb5b20dbf8cfb7d335698536067c49 Reviewed-on: https://gerrit.libreoffice.org/34436 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-16xmlsecurity: remove unused DecryptorImplMiklos Vajna
No longer necessary since commit 50669de68785d61534c4c3fe101fd8e1d12fae65 (xmlsecurity: remove unused xsec_fw_component_getFactory(), 2017-02-02). Change-Id: I24ee6fcd01a238151058559a7bf994e27b7b64cf Reviewed-on: https://gerrit.libreoffice.org/34332 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-02-15Some simplifications, using UNO_QUERY_THROWStephan Bergmann
Change-Id: I6e7555472da6b23af4c64b299182339a5b324ee9 Reviewed-on: https://gerrit.libreoffice.org/34250 Tested-by: Stephan Bergmann <sbergman@redhat.com> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-02-10Remove MinGW supportStephan Bergmann
In OOo times, there'd originally been efforts to allow building on Windows with MinGW. Later, in LO times, this has been shifted to an attempt of cross- compiling for Windows on Linux. That attempt can be considered abandoned, and the relevant code rotting. Due to this heritage, there are now three kinds of MinGW-specific code in LO: * Code from the original OOo native Windows effort that is no longer relevant for the LO cross-compilation effort, but has never been removed properly. * Code from the original OOo native Windows effort that is re-purposed for the LO cross-compilation effort. * Code that has been added specifially for the LO cross-compilation effort. All three kinds of code are removed. (An unrelated, remaining use of MinGW is for --enable-build-unowinreg, utilizing --with-mingw-cross-compiler, MINGWCXX, and MINGWSTRIP.) Change-Id: I49daad8669b4cbe49fa923050c4a4a6ff7dda568 Reviewed-on: https://gerrit.libreoffice.org/34127 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-02-10add --disable-pdfiumCaolán McNamara
Change-Id: I9137dc0030c3c752ffc0931721bf6b0013309d39
2017-02-10pdfverify preview: fix macOS color spaceMiklos Vajna
Unlike on Linux and Windows, we need to do an ARGB -> BGRA conversion here. Change-Id: Ifa539973de439de25125e544cfbbe941d08dee00
2017-02-10xmlsecurity: use pdfium to generate a preview in pdfverifyMiklos Vajna
This is just test code to check if the bundled pdfium is usable. Change-Id: I1f1d808796fe77924518cd004d99affe70279e88 Reviewed-on: https://gerrit.libreoffice.org/34081 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-02-10convert SvtSecurityOptions::EOption to scoped enumNoel Grandin
and drop unused E_MACRO_DISABLE enumerator Change-Id: I0bd706d4d4e1d8b9004e68c9e77c11410c62a64a Reviewed-on: https://gerrit.libreoffice.org/34067 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-09xmlsecurity: remove unused EncryptorImplMiklos Vajna
No longer necessary since commit 50669de68785d61534c4c3fe101fd8e1d12fae65 (xmlsecurity: remove unused xsec_fw_component_getFactory(), 2017-02-02). Change-Id: Ibbc78888abcd1cb6d7f242c93f28cdaf836cca14
2017-02-08Add missing #includesStephan Bergmann
...like 6dce9c6757823b9e89863716ae70ff4e8ddd4e60, for Windows-only code Change-Id: I35f37aae2e6f55ff8ed82afc710a9b59a43b028c
2017-02-06Add missing #includesStephan Bergmann
...and remove some unncessary using directives/declarations, in preparation of removing now-unnecessary #includes from cppumaker-generated files, post e57ca02849c3d87142ff5ff9099a212e72b8139c "Remove dynamic exception specifications". Change-Id: Iaf1f268871e2ee1d1c76cf90f03557527ebc9067
2017-02-03TyposJulien Nabet
Change-Id: I36f443c266670bd26aa6b813075e18653f372f52 Reviewed-on: https://gerrit.libreoffice.org/33900 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-02-02loplugin:useuniqueptrStephan Bergmann
Change-Id: I3a246a22baaac8195dc1b94c42994de7d80e8336
2017-02-02xmlsecurity: remove unused xsec_fw_component_getFactory()Miklos Vajna
No longer needed since commit a4af8986c94ff2d1bea0c21f798330efcc97b133 ([API CHANGE] offapi: remove unused xsec_fw UNO services, 2017-01-26). Change-Id: I428c07bfe2846cdc54b35a62554a21197e62245f
2017-02-01xmlsecurity: various small cleanupsMiklos Vajna
Change-Id: Id713460036331fd9f98fd1eca85ca61f57cf5afe Reviewed-on: https://gerrit.libreoffice.org/33779 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-01-31tdf#105637 Digital signatures dialog has unnessary labelsSamuel Mehrbrodt
Change-Id: I474968d566a31fba29bcdc1f74749de8e86fedce Reviewed-on: https://gerrit.libreoffice.org/33754 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-01-31teach lolugin:stringconstant about calling constructorsNoel Grandin
so we can remove unnecessary calls to the OUString(literal) constructor when calling constructors like this: Foo(OUString("xxx"), 1) Change-Id: I1de60ef561437c86b27dc9cb095a5deb2e103b36 Reviewed-on: https://gerrit.libreoffice.org/33698 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-29cppcheck: postfix operatorJulien Nabet
Change-Id: I2b6f0c922b0e70ecbf79f60831ff5d71cd1438fb Reviewed-on: https://gerrit.libreoffice.org/33656 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-28loplugin:stringconstant check for unnecessary OUString constructor..Noel Grandin
..calls when creating exceptions Change-Id: I3bc58a5aa4dc6f0508ecb88b3a843b96b8c7ebfe Reviewed-on: https://gerrit.libreoffice.org/33617 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-27loplugin: unnecessary destructor writerfilter..xmloffNoel Grandin
Change-Id: I511822dc874101ed3b9850b015b746a86d26c3b5 Reviewed-on: https://gerrit.libreoffice.org/33578 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-26Remove dynamic exception specificationsStephan Bergmann
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-26[API CHANGE] offapi: remove unused xsec_fw UNO servicesMiklos Vajna
This is mostly just the offapi/ part, more C++ code can be removed in xmlsecurity/ after this. SignatureVerifier, SAXEventKeeper, SignatureCreator, XMLSignatureTemplate and XMLEncryptionTemplate was only used inside xmlsecurity, but they all are accessed directly already. Decryptor and Encryptor wasn't even used by internal code since they were added in commit 9f34fde7a8750b856570b5e855d2ecb226bf0c23 (libxmlsec, 2004-07-12). It seems to be unlikely that any of these non-published services were used by 3rd-party code, since they were specific to other xmlsecurity/ code, not generic functionality that could be useful in other contexts. Change-Id: I4bcfa88d11d2b92a440f6617193c6460125ce4fd Reviewed-on: https://gerrit.libreoffice.org/33569 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-01-25Fix typo in comments: relativ -> relativeTakeshi Abe
Change-Id: I58833e503e93b8057f92710c5828bba6cecd4e09 Reviewed-on: https://gerrit.libreoffice.org/33488 Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp> Tested-by: Takeshi Abe <tabe@fixedpoint.jp>
generated by cgit (git 2.34.1) at 2025-01-21 10:17:57 +0000