r' content='cgit '/>
summaryrefslogtreecommitdiff
path: root/connectivity/source/drivers/firebird/StatementCommonBase.cxx
AgeCommit message (Collapse)Author
2024-09-12use more concrete UNO classes in connectivityNoel Grandin
Change-Id: I5c70278add0aa0b0c4a7680c6615b75b688f2180 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173247 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-05-06WaE: C6011 Dereferencing NULL pointer warningsCaolán McNamara
Change-Id: I396bada76e47f5bccca8296e844822a564b1ea0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167196 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-07-22tdf#146584: FB Setting default with ALTER TABLE works but gives useless messageJulien Nabet
ALTER is a DDL (DATA DEFINITION LANGAGE) instruction, no count row is expected. Change-Id: I3d5bfe240b85c5b79392c92fdd870bc045e1eb46 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154755 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2023-02-15Drop 'using namespace ::std' in dirs b* c*Gabor Kelemen
Change-Id: I59392ee7aa71c219e475a09da67a868cfdd14b41 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147074 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2022-02-18Simplify sequence of Property in connectivity/firebirdJulien Nabet
Change-Id: Ie45d5418e474cfeb2ac3ac62edbaa1e5bd688d9e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130136 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-01-13Recheck modules [a-c]* with IWYUGabor Kelemen
See tdf#42949 for motivation Change-Id: I74a3c3a67c3639376e2251c3eb917fa4139dfbd0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127808 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-12-28Drop FIREBIRD_SQL_DIALECT constant and use SQL_DIALECT_CURRENTJulien Nabet
Change-Id: I6731ad4c49066b197ffc5b4e5d2c482bd7ca169e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127615 Reviewed-by: Lionel Mamane <lionel@mamane.lu> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2021-12-21loplugin:flatten in canvas..cuiNoel Grandin
Change-Id: I208767eaa60d913fe2882403f1f9351eb08256f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127224 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-05m_pInSqlda is not needed in prepareAndDescribeStatementMike Kaganski
As described in Isc_dsql_prepare [1] and Isc_dsql_describe [2] docs, these two take and fill a pointer to XSQLDA used for output. Only Isc_dsql_describe_bind [3] fills the structure used for input. Additionally, since Isc_dsql_prepare already does the necessary initialization, Isc_dsql_describe is documented to be not needed unless there is an indication that there is insufficient room in the output XSQLDA. Hence the change allows to avoid one redundant call. [1] https://docwiki.embarcadero.com/InterBase/2020/en/Isc_dsql_prepare() [2] https://docwiki.embarcadero.com/InterBase/2020/en/Isc_dsql_describe() [3] https://docwiki.embarcadero.com/InterBase/2020/en/Isc_dsql_describe_bind() Change-Id: Ia8ba09f079fa949e53a174f551fca6653852d31e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121563 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-06-10update firebird modelinesCaolán McNamara
with solenv/bin/add-modelines -p connectivity/source/drivers/firebird because a bunch are missing the trailing ones Change-Id: I168c22586744cd666e6c18a569e143b6caccd421 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116963 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-02throw() -> noexcept, part 2/3: Automatic loplugin:noexcept rewriteStephan Bergmann
Change-Id: I076f16d0536b534abf0ced4d76051eadb4c0e033 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114949 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-01-29loplugin:stringviewparam extend to new..Noel
O[U]StringBuffer methods Change-Id: I0ffbc33d54ae7c98b5652434f3370ee4f819f6f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110090 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-11Adapt the remaining OUString functions to std string_viewStephan Bergmann
...for LIBO_INTERNAL_ONLY. These had been missed by 1b43cceaea2084a0489db68cd0113508f34b6643 "Make many OUString functions take std::u16string_view parameters" because they did not match the multi-overload pattern that was addressed there, but they nevertheless benefit from being changed just as well (witness e.g. the various resulting changes from copy() to subView()). This showed a conversion from OStringChar to std::string_view to be missing (while the corresponding conversion form OUStringChar to std::u16string_view was already present). The improvement to loplugin:stringadd became necessary to fix > [CPT] compilerplugins/clang/test/stringadd.cxx > error: 'error' diagnostics expected but not seen: > File ~/lo/core/compilerplugins/clang/test/stringadd.cxx Line 43 (directive at ~/lo/core/compilerplugins/clang/test/stringadd.cxx:42): simplify by merging with the preceding assignment [loplugin:stringadd] > File ~/lo/core/compilerplugins/clang/test/stringadd.cxx Line 61 (directive at ~/lo/core/compilerplugins/clang/test/stringadd.cxx:60): simplify by merging with the preceding assignment [loplugin:stringadd] > 2 errors generated. Change-Id: Ie40de0616a66e60e289c1af0ca60aed6f9ecc279 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107602 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-14tdf#42949 Fix IWYU warnings in connectivity/*/*cxxGabor Kelemen
Except for platform specific drivers/ado and drivers/macab dirs Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I24b741cded8995e29ac3d518aeaa0d60b3c55b56 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86317 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-12-16tdf#42949 Fix IWYU warnings in connectivity/*/*hxxGabor Kelemen
Except for non Linux specific parts: connectivity/source/drivers/macab/ connectivity/source/inc/ado/ Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Iba6d0cd0effdac777be6fbc8f12f2e92cae47887 Reviewed-on: https://gerrit.libreoffice.org/84174 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-07-19loplugin:referencecasting in comphelper..connectivityNoel Grandin
Change-Id: I21896885c29e9ab58ebab17b59f1480c6a06fb38 Reviewed-on: https://gerrit.libreoffice.org/75936 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-13loplugin:sequentialassign in codemaker..connectivityNoel Grandin
Change-Id: I9776431ebce95a88ae42715aaba2ddc28fb52471 Reviewed-on: https://gerrit.libreoffice.org/70642 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-04tdf#122129 Firebird: fix concurrency issueTamas Bunth
Allow only one isc_dsql_prepare at a time. Change-Id: I3d5974057272cd47697aeb7be54579d0c1a662a0 Reviewed-on: https://gerrit.libreoffice.org/67231 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2019-01-04Fix typoAndrea Gelmini
Change-Id: Ic162e36173fb2bfe9c0006d5b608714fa104c541 Reviewed-on: https://gerrit.libreoffice.org/65846 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-10-18clang-tidy readability-simplify-boolean-exprNoel Grandin
Change-Id: I78fa01a6c803dec782488490b730af3a11814d64 Reviewed-on: https://gerrit.libreoffice.org/61902 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-16Add missing sal/log.hxx headersGabor Kelemen
rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx> (and don't make use of it themselves), but many other files happen to depend on it. This is a continuation of commit 6ff2d84ade299cb3d14d4110e4cf1a4b8070c030 to be able to remove those unneeded includes. This commit adds missing headers to every file found by: grep -FwL sal/log.hxx $(git grep -Elw 'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF|SAL_DETAIL_LOG_STREAM|SAL_WHERE|SAL_STREAM|SAL_DEBUG') to directories from connectivity to cui Change-Id: I9903c10d0a04bbeb93d0f776d1d252b152459499 Reviewed-on: https://gerrit.libreoffice.org/57408 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-04-07dbaccess: Enable hsql migration by defaultTamas Bunth
Also make Firebird driver not experimental anymore. With hsql migration enabled, the hsqldb related unit tests can be reused, because the underlying DBMS is transparent. To achieve that, I added firebird_sdbc component to hsqldb CppunitTest_* files. This commit also contains fixes for upcoming bugs while migrating from hsqldb to firebird, shown by hsqldb related unit tests: - null values: in case of null values, the setNull method should be used instead of nothing. (malformed string otherwise) Remove DBACCESS_HSQL_MIGRATION environment variable, since migration is default from now on. JunitTest_dbaccess_complex was based on HSQLDB. This commit replaces "if exists" hsql specific solution with firebird specific. Also disable test for queries with named parameters. Change-Id: Ieb68f5ad3a11389599c4f268ea4df82a83643b82 Reviewed-on: https://gerrit.libreoffice.org/52008 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2018-03-12loplugin:redundantfcast look for redundant copies in return statementsNoel Grandin
Change-Id: I5f416c865dfe1c36018784246a8007452eb42008 Reviewed-on: https://gerrit.libreoffice.org/50996 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-12More loplugin:cstylecast: connectivityStephan Bergmann
auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/> "Enable loplugin:cstylecast for some more cases" plus solenv/clang-format/reformat-formatted-files Change-Id: Idbefb16acae20ab137497e78c9bc5dc5634c07fe
2017-12-28firebird: return consistent (if wrong...) results for XMultipleResultsLionel Elie Mamane
Just in case we are called by code not checking our DatabaseMetadata to learn we don't support multiple resultsets. Change-Id: I6d8c5f4ef04bcd9ec8b66a83881607281e125b7b Reviewed-on: https://gerrit.libreoffice.org/47117 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-10-23loplugin:includeform: connectivityStephan Bergmann
Change-Id: I06596fac09f0568b8bab2e2e235a2b88bcd3fc7a
2017-07-02loplugin:casttovoid: connectivityStephan Bergmann
Change-Id: I03127890499dac67816bb43a8c3fb9dd87eefcab
2017-06-20loplugin:oncevar in codemaker..connectivityNoel Grandin
Change-Id: Ia479d9d3d459a699dfc5c1148d01c35e8bc973bd Reviewed-on: https://gerrit.libreoffice.org/39000 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-26Remove dynamic exception specificationsStephan Bergmann
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-06-21connecitivty: [loplugin:nullptr]Michael Stahl
Change-Id: Ic717e1d119e1a5b8a87caca263322d9e58fe6c68
2016-05-30com::sun::star->css in connectivityNoel Grandin
Change-Id: I9489e92dc89a6d83a26ff4f0d9aad26acd28ad9f Reviewed-on: https://gerrit.libreoffice.org/25537 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-20loplugin:salbool: Automatic rewrite of sal_False/TrueStephan Bergmann
Change-Id: I6fada7331ee369c35cbe019db4e730ce56cd1a1f
2016-02-09Remove excess newlinesChris Sherlock
A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2015-11-30loplugin:unusedfieldsNoel Grandin
Change-Id: Icac4ac1a2614e72bc9ff070819533e09eeb1a864
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann
Change-Id: Iefeeb51c2b101c097a8d77a4625f84baf1f2da44
2015-10-30use uno::Reference::set method instead of assignmentNoel Grandin
Change-Id: I080668f86f0ab8b3bba857ee21411f907ae285c4
2015-10-12tdf#65108 "" instead of <> written in include lineFeyza Yavuz
Underwent the same process under the connectivity/source/drivers/firebird/ Change-Id: Id64b1f52a2f19cb91590bebe80a2f6aea70cc9ee Reviewed-on: https://gerrit.libreoffice.org/19137 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2015-04-13loplugin:redundantcast: redundant const_cast followed by implicit upcastStephan Bergmann
Change-Id: I58297ba336d96358eb0683684bbd763870ef56cb
2015-04-01Remove redundant Reference<> from within UnoType<> usesStephan Bergmann
Change-Id: I1aeb9c73c284e39f371e49ded98e8dba0d055056
2015-04-01Replace remaining getCppuType et al with cppu::UnoTypeStephan Bergmann
Change-Id: Id2361bd7b50f4724211661b024583b8a3445500b
2015-03-28Clean up C-style casts from pointers to voidStephan Bergmann
Change-Id: I6c7c31befd61cbf0800a62c08e7395ddf78e4b30
2014-10-29remove unnecessary 'using namespace rtl' declarationsNoel Grandin
It turns out that almost none of them were necessary. Change-Id: I1311ed28409c682b57ea8d149bcbaf2c49133e83 Reviewed-on: https://gerrit.libreoffice.org/12133 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-21connectivity: firebird: fix Connection leak in OStatementCommonBaseMichael Stahl
bin/refcount_leak.py was very helpful here. Change-Id: I61dc57408cf1533f733c08b701884851ec6afb8d
2014-06-27fdo#80574 firebird memory management issuesNorbert Thiebaud
Change-Id: I37438cd3f9c8e197e5a3aa3d9cbcc5bf3681d792
2014-06-11Related fdo#79714 OSX-crash opening query or table in embedded Firebird ODBJulien Nabet
See https://bugs.freedesktop.org/attachment.cgi?id=100839 and other comments Change-Id: I1187b171caf54997f5e8850ade4a3fb35ad9ec29
2014-05-12Kill DECL_PROP0 and the rest + clean propertyids.hxxJulien Nabet
Change-Id: I872bc07ff9b1fe96a35e06ad3c5d8aaa75199bdd