From 04b472af1e1c9a3de4b8380305d2b4e8ce3a43df Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Tue, 14 Jul 2015 14:58:02 +0200 Subject: loplugin:unusedmethods accessibility,fpicker,uui Change-Id: I106a0be06c4b9fe1313bbd8d4c62472c4b0a4b4f Reviewed-on: https://gerrit.libreoffice.org/17045 Tested-by: Jenkins Reviewed-by: Noel Grandin --- .../extended/AccessibleGridControlBase.hxx | 10 ---- .../extended/AccessibleGridControlHeaderCell.hxx | 5 -- .../extended/accessibletablistboxtable.hxx | 4 -- .../accessibility/helper/IComboListBoxHelper.hxx | 1 - .../inc/accessibility/helper/listboxhelper.hxx | 5 -- .../standard/accessiblemenubasecomponent.hxx | 24 ++++----- .../accessibility/standard/vclxaccessiblebox.hxx | 2 - .../standard/vclxaccessiblelistitem.hxx | 2 - .../standard/vclxaccessibletoolboxitem.hxx | 2 - fpicker/source/office/fpsmartcontent.hxx | 2 - fpicker/source/office/iodlg.hxx | 63 ---------------------- fpicker/source/office/iodlgimp.hxx | 6 --- uui/source/logindlg.hxx | 8 +-- uui/source/loginerr.hxx | 5 -- 14 files changed, 13 insertions(+), 126 deletions(-) diff --git a/accessibility/inc/accessibility/extended/AccessibleGridControlBase.hxx b/accessibility/inc/accessibility/extended/AccessibleGridControlBase.hxx index 789f6a321d42..dacd8fa21ff1 100644 --- a/accessibility/inc/accessibility/extended/AccessibleGridControlBase.hxx +++ b/accessibility/inc/accessibility/extended/AccessibleGridControlBase.hxx @@ -271,9 +271,6 @@ protected: /** Changes the name of the object (flat assignment, no notify). @attention This method requires a locked mutex. */ inline void implSetName( const OUString& rName ); - /** Changes the description of the object (flat assignment, no notify). - @attention This method requires a locked mutex. */ - inline void implSetDescription( const OUString& rDescription ); /** Locks all mutex's and calculates the bounding box relative to the parent window. @@ -369,13 +366,6 @@ inline void AccessibleGridControlBase::implSetName( m_aName = rName; } -inline void AccessibleGridControlBase::implSetDescription( - const OUString& rDescription ) -{ - m_aDescription = rDescription; -} - - } // namespace accessibility diff --git a/accessibility/inc/accessibility/extended/AccessibleGridControlHeaderCell.hxx b/accessibility/inc/accessibility/extended/AccessibleGridControlHeaderCell.hxx index 0debdbb8072b..6a10f9f1edd7 100644 --- a/accessibility/inc/accessibility/extended/AccessibleGridControlHeaderCell.hxx +++ b/accessibility/inc/accessibility/extended/AccessibleGridControlHeaderCell.hxx @@ -64,11 +64,6 @@ namespace accessibility getAccessibleContext() throw ( ::com::sun::star::uno::RuntimeException, std::exception ) SAL_OVERRIDE; - inline bool isRowBarCell() const - { - return getType() == ::svt::table::TCTYPE_ROWHEADERCELL; - } - /** @return The name of this class. */ diff --git a/accessibility/inc/accessibility/extended/accessibletablistboxtable.hxx b/accessibility/inc/accessibility/extended/accessibletablistboxtable.hxx index 8c47222f2ff2..21c2838fb66c 100644 --- a/accessibility/inc/accessibility/extended/accessibletablistboxtable.hxx +++ b/accessibility/inc/accessibility/extended/accessibletablistboxtable.hxx @@ -65,12 +65,8 @@ private: /** Returns the row index from cell index. */ inline sal_Int32 implGetRow( sal_Int32 _nIndex ) const { return _nIndex / implGetColumnCount(); } - /** Returns the column index from cell index. */ - inline sal_Int32 implGetColumn( sal_Int32 _nIndex ) const { return _nIndex % implGetColumnCount(); } /** Returns the absolute row index of the nSelRow-th selected row. */ sal_Int32 implGetSelRow( sal_Int32 _nSelRow ) const; - /** Returns the child index from cell position. */ - inline sal_Int32 implGetIndex( sal_Int32 _nRow, sal_Int32 _nColumn ) const { return _nRow * implGetColumnCount() + _nColumn; } public: /** ctor() diff --git a/accessibility/inc/accessibility/helper/IComboListBoxHelper.hxx b/accessibility/inc/accessibility/helper/IComboListBoxHelper.hxx index c218d0e59ee2..c3910b59fdc7 100644 --- a/accessibility/inc/accessibility/helper/IComboListBoxHelper.hxx +++ b/accessibility/inc/accessibility/helper/IComboListBoxHelper.hxx @@ -42,7 +42,6 @@ namespace accessibility virtual Rectangle GetDropDownPosSizePixel( ) const = 0; virtual Rectangle GetBoundingRectangle( sal_uInt16 nItem ) const = 0; virtual Rectangle GetWindowExtentsRelative( vcl::Window* pRelativeWindow ) = 0; - virtual bool IsActive() const = 0; virtual bool IsEnabled() const = 0; virtual bool IsEntryVisible( sal_Int32 nPos ) const = 0; virtual sal_uInt16 GetDisplayLineCount() const = 0; diff --git a/accessibility/inc/accessibility/helper/listboxhelper.hxx b/accessibility/inc/accessibility/helper/listboxhelper.hxx index 98ee64ddcfde..89c5b0cc762b 100644 --- a/accessibility/inc/accessibility/helper/listboxhelper.hxx +++ b/accessibility/inc/accessibility/helper/listboxhelper.hxx @@ -81,11 +81,6 @@ public: return m_aComboListBox.GetWindowExtentsRelative( pRelativeWindow ); } - virtual bool IsActive() const SAL_OVERRIDE - { - return m_aComboListBox.IsActive(); - } - virtual bool IsEnabled() const SAL_OVERRIDE { return m_aComboListBox.IsEnabled(); diff --git a/accessibility/inc/accessibility/standard/accessiblemenubasecomponent.hxx b/accessibility/inc/accessibility/standard/accessiblemenubasecomponent.hxx index 3a2b6b9aa950..fe772e47d724 100644 --- a/accessibility/inc/accessibility/standard/accessiblemenubasecomponent.hxx +++ b/accessibility/inc/accessibility/standard/accessiblemenubasecomponent.hxx @@ -64,19 +64,17 @@ protected: AccessibleChildren m_aAccessibleChildren; Menu* m_pMenu; - bool m_bEnabled; - bool m_bFocused; - bool m_bVisible; - bool m_bSelected; - bool m_bChecked; - - Menu* GetMenu() { return m_pMenu; } - - virtual bool IsEnabled(); - virtual bool IsFocused(); - virtual bool IsVisible(); - virtual bool IsSelected(); - virtual bool IsChecked(); + bool m_bEnabled; + bool m_bFocused; + bool m_bVisible; + bool m_bSelected; + bool m_bChecked; + + virtual bool IsEnabled(); + virtual bool IsFocused(); + virtual bool IsVisible(); + virtual bool IsSelected(); + virtual bool IsChecked(); void SetEnabled( bool bEnabled ); void SetFocused( bool bFocused ); diff --git a/accessibility/inc/accessibility/standard/vclxaccessiblebox.hxx b/accessibility/inc/accessibility/standard/vclxaccessiblebox.hxx index ab84e6ab2d5c..e739fa216ac3 100644 --- a/accessibility/inc/accessibility/standard/vclxaccessiblebox.hxx +++ b/accessibility/inc/accessibility/standard/vclxaccessiblebox.hxx @@ -137,8 +137,6 @@ public: virtual ::com::sun::star::uno::Any SAL_CALL getMinimumValue( ) throw (::com::sun::star::uno::RuntimeException, std::exception) SAL_OVERRIDE; - bool IsDropDownBox() {return m_bIsDropDownBox;}; - BoxType GetBoxType() { return m_aBoxType;}; protected: /** Specifies whether the box is a combo box or a list box. List boxes have multi selection. diff --git a/accessibility/inc/accessibility/standard/vclxaccessiblelistitem.hxx b/accessibility/inc/accessibility/standard/vclxaccessiblelistitem.hxx index 87db9bea130f..efeeac9585cf 100644 --- a/accessibility/inc/accessibility/standard/vclxaccessiblelistitem.hxx +++ b/accessibility/inc/accessibility/standard/vclxaccessiblelistitem.hxx @@ -116,8 +116,6 @@ public: inline bool IsSelected() const { return m_bSelected; } void SetSelected( bool _bSelected ); void SetVisible( bool _bVisible ); - inline bool DecrementIndexInParent() { OSL_ENSURE(m_nIndexInParent != 0,"Invalid call!");--m_nIndexInParent; return true;} - inline bool IncrementIndexInParent() { ++m_nIndexInParent; return true;} // XInterface virtual ::com::sun::star::uno::Any SAL_CALL queryInterface( const ::com::sun::star::uno::Type& aType ) throw(::com::sun::star::uno::RuntimeException, std::exception) SAL_OVERRIDE; diff --git a/accessibility/inc/accessibility/standard/vclxaccessibletoolboxitem.hxx b/accessibility/inc/accessibility/standard/vclxaccessibletoolboxitem.hxx index a05f31b89d1f..7c7d605af802 100644 --- a/accessibility/inc/accessibility/standard/vclxaccessibletoolboxitem.hxx +++ b/accessibility/inc/accessibility/standard/vclxaccessibletoolboxitem.hxx @@ -83,9 +83,7 @@ public: void SetFocus( bool _bFocus ); inline bool HasFocus() const { return m_bHasFocus; } void SetChecked( bool _bCheck ); - inline bool IsChecked() const { return m_bIsChecked; } void SetIndeterminate( bool _bIndeterminate ); - inline bool IsIndeterminate() const { return m_bIndeterminate; } inline void ReleaseToolBox() { m_pToolBox = NULL; } void NameChanged(); void SetChild( const ::com::sun::star::uno::Reference< ::com::sun::star::accessibility::XAccessible >& _xChild ); diff --git a/fpicker/source/office/fpsmartcontent.hxx b/fpicker/source/office/fpsmartcontent.hxx index cce20ec5061e..b6ffd7281848 100644 --- a/fpicker/source/office/fpsmartcontent.hxx +++ b/fpicker/source/office/fpsmartcontent.hxx @@ -198,8 +198,6 @@ namespace svt } inline bool isFolder( ) { return isFolder( getURL() ); } - inline bool isDocument( ) { return isDocument( getURL() ); } - inline bool is( ) { return is( getURL() ); } }; diff --git a/fpicker/source/office/iodlg.hxx b/fpicker/source/office/iodlg.hxx index bf01b492d9a9..7770935f0e78 100644 --- a/fpicker/source/office/iodlg.hxx +++ b/fpicker/source/office/iodlg.hxx @@ -162,7 +162,6 @@ private: protected: virtual bool Notify( NotifyEvent& rNEvt ) SAL_OVERRIDE; - void EnableInternet( bool bInternet ); // originally from VclFileDialog Link<> _aOKHdl; @@ -229,7 +228,6 @@ public: inline SvtFileView* GetView() const; - void DisableSaveLastDirectory(); void InitSize(); void UpdateControls( const OUString& rURL ); void EnableAutocompletion( bool _bEnable = true ); @@ -260,12 +258,6 @@ public: inline void SetDefaultExt( const OUString& rExt ); inline void EraseDefaultExt( sal_Int32 _nIndex = 0 ); inline const OUString& GetDefaultExt() const; - inline void SetOKHdl( const Link<>& rLink ); - inline const Link<>& GetOKHdl() const; - inline void SetFileSelectHdl( const Link<>& rLink ); - inline const Link<>& GetFileSelectHdl() const; - inline void SetFilterSelectHdl( const Link<>& rLink ); - inline const Link<>& GetFilterSelectHdl() const; inline Image GetButtonImage( sal_uInt16 _nButtonId ) const { return m_aImages.GetImage( _nButtonId ); } @@ -368,67 +360,12 @@ inline const OUString& SvtFileDialog::GetDefaultExt() const } - -inline void SvtFileDialog::SetOKHdl -( - const Link<>& rLink -) -{ - _aOKHdl = rLink; -} - - - -inline const Link<>& SvtFileDialog::GetOKHdl() const -{ - return _aOKHdl; -} - - - -inline void SvtFileDialog::SetFileSelectHdl -( - const Link<>& rLink -) -{ - _aFileSelectHdl = rLink; -} - - - -inline const Link<>& SvtFileDialog::GetFileSelectHdl() const -{ - return _aFileSelectHdl; -} - - - -inline void SvtFileDialog::SetFilterSelectHdl -( - const Link<>& rLink -) -{ - _aFilterSelectHdl = rLink; -} - - - -inline const Link<>& SvtFileDialog::GetFilterSelectHdl() const -{ - return _aFilterSelectHdl; -} - - - inline SvtFileView* SvtFileDialog::GetView() const { return _pFileView; } - - - #define FILE_SELECTION_CHANGED 1 #define DIRECTORY_CHANGED 2 #define HELP_REQUESTED 3 diff --git a/fpicker/source/office/iodlgimp.hxx b/fpicker/source/office/iodlgimp.hxx index dd6244b4fe21..243f6afa620e 100644 --- a/fpicker/source/office/iodlgimp.hxx +++ b/fpicker/source/office/iodlgimp.hxx @@ -217,7 +217,6 @@ public: inline const SvtFileDialogFilter_Impl* GetCurFilter( ) const; inline const OUString& GetCurFilterDisplayName() const; void SetCurFilter( SvtFileDialogFilter_Impl* _pFilter, const OUString& _rDisplayName ); - inline void SetCurFilter( SvtFileDialogFilter_Impl* _pFilter ); }; inline void SvtExpFileDlg_Impl::SetFilterListSelectHdl( const Link<>& _rHandler ) @@ -261,11 +260,6 @@ inline const OUString& SvtExpFileDlg_Impl::GetCurFilterDisplayName() const return m_sCurrentFilterDisplayName; } -inline void SvtExpFileDlg_Impl::SetCurFilter( SvtFileDialogFilter_Impl* pFilter ) -{ - SetCurFilter( pFilter, pFilter->GetName() ); -} - #endif // INCLUDED_FPICKER_SOURCE_OFFICE_IODLGIMP_HXX diff --git a/uui/source/logindlg.hxx b/uui/source/logindlg.hxx index cc32d5e94ae9..96304a0359ed 100644 --- a/uui/source/logindlg.hxx +++ b/uui/source/logindlg.hxx @@ -70,23 +70,19 @@ public: LoginDialog(vcl::Window* pParent, sal_uInt16 nFlags, const OUString& rServer, const OUString &rRealm); virtual ~LoginDialog(); - virtual void dispose() SAL_OVERRIDE; + virtual void dispose() SAL_OVERRIDE; - OUString GetPath() const { return m_pPathED->GetText(); } - void SetPath( const OUString& rNewPath ) { m_pPathED->SetText( rNewPath ); } OUString GetName() const { return m_pNameED->GetText(); } void SetName( const OUString& rNewName ) { m_pNameED->SetText( rNewName ); } OUString GetPassword() const { return m_pPasswordED->GetText(); } void SetPassword( const OUString& rNew ) { m_pPasswordED->SetText( rNew ); } OUString GetAccount() const { return m_pAccountED->GetText(); } - void SetAccount( const OUString& rNew ) { m_pAccountED->SetText( rNew ); } bool IsSavePassword() const { return m_pSavePasswdBtn->IsChecked(); } void SetSavePassword( bool bSave ) { m_pSavePasswdBtn->Check( bSave ); } void SetSavePasswordText( const OUString& rTxt ) { m_pSavePasswdBtn->SetText( rTxt ); } - bool IsUseSystemCredentials() const { return m_pUseSysCredsCB->IsChecked(); } + bool IsUseSystemCredentials() const { return m_pUseSysCredsCB->IsChecked(); } void SetUseSystemCredentials( bool bUse ); void SetErrorText( const OUString& rTxt ) { m_pErrorInfo->SetText( rTxt ); } - void SetLoginRequestText( const OUString& rTxt ) { m_pRequestInfo->SetText( rTxt ); } void ClearPassword(); void ClearAccount(); }; diff --git a/uui/source/loginerr.hxx b/uui/source/loginerr.hxx index 81c3769a2c1c..793b965ac5e7 100644 --- a/uui/source/loginerr.hxx +++ b/uui/source/loginerr.hxx @@ -55,7 +55,6 @@ public: { } - const OUString& GetTitle() const { return m_aTitle; } const OUString& GetServer() const { return m_aServer; } const OUString& GetAccount() const { return m_aAccount; } const OUString& GetUserName() const { return m_aUserName; } @@ -90,12 +89,8 @@ public: { m_aPasswordToModify = aPassword; } void SetRecommendToOpenReadonly( bool bVal ) { m_bRecommendToOpenReadonly = bVal; } - void SetPath( const OUString& aPath ) - { m_aPath = aPath; } void SetErrorText( const OUString& aErrorText ) { m_aErrorText = aErrorText; } - void SetFlags( sal_uInt8 nFlags ) - { m_nFlags = nFlags; } inline void SetCanRememberPassword( bool bSet ); inline void SetIsRememberPassword( bool bSet ); -- cgit