From 0576911eec4f5fab4d4dd4f0cd46744b9a567899 Mon Sep 17 00:00:00 2001 From: Caolán McNamara Date: Mon, 19 Aug 2019 20:57:39 +0100 Subject: Resolves: tdf#127021 not all formatting options shown for set variable MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit because we need to call SwNumFormatTreeView::clear to flag we want them added following that we then need to insert the extra entries before those now inserted stock ones Change-Id: Iccbd3a6b2c9fd48ad823b9dcc7cdfca87d29873c Reviewed-on: https://gerrit.libreoffice.org/77768 Tested-by: Julien Nabet Reviewed-by: Caolán McNamara Tested-by: Caolán McNamara --- sw/source/ui/fldui/fldvar.cxx | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/sw/source/ui/fldui/fldvar.cxx b/sw/source/ui/fldui/fldvar.cxx index 0f304387ab58..b56f88bd4470 100644 --- a/sw/source/ui/fldui/fldvar.cxx +++ b/sw/source/ui/fldui/fldvar.cxx @@ -680,7 +680,7 @@ void SwFieldVarPage::FillFormatLB(sal_uInt16 nTypeId) // fill Format-Listbox m_xFormatLB->freeze(); m_xFormatLB->clear(); - rWidget.clear(); + m_xNumFormatLB->clear(); // flags list as dirty and needing refilling with stock entries bool bSpecialFormat = false; if( TYP_GETREFPAGEFLD != nTypeId ) @@ -714,8 +714,9 @@ void SwFieldVarPage::FillFormatLB(sal_uInt16 nTypeId) { if (!IsFieldEdit() || bSpecialFormat) { - rWidget.append(OUString::number(NUMBERFORMAT_ENTRY_NOT_FOUND), SwResId(FMT_MARK_TEXT)); - rWidget.append(OUString::number(NUMBERFORMAT_ENTRY_NOT_FOUND), SwResId(FMT_USERVAR_CMD)); + OUString sId(OUString::number(NUMBERFORMAT_ENTRY_NOT_FOUND)); + rWidget.insert(0, SwResId(FMT_MARK_TEXT), &sId, nullptr, nullptr); + rWidget.insert(1, SwResId(FMT_USERVAR_CMD), &sId, nullptr, nullptr); } } break; @@ -724,20 +725,23 @@ void SwFieldVarPage::FillFormatLB(sal_uInt16 nTypeId) { if (!IsFieldEdit() || bSpecialFormat) { - rWidget.append(OUString::number(NUMBERFORMAT_ENTRY_NOT_FOUND), SwResId(FMT_SETVAR_TEXT)); + OUString sId(OUString::number(NUMBERFORMAT_ENTRY_NOT_FOUND)); + rWidget.insert(0, SwResId(FMT_SETVAR_TEXT), &sId, nullptr, nullptr); } } break; case TYP_FORMELFLD: { - rWidget.append(OUString::number(NUMBERFORMAT_ENTRY_NOT_FOUND), SwResId(FMT_GETVAR_NAME)); + OUString sId(OUString::number(NUMBERFORMAT_ENTRY_NOT_FOUND)); + rWidget.insert(0, SwResId(FMT_GETVAR_NAME), &sId, nullptr, nullptr); } break; case TYP_GETFLD: { - rWidget.append(OUString::number(NUMBERFORMAT_ENTRY_NOT_FOUND), SwResId(FMT_GETVAR_NAME)); + OUString sId(OUString::number(NUMBERFORMAT_ENTRY_NOT_FOUND)); + rWidget.insert(0, SwResId(FMT_GETVAR_NAME), &sId, nullptr, nullptr); } break; } -- cgit